[GitHub] [drill] jnturton commented on pull request #886: Update 010-performance-tuning-introduction.md

2022-01-18 Thread GitBox
jnturton commented on pull request #886: URL: https://github.com/apache/drill/pull/886#issuecomment-1016155831 Thank you for the pull request. If you'd like to revisit it, please open a new pull request against the apache/drill-site repo. -- This is an automated message from the Apache

[GitHub] [drill] jnturton commented on a change in pull request #886: Update 010-performance-tuning-introduction.md

2022-01-18 Thread GitBox
jnturton commented on a change in pull request #886: URL: https://github.com/apache/drill/pull/886#discussion_r787409132 ## File path: _docs/performance-tuning/010-performance-tuning-introduction.md ## @@ -3,9 +3,9 @@ title: "Performance Tuning Introduction" date: parent:

[GitHub] [drill] jnturton merged pull request #2388: DRILL-8057: INFORMATION_SCHEMA filter push down is inefficient

2022-01-18 Thread GitBox
jnturton merged pull request #2388: URL: https://github.com/apache/drill/pull/2388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton merged pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

2022-01-18 Thread GitBox
jnturton merged pull request #2429: URL: https://github.com/apache/drill/pull/2429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cgivre commented on pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-18 Thread GitBox
cgivre commented on pull request #2401: URL: https://github.com/apache/drill/pull/2401#issuecomment-1015618627 @vvysotskyi I added a parameter to put the access token in the URL instead of the header. This is technically not part of the OAuth spec -- This is an automated message

[GitHub] [drill] cgivre commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-18 Thread GitBox
cgivre commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r786914543 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -133,6 +138,71 @@ } }); +$("#getOauth").click(function() {

[GitHub] [drill] vdiravka commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

2022-01-18 Thread GitBox
vdiravka commented on a change in pull request #2429: URL: https://github.com/apache/drill/pull/2429#discussion_r786851263 ## File path: exec/jdbc-all/pom.xml ## @@ -874,6 +874,42 @@ + + hadoop-2 + + + +

[GitHub] [drill] vdiravka commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

2022-01-18 Thread GitBox
vdiravka commented on a change in pull request #2429: URL: https://github.com/apache/drill/pull/2429#discussion_r786851263 ## File path: exec/jdbc-all/pom.xml ## @@ -874,6 +874,42 @@ + + hadoop-2 + + + +

[GitHub] [drill] cgivre commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-18 Thread GitBox
cgivre commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r786866169 ## File path: exec/jdbc-all/pom.xml ## @@ -562,7 +562,7 @@ This is likely due to you adding new dependencies to a java-exec and not

[GitHub] [drill] lgtm-com[bot] commented on pull request #2430: DRILL-8023: Empty dict page breaks the "old" Parquet reader

2022-01-18 Thread GitBox
lgtm-com[bot] commented on pull request #2430: URL: https://github.com/apache/drill/pull/2430#issuecomment-1015503422 This pull request **introduces 1 alert** when merging 1781dfc3b444c07eb6d596a69628732927fedc17 into 55e94c4e1c4a05ac7010391daea8f4f0804b0286 - [view on

[jira] [Resolved] (DRILL-8047) Add a custom authn provider for HashiCorp Vault

2022-01-18 Thread James Turton (Jira)
[ https://issues.apache.org/jira/browse/DRILL-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton resolved DRILL-8047. - Resolution: Fixed > Add a custom authn provider for HashiCorp Vault >

[GitHub] [drill] cgivre commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

2022-01-18 Thread GitBox
cgivre commented on a change in pull request #2429: URL: https://github.com/apache/drill/pull/2429#discussion_r786802924 ## File path: exec/jdbc-all/pom.xml ## @@ -874,6 +874,42 @@ + + hadoop-2 + + + +

[GitHub] [drill] jnturton opened a new pull request #2430: DRILL-8023: Empty dict page breaks the "old" Parquet reader

2022-01-18 Thread GitBox
jnturton opened a new pull request #2430: URL: https://github.com/apache/drill/pull/2430 # [DRILL-8023](https://issues.apache.org/jira/browse/DRILL-8023): Empty dict page breaks the "old" Parquet reader ## Description Dictionary pages of zero bytes caused exceptions to be

[GitHub] [drill] jnturton commented on a change in pull request #2424: DRILL-8092: Add Auto Pagination to HTTP Storage Plugin

2022-01-18 Thread GitBox
jnturton commented on a change in pull request #2424: URL: https://github.com/apache/drill/pull/2424#discussion_r786652254 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/paginator/PagePaginator.java ## @@ -64,16 +60,16 @@ public

[GitHub] [drill] jnturton commented on a change in pull request #2424: DRILL-8092: Add Auto Pagination to HTTP Storage Plugin

2022-01-18 Thread GitBox
jnturton commented on a change in pull request #2424: URL: https://github.com/apache/drill/pull/2424#discussion_r786651480 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/paginator/PagePaginator.java ## @@ -47,11 +44,10 @@ * @param

Drill 1.20 Update

2022-01-18 Thread James Turton
Hi all The current status of the Jira issues marked for 1.20.  The blocker DRILL-8060 is new.  Outside of this list DRILL-8107, which is currently under review, will mean that we can ship Hadoop 2 and Hadoop 3 builds of Drill for the first time. *Closed* DRILL-1282 Parquet v2 read+write

Re: [DISCUSS] Drill 2 and plug-in organisation

2022-01-18 Thread Paul Rogers
Hi James, My experience might be a bit old. I seem to recall, way back when, we did try to build some plugins outside of Drill itself and that there were issues. Maybe it was just the inconvenience of debugging? Perhaps the test libraries were not available? Development is fastest when you can

Re: [DISCUSS] Drill 2 and plug-in organisation

2022-01-18 Thread James Turton
For my part, I'd forgotten that GitHub does give users the opportunity to attach binary distributables to releases.  So my first thought of "GitHub would mean using Git repositories to host Jar files" was off the mark. Paul, setting aside the hosting and distribution for a moment, may I ask

[GitHub] [drill] Agirish closed pull request #1710: DRILL-7127: Updating hbase version for mapr profile

2022-01-18 Thread GitBox
Agirish closed pull request #1710: URL: https://github.com/apache/drill/pull/1710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: