Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/341
This has been replaced by
https://github.com/apache/drill/pull/595
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jaltekruse closed the pull request at:
https://github.com/apache/drill/pull/341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r82291973
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java
---
@@ -123,6 +123,7 @@ public
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r82292165
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -184,17 +201,15 @@ public static
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r82292241
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -107,6 +107,7 @@ public ScanBatch getBatch
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r82274813
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -184,17 +201,15 @@ public static
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r82273282
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -918,18 +916,22 @@ public void setMax(Object max
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r82272848
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java
---
@@ -123,6 +123,7 @@ public
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r81396800
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -918,18 +916,22 @@ public void setMax(Object max
Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/518
After this was discussed at the Hangout a few weeks back, I had been
thinking about it more.
My initial request was for warnings to be returned along with query
results. Some initial work
Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/546
One small last comment. The method testNoResult() doesn't actually verify
that they query has no results, it just ignores whatever the query returns. I
would recommend instead using
Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/546
The original behavior was not by design, it was a bug. I would just detect
the case where a scalar is being flattened and throw an appropriate user facing
message like "Flatten does not su
Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/518
I don't think we should merge this without a mechanism to return a warning
to the user to tell them at least that some data was ignored, and ideally some
indication of how much data was discarded
Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/459
@amansinha100 It looks like the expected output of the test is just wrong,
flattening an empty array should produce 0 rows.
---
If your project is set up for it, you can reply to this email
Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/524
+1 one small comment, otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/524#discussion_r67415245
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilterBuilder.java
---
@@ -73,9 +73,12 @@ public ExprNode
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/425#issuecomment-220190035
As a matter of good convention can we add a JIRA number to the TODOs? I
don't think it is necessary to create a JIRA for each one, but even a follow up
JIRA that says
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/495#issuecomment-216937718
We currently use multiple drillbits in the same JVM process for our unit
tests, won't this cause them to conflict with one another? I don't know if
production use
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/379#issuecomment-212534349
@jinfengni looks like this was merged, can you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/483#issuecomment-211443930
Is there a way we could test this with a simple plugin stub?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/483#issuecomment-211443568
We have talked about the possibility of providing a message to users when
they try using a malformed UDF, by providing a placeholder that will give them
back
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/451#issuecomment-206989347
Hey @magpierre Thanks for the work on this, we have had request for an XML
reader from a number of community members in the past.
This is the right way
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58904346
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLRecordReader.java
---
@@ -0,0 +1,95 @@
+/**
+ * Licensed
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58903153
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLFormatPlugin.java
---
@@ -0,0 +1,139 @@
+/**
+ * Licensed
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58902477
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLFormatPlugin.java
---
@@ -0,0 +1,139 @@
+/**
+ * Licensed
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/454#discussion_r58108889
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
@@ -110,11 +111,12 @@
private
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/452#issuecomment-203637282
Addressed both comments, @jinfengni can you take another look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/454#discussion_r57955905
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
@@ -110,11 +111,12 @@
private
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/452#discussion_r57943477
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctionHelpers.java
---
@@ -213,11 +213,39 @@ public static long getDate
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/452#discussion_r57942687
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java
---
@@ -40,6 +41,36 @@
public class
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/452
DRILL-4551: Implement new functions (cot, regex_matches, split_part, â¦
â¦isdate)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaltekruse
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/431#discussion_r56354881
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDFs.java
---
@@ -43,4 +47,17 @@ public void testEncode
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/398#issuecomment-195623864
@StevenMPhillips Can you separate out the package renames into their own
commit? It would be useful to see any meaningful code changes isolated. The
diff is so big
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/419
DRILL-4482: Avro subselection broken by 4382
This fix includes a number of test updates to ensure Avro files are being
read correctly.
The branch includes 4441, which is on a different
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/418#issuecomment-194049783
Is there a way to ask Jackson to look at a POJO and give you what it
considers to be the serializable fields? This isn't quite the right fix because
it is valid
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/415#issuecomment-193884035
Could you also close this PR and open a new one? the JIRA number was wrong
in your commit so this is posting to the JIRA about incorrect creation if
direct scans
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/412#issuecomment-193558494
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/395#issuecomment-193418830
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/389#issuecomment-193372672
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/410#issuecomment-193362442
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/372#issuecomment-192701211
@daveoshinsky I have a few questions about your design here, I have a
proposed alternative but I might be wrong about what you are trying to
accomplish.
---
If your
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/372#discussion_r55125267
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
---
@@ -69,11 +73,16
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/402
DRILL-4375: Fix the maven release profile
This generated pom file was being discovered and maven was trying to
run the target directory in jdbc-all as a submodule.
This change reverts
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/394#issuecomment-190353355
@sudheeshkatkam @parthchandra @adeneche @StevenMPhillips Would any of you
be able to do a review?
---
If your project is set up for it, you can reply to this email
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/381#discussion_r54018324
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
---
@@ -98,7 +102,9 @@ public void
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/381#discussion_r54017535
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
---
@@ -47,7 +47,11 @@
private
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/381#discussion_r54017219
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
---
@@ -47,7 +47,11 @@
private
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/380#issuecomment-187942345
+1 @hsuanyi Does this second test look good to you? I will test this on
windows before merging, but I think it should be fine. Will do a small
refactoring to use
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/380#issuecomment-185825063
Could you also add result verification? While there are some older tests
that just run queries to verify that errors that previously occurred are gone,
we have been
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/380#issuecomment-185568844
Can you generate these files in the tests rather than check them in?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/375
DRILL-4383: Allow custom configurations to be specified for a FileSysâ¦
â¦tem plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/365#issuecomment-181638322
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/363#issuecomment-181638228
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/347#discussion_r52048231
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
@@ -84,6 +64,26 @@
import
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/351#issuecomment-180472482
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/362#issuecomment-180506885
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/347#issuecomment-180471371
Other than the two small comments this looks good to me +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/311#issuecomment-180479132
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/363#discussion_r52080108
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/EndpointAffinity.java
---
@@ -96,6 +96,42 @@ public boolean isAssignmentRequired
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/363#discussion_r52084085
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/EndpointAffinity.java
---
@@ -96,6 +96,42 @@ public boolean isAssignmentRequired
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/359#issuecomment-180514935
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/359#issuecomment-180079688
Currently running tests on the patch rebased onto the 1.5 release branch.
Do you want to go mention on the vote thread that you would like this to be
included
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/339#discussion_r51908667
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java ---
@@ -235,6 +240,20 @@ public CSVTestBuilder csvBaselineFile(String filePath
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/339#issuecomment-179963620
@hsuanyi Other than the small comment this looks good to me +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/353
DRILL-4128: Fix NPE when calling getString on a JDBC ResultSet when tâ¦
â¦he type is not varchar
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/348#issuecomment-177013054
+1 tested the change by swapping the 1.5 mongo storage plugin jar with the
1.4 one and it worked.
---
If your project is set up for it, you can reply to this email
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/343#issuecomment-176314047
@sudheeshkatkam Just saw that you actually had a patch for this, I was
looking at DRILL-2663 originally, and found the duplicate DRILL-2653 when I
went to write
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/343
DRILL-2653: Improve web UI experience when there is an error in a stoâ¦
â¦rage plugin configuration
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/344
DRILL-4322: Add underlying exception message when IOException causes â¦
â¦DROP TABLE failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/343#issuecomment-176312248
@sudheeshkatkam @jacques-n Can you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/343#discussion_r51185648
--- Diff: exec/java-exec/src/main/resources/rest/storage/update.ftl ---
@@ -53,8 +53,17 @@
});
function doUpdate
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/343#issuecomment-176434681
@sudheeshkatkam Message fixed, also added more colors :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/341#issuecomment-175920847
Did you see my comment above? I am using the version number to signal that
the dates are fixed now and in all future versions. All other commits with a
version
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/341
DRILL-4203: fix dates written into parquet files to conform to parquet
format spec
This branch includes an update of the version number to 1.5.0, this is
required because we need a hard release
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/341#issuecomment-175793221
@adeneche @parthchandra @StevenMPhillips Can one of you please review this
change?
---
If your project is set up for it, you can reply to this email and have your
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/339#issuecomment-175874266
Can do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/336#issuecomment-174627297
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/336#discussion_r50741405
--- Diff: exec/vector/src/main/java/org/apache/drill/exec/util/Text.java ---
@@ -0,0 +1,612 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/334#discussion_r50482911
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
---
@@ -106,6 +106,16 @@ public void
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/331#issuecomment-173078753
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/326#issuecomment-172110734
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/314#issuecomment-168730376
I agree with Steven, at the hackathon we already did some basic performance
and correctness verification at reasonable scale. +1
---
If your project is set up
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/293#issuecomment-162680673
This should not be using the File.Separator, as it is working with Hadoop
and will always get Unix paths, even when running on Windows. Please see the
JIRA linked
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/293#issuecomment-162696095
One other point here, the issue with fully qualified names actually
shouldn't be a problem in the usual usage of this function. The function was
only designed
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/293#issuecomment-162704924
Apologies, didn't think about the order in which compilation and resolving
the injectables would be executed. I thought I had verified that this error
would make
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/289#issuecomment-161813807
As long as you are changing it do you want to remove the two test classes
still using this method and then just delete it?
---
If your project is set up for it, you
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/289#issuecomment-161818595
The one that is generating a string representation of the result set, which
caused the bug. getResultString()
---
If your project is set up for it, you can reply
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/281#issuecomment-160799401
I put it on my merge branch but it actually caused two small compilation
issues in other modules that were using the utility method you refactored. I
forgot to update
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/281#issuecomment-159748623
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/266#issuecomment-159106823
This was merged into the 1.3 release branch, but I just realized it was not
merged into master. Will get it in shortly.
---
If your project is set up for it, you can
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/247#issuecomment-159107022
Fixed in a5a1aa6b487d0642641ce70f2c2500465956f9ec
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user jaltekruse reopened a pull request:
https://github.com/apache/drill/pull/266
DRILL-4056: Avro corruption bug with UTF-8 strings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaltekruse/incubator-drill
4056-avro
Github user jaltekruse closed the pull request at:
https://github.com/apache/drill/pull/266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jaltekruse closed the pull request at:
https://github.com/apache/drill/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/278
DRILL-4070: Add note about parquet file migration in 1.3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaltekruse/incubator-drill gh-pages
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/271#discussion_r45524312
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java ---
@@ -33,6 +33,30 @@
public class TestExampleQueries extends
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/264#issuecomment-157576301
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/266
DRILL-4056: Avro corruption bug with UTF-8 strings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaltekruse/incubator-drill
4056-avro
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/251#issuecomment-156234958
Just reflecting a short offline conversation I had with Adrew here. It
looks like we're missing a few MySQL types here (YEAR, ENUM) as well as a
couple of derby types
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/252#discussion_r44725024
--- Diff:
common/src/main/java/org/apache/drill/common/scanner/ClassPathScanner.java ---
@@ -422,11 +423,16 @@ static ScanResult scan(Collection
1 - 100 of 155 matches
Mail list logo
