[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-31 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r373600104 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-31 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r373582218 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-31 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r373579329 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-31 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r373451734 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369729458 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369664401 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369673001 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/filter/package-info.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369663654 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369720302 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/base/TestFilterPushDown.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369689965 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/base/DummyBatchReader.java ##

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369665119 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369654393 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369617363 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-22 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369492043 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseGroupScan.java ##

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369129074 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseGroupScan.java ##

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369116545 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseGroupScan.java ##

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369122660 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseStoragePlugin.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369146546 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369116226 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseGroupScan.java ##

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369112612 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseGroupScan.java ##

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369126051 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseSubScan.java ## @@

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369114727 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseGroupScan.java ##

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369127232 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseSubScan.java ## @@

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369107575 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseGroupScan.java ##

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369120596 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/base/BaseStoragePlugin.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins

2020-01-21 Thread GitBox
vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369095160 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ## @@