[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2018-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1049 ---

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158985937 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java --- @@ -138,6 +138,8 @@

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158986798 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java --- @@ -193,4 +200,168 @@ public void

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158986526 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java --- @@ -193,4 +200,168 @@ public void

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r159003539 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -394,9 +394,11 @@ public void get(int index,

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-26 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158702875 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java --- @@ -138,6 +138,8 @@

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-26 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158700125 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -394,9 +394,11 @@ public void get(int index, Nullable${minor.class}Holder

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-26 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158702957 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -636,8 +636,10 @@ public void

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-26 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158703477 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java --- @@ -193,4 +200,168 @@ public void notxistsField()

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-26 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158703375 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java --- @@ -193,4 +200,168 @@ public void notxistsField()

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-26 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158703216 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java --- @@ -193,4 +200,168 @@ public void notxistsField()

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-12-26 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r158703447 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java --- @@ -193,4 +200,168 @@ public void notxistsField()

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-11-29 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r153739725 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java --- @@ -138,6 +138,8 @@

[GitHub] drill pull request #1049: DRILL-5971: Fix INT64, INT32 logical types in comp...

2017-11-29 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1049#discussion_r153735994 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java --- @@ -138,6 +138,8 @@