Re: Drill not compiling after rebase!!

All, I submitted the following PR which fixes this: https://github.com/apache/drill/pull/1731 . @vvysotskyi, can you review and commit? Thanks, — C > On Apr 2, 2019, at 17:25, hanu mapr wrote: > > Hello Vova, > > Option 2 makes sense to me. I

Re: Drill not compiling after rebase!!

Hello Vova, Option 2 makes sense to me. I have tried with type casting the accept method and it worked. Thanks, -Hanu On Tue, Apr 2, 2019 at 9:23 AM Arina Yelchiyeva wrote: > I would go with the second approach, since it would have less impact on > the project. > > Kind regards, > Arina > > >

Re: Drill not compiling after rebase!!

I would go with the second approach, since it would have less impact on the project. Kind regards, Arina > On Apr 2, 2019, at 6:53 PM, Vova Vysotskyi wrote: > > Hi, > > For now, I see two ways of solving this issue: > > 1. Find minimum JDK build version where this issue is fixed and specify

Re: Drill not compiling after rebase!!

Hi, For now, I see two ways of solving this issue: 1. Find minimum JDK build version where this issue is fixed and specify it in requireJavaVersion tag in maven-enforcer-plugin: https://maven.apache.org/enforcer/enforcer-rules/requireJavaVersion.html So build will fail with a clear error message

Re: Drill not compiling after rebase!!

All, I tried this on another machine with a higher version of Java and it worked without the changes below. So it would seem that this probably is a bug in JDK. How do we proceed? > On Apr 1, 2019, at 17:12, Sorabh Hamirwasia wrote: > > I am not seeing any issue with latest maven and with

Re: Drill not compiling after rebase!!

I am not seeing any issue with latest maven and with below java version. As Vova suggested this could be a JDK bug. *# mvn --version* *Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0* *Apache Maven 3.6.0

Re: Drill not compiling after rebase!!

Hello Vova, Here is the java version on my laptop. HMADURI-E597:drill hmaduri$ java -version java version "1.8.0_91" Java(TM) SE Runtime Environment (build 1.8.0_91-b14) Java HotSpot(TM) 64-Bit Server VM (build 25.91-b14, mixed mode) HMADURI-E597:drill hmaduri$ javac -version javac 1.8.0_91

Re: Drill not compiling after rebase!!

Hi Volodmyr, I’m on a Mac OSX Mohave, java version 1.8.0_65, maven version 3.6.0. In order to get Drill to build I had to make the following changes: org/apache/drill/exec/store/parquet/TestParquetFilterPushDown.java (add try/catch) private void

Re: Drill not compiling after rebase!!

Hi all, Looking into the code, I don't see a reason for compilation failure, since the exception type should be inferred from *FieldReferenceFinder*, which contains *RuntimeException*. Perhaps it may be JDK bug, something like this https://bugs.openjdk.java.net/browse/JDK-8066974. Charles, Hanu,

Re: Drill not compiling after rebase!!

Hi Hanu, I posted code that fixed this to the list. Once I did that, it worked fine. —C > On Apr 1, 2019, at 15:39, hanu mapr wrote: > > Hello All, > > The exact function which is causing this error is the following. > > public static RowsMatch evalFilter(LogicalExpression expr, >

Re: Drill not compiling after rebase!!

Hello All, The exact function which is causing this error is the following. public static RowsMatch evalFilter(LogicalExpression expr, MetadataBase.ParquetTableMetadataBase footer, int rowGroupIndex, OptionManager options, FragmentContext fragmentContext)

Re: Drill not compiling after rebase!!

Hello All, I am also getting the same error which Charles got on compilation of the latest build. Here is the message which I got. [ERROR] /Users/hmaduri/contribs/APACHE/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/FilterEvaluatorUtils.java:[59,68] error: unreported

Re: Drill not compiling after rebase!!

Hey Charles, On the latest apache/drill master, I don't see any errors during build / running unit tests. But sometimes I've seen this issue with stale artifacts.. Can you clear all maven artifacts from your local maven repo cache and build master again (or with -U option)? On Mon, Apr 1, 2019

Re: Drill not compiling after rebase!!

Hello all, There does seem to be some regression here… In order to get Drill to build I had to make the following changes: org/apache/drill/exec/store/parquet/TestParquetFilterPushDown.java (add try/catch) private void testParquetRowGroupFilterEval(MetadataBase.ParquetTableMetadataBase

Re: Drill not compiling after rebase!!

Hey Arina, Just some more info… I cloned the repo straight from the Apache/Drill github repo, attempted to build and got the same error. I’m on a Mac OSX Mohave, java version 1.8.0_65, maven version 3.6.0. Could there be something in my environment that is causing this? Can anyone else

Re: Drill not compiling after rebase!!

Hey Arina, Any suggestions on how to fix? I’ve tried rebasing again to no avail. > On Apr 1, 2019, at 10:28, Arina Yelchiyeva wrote: > > Hi Charles, > > Build on the latest commit is successful - >

Re: Drill not compiling after rebase!!

Hi Charles, Build on the latest commit is successful - https://travis-ci.org/apache/drill/builds/514145219?utm_source=github_status_medium=notification Git does not always rebase smoothly, even

Drill not compiling after rebase!!

All, I just rebased Drill with the latest commits and it no longer builds. I’m getting the following errors: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project drill-java-exec: Compilation failure [ERROR]