Re: Time for a 1.7 release

2016-06-22 Thread Aman Sinha
DRILL-4733 patch is reviewed and tested, so I will include it in the release (pending a minor update to the unit test). A regression was reported for a few decimal tests, see https://issues.apache.org/jira/browse/DRILL-4746, which was caused by DRILL-3149, so I will be excluding this commit from

Re: Time for a 1.7 release

2016-06-20 Thread Aman Sinha
Quick update: DRILL-4733 (https://issues.apache.org/jira/browse/DRILL-4733) is a regression that Drill QA team found today, so I will have to wait to have it resolved for 1.7.0 before creating a release candidate. On Mon, Jun 20, 2016 at 1:52 PM, Johannes Schulte < johannes.schu...@gmail.com>

Re: Time for a 1.7 release

2016-06-20 Thread Johannes Schulte
Speaking for DRILL-4574: I can get a simple mvn test to run, even on the master. I always get [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack (unpack-vector-types) on project drill-java-exec: Artifact has not been packaged yet. When used on reactor

Re: Time for a 1.7 release

2016-06-19 Thread Aman Sinha
For the fixes that were committed in the last few days, could the committers close the pull requests and update the JIRAs with 'Fixed' status for 1.7. For the remaining JIRAs mentioned in this thread, here are the status: 1. DRILL-4525 (BETWEEN clause on Date and Timestamp): the right place to

Re: Time for a 1.7 release

2016-06-16 Thread Aman Sinha
It does look like DRILL-4574 was previously reviewed and ready to be merged. Right now it will need to be rebased on master branch. Since this is in the Avro plugin, I am unsure about the types of tests that need to be run.. I would prefer if Jason Altekruse could take a quick look and merge

Re: Time for a 1.7 release

2016-06-16 Thread Johannes Schulte
Hi, https://github.com/apache/drill/pull/459 ( https://issues.apache.org/jira/browse/DRILL-4574) is still not merged but i think it is ready for a merge. Are there any other actions necessary? Johannes On Thu, Jun 16, 2016 at 8:07 PM, Jinfeng Ni wrote: > I will review

Re: Time for a 1.7 release

2016-06-16 Thread Jinfeng Ni
I will review the Sean's PR for DRILL-4525, since it's a regression from 1.6. On Thu, Jun 16, 2016 at 9:39 AM, rahul challapalli wrote: > I would like to have DRILL-4525 as this is a regression (most likely from > 1.6). Any takers for this? > > - Rahul > > On Wed,

Re: Time for a 1.7 release

2016-06-15 Thread Aman Sinha
I can take a look at DRILL-4653. Could someone familiar with the Decimal type take a look at DRILL-4704 ? Agree with Dave that it is a simple case that should be fixed (note, however, that decimal is disabled by default currently). On Wed, Jun 15, 2016 at 3:12 PM, Subbu Srinivasan

Re: Time for a 1.7 release

2016-06-15 Thread Subbu Srinivasan
Who can review https://issues.apache.org/jira/browse/DRILL-4653 ? On Wed, Jun 15, 2016 at 1:37 PM, Parth Chandra wrote: > +1 on the 1.7 release > > I'm reviewing the following and hope to get them in the release before > cutoff: >

Re: Time for a 1.7 release

2016-06-15 Thread Parth Chandra
+1 on the 1.7 release I'm reviewing the following and hope to get them in the release before cutoff: https://issues.apache.org/jira/browse/DRILL-2593 https://issues.apache.org/jira/browse/DRILL-4309 On Wed, Jun 15, 2016 at 1:20 PM, Jinfeng Ni wrote: > I'm reviewing a

Re: Time for a 1.7 release

2016-06-15 Thread Jinfeng Ni
I'm reviewing a follow-up PR [1] for DRILL-4573. I think we need get it merged in, since it's a regression in terms of query correctness from release 1.6. [1] https://github.com/apache/drill/pull/512 On Wed, Jun 15, 2016 at 12:21 PM, Dave Oshinsky wrote: > This is a

RE: Time for a 1.7 release

2016-06-15 Thread Dave Oshinsky
This is a pretty basic bug affecting decimal values, with a simple fix: https://issues.apache.org/jira/browse/DRILL-4704 It would be great if it could be reviewed. -Original Message- From: Aman Sinha [mailto:amansi...@apache.org] Sent: Wednesday, June 15, 2016 3:15 PM To: dev Subject:

Re: Time for a 1.7 release

2016-06-15 Thread Subbu Srinivasan
Can https://issues.apache.org/jira/browse/DRILL-4653 be reviewed? On Wed, Jun 15, 2016 at 12:14 PM, Aman Sinha wrote: > Hello everyone, > > A 1.7 release is quite overdue ! I would like to get the ball rolling... > > In preparation, could developers please close the