Re: Time for 1.10 release

2017-03-08 Thread Jinfeng Ni
I merged the PR for DRILL-5326 to master branch, and will start building RC0 shortly. On Tue, Mar 7, 2017 at 2:13 PM, Jinfeng Ni wrote: > Yes, DRILL-5326 is blocking issue for RC0, if build with unit test fails. > > > On Tue, Mar 7, 2017 at 12:55 PM, Zelaine Fong

Re: Time for 1.10 release

2017-03-07 Thread Jinfeng Ni
Yes, DRILL-5326 is blocking issue for RC0, if build with unit test fails. On Tue, Mar 7, 2017 at 12:55 PM, Zelaine Fong wrote: > It looks like DRILL-5326 has just been logged. I assume we need this for RC0? > > Vitalii – it looks like you have a fix. Can you post a pull

Re: Time for 1.10 release

2017-03-07 Thread Vitalii Diravka
I posted a PR for the DRILL-5326 since it can be blocker for a new release. Jinfeng, please take a look at this. Kind regards Vitalii On Tue, Mar 7, 2017 at 8:55 PM, Zelaine Fong

Re: Time for 1.10 release

2017-03-07 Thread Zelaine Fong
It looks like DRILL-5326 has just been logged. I assume we need this for RC0? Vitalii – it looks like you have a fix. Can you post a pull request as soon as you’re ready with the change. Thanks. -- Zelaine On 3/3/17, 2:13 PM, "Jinfeng Ni" wrote: Pushed the patch for

Re: Time for 1.10 release

2017-03-03 Thread Jinfeng Ni
Pushed the patch for DRILL-5313, as well as two other patches which were reviewed before 3/1. I will start build RC0 after QA sanity test is completed. On Thu, Mar 2, 2017 at 11:00 PM, Jinfeng Ni wrote: > Looks like the C++ client is not able to built successfully [1], after >

Re: Time for 1.10 release

2017-03-02 Thread Jinfeng Ni
Looks like the C++ client is not able to built successfully [1], after the change of DRILL-5301 / DRILL-5167. This seems to be a blocking issue for 1.10.0, and I'll merge the patch once it's verified/reviewed. 1. https://issues.apache.org/jira/browse/DRILL-5313 On Thu, Mar 2, 2017 at 5:37 PM,

Re: Time for 1.10 release

2017-03-02 Thread Jinfeng Ni
I missed 5208, because it did not show up in Paul's list when he replied to this thread. On Thu, Mar 2, 2017 at 2:58 PM Zelaine Fong wrote: > Jinfeng, > > I notice the following Jira has the ready-to-commit label but isn’t on > your list: > > DRILL-5208 > > Was this one

Re: Time for 1.10 release

2017-03-02 Thread Zelaine Fong
Jinfeng, I notice the following Jira has the ready-to-commit label but isn’t on your list: DRILL-5208 Was this one overlooked? -- Zelaine On 3/2/17, 1:04 PM, "Jinfeng Ni" wrote: The following PRs have been merged to Apache master. DRILL-4994 DRILL-4730

Re: Time for 1.10 release

2017-03-02 Thread Jinfeng Ni
The following PRs have been merged to Apache master. DRILL-4994 DRILL-4730 DRILL-5301 DRILL-5167 DRILL-5221 DRILL-5258 DRILL-5034 DRILL-4963 DRILL-5252 DRILL-5266 DRILL-5284 DRILL-5304 DRILL-5290 DRILL-5287 QA folks will run tests. If no issue found, I'll build a RC0 candidate for 1.10 and start

Re: Time for 1.10 release

2017-03-02 Thread Jinfeng Ni
I'm building a merge branch, and hopefully push to master branch today if things go smoothly. On Wed, Mar 1, 2017 at 7:13 PM, Padma Penumarthy wrote: > Hi Jinfeng, > > Please include DRILL-5287, DRILL-5290 and DRILL-5304. > > Thanks, > Padma > > >> On Feb 22, 2017, at

Re: Time for 1.10 release

2017-03-02 Thread Padma Penumarthy
Hi Jinfeng, Please include DRILL-5287, DRILL-5290 and DRILL-5304. Thanks, Padma > On Feb 22, 2017, at 11:16 PM, Jinfeng Ni wrote: > > Hi Drillers, > > It has been almost 3 months since we release Drill 1.9. We have > resolved plenty of fixes and improvements (closed around

Re: Time for 1.10 release

2017-03-01 Thread Jinfeng Ni
Hi Laurent, Thanks for the update. I'm putting the patches in a merge branch, and will merge to master once I complete the regression run. On Wed, Mar 1, 2017 at 6:18 PM, Laurent Goujon wrote: > The C++ patches have been built under windows/Linux/macos, and sanity >

Re: Time for 1.10 release

2017-03-01 Thread Laurent Goujon
The C++ patches have been built under windows/Linux/macos, and sanity checks have been done for all of them. For the escape character fix and the cancel fix, those have been tested in production like environment for weeks. Laurent On Mar 1, 2017 13:10, "Jinfeng Ni" wrote: Hi

Re: Time for 1.10 release

2017-03-01 Thread Jinfeng Ni
I applied Laurent's PR on top of latest Apache master branch, and hit build failure: " This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.

Re: Time for 1.10 release

2017-03-01 Thread Jinfeng Ni
Hi Laurent, Thanks for the update. For the C++ client commits (DRILL-5301, DRILL-5221), did you guys run some sanity check to see if there is any regression? I know Parth used to build/test with the new C++ change. Since he is not available this time, just wanna to check if you have done similar

Re: Time for 1.10 release

2017-03-01 Thread Laurent Goujon
The following jiras have all been reviewed and are ready to commit: * DRILL-4994: Add back JDBC prepared statement for older servers * DRILL-4730: Update JDBC DatabaseMetaData implementation to use new Metadata APIs * DRILL-5301: Server metadata API * DRILL-5167: Send escape character for metadata

Re: Time for 1.10 release

2017-02-27 Thread Laurent Goujon
Thanks for the heads up: I'll try to ping directly some committers to review my changes. For information, what's the official cutoff date? Laurent PS: it's too bad that people with expertise don't have time to review my patches, since some of them have been open for weeks or even months (e.g.

Re: Time for 1.10 release

2017-02-27 Thread Jinfeng Ni
Here are the current status for the pending PRs for 1.10. JIRAs have been merged into Apache master branches: DRILL-4280 DRILL-5275 DRILL-5260 DRILL-5273 DRILL-5257 DRILL-5255 DRILL-5274 JIRAs that are in "ready-to-commit" status: DRILL-5258 DRILL-5034 DRILL-4963

Re: Time for 1.10 release

2017-02-27 Thread Laurent Goujon
Hi Jinfeng, Thanks for volunteering: Please consider the following JIRAs (PRs already open): * DRILL-4994: Add back JDBC prepared statement for older servers * DRILL-4730: Update JDBC DatabaseMetaData implementation to use new Metadata APIs * DRILL-5301: Server metadata API * DRILL-5167: Send

Re: Time for 1.10 release

2017-02-24 Thread Arina Yelchiyeva
Hi Jinfeng, please also consider the following Jiras (PR are already open): * DRILL-4963: Issues when overloading Drill native functions with dynamic UDFs * DRILL-5255: Remove default temporary workspace check at drillbit start up * DRILL-5274: Exception thrown in Drillbit shutdown in UDF cleanup

Re: Time for 1.10 release

2017-02-23 Thread Paul Rogers
Hi Jinfeng, Thanks for volunteering! The following are working their way though the system: PRs outstanding: * DRILL-5275: Sort spill is slow due to repeated allocations * DRILL-5260: Extend "Cluster Fixture" test framework * DRILL-5258: Access mock data definition from SQL * DRILL-5273:

Re: Time for 1.10 release

2017-02-23 Thread Sudheesh Katkam
I would like to include: + DRILL-4280: https://github.com/apache/drill/pull/578 (going through the last round of comments) Thank you, Sudheesh > On Feb 22, 2017, at 11:16 PM, Jinfeng Ni wrote: > > Hi Drillers, > > It has been almost 3 months since we release Drill 1.9. We