RE: question on failed unit test (in protobuf)

2016-08-12 Thread Dave Oshinsky
Message- From: Dave Oshinsky [mailto:doshin...@commvault.com] Sent: Friday, August 12, 2016 6:27 PM To: dev@drill.apache.org Subject: RE: question on failed unit test (in protobuf) Thanks Jinfeng, you nailed it. I added some incorrect code in GetSetVectorHelper.java for VARDECIMAL Regarding

RE: question on failed unit test (in protobuf)

2016-08-12 Thread Dave Oshinsky
t 12, 2016 5:55 PM To: dev Subject: Re: question on failed unit test (in protobuf) Have you looked at GetSetVectorHelper [1]? Are you trying to model decimal as something similar to VARCHAR, since you use VARDECMIAL? If that's the case, you need check the code corresponding to VARCHAR, which has both

Re: question on failed unit test (in protobuf)

2016-08-12 Thread Jinfeng Ni
out8 = out; > } > // end of eval portion of equal function. // > return (out8 .value == 1); > } > } > > public void __DRILL_INIT__() > throws SchemaChangeException > { > } > >

RE: question on failed unit test (in protobuf)

2016-08-12 Thread Dave Oshinsky
...@commvault.com] Sent: Friday, August 12, 2016 1:09 PM To: dev@drill.apache.org Subject: RE: question on failed unit test (in protobuf) Jinfeng, Actually, it turned out that the error message was because some of the hooks in the code to setup the Casting mechanism were missing for VARDE

RE: question on failed unit test (in protobuf)

2016-08-12 Thread Dave Oshinsky
dex + 1, outputStart + len); from.data.getBytes(start, data, outputStart, len); return true; } -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Thursday, August 11, 2016 7:28 PM To: dev Subject: Re: question on failed unit test (in protobuf) For IDEA debu

Re: question on failed unit test (in protobuf)

2016-08-11 Thread Jinfeng Ni
mvau > lt.com:31010] (state=,code=0) > 0: jdbc:drill:zk=local> > > Dave Oshinsky > > -Original Message- > From: Jinfeng Ni [mailto:jinfengn...@gmail.com] > Sent: Thursday, August 11, 2016 2:05 PM > To: dev > Subject: Re: question on failed unit test

RE: question on failed unit test (in protobuf)

2016-08-11 Thread Dave Oshinsky
Oshinsky -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Thursday, August 11, 2016 2:05 PM To: dev Subject: Re: question on failed unit test (in protobuf) The readme.txt is right in protocol directory, where the protobuf definition files are located. Actuall

RE: question on failed unit test (in protobuf)

2016-08-11 Thread Dave Oshinsky
IntelliJ IDEA)? Dave Oshinsky -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Wednesday, August 10, 2016 8:59 PM To: dev Subject: Re: question on failed unit test (in protobuf) Did you follow the steps specified in this readme.txt [1]? [1] https://github.com

Re: question on failed unit test (in protobuf)

2016-08-10 Thread Jinfeng Ni
Did you follow the steps specified in this readme.txt [1]? [1] https://github.com/apache/drill/blob/master/protocol/readme.txt On Tue, Aug 9, 2016 at 3:59 PM, Dave Oshinsky wrote: > I have a drill 1.7 node (Windows 7, Java 8) in which I've made numerous > experimental

question on failed unit test (in protobuf)

2016-08-09 Thread Dave Oshinsky
I have a drill 1.7 node (Windows 7, Java 8) in which I've made numerous experimental changes to try adding a new kind of vector, VarDecimal. I found that I needed to modify Types.proto to add "VARDECIMAL = 43;", and I ran protoc.exe to generate a new TypeProtos.java. Do I need to change