[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/500 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Dynamic UDFs support

Hi all! I have created Jira to allow dynamic UDFs support in Drill ( https://issues.apache.org/jira/browse/DRILL-4726). There is a link to design document in Jira description. Comments or suggestions are welcomed. Kind regards Arina

[jira] [Created] (DRILL-4726) Dynamic UDFs support

Arina Ielchiieva created DRILL-4726: --- Summary: Dynamic UDFs support Key: DRILL-4726 URL: https://issues.apache.org/jira/browse/DRILL-4726 Project: Apache Drill Issue Type: New Feature

[GitHub] drill pull request #525: DRILL-4727: Exclude netty from HBase Client's trans...

GitHub user adityakishore opened a pull request: https://github.com/apache/drill/pull/525 DRILL-4727: Exclude netty from HBase Client's transitive dependencies Excluded `netty-all` from the list of transitive dependencies pulled by `hbase-client`. You can merge this pull request

[GitHub] drill pull request #524: DRILL-4725: Improvements to InfoSchema RecordGenera...

Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/524#discussion_r67415245 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilterBuilder.java --- @@ -73,9 +73,12 @@ public ExprNode

[jira] [Created] (DRILL-4727) Exclude netty from HBase Client's transitive dependencies

Aditya Kishore created DRILL-4727: - Summary: Exclude netty from HBase Client's transitive dependencies Key: DRILL-4727 URL: https://issues.apache.org/jira/browse/DRILL-4727 Project: Apache Drill

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67426795 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java --- @@ -179,4 +180,43 @@ public void

Re: Question about Fragment Stats start time

It has to do with fast schema. It doesn't matter when the start time is called because all the fragments will execute right at the beginning of the query and propagate a first "schema batch". You could possibly modify it to be the start of the second batch time to get what you want. (This would

[GitHub] drill issue #524: DRILL-4725: Improvements to InfoSchema RecordGenerator nee...

Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/524 Updated patch addresses the review comment. Separated the binary and ternary into separate cases with proper variable names. --- If your project is set up for it, you can reply to this email and

Re: Time for a 1.7 release

It does look like DRILL-4574 was previously reviewed and ready to be merged. Right now it will need to be rebased on master branch. Since this is in the Avro plugin, I am unsure about the types of tests that need to be run.. I would prefer if Jason Altekruse could take a quick look and merge

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/518 Looks much better. Sorry for the nitpick but I still have a couple more related to the coding conventions. :)Also, could you squash the commits into 1 and use the DRILL-: format for

[GitHub] drill issue #524: DRILL-4725: Improvements to InfoSchema RecordGenerator nee...

Github user jaltekruse commented on the issue: https://github.com/apache/drill/pull/524 +1 one small comment, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Time for a 1.7 release

Hi, https://github.com/apache/drill/pull/459 ( https://issues.apache.org/jira/browse/DRILL-4574) is still not merged but i think it is ready for a merge. Are there any other actions necessary? Johannes On Thu, Jun 16, 2016 at 8:07 PM, Jinfeng Ni wrote: > I will review

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user ssriniva123 commented on the issue: https://github.com/apache/drill/pull/518 I have made changes are recommended by reviewers: - Changed JSON_READER_SKIP_INVALID_RECORDS_FLAG constant - Modified unit test to use builder framework - Code indendation changes.

Re: Question about Fragment Stats start time

Thanks Jacques for the explanation. I'm actually looking into ways to improve this, so hopefully we'll have better information in the profiles On Thu, Jun 16, 2016 at 2:14 PM, rahul challapalli < challapallira...@gmail.com> wrote: > +1 on this change. The existing numbers are misleading

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67426381 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java --- @@ -189,39 +191,33 @@ private long

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user ssriniva123 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67431369 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java --- @@ -189,39 +191,33 @@ private long

[GitHub] drill issue #521: DRILL-4715: Fix java compilation error in run-time generat...

Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/521 I had couple of minor comments. Changes LGTM. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill issue #521: DRILL-4715: Fix java compilation error in run-time generat...

Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/521 Just to be sure, I confirmed with @jinfengni that the new generated code would look like the following: (assume 100 expressions in the Project and limit of 50 exprs per block): doEval()

[GitHub] drill pull request #521: DRILL-4715: Fix java compilation error in run-time ...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/521#discussion_r67442526 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java --- @@ -215,22 +219,47 @@ public JVar

[GitHub] drill pull request #521: DRILL-4715: Fix java compilation error in run-time ...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/521#discussion_r67442811 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/SizedJBlock.java --- @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software

Re: DRILL-4199: Add Support for HBase 1.X - planning to merge

https://issues.apache.org/jira/browse/DRILL-4727 On Thu, Jun 16, 2016 at 11:39 AM, Aman Sinha wrote: > Qiang/Aditya can you create a JIRA for this and mark it for 1.7. thanks. > > On Thu, Jun 16, 2016 at 11:25 AM, Aditya wrote: > > > Thanks for

Re: Question about Fragment Stats start time

+1 on this change. The existing numbers are misleading sometimes. - Rahul On Thu, Jun 16, 2016 at 2:03 PM, Jacques Nadeau wrote: > It has to do with fast schema. It doesn't matter when the start time is > called because all the fragments will execute right at the beginning

[GitHub] drill issue #501: DRILL-2385: Count on complex objects failed with missing f...

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/501 Squashing and rebasing to the master were done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill pull request #519: DRILL-4530: Optimize partition pruning with metadat...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/519#discussion_r67387102 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -208,8 +209,18 @@ public DrillTable

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67388118 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java --- @@ -39,6 +40,7 @@ import

Re: Dynamic UDFs support

Charles - I think would be pretty cool. It would add in some functionality we "lost" when we moved on from Hive (you could use transform with a python script to do some basic in and out). This would be a neat feature, but I think it would benefit from a design document outlining what it would

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67389073 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -135,6 +135,9 @@ BooleanValidator JSON_EXTENDED_TYPES = new

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67389956 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java --- @@ -116,6 +117,7 @@ public void

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67390934 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java --- @@ -116,6 +117,7 @@ public void

[GitHub] drill pull request #519: DRILL-4530: Optimize partition pruning with metadat...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/519#discussion_r67392462 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -208,8 +209,18 @@ public DrillTable

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67389362 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java --- @@ -189,39 +194,37 @@ private long

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67389726 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java --- @@ -189,39 +194,37 @@ private long

Re: Dynamic UDFs support

Since UDF's use source code transformation, using Jython would be difficult. On Thu, Jun 16, 2016 at 9:42 AM, Arina Yelchiyeva < arina.yelchiy...@gmail.com> wrote: > Hi Charles, > > not that I am aware of. Proposed solution doesn't invent anything new, just > adds possibility to add UDFs

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67389846 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java --- @@ -189,39 +194,37 @@ private long

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67390506 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java --- @@ -179,4 +181,28 @@ public void

Re: Dynamic UDFs support

Hi Charles, not that I am aware of. Proposed solution doesn't invent anything new, just adds possibility to add UDFs without drillbit restart. But contributions are welcomed. On Thu, Jun 16, 2016 at 4:52 PM Charles Givre wrote: > Arina, > Has there been any discussion about

[GitHub] drill issue #523: DRILL-2593: 500 error when crc for a query profile is out ...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/523 +1. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: DRILL-4199: Add Support for HBase 1.X - planning to merge

Thanks for reporting, I'm looking into it and will post a patch soon. On Wed, Jun 15, 2016 at 7:27 PM, qiang li wrote: > Hi Aditya, > > I tested the latest version and got this exception and the drillbit fail > to startup . > > Exception in thread "main"

Re: Time for a 1.7 release

I will review the Sean's PR for DRILL-4525, since it's a regression from 1.6. On Thu, Jun 16, 2016 at 9:39 AM, rahul challapalli wrote: > I would like to have DRILL-4525 as this is a regression (most likely from > 1.6). Any takers for this? > > - Rahul > > On Wed,

Question about Fragment Stats start time

Hey all, In the query profile, fragment's start time is taken when the fragment is first initialized. For leaf fragments that's fine as they'll start running right away, but for intermediate/root fragment, a long time may pass before they effectively start running (submitted to the execution

Re: DRILL-4199: Add Support for HBase 1.X - planning to merge

Qiang/Aditya can you create a JIRA for this and mark it for 1.7. thanks. On Thu, Jun 16, 2016 at 11:25 AM, Aditya wrote: > Thanks for reporting, I'm looking into it and will post a patch soon. > > On Wed, Jun 15, 2016 at 7:27 PM, qiang li wrote: