[GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/685#discussion_r91516244 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -115,6 +118,7 @@ public UserSession build() {

[GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...

GitHub user nagarajanchinnasamy opened a pull request: https://github.com/apache/drill/pull/685 Drill 5043: Function that returns a unique id per session/connection similar to MySQL's CONNECTION_ID() Please check [DRILL-5043](https://issues.apache.org/jira/browse/DRILL-5043) for

[GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/685#discussion_r91515498 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -115,6 +118,7 @@ public UserSession build() {

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91531972 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java --- @@ -33,36 +32,71 @@ import

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91531999 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java --- @@ -33,36 +32,71 @@ import

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91285978 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassCompilerSelector.java --- @@ -0,0 +1,146 @@ +/** + * Licensed to

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91529643 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java --- @@ -58,5 +56,27 @@ public

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91510444 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java --- @@ -0,0 +1,190 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91509053 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassCompilerSelector.java --- @@ -0,0 +1,146 @@ +/** + * Licensed to

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91513389 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java --- @@ -67,6 +72,14 @@ public boolean isCompiled() {

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91533256 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java --- @@ -0,0 +1,190 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91300674 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java --- @@ -711,18 +711,20 @@ private MSorter

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91513124 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassCompilerSelector.java --- @@ -0,0 +1,146 @@ +/** + * Licensed to

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91511795 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java --- @@ -58,5 +56,27 @@ public

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91531809 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java --- @@ -0,0 +1,190 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91300485 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java --- @@ -67,26 +96,71 @@ try { this.model =

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91300800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java --- @@ -711,18 +711,20 @@ private MSorter

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91279238 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java --- @@ -411,6 +417,10 @@ public boolean equals(Object obj) {

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91276697 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java --- @@ -0,0 +1,70 @@ +/** + * Licensed to the

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91278330 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91520598 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java --- @@ -38,14 +39,18 @@ private

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91278968 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91274791 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java --- @@ -0,0 +1,70 @@ +/** + * Licensed to the

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91275047 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java --- @@ -0,0 +1,70 @@ +/** + * Licensed to the

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91509351 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/MergeAdapter.java --- @@ -253,7 +257,13 @@ public static MergedClassResult

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91277152 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java --- @@ -33,36 +32,71 @@ import

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91278889 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/DirectExpression.java --- @@ -20,6 +20,12 @@ import

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91521257 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java --- @@ -67,6 +72,14 @@ public boolean isCompiled() {

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91322821 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/TemplateClassDefinition.java --- @@ -63,6 +78,14 @@ public SignatureHolder

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91273747 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java --- @@ -0,0 +1,70 @@ +/** + * Licensed to the

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91279454 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java --- @@ -246,6 +246,12 @@ public void rotateBlock() {

UDF Question

Hello Drill Developers, I have a question for the community. I’m working on a UDF which depends on a static datafile—specifically the MaxMindDB for Geolocating IP addresses. I have a UDF that takes an IP and queries the MaxMindDB for the Geo information, but the UDF required me to hard code

[GitHub] drill issue #660: DRILL-5052: Option to debug generated Java code using an I...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/660 Paul, it's really good feature! I have left some comments in PR. Other than that: 1. Please format the code to remove unnecessary spaces. Examples: addClass( key, results.get(

[GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/685 As it turns out, Arina is building something very similar for the CTTAS feature. See the PR: https://github.com/apache/drill/pull/666 Can the two of your coordinate so that the same ID

Request: new JIRA component "Client - Java"

I'm becoming a user of DrillClient as a means to sending queries to Drill. There isn't a good component to categorize JIRA tickets for that. I'd like to request that someone with admin rights on the Drill JIRA create a new component for "Client - Java" Thanks!

[GitHub] drill issue #684: DRILL-5070: Code gen: create methods in fixed order to all...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/684 Golden copies are needed only for tests that, today, do their "testing" by dumping generated code to stdout. Such tests do absolutely nothing (other than detect crashes) when run under Maven. The

Re: Request: new JIRA component "Client - Java"

Done. -- Zelaine On Thu, Dec 8, 2016 at 11:08 AM, Chris Westin wrote: > I'm becoming a user of DrillClient as a means to sending queries to Drill. > There isn't a good component to categorize JIRA tickets for that. I'd like > to request that someone with admin rights

[jira] [Created] (DRILL-5115) Metadata Cache Pruning randomly returns wrong results at higher concurrencies

Rahul Challapalli created DRILL-5115: Summary: Metadata Cache Pruning randomly returns wrong results at higher concurrencies Key: DRILL-5115 URL: https://issues.apache.org/jira/browse/DRILL-5115

Is it ok to including tpch queries in source codes?

Hi Drill Dev, I noticed that drill has included all the tcph queries in the unit test codes to verify whether these queries can be translated properly. I was wondering is there any legal restriction or license problem which will prevent a ASF project doing this? Have you guys cheched this?

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91638121 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java --- @@ -33,36 +32,71 @@ import

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91634477 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassCompilerSelector.java --- @@ -0,0 +1,146 @@ +/** + * Licensed to the

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91633361 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java --- @@ -0,0 +1,190 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91642060 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91640657 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/TemplateClassDefinition.java --- @@ -63,6 +78,14 @@ public SignatureHolder

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91640094 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java --- @@ -58,5 +56,27 @@ public

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91642556 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java --- @@ -711,18 +711,20 @@ private MSorter

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91641345 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java --- @@ -246,6 +246,12 @@ public void rotateBlock() {

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91633167 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java --- @@ -0,0 +1,190 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91632144 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java --- @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91641492 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java --- @@ -411,6 +417,10 @@ public boolean equals(Object obj) {

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91642120 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91633759 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java --- @@ -0,0 +1,190 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91640219 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/MergeAdapter.java --- @@ -253,7 +257,13 @@ public static MergedClassResult

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91632286 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java --- @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91642325 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/DirectExpression.java --- @@ -20,6 +20,12 @@ import

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91634371 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassCompilerSelector.java --- @@ -0,0 +1,146 @@ +/** + * Licensed to the

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91642538 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java --- @@ -711,18 +711,20 @@ private MSorter

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91638426 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java --- @@ -67,6 +72,14 @@ public boolean isCompiled() {

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91631857 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java --- @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91635970 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java --- @@ -33,36 +32,71 @@ import

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91638845 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java --- @@ -58,5 +56,27 @@ public

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91638703 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java --- @@ -67,6 +72,14 @@ public boolean isCompiled() {

[GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91641555 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java --- @@ -67,26 +96,71 @@ try { this.model = new