[GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/938#discussion_r138240616 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -297,10 +302,7 @@ public void

[GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/938#discussion_r138236250 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -92,18 +92,20 @@ // Hash Aggregate Options -

[jira] [Resolved] (DRILL-5522) OOM during the merge and spill process of the managed external sort

[ https://issues.apache.org/jira/browse/DRILL-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hou resolved DRILL-5522. --- Resolution: Fixed This has been resolved. > OOM during the merge and spill process of the managed

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138205470 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java --- @@ -56,7 +56,7 @@ public void checkChangedColumn() throws Exception

[GitHub] drill issue #923: DRILL-5723: Added System Internal Options That can be Modi...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/923 @paul-rogers Finished apply review comments. PR is ready for review again. ---

[GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/938#discussion_r138236176 --- Diff: common/src/main/java/org/apache/drill/common/exceptions/RetryAfterSpillException.java --- @@ -0,0 +1,32 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/938#discussion_r138236706 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -109,14 +107,21 @@ private

[jira] [Resolved] (DRILL-5443) Managed External Sort fails with OOM while spilling to disk

[ https://issues.apache.org/jira/browse/DRILL-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hou resolved DRILL-5443. --- Resolution: Fixed This has been resolved. > Managed External Sort fails with OOM while spilling to

[GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/938#discussion_r138236560 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java --- @@ -293,7 +299,7 @@ private HashAggregator

[jira] [Created] (DRILL-5780) Apache Drill in embedded mode

Mayank Jain created DRILL-5780: -- Summary: Apache Drill in embedded mode Key: DRILL-5780 URL: https://issues.apache.org/jira/browse/DRILL-5780 Project: Apache Drill Issue Type: Task

[GitHub] drill issue #925: DRILL-5749: solve foreman and netty threads deadlock

Github user weijietong commented on the issue: https://github.com/apache/drill/pull/925 @paul-rogers have refactored the codes. @sudheeshkatkam nothing to fix ,once the netty thread got the re-spawned RPC connection ,it will send out the message. ---

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138168189 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionMetaData.java --- @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138171404 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/DrillConfigIterator.java --- @@ -58,17 +58,17 @@ public OptionValue next() {

Re: Checkstyle Unused Imports

On Mon, Sep 11, 2017 at 6:53 PM, Paul Rogers wrote: > The check style improvements are good, they will likely save developers > minutes per day. > > I would encourage us to consider other time savers. > > In normal development builds, Checkstyle issues should be warnings, not >

Re: Checkstyle Unused Imports

The options Ted is thinking of are: -Dcheckstyle.skip -DskipTests Julian > On Sep 11, 2017, at 12:46 PM, Ted Dunning wrote: > > On Mon, Sep 11, 2017 at 6:53 PM, Paul Rogers wrote: > >> The check style improvements are good, they will likely save

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138173050 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/BaseOptionManager.java --- @@ -17,44 +17,84 @@ */ package

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138167788 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java --- @@ -63,32 +88,32 @@ public final Double float_val;

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138168825 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionManager.java --- @@ -17,49 +17,97 @@ */ package

Re: UDF java.lang.IndexOutOfBoundsException

argh. buffer = out.buffer = buffer.reallocIfNeeded(outputSize); found it in the STAsText.java example. apologies for dev spam. -boB On Mon, Sep 11, 2017 at 10:32 AM, Bob Rudis wrote: > I'm working on a base64 encoding / decoding UDFs for Drill and > building off of other,

UDF java.lang.IndexOutOfBoundsException

I'm working on a base64 encoding / decoding UDFs for Drill and building off of other, simple UDFs I've written before. If the byte array is larger than 256 I get: java.lang.IndexOutOfBoundsException: index: 0, length: (expected: range(0, 256)) regardless of which @Output holder I've

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138133105 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java --- @@ -216,79 +216,77 @@ public void

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138132972 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/RestClientFixture.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138133008 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java --- @@ -150,66 +150,61 @@ public void pauseOnSpecificBit() {

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138132892 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java --- @@ -56,7 +56,7 @@ public void checkChangedColumn() throws Exception

[GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/930#discussion_r138102613 --- Diff: common/src/test/resources/logback-test.xml --- @@ -0,0 +1,111 @@ + + + + + + + +true +

[GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/930#discussion_r138103031 --- Diff: common/src/test/resources/logback-test.xml --- @@ -0,0 +1,111 @@ + + + + + + + +true +

[GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/930#discussion_r138100617 --- Diff: common/src/test/resources/logback-test.xml --- @@ -0,0 +1,111 @@ + + + + + + + +true +

Re: Checkstyle Unused Imports

The check style improvements are good, they will likely save developers minutes per day. I would encourage us to consider other time savers. In normal development builds, Checkstyle issues should be warnings, not errors. Developers waste many five-minute build cycles per day when we do a quick

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138133824 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java --- @@ -71,7 +72,8 @@ public void

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138152185 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -346,17 +347,63 @@ public void

Checkstyle error or warning (was: Checkstyle Unused Imports)

I think that it is not necessary to or even undesirable to convert code style (checkstyle) errors into warnings. I am not sure how it is handled in Drill, in Apex we use -Dcheckstyle.skip=true to disable checkstyle plugin during development builds. If the community prefers, another option

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138148176 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java --- @@ -102,10 +103,11 @@ public void

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138152163 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java --- @@ -102,10 +103,11 @@ public void

Re: Checkstyle Unused Imports

Let's not muddle the original suggestion that Tim had which was simply about having checkstyle do the checks for unused imports. That seems reasonable to me. A few other checkstyle suggestions that people have made could also be added. All other discussion about code structure, unit tests etc

[GitHub] drill pull request #937: DRILL-5002: Using hive's date functions on top of d...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/937#discussion_r138133454 --- Diff: contrib/storage-hive/core/src/main/codegen/templates/ObjectInspectorHelper.java --- @@ -204,7 +204,11 @@ public static JBlock

[GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/930#discussion_r138200345 --- Diff: common/src/test/resources/logback-test.xml --- @@ -0,0 +1,111 @@ + + + + + + + +true +

[GitHub] drill issue #916: DRILL-5377: Five-digit year dates are displayed incorrectl...

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/916 @paul-rogers There is no bug with corrupt Parquet dates, it was fixed in context of DRILL-4203. This commit fixes representing of the five digit year dates and doesn't change

[jira] [Resolved] (DRILL-5744) External sort fails with OOM error

[ https://issues.apache.org/jira/browse/DRILL-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hou resolved DRILL-5744. --- Resolution: Fixed This has been verified. > External sort fails with OOM error >

Re: Checkstyle Unused Imports

On Mon, Sep 11, 2017 at 9:48 PM, Julian Hyde wrote: > The options Ted is thinking of are: > > -Dcheckstyle.skip > -DskipTests > It is sooo cool to have well-informed people around! Thanks Julian.

[jira] [Resolved] (DRILL-5753) Managed External Sort: One or more nodes ran out of memory while executing the query.

[ https://issues.apache.org/jira/browse/DRILL-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hou resolved DRILL-5753. --- Resolution: Fixed > Managed External Sort: One or more nodes ran out of memory while executing > the

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138182296 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/BaseOptionManager.java --- @@ -17,44 +17,84 @@ */ package