[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-28 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198912485 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -63,17

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-28 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198902957 ## File path: distribution/src/deb/control/conffiles ## @@ -16,3 +16,4 @@ /etc/drill/conf/drill-override.conf

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-28 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198912059 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83,15

[GitHub] sohami commented on issue #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i…

2018-06-28 Thread GitBox
sohami commented on issue #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i… URL: https://github.com/apache/drill/pull/1352#issuecomment-401251159 @Ben-Zvi - Can you please review this ? This is an

[GitHub] sohami edited a comment on issue #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i…

2018-06-28 Thread GitBox
sohami edited a comment on issue #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i… URL: https://github.com/apache/drill/pull/1352#issuecomment-401251159 @Ben-Zvi - Can you please review this ? Issue was in BuildSchema phase TopN was receiving NONE outcome

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Timothy Farkas
Hi Charles, So it is actually supported. Drill's boolean vector is BitVector. Internally bits are stored efficiently, but when you fetch a bit from the vector it becomes an int, -1 for true and 0 for false. So currently you can check this by using singletonInt and comparing against -1 and 0.

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199023543 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199026541 ## File path: exec/java-exec/src/main/resources/rest/storage/list.ftl ## @@ -38,6

[GitHub] HanumathRao commented on a change in pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

2018-06-28 Thread GitBox
HanumathRao commented on a change in pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#discussion_r199027667 ## File path:

[GitHub] chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199033434 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@

[GitHub] Ben-Zvi opened a new pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

2018-06-28 Thread GitBox
Ben-Zvi opened a new pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct URL: https://github.com/apache/drill/pull/1351 (1) Turned the default for Hash Join Fallback to **false**. (2) Added a new option:

Re: Discussion about the metadata design

2018-06-28 Thread weijie tong
Hi Vitalii: Glad to hear that you are also looking at this part. Let's keep discussion under that Jira. On Fri, Jun 29, 2018 at 1:27 AM Vitalii Diravka wrote: > Hi Weijie, > > Thanks for bringing this topic up! > > Basically you are right, Hive Metastore is one the best candidates for >

[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature

2018-06-28 Thread GitBox
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401246375 @weijietong thanks for the PR. Yes, this is high on my list to review. I am tied up until tomorrow but will review during the weekend.

[GitHub] sohami opened a new pull request #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i…

2018-06-28 Thread GitBox
sohami opened a new pull request #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i… URL: https://github.com/apache/drill/pull/1352 …n buildSchema phase This is an automated message from the Apache

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198896839 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198907027 ## File path:

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198899847 ## File path:

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198900647 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198910755 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198910736 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[jira] [Created] (DRILL-6552) Drill Metadata management "Drill MetaStore"

2018-06-28 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-6552: -- Summary: Drill Metadata management "Drill MetaStore" Key: DRILL-6552 URL: https://issues.apache.org/jira/browse/DRILL-6552 Project: Apache Drill Issue

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198911099 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

[jira] [Created] (DRILL-6553) Fix TopN for unnest operator

2018-06-28 Thread Volodymyr Vysotskyi (JIRA)
Volodymyr Vysotskyi created DRILL-6553: -- Summary: Fix TopN for unnest operator Key: DRILL-6553 URL: https://issues.apache.org/jira/browse/DRILL-6553 Project: Apache Drill Issue Type:

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198832226 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,133 @@ + +

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198905422 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,147 @@ + +

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198904728 ## File path: drill-shaded/pom.xml ## @@ -0,0 +1,84 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198903696 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,133 @@ + +

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198907077 ## File path: pom.xml ## @@ -3334,5 +3351,6 @@ exec drill-yarn distribution +

Re: Discussion about the metadata design

2018-06-28 Thread Vitalii Diravka
Hi Weijie, Thanks for bringing this topic up! Basically you are right, Hive Metastore is one the best candidates for storing Driil's metadata. Also it will be good to make an abstraction, which will allow to implement and use other kind of tools for Metastore. The question of Metastore

[GitHub] ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#issuecomment-401101245 @Ben-Zvi addressed review comments. please take a look. This is an

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198911603 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java

[GitHub] Ben-Zvi closed pull request #1340: DRILL-6539: Record count not set for this vector container error

2018-06-28 Thread GitBox
Ben-Zvi closed pull request #1340: DRILL-6539: Record count not set for this vector container error URL: https://github.com/apache/drill/pull/1340 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] Ben-Zvi closed pull request #1341: DRILL-6512: Remove unnecessary processing overhead from RecordBatchSizer

2018-06-28 Thread GitBox
Ben-Zvi closed pull request #1341: DRILL-6512: Remove unnecessary processing overhead from RecordBatchSizer URL: https://github.com/apache/drill/pull/1341 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199036078 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401230944 I am not convinced that a user should be able to change the amount of logging from a client session. A user may cause an

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

2018-06-28 Thread GitBox
weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401230814 ping @amansinha100 @parthchandra or someone else would be pleased to review this PR.

[GitHub] sachouche commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401237920 - Updated code based on most recent comments - Fixed a compilation failure due to changes in the Batch Sizer APIs made

[GitHub] Agirish opened a new pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish opened a new pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350 Added an "Export" button to enabled storage plugins to support exporting the configuration into a JSON file. This can be useful to backup

[GitHub] kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199022055 ## File path: exec/java-exec/src/main/resources/rest/storage/list.ftl ## @@ -38,6

[GitHub] kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199022430 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6

[GitHub] HanumathRao commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

2018-06-28 Thread GitBox
HanumathRao commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-401215354 @vvysotskyi Thanks for making the code changes. Code changes look good to me. +1.

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199037297 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199036653 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198938982 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199036942 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198940291 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199031515 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199037140 ## File path: exec/java-exec/src/main/resources/drill-module.conf ## @@ -482,6 +482,8

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199030833 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198930977 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198935830 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198937973 ## File path:

[GitHub] sachouche commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401231517 @vrozov The logging functionality is not exposed to end users. All batch stats flags are internal.

[jira] [Created] (DRILL-6555) Add unit tests for REST API

2018-06-28 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-6555: -- Summary: Add unit tests for REST API Key: DRILL-6555 URL: https://issues.apache.org/jira/browse/DRILL-6555 Project: Apache Drill Issue Type: Bug

[jira] [Created] (DRILL-6556) Provide secure location for JDBC credentials

2018-06-28 Thread Charles Givre (JIRA)
Charles Givre created DRILL-6556: Summary: Provide secure location for JDBC credentials Key: DRILL-6556 URL: https://issues.apache.org/jira/browse/DRILL-6556 Project: Apache Drill Issue

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199026541 ## File path: exec/java-exec/src/main/resources/rest/storage/list.ftl ## @@ -38,6

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199019017 ## File path:

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199022923 ## File path:

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199018067 ## File path:

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199016141 ## File path:

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199020924 ## File path:

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199026644 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198941031 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198933150 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198937814 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198942743 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199029854 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199036789 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199031792 ## File path:

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198932595 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401234061 @sachouche I refer to your following comment: >User should be able to control batch statistics behavior within a client

Travis CI Timed Out

2018-06-28 Thread Charles Givre
I submitted some changes and the following happened. Any suggestions? Audit done. [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (avoid_bad_dependencies) @ drill-sqlline --- [INFO] [INFO] ---

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198850630 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.java

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198886170 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] arina-ielchiieva edited a comment on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-06-28 Thread GitBox
arina-ielchiieva edited a comment on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401134771 @ilooner maybe we can consider allowing

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Arina Yelchiyeva
Hi Tim, it looks like deprecating BaseTestQuery was a little bit pre-mature. For example, from in this PR - https://github.com/apache/drill/pull/1331 - Charles is trying to re-work BaseTestQuery usage to ClusterTest. First, it did not contain getSigletonDouble method which Charles has

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198861948 ## File path:

Discussion about the metadata design

2018-06-28 Thread weijie tong
HI all: As @aman ever noticed me about the roadmap of DRILL-2.0 ,which includes the description of the metadata design ( https://lists.apache.org/thread.html/74cf48dd78d323535dc942c969e72008884e51f8715f4a20f6f8fb66@%3Cdev.drill.apache.org%3E) , I am interested in taking the role to implement

[GitHub] arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-06-28 Thread GitBox
arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401134771 @ilooner maybe can consider allowing stout to

[GitHub] sohami closed pull request #1323: DRILL-6498: Support for EMIT outcome in ExternalSortBatch

2018-06-28 Thread GitBox
sohami closed pull request #1323: DRILL-6498: Support for EMIT outcome in ExternalSortBatch URL: https://github.com/apache/drill/pull/1323 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] Agirish opened a new pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-28 Thread GitBox
Agirish opened a new pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348 Added apache-release profile in distribution/pom.xml to build a Docker image once the project is built successfully. While the Docker image can be

[GitHub] ilooner-mapr commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-06-28 Thread GitBox
ilooner-mapr commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401113654 Thx @vvysotskyi @arina-ielchiieva. I will do the

[jira] [Resolved] (DRILL-6551) Concat function results in SYSTEM ERROR: IllegalStateException: Tried to remove unmanaged buffer.

2018-06-28 Thread Vitalii Diravka (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-6551. Resolution: Duplicate [~priteshm] Yes, it seems the same issue. Closed this as duplicate.

[jira] [Created] (DRILL-6554) Minor code improvements in parquet statistics handling

2018-06-28 Thread Vlad Rozov (JIRA)
Vlad Rozov created DRILL-6554: - Summary: Minor code improvements in parquet statistics handling Key: DRILL-6554 URL: https://issues.apache.org/jira/browse/DRILL-6554 Project: Apache Drill Issue

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Timothy Farkas
- We would have to add a boolean column reader to ColumnAccessors and wire it in and add a getBoolean method to ScalarReader. - Your example should work as is, ClusterTest has a testBuilder method that allows you to use the traditional test builder. Is there something not working with the test

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Charles Givre
Hi Tim, Could post some sample code as to how to test a SQL query that returns a Boolean? —C > On Jun 28, 2018, at 17:30, Timothy Farkas wrote: > > - We would have to add a boolean column reader to ColumnAccessors and wire > it in and add a getBoolean method to ScalarReader. > > - Your

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198962585 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Timothy Farkas
Hi Charles, Currently the RowSetReader doesn't support booleans, but it can be added. I'll try to add it now, and see if it could be done quickly. I'll update you on my progress. Tim On Thu, Jun 28, 2018 at 2:38 PM, Charles Givre wrote: > Hi Tim, > Could post some sample code as to how to

[jira] [Resolved] (DRILL-6447) Unsupported Operation when reading parquet data

2018-06-28 Thread Pritesh Maker (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritesh Maker resolved DRILL-6447. -- Resolution: Fixed Resolved with the Parquet MR upgrade - DRILL-6353 > Unsupported Operation

[GitHub] jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-400935684 Hello, @arina-ielchiieva : all comment addressed. @vrozov : idem. Please tell me if there i something else to do.

[GitHub] arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-06-28 Thread GitBox
arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-400969030 Me might consider the following as well: 1.

[jira] [Created] (DRILL-6550) Request for additional SQL functions

2018-06-28 Thread Alexander Malic (JIRA)
Alexander Malic created DRILL-6550: -- Summary: Request for additional SQL functions Key: DRILL-6550 URL: https://issues.apache.org/jira/browse/DRILL-6550 Project: Apache Drill Issue Type:

Re: [ANNOUNCE] New PMC member: Vitalii Diravka

2018-06-28 Thread Kunal Khatua
Congratulations, Vitalli... well deserved! On 6/27/2018 10:43:38 AM, Vitalii Diravka wrote: Thank you all! It is a pleasure to work with all of you. I am sure Drill has a bright future. Therefore it's a honor for me to make contribution to this project. Kind regards Vitalii On Wed, Jun 27,

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198766543 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198767308 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198766336 ## File path:

[GitHub] vvysotskyi opened a new pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

2018-06-28 Thread GitBox
vvysotskyi opened a new pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346 - Added new rule `ProjectComplexRexNodeCorrelateTransposeRule` which takes a complex expression from the `Project` below

[GitHub] vrozov opened a new pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-28 Thread GitBox
vrozov opened a new pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349 @arina-ielchiieva Please review This is an automated message from the

[jira] [Resolved] (DRILL-6499) No need to calculate stdRowWidth for every batch by default

2018-06-28 Thread Pritesh Maker (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritesh Maker resolved DRILL-6499. -- Resolution: Duplicate DRILL-6512 will address this. > No need to calculate stdRowWidth for

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198850069 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunctions.java

  1   2   >