Re: 2.0.0-SNAPSHOT

2022-03-17 Thread Vitalii Diravka
Does that mean we can merge the non backward compatible changes then, right? Kind regards Vitalii On Mon, Mar 14, 2022 at 10:47 AM James Turton wrote: > Hi all > > Does anyone have any objections to > https://github.com/apache/drill/pull/2490? Any reasons to do a 1.21.0 > before a 2.0.0? > >

Re: 2.0.0-SNAPSHOT

2022-03-17 Thread James Turton
Yes! Assuming we're roughly following the "semantic versioning" convention then here's what they say: Given a version number MAJOR.MINOR.PATCH, increment the: 1. MAJOR version when you make incompatible API changes, 2. MINOR version when you add functionality in a backwards

Re: [VOTE] Adopt the Drill Test Framework from MapR

2022-03-17 Thread Charles Givre
+1 from me. Sent from my iPhone > On Mar 17, 2022, at 05:03, James Turton wrote: > > Hi dev community! > > Many of you need no introduction to the test framework developed by MapR > > https://github.com/mapr/drill-test-framework > > . For those who don't know, the test framework contains

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829065654 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829066804 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/HttpUtils.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] vvysotskyi commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
vvysotskyi commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829053206 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java ## @@ -0,0 +1,166 @@ +/* + * Licensed

[GitHub] [drill] jnturton commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
jnturton commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829080866 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/HttpUtils.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] pjfanning commented on pull request #2480: DRILL-8154: Upgrade to poi 5.2.1

2022-03-17 Thread GitBox
pjfanning commented on pull request #2480: URL: https://github.com/apache/drill/pull/2480#issuecomment-1070614000 @jnturton thanks - I'll try that out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[VOTE] Adopt the Drill Test Framework from MapR

2022-03-17 Thread James Turton
Hi dev community! Many of you need no introduction to the test framework developed by MapR https://github.com/mapr/drill-test-framework . For those who don't know, the test framework contains around 10k tests often exercising scenarios not covered by Drill's unit tests. Just weeks ago it

[GitHub] [drill] jnturton commented on pull request #2480: DRILL-8154: Upgrade to poi 5.2.1

2022-03-17 Thread GitBox
jnturton commented on pull request #2480: URL: https://github.com/apache/drill/pull/2480#issuecomment-1070596335 @pjfanning I had the wrong sites there, the account linking is at https://gitbox.apache.org -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [drill] jnturton commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
jnturton commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r828820399 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829637402 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/HttpUtils.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829656793 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829659506 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperUtils.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to the

Re: [VOTE] Adopt the Drill Test Framework from MapR

2022-03-17 Thread James Turton
Excellent!  Abhishek and Anton have offered to run this project which, assuming the stars align, will be more of a source code migration than a fork which is even better. On 2022/03/17 18:39, Ted Dunning wrote: Big +1 from me!!! We at MapR built that test framework to support aggressive

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829656132 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829656195 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/HttpUtils.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829656249 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to

[GitHub] [drill] cgivre commented on a change in pull request #2496: DRILL-8169: Add UDFs to HTTP Plugin to Facilitate Joins

2022-03-17 Thread GitBox
cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829658108 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperUtils.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to the

Re: [VOTE] Adopt the Drill Test Framework from MapR

2022-03-17 Thread Paul Rogers
Abhishek used to have that thing running like a charm. Great to see it getting attention again. +1 - Paul On Thu, Mar 17, 2022 at 2:03 AM James Turton wrote: > Hi dev community! > > Many of you need no introduction to the test framework developed by MapR > >

Re: [VOTE] Adopt the Drill Test Framework from MapR

2022-03-17 Thread Ted Dunning
Big +1 from me!!! We at MapR built that test framework to support aggressive testing of Drill. It would be great to see it continue to meet that need. (... I was CTO at MapR when it was acquired by HPE but I don't have any special position in the Drill community ...) On Thu, Mar 17, 2022 at