[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user ssriniva123 commented on the issue: https://github.com/apache/drill/pull/518 I updated the pull request with more changes requested by the reviewers. On Wed, Jun 15, 2016 at 5:28 PM, Aman Sinha wrote: > Yes, it does in fact

[GitHub] drill pull request #519: DRILL-4530: Optimize partition pruning with metadat...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/519#discussion_r67289117 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -208,8 +209,18 @@ public DrillTable

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user ssriniva123 commented on the issue: https://github.com/apache/drill/pull/518 For some reason the build terminated- What needs to be done to fire it again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: DRILL-4199: Add Support for HBase 1.X - planning to merge

Also when I query hbase, its throw exception : 2016-06-16 10:29:51,788 [289df0e3-05dc-f882-8c51-20dd0f98235b:frag:0:0] ERROR o.a.drill.exec.compile.MergeAdapter - Failure while merging classes. java.lang.RuntimeException: Error at instruction 370: Expected an object reference, but found .

[GitHub] drill pull request #519: DRILL-4530: Optimize partition pruning with metadat...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/519#discussion_r67272839 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -208,8 +209,18 @@ public DrillTable

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user ssriniva123 commented on the issue: https://github.com/apache/drill/pull/518 I have added support so that it prints the offending file/line nos. Error parsing JSON in DRILL-4653.json : line nos :13 Error parsing JSON in DRILL-4653.json : line nos :14 --- If

[GitHub] drill issue #512: Drill 4573 fix issue with unicode chars

Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/512 I did the following small changes to this PR, and I'm going to rebase and re-run the regression suite before merge this PR. 1) fix one bug which causes regression failure (IOBE). 2) add

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user ssriniva123 commented on the issue: https://github.com/apache/drill/pull/518 Yes, I looked at DRILL-3764. The changes made to JSONProcessing do not conflict with my changes. The only conflict I see is these two constants, I have defined my own. String

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/518 Yes, it does in fact have a conflict with DRILL-3764 which has changes to the JsonRecordReader, although this issue is still in progress. I noticed that @adeneche mentioned this in the JIRA.

Re: Manta Object Store Support

Please disregard this. I’ve figured out how to get it working. Once I realized that error logging for Hadoop Filesystem drivers wasn’t enabled by logback by default, then everything clicked into place. I’ll be back to ask more questions. Thank you for your time, Elijah Zupancic > On May 6,

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67267511 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java --- @@ -217,11 +228,11 @@ public int next() {

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/518 Does this conflict with Drill 3764 (see https://github.com/apache/drill/pull/497)?. I think there was a broader discussion around this as part of enabling the functionality of skipping/logging

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67267273 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java --- @@ -64,6 +64,8 @@ private final boolean

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user ssriniva123 commented on the issue: https://github.com/apache/drill/pull/518 Do u anticipate this to be logged using log4j? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/518 A high level comment I have about this PR is that keeping the number of 'malformed' records in the json file may not be sufficient..I would expect the user would want to know the file name and

[GitHub] drill issue #522: DRILL-4716: status.json doesn't work in drill ui

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/522 +1 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: Time for a 1.7 release

I can take a look at DRILL-4653. Could someone familiar with the Decimal type take a look at DRILL-4704 ? Agree with Dave that it is a simple case that should be fixed (note, however, that decimal is disabled by default currently). On Wed, Jun 15, 2016 at 3:12 PM, Subbu Srinivasan

Re: Time for a 1.7 release

Who can review https://issues.apache.org/jira/browse/DRILL-4653 ? On Wed, Jun 15, 2016 at 1:37 PM, Parth Chandra wrote: > +1 on the 1.7 release > > I'm reviewing the following and hope to get them in the release before > cutoff: >

[GitHub] drill issue #501: DRILL-2385: Count on complex objects failed with missing f...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/501 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: Time for a 1.7 release

+1 on the 1.7 release I'm reviewing the following and hope to get them in the release before cutoff: https://issues.apache.org/jira/browse/DRILL-2593 https://issues.apache.org/jira/browse/DRILL-4309 On Wed, Jun 15, 2016 at 1:20 PM, Jinfeng Ni wrote: > I'm reviewing a

Re: Time for a 1.7 release

I'm reviewing a follow-up PR [1] for DRILL-4573. I think we need get it merged in, since it's a regression in terms of query correctness from release 1.6. [1] https://github.com/apache/drill/pull/512 On Wed, Jun 15, 2016 at 12:21 PM, Dave Oshinsky wrote: > This is a

RE: Time for a 1.7 release

This is a pretty basic bug affecting decimal values, with a simple fix: https://issues.apache.org/jira/browse/DRILL-4704 It would be great if it could be reviewed. -Original Message- From: Aman Sinha [mailto:amansi...@apache.org] Sent: Wednesday, June 15, 2016 3:15 PM To: dev Subject:

Re: Time for a 1.7 release

Can https://issues.apache.org/jira/browse/DRILL-4653 be reviewed? On Wed, Jun 15, 2016 at 12:14 PM, Aman Sinha wrote: > Hello everyone, > > A 1.7 release is quite overdue ! I would like to get the ball rolling... > > In preparation, could developers please close the

Time for a 1.7 release

Hello everyone, A 1.7 release is quite overdue ! I would like to get the ball rolling... In preparation, could developers please close the pull requests that have already been merged into master ? This will give me a better sense of what is in progress. Can all the folks working on open

[GitHub] drill pull request #524: DRILL-4724: Improvements to InfoSchema RecordGenera...

GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/524 DRILL-4724: Improvements to InfoSchema RecordGenerator needed for DRILL-4714 1. Add support for pushing the filter on following fields into InfoSchemaRecordGenerator: - CATALOG_NAME

[jira] [Created] (DRILL-4725) Improvements to InfoSchema RecordGenerator needed for DRILL-4714

Venki Korukanti created DRILL-4725: -- Summary: Improvements to InfoSchema RecordGenerator needed for DRILL-4714 Key: DRILL-4725 URL: https://issues.apache.org/jira/browse/DRILL-4725 Project: Apache

[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/500 +1 looks good. Can you squash and rebase ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Created] (DRILL-4724) convert_from(binary_string(expression),'INT_BE') results in Exception

Khurram Faraaz created DRILL-4724: - Summary: convert_from(binary_string(expression),'INT_BE') results in Exception Key: DRILL-4724 URL: https://issues.apache.org/jira/browse/DRILL-4724 Project:

[GitHub] drill issue #436: DRILL-4514 : Add describe schema command

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/436 @jinfengni PR is updated, physical_location is removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project