[GitHub] drill issue #901: DRILL-5709: Provide a value vector method to convert a vec...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/901 @arina-ielchiieva, conflicts are resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill pull request #924: DRILL-5740: Ensure spill directories are unique

GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/924 DRILL-5740: Ensure spill directories are unique A recent change added the node name and port to make the spill path unique. Turns out we need to add this information to the single spill

[GitHub] drill issue #922: DRILL-5741: During startup Drill should not exceed the ava...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/922 -1 This seems like a good idea. But, I don't think this is the way we should go for reasons identified in the JIRA. For one, we count on the user to provide a parameter to

[GitHub] drill issue #868: DRILL-5547:Linking config options with system option manag...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/868 @ilooner, @Ben-Zvi, the PR is now in master. Have fun! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/868 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill issue #923: DRILL-5723

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/923 Please add a brief description in the PR title. This PR has commits from other PRs, and has merge conflicts. If this PR depends on others, then please identify the commits to be reviewed,

[GitHub] drill pull request #923: Drill 5723

GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/923 Drill 5723 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ilooner/drill DRILL-5723 Alternatively you can review and apply these changes as the

[jira] [Created] (DRILL-5742) CONVERT_FROM_JSON on a non-existing column in a file throws null pointer exception

Prasad Nagaraj Subramanya created DRILL-5742: Summary: CONVERT_FROM_JSON on a non-existing column in a file throws null pointer exception Key: DRILL-5742 URL:

Re: DrillRestServer Tests

Hey Kunal, I tried rest-assured out for my rest api unit tests and It works. I'll include it as part of my PR for DRILL-5723. Thanks, Tim From: Timothy Farkas Sent: Friday, August 25, 2017 2:46:53 PM To: dev@drill.apache.org Subject: Re: DrillRestServer Tests

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135373441 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)

[GitHub] drill issue #922: DRILL-5741: During startup Drill should not exceed the ava...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/922 @ppadma Can you please review this? The changes have been tested with and without the parameter. If the env variable is set as `40%` , `drillbit.out` reports ``` Aug 25, 2017 4:30:59

Re: Missing versions for "Affected Versions" and "Fix Version" fields ?

They are showing up again, thanks Pritesh. Thanks, Gelbana On Sat, Aug 26, 2017 at 1:26 AM, Pritesh Maker wrote: > I was trying to clean up some of the older versions and I didn’t realize > that marking the older versions as archived will also affect the “Affected > Versions”

[GitHub] drill pull request #922: DRILL-5741: During startup Drill should not exceed ...

GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/922 DRILL-5741: During startup Drill should not exceed the available memory Providing an environment variable - DRILLBIT_MAX_PROC_MEM to ensure that a Drillbit's max memory parameters, cumulatively,

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135371425 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135367166 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135369535 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135371136 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135370205 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135366734 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -152,97 +157,75 @@ public void kill(boolean

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135368764 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135370016 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135370581 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135368986 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135369170 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -130,562 +145,248 @@ public IterOutcome

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135369225 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -39,88 +35,107 @@ import

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135368337 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -39,88 +35,107 @@ import

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135371013 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -39,88 +35,107 @@ import

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135369394 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -39,88 +35,107 @@ import

Missing versions for "Affected Versions" and "Fix Version" fields ?

For the "Affected Versions" and "Fix Version" JIRA fields, I can only find the following versions: - 1.11.0 - 1.12.0 - 2.0 - Future Aren't versions 1.10.0 and earlier supported anymore ? Thanks, Gelbana

[GitHub] drill issue #868: DRILL-5547:Linking config options with system option manag...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/868 From a note sent by @dvjyothsna: All the system/session option default values are externalized to the conf file. Now the options are looked up in the hierarchical order of SESSION -

[GitHub] drill issue #805: Drill-4139: Exception while trying to prune partition. jav...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/805 OK. Since I'm not a Parquet expert, have asked Salim to take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r135359090 --- Diff: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/CompareFunctionsProcessor.java --- @@ -82,466 +45,37 @@ public

[GitHub] drill issue #914: DRILL-5657: Size-aware vector writer structure

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/914 Merged a set of enhancements & bug fixes. Compared to the first set of commits: * Provides tools to print the sometimes-complex tuple model, schema and writer object used for complex

Re: DrillRestServer Tests

I got something that does more or less what I want. It is easy to start a drill bit with the web server in tests now with the existing Fixture infrastructure. FixtureBuilder builder = ClusterFixture.builder(). configProperty(ExecConstants.HTTP_ENABLE, true) ClusterFixture cluster =

Re: Dynamically change logging levels for loggers

+1 for exploring adding this feature. We had a feature to dynamically change log levels at runtime through the rest API in Apache Apex and it was very helpful with debugging things. From: Paul Rogers Sent: Friday, August 25, 2017 11:01:29 AM

[GitHub] drill issue #805: Drill-4139: Exception while trying to prune partition. jav...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/805 @paul-rogers, PR is already merged :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill issue #868: DRILL-5547:Linking config options with system option manag...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/868 @dvjyothsna @paul-rogers Tim here. When do you guys think this PR will go in? Seems like it didn't make it into this last batch of commits :(. I will be opening another PR soon that is dependent on

[GitHub] drill issue #875: DRILL-5671 Set secure ACLs (Access Control List) for Drill...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/875 Where are we on this PR? A note three weeks ago said that another commit would be coming; but haven't see it... --- If your project is set up for it, you can reply to this email and have your

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135351183 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135351043 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java --- @@ -46,14 +56,18 @@ public Project(@JsonProperty("exprs")

[GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/906#discussion_r135351026 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java --- @@ -35,9 +35,19 @@ static final org.slf4j.Logger

[GitHub] drill issue #805: Drill-4139: Exception while trying to prune partition. jav...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/805 Thanks for addressing my questions. While waiting for DRILL-5660, I wonder if we can ask Salim to take a look? --- If your project is set up for it, you can reply to this email and have your

[jira] [Created] (DRILL-5741) Drillbit during startup should not exceed the available memory on a node

Kunal Khatua created DRILL-5741: --- Summary: Drillbit during startup should not exceed the available memory on a node Key: DRILL-5741 URL: https://issues.apache.org/jira/browse/DRILL-5741 Project: Apache

[jira] [Created] (DRILL-5740) hash agg fail to read spill file

Chun Chang created DRILL-5740: - Summary: hash agg fail to read spill file Key: DRILL-5740 URL: https://issues.apache.org/jira/browse/DRILL-5740 Project: Apache Drill Issue Type: Bug

NodeJS Driver for Drill

All, I thought I’d share with the community, but I just finished a NodeJS driver for Drill. It’s available here: https://github.com/cgivre/drill-nodejs or via npm install drill-client. Keep in mind, I know nothing about NodeJS, but it largely follows the functionality of PyDrill. I’ll

[GitHub] drill pull request #910: DRILL-5726: Support Impersonation without authentic...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/910#discussion_r135193811 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java --- @@ -230,6 +230,27 @@ public WebUserConnection provide() {

[GitHub] drill pull request #910: DRILL-5726: Support Impersonation without authentic...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/910#discussion_r135193019 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java --- @@ -54,7 +56,10 @@ @Path("/query")

[GitHub] drill pull request #910: DRILL-5726: Support Impersonation without authentic...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/910#discussion_r135194263 --- Diff: exec/java-exec/src/main/resources/rest/query/query.ftl --- @@ -21,8 +24,16 @@ Sample SQL query: SELECT * FROM cp.`employee.json`

Re: Dynamically change logging levels for loggers

Hi Kunal, Don’t know about rereading the config file, but I have had luck in the unit test framework with adjusting log levels programmatically. (Tests turn on interesting log levels for the duration of a single tests.) We might be able to use that capability (provided by Logback) to make

Dynamically change logging levels for loggers

I figured this is a rarely modified piece of code but most frequently used across all components. Hoping that someone who might have worked on logging can share some insight from their experience in general, if not within Drill. I was wondering if changes to Drill's logback.xml can be picked up

RE: DrillRestServer Tests

Krystal pointed out to an existing tool that allows testing for REST APIs. https://github.com/rest-assured/rest-assured Unfortunately, we're currently running short of hands in getting a good robust prototype for this. Is anyone interested in volunteering? -Original Message- From:

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov I've fixed the source.skip switch to be maven.source.skip as you pointed out. For now I also made the **script** tag a noop since as you said the mvn package command is redundant at this

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

Github user ilooner-mapr commented on a diff in the pull request: https://github.com/apache/drill/pull/913#discussion_r135312783 --- Diff: .travis.yml --- @@ -13,8 +13,9 @@ # See the License for the specific language governing permissions and # limitations under the

Re: DrillRestServer Tests

To simplify code reviews in this area, should we add tests? Might be mighty hard to “mentally execute” in lieu of tests… - Paul > On Aug 25, 2017, at 9:40 AM, Parth Chandra wrote: > > Don't think there are any unit tests, and again there is no rest api > client. The UI is

Re: DrillRestServer Tests

Don't think there are any unit tests, and again there is no rest api client. The UI is the only test tool, sadly. On Thu, Aug 24, 2017 at 12:55 PM, Timothy Farkas wrote: > Hi All, > > I want to add some unit tests for a new rest endpoint I added to the > DrillRestServer. I've

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/921 DRILL-4286 Graceful shutdown of drillbit Following is the design document https://docs.google.com/document/d/1AauIwVCjsBKBSbbU6sQODErrEp7n3IwniMtgK4m09MQ/edit#heading=h.224lbmcaxu2d. I

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135292416 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/913#discussion_r135291374 --- Diff: .travis.yml --- @@ -13,8 +13,9 @@ # See the License for the specific language governing permissions and # limitations under the License.

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

Github user vrozov commented on the issue: https://github.com/apache/drill/pull/913 @parthchandra LGTM. There are questions that I have related to how travis-ci build is configured, but they are for pre-existing settings and can be addressed in a follow up PR if necessary. --- If

[GitHub] drill issue #915: DRILL-1051: Casting timestamp as date gives wrong result f...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/915 Two functional unit tests are failing after the changes: ``` /root/drillAutomation/drill-test-framework/framework/resources/Functional/datetime/datetime189.q Query: select

[GitHub] drill pull request #911: - DRILL-5507 Made verbose info logging message debu...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/911 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #908: DRILL-5725: Update Jackson version to 2.7.8

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/908 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #894: DRILL-5701: drill.connections.rpc.

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/894 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

Github user weijietong commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135254275 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

Github user weijietong commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135249441 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -204,24 +205,28 @@ public static void

[GitHub] drill issue #901: DRILL-5709: Provide a value vector method to convert a vec...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/901 @paul-rogers please resolve the conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Apache Drill Project: how to work on Jira tickets, create PRs and merge the changes

Hi all, since there are many new contributors in Apache Drill project, I'd like to outline the main points on how to work on Jira tickets, create PRs and merge the changes. *When you start working on Apache Drill Jira ticket* 1. Please add yourself as the assignee and put Jira status `In

[jira] [Resolved] (DRILL-4690) Header in RestApi CORS support

[ https://issues.apache.org/jira/browse/DRILL-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-4690. - Resolution: Fixed Reviewer: Parth Chandra Fix Version/s: 1.8.0 > Header

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135196236 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -204,24 +205,28 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135199961 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean