[GitHub] drill issue #975: DRILL-5743: Handling column family and column scan for hba...

2017-10-06 Thread prasadns14
Github user prasadns14 commented on the issue: https://github.com/apache/drill/pull/975 @paul-rogers please review ---

[GitHub] drill pull request #975: DRILL-5743: Handling column family and column scan ...

2017-10-06 Thread prasadns14
Github user prasadns14 commented on a diff in the pull request: https://github.com/apache/drill/pull/975#discussion_r143322351 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java --- @@ -97,6 +97,7 @@ public

[GitHub] drill pull request #975: DRILL-5743: Handling column family and column scan ...

2017-10-06 Thread prasadns14
Github user prasadns14 commented on a diff in the pull request: https://github.com/apache/drill/pull/975#discussion_r143322352 --- Diff: contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestTableGenerator.java --- @@ -133,6 +133,43 @@ public static void

[jira] [Created] (DRILL-5855) Provide a useful error message when the SystemOptionManager is queried for a non-existent option

2017-10-06 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-5855: - Summary: Provide a useful error message when the SystemOptionManager is queried for a non-existent option Key: DRILL-5855 URL: https://issues.apache.org/jira/browse/DRILL-5855

[GitHub] drill issue #979: DRILL-5853 : Update Calcite to get NULL direction for sort...

2017-10-06 Thread gparai
Github user gparai commented on the issue: https://github.com/apache/drill/pull/979 @amansinha100 Can you please review the PR? Thanks! ---

[GitHub] drill pull request #979: DRILL-5853 : Update Calcite to get NULL direction f...

2017-10-06 Thread gparai
GitHub user gparai opened a pull request: https://github.com/apache/drill/pull/979 DRILL-5853 : Update Calcite to get NULL direction for sort removal You can merge this pull request into a Git repository by running: $ git pull https://github.com/gparai/drill Drill-5853-ACM

[jira] [Created] (DRILL-5854) IllegalStateException when empty batch with valid schema is received.

2017-10-06 Thread Padma Penumarthy (JIRA)
Padma Penumarthy created DRILL-5854: --- Summary: IllegalStateException when empty batch with valid schema is received. Key: DRILL-5854 URL: https://issues.apache.org/jira/browse/DRILL-5854 Project:

[jira] [Created] (DRILL-5853) Sort removal based on NULL direction

2017-10-06 Thread Gautam Kumar Parai (JIRA)
Gautam Kumar Parai created DRILL-5853: - Summary: Sort removal based on NULL direction Key: DRILL-5853 URL: https://issues.apache.org/jira/browse/DRILL-5853 Project: Apache Drill Issue

[GitHub] drill pull request #960: DRILL-5815: Option to set query memory as percent o...

2017-10-06 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/960#discussion_r143317064 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/MemoryAllocationUtilities.java --- @@ -56,30 +59,90 @@ public static void

[GitHub] drill pull request #960: DRILL-5815: Option to set query memory as percent o...

2017-10-06 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/960#discussion_r143316843 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/MemoryAllocationUtilities.java --- @@ -56,30 +59,90 @@ public static void

[jira] [Created] (DRILL-5852) Display the "memory per query per node" in the query's profile

2017-10-06 Thread Boaz Ben-Zvi (JIRA)
Boaz Ben-Zvi created DRILL-5852: --- Summary: Display the "memory per query per node" in the query's profile Key: DRILL-5852 URL: https://issues.apache.org/jira/browse/DRILL-5852 Project: Apache Drill

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143315906 --- Diff: zookeeper.out --- @@ -0,0 +1,31 @@ +2017-10-05 20:21:32,418 [myid:] - INFO [main:QuorumPeerConfig@124] - Reading configuration from:

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143315980 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -74,23 +79,66 @@ -Encryption Info +

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143315088 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/DistributedQueryQueue.java --- @@ -0,0 +1,342 @@ +/* + * Licensed

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143315595 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/DistributedQueryQueue.java --- @@ -0,0 +1,342 @@ +/* + * Licensed

[jira] [Created] (DRILL-5851) Empty table during a join operation with a non empty table produces cast exception

2017-10-06 Thread Hanumath Rao Maduri (JIRA)
Hanumath Rao Maduri created DRILL-5851: -- Summary: Empty table during a join operation with a non empty table produces cast exception Key: DRILL-5851 URL: https://issues.apache.org/jira/browse/DRILL-5851

[GitHub] drill pull request #978: DRILL-5842: Refactor and simplify the fragment, ope...

2017-10-06 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/978 DRILL-5842: Refactor and simplify the fragment, operator contexts for testing Drill's execution engine has a "fragment context" that provides state for a fragment as a whole, and an "operator

[jira] [Created] (DRILL-5850) Problem Querying Directory with Drill

2017-10-06 Thread Joe Bringley (JIRA)
Joe Bringley created DRILL-5850: --- Summary: Problem Querying Directory with Drill Key: DRILL-5850 URL: https://issues.apache.org/jira/browse/DRILL-5850 Project: Apache Drill Issue Type: Bug

[GitHub] drill issue #973: DRILL-5775: Select * query on a maprdb binary table fails

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/973 Does this PR duplicates some work in #972? Can we review and commit that one first before we redo the work here? ---

[GitHub] drill pull request #975: DRILL-5743: Handling column family and column scan ...

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/975#discussion_r143266651 --- Diff: contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestTableGenerator.java --- @@ -133,6 +133,43 @@ public static void

[GitHub] drill pull request #975: DRILL-5743: Handling column family and column scan ...

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/975#discussion_r143265009 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java --- @@ -109,11 +110,14 @@ public

[GitHub] drill pull request #975: DRILL-5743: Handling column family and column scan ...

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/975#discussion_r143265321 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java --- @@ -109,11 +110,14 @@ public

[GitHub] drill pull request #975: DRILL-5743: Handling column family and column scan ...

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/975#discussion_r143264890 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java --- @@ -97,6 +97,7 @@ public

[GitHub] drill pull request #976: DRILL-5797: Choose parquet reader from read columns

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/976#discussion_r143264522 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -156,18 +160,39 @@ public ScanBatch

[GitHub] drill pull request #976: DRILL-5797: Choose parquet reader from read columns

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/976#discussion_r143263332 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -156,18 +160,39 @@ public ScanBatch

[GitHub] drill pull request #976: DRILL-5797: Choose parquet reader from read columns

2017-10-06 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/976#discussion_r143263740 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -156,18 +160,39 @@ public ScanBatch

[GitHub] drill issue #977: DRILL-5849: Add freemarker lib to dependencyManagement to ...

2017-10-06 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/977 The proposed changes simplify the dependency management, but do not change the dependency resolution, AFAIK. ---

[GitHub] drill issue #950: DRILL-5431: SSL Support

2017-10-06 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 Squashed and rebased on master again. ---

[GitHub] drill issue #950: DRILL-5431: SSL Support

2017-10-06 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 @laurentgo are you good with this? I'll open a new JIRA for the enhancements to the C++ client. ---

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-06 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r143246761 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSL.java --- @@ -201,6 +202,7 @@ public void testSSLQuery()

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

2017-10-06 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/976 Sure! Regards, Salim From: dprofeta Sent: Friday, October 6, 2017 8:52:51 AM To: apache/drill

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

2017-10-06 Thread dprofeta
Github user dprofeta commented on the issue: https://github.com/apache/drill/pull/976 @sachouche Can you review it? ---

[GitHub] drill pull request #977: DRILL-5849: Add freemarker lib to dependencyManagem...

2017-10-06 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/977 DRILL-5849: Add freemarker lib to dependencyManagement to ensure prop… …er version is used when resolving dependency version conflicts Details in

[jira] [Created] (DRILL-5849) Add freemarker to dependencyManagement to ensure proper version is used when resolving dependency version conflicts

2017-10-06 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-5849: --- Summary: Add freemarker to dependencyManagement to ensure proper version is used when resolving dependency version conflicts Key: DRILL-5849 URL:

[GitHub] drill issue #973: DRILL-5775: Select * query on a maprdb binary table fails

2017-10-06 Thread vdiravka
Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/973 @jinfengni Could you please review this PR? ---

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143154343 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/DistributedQueryQueue.java --- @@ -0,0 +1,342 @@ +/* + *

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143152928 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/DistributedQueryQueue.java --- @@ -0,0 +1,342 @@ +/* + *

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r143152156 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java --- @@ -76,7 +76,7 @@ public void testMissingKeystorePassword()

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r143151998 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSL.java --- @@ -201,6 +202,7 @@ public void

[GitHub] drill issue #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/928 @paul-rogers please don't forget to resolve conflicts. ---

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143147464 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -74,23 +79,66 @@ -Encryption Info +

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143149580 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/AbstractResourceManager.java --- @@ -0,0 +1,68 @@ +/* + *

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/928#discussion_r143147148 --- Diff: zookeeper.out --- @@ -0,0 +1,31 @@ +2017-10-05 20:21:32,418 [myid:] - INFO [main:QuorumPeerConfig@124] - Reading configuration from:

[GitHub] drill pull request #976: DRILL-5797: Choose parquet reader from read columns

2017-10-06 Thread dprofeta
GitHub user dprofeta opened a pull request: https://github.com/apache/drill/pull/976 DRILL-5797: Choose parquet reader from read columns ParquetRecordReader is not able to read complex columns. However it is able to read simple columns in a file containing complex columns.

[jira] [Resolved] (DRILL-5839) Handle Empty Batches in Merge Receiver

2017-10-06 Thread Paul Rogers (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Rogers resolved DRILL-5839. Resolution: Fixed Reviewer: Paul Rogers > Handle Empty Batches in Merge Receiver >

[GitHub] drill pull request #974: DRILL-5839: Handle Empty Batches in Merge Receiver

2017-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/974 ---

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/940 ---