[GitHub] drill pull request #1082: DRILL-5741: Automatically manage memory allocation...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1082#discussion_r160606654 --- Diff: distribution/src/resources/drill-config.sh --- @@ -180,18 +251,46 @@ else fi fi -# Default memory settings if none provided

[GitHub] drill pull request #1082: DRILL-5741: Automatically manage memory allocation...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1082#discussion_r160606258 --- Diff: distribution/src/resources/distrib-auto.sh --- @@ -0,0 +1,223 @@ +#!/usr/bin/env bash --- End diff -- Wasn't sure which would be a

[GitHub] drill pull request #1082: DRILL-5741: Automatically manage memory allocation...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1082#discussion_r160606013 --- Diff: distribution/src/assemble/bin.xml --- @@ -345,6 +345,16 @@ 0755 conf + +

[GitHub] drill issue #1087: Attempt to fix memory leak in Parquet

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1087 @parthchandra can you please review this fix? ---

[GitHub] drill pull request #1087: Attempt to fix memory leak in Parquet

GitHub user sachouche opened a pull request: https://github.com/apache/drill/pull/1087 Attempt to fix memory leak in Parquet ** Problem Description ** This is an extremely rare leak which I was able to emulate by putting a sleep in the AsyncPageReader right after reading the

[GitHub] drill issue #1001: JIRA DRILL-5879: Like operator performance improvements

Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1001 @sachouche can you update this PR? ---

Re: Parquet MR version

Support for byte buffers aka "PARQUET-77: ByteBuffer use in read and write paths" is included both to 1.8.2 and 1.9.0 parquet-mr. Based on the following discussion https://lists.apache.org/thread.html/e1a3d1e49d3b775cb5e1417c882dad7bd2f038e00237ff2a9057c608@1454714357@%3Cdev.drill.apache.org%3E

[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/367 @nagix Did you get a chance to rebase this commit? ---

[GitHub] drill issue #456: DRILL-4566: TDigest, median, and quantile functions

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/456 Is anyone reviewing this? ---

[jira] [Created] (DRILL-6079) Memory leak caused by ParquetRowGroupScan

salim achouche created DRILL-6079: - Summary: Memory leak caused by ParquetRowGroupScan Key: DRILL-6079 URL: https://issues.apache.org/jira/browse/DRILL-6079 Project: Apache Drill Issue Type:

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r160542798 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java --- @@ -333,4 +339,55 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r160542923 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java --- @@ -333,4 +339,55 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r160540854 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java --- @@ -228,4 +228,20 @@ public WritableBatch

[GitHub] drill pull request #1082: DRILL-5741: Automatically manage memory allocation...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1082#discussion_r160537845 --- Diff: distribution/src/resources/distrib-auto.sh --- @@ -0,0 +1,223 @@ +#!/usr/bin/env bash --- End diff -- In general, "distrib"

[GitHub] drill pull request #1082: DRILL-5741: Automatically manage memory allocation...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1082#discussion_r160538214 --- Diff: distribution/src/assemble/bin.xml --- @@ -345,6 +345,16 @@ 0755 conf + +

[GitHub] drill pull request #1082: DRILL-5741: Automatically manage memory allocation...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1082#discussion_r160539584 --- Diff: distribution/src/resources/drill-config.sh --- @@ -180,18 +251,46 @@ else fi fi -# Default memory settings if none

[GitHub] drill pull request #1082: DRILL-5741: Automatically manage memory allocation...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1082#discussion_r160539726 --- Diff: distribution/src/resources/drill-config.sh --- @@ -180,18 +251,46 @@ else fi fi -# Default memory settings if none

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525590 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetGroupScan.java --- @@ -56,65 +56,50 @@ private void

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525146 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseTestQuery.java --- @@ -119,6 +125,15 @@ public static void

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160526940 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -250,20 +250,12 @@ private boolean

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160524662 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SchemalessScan.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525926 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java --- @@ -1197,4 +1197,64 @@ public void testFieldWithDots() throws

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525739 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestEmptyInputSql.java --- @@ -177,4 +177,33 @@ public void testQueryEmptyCsv() throws

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160524828 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java --- @@ -78,19 +78,24 @@ public

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525303 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseTestQuery.java --- @@ -119,6 +125,15 @@ public static void

[GitHub] drill issue #652: DRILL-4990:Use new HDFS API access instead of listStatus t...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/652 @ppadma can you rebase this with the current master, and include the workaround? It does not make sense to hold up this commit for so long if a workaround for the Windows platform is sufficient.

[GitHub] drill issue #440: Elasticsearch storage plugin

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/440 @hamdanuk this commit has too many commits, which makes the PR nearly impossible to review. Would you like to rebase your work on the latest Drill 1.12.0 and try again? ---

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r160514755 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VLAbstractEntryReader.java --- @@ -0,0 +1,215 @@

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 Before I reply to the provided comments I want first to thank both Parth and Paul for taking time to review this Pull Request. @parthchandra Regarding the High Level Comments - FS

[GitHub] drill issue #458: DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/458 @jcmcote Did you get a chance to follow up on @jinfengni 's comment on this PR? ---

[GitHub] drill issue #814: Add clickable localhost URL

Github user ebuildy commented on the issue: https://github.com/apache/drill/pull/814 Hello, nop, no JIRA ticket associated. ---

[GitHub] drill issue #814: Add clickable localhost URL

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/814 @ebuildy is there a JIRA associated with this PR? ---

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160492087 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -539,7 +553,12 @@ public void setValueLengthSafe(int index, int length)

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160489866 --- Diff: exec/vector/src/main/codegen/templates/ComplexWriters.java --- @@ -99,7 +99,7 @@ public void write(Nullable${minor.class?cap_first}Holder h) {

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160480509 --- Diff: exec/java-exec/src/main/codegen/templates/SqlAccessors.java --- @@ -127,6 +127,25 @@ public String getString(int index) { }

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160481004 --- Diff: exec/java-exec/src/main/codegen/templates/StringOutputRecordWriter.java --- @@ -146,7 +146,7 @@ public void writeField() throws IOException {

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160458242 --- Diff: exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalVarchar.java --- @@ -150,6 +150,14 @@ public void setup() { public

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160492409 --- Diff: exec/vector/src/main/java/org/apache/drill/exec/util/DecimalUtility.java --- @@ -159,9 +159,20 @@ public static BigDecimal

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160476071 --- Diff: exec/java-exec/src/main/codegen/templates/Decimal/DecimalFunctions.java --- @@ -102,7 +111,578 @@ <#-- For each DECIMAL... type (in

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160473858 --- Diff: exec/java-exec/src/main/codegen/templates/Decimal/DecimalAggrTypeFunctions2.java --- @@ -108,9 +108,12 @@ public void output() {

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160490947 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -327,13 +327,17 @@ public Mutator getMutator(){ return v;

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r160465652 --- Diff: exec/java-exec/src/main/codegen/templates/Decimal/CastIntDecimal.java --- @@ -68,15 +68,31 @@ public void setup() { public void

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160491764 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/mode-sql.js --- @@ -1 +1,128 @@

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160491309 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/mode-sql.js --- @@ -1 +1,128 @@

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160485223 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/snippets/sql.js --- @@ -0,0 +1,46 @@ +/** + * Drill SQL Syntax Snippets

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160482817 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/mode-sql.js --- @@ -1 +1,128 @@

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160482221 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/mode-sql.js --- @@ -1 +1,128 @@

Re: Drill Hangout Jan 9, 2018

Should we also talk about Java 9 and Hadoop 3.x support? Thank you, Vlad On 1/9/18 08:36, Arina Yelchiyeva wrote: Mark Java 8 support as critical for 1.13.0 release? For example, in Calcite 1.16 support for Java 7 will be dropped. On Tue, Jan 9, 2018 at 9:34 AM, Aditya Allamraju

Re: Drill Hangout Jan 9, 2018

Hi Aditya, Yes, it is open to everyone with exception that hangouts allow 10 connections only. Thank you, Vlad On 1/8/18 23:34, Aditya Allamraju wrote: Hi Vlad, If this is open to everyone in this group, i would like to join this hangout. Please let me know. Thanks Aditya On Tue, Jan 9,

Re: Drill Hangout Jan 9, 2018

Mark Java 8 support as critical for 1.13.0 release? For example, in Calcite 1.16 support for Java 7 will be dropped. On Tue, Jan 9, 2018 at 9:34 AM, Aditya Allamraju wrote: > Hi Vlad, > > If this is open to everyone in this group, i would like to join this >

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160457025 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/snippets/sql.js --- @@ -0,0 +1,46 @@ +/** + * Drill SQL Syntax

Re: PCAP Issues

The pcap format is there almost entirely just to give us a record structure. The stream could give us that just as easily. So that is one thing that could be done. Another thought is that data could be buffered a (very) short time and groups of packets could be sent as a single message. That

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160447919 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/mode-sql.js --- @@ -1 +1,128 @@

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160452751 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/mode-sql.js --- @@ -1 +1,128 @@

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r160449936 --- Diff: exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/snippets/sql.js --- @@ -0,0 +1,46 @@ +/** + * Drill SQL Syntax

Re: PCAP Issues

I've been following this and and also now playing with them more. A couple of tidbits that I think are worth re-mentioning: 1. pcapng the ability to read this too will be handy. 2. The flags are really cool, and the work here is great. The other thing I'd like to consider for this is with

[GitHub] drill pull request #1047: DRILL-5970: DrillParquetReader always builds the s...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1047#discussion_r160419416 --- Diff: exec/vector/src/main/codegen/templates/BaseWriter.java --- @@ -106,37 +114,37 @@ MapOrListWriter list(String name); boolean

[GitHub] drill issue #1066: DRILL-3993: Changes to support Calcite 1.15

Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1066 @chunhui-shi, I have made additional fixes in new commits (commits after DRILL-3993: Changes after code review. 3120762). Could you please take a look? Also, I have created pull request on

[GitHub] drill issue #1049: DRILL-5971: Fix INT64, INT32 logical types in complex par...

Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1049 @parthchandra, thanks for the pull request! LGTM, +1. ---

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @paul-rogers For some reason this wan't included in a batch commit. After rebasing onto master I noticed some tests were failing sporadically so I've included a 1 line fix for DRILL-6003 in the last