Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1058#discussion_r160841030
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java
---
@@ -107,7 +107,7 @@
* nodes provide
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1069
@MitchelLabonte My proposal is to limit the number of acceptors instead of
allowing to increase the max number of threads in the connection pool. If the
number of acceptors is limited, the number of
Github user MitchelLabonte commented on the issue:
https://github.com/apache/drill/pull/1069
@vrozov the Web server definitely doesn't need this much, but Drill won't
launch on a machine with more than 200 cores and throw an exception:
Exception in thread "main"
Paul Rogers created DRILL-6080:
--
Summary: Sort incorrectly limits batch size to 65535 records
rather than 65536
Key: DRILL-6080
URL: https://issues.apache.org/jira/browse/DRILL-6080
Project: Apache
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1069
@MitchelLabonte @arina-ielchiieva I don't think that Drill needs that many
threads/acceptors to handle HTTP(s) requests as it is not a real web (REST API)
server. For proper resource utilization, it
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1082#discussion_r160803438
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -180,18 +251,46 @@ else
fi
fi
-# Default memory settings if none provided
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1082#discussion_r160802962
--- Diff: distribution/src/assemble/bin.xml ---
@@ -345,6 +345,16 @@
0755
conf
+
+
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160759375
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160763490
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160753323
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160765882
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestSqlPatterns.java
---
@@ -446,6 +446,61 @@ public void
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160755097
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160758370
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160764681
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160754694
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160792114
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/util/DecimalUtility.java ---
@@ -159,9 +159,20 @@ public static BigDecimal
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160791971
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -539,7 +553,12 @@ public void setValueLengthSafe(int index, int
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160790684
--- Diff: exec/vector/src/main/codegen/templates/ComplexWriters.java ---
@@ -99,7 +99,7 @@ public void write(Nullable${minor.class?cap_first}Holder
h) {
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160786416
--- Diff:
exec/java-exec/src/main/codegen/templates/StringOutputRecordWriter.java ---
@@ -146,7 +146,7 @@ public void writeField() throws IOException {
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160785721
--- Diff: exec/java-exec/src/main/codegen/templates/SqlAccessors.java ---
@@ -127,6 +127,25 @@ public String getString(int index) {
}
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160779892
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/DecimalFunctions.java ---
@@ -102,7 +111,578 @@
<#-- For each DECIMAL... type (in
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160777281
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/CastIntDecimal.java ---
@@ -68,15 +68,31 @@ public void setup() {
public void
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160776544
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/DecimalAggrTypeFunctions2.java
---
@@ -108,9 +108,12 @@ public void output() {
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1086
@paul-rogers, @parthchandra can you review/ comment on this change?
---
Attendees: Arina, Paul, Pritesh, Vitalii, Volodymyr, Vova, Vlad, Sorabh,
Anil, Hanumath, Boaz, Karthik
Discussion topics and action items:
- Support Java 8 in 1.13.0 by default. Community to continue work on
several JIRAs (see
[
https://issues.apache.org/jira/browse/DRILL-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Rogers resolved DRILL-5833.
Resolution: Fixed
> Parquet reader fails with assertion error for Decimal9, Decimal18 types
>
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1078#discussion_r160741806
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
@@ -195,8 +195,16 @@ private
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1078#discussion_r160741771
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
@@ -228,13 +236,16 @@ private
Github user sachouche closed the pull request at:
https://github.com/apache/drill/pull/1001
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
Created another pull request #1072to merge my changes with the one done
with Padma's.
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1087
Thank you Arina for catching this; I created the commit for QA before
vacation so that they could verify the fix. At that time, I didn't have an
Apache JIRA. I have now updated the comment to
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160717181
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
---
@@ -250,20 +250,12 @@ private boolean
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160711830
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SchemalessScan.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160712431
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -424,6 +429,23 @@ public MetadataContext
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160685002
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
---
@@ -250,20 +250,12 @@ private boolean
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160666020
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BaseTestQuery.java ---
@@ -119,6 +125,15 @@ public static void setupDefaultTestCluster()
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160663414
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SchemalessScan.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160663989
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/TestEmptyInputSql.java ---
@@ -177,4 +177,33 @@ public void testQueryEmptyCsv() throws
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160664191
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetGroupScan.java
---
@@ -56,65 +56,50 @@ private void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160663507
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java
---
@@ -78,19 +78,24 @@ public PhysicalPlan
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160663899
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -1197,4 +1197,64 @@ public void testFieldWithDots() throws Exception {
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160666274
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BaseTestQuery.java ---
@@ -119,6 +125,15 @@ public static void setupDefaultTestCluster()
During hangout was decided to support JDK 8 by default in Apache Drill
1.13.0. We'l consider moving to Java 9 afterwards.
There is already open Jira for this issue -
https://issues.apache.org/jira/browse/DRILL-1491. I have linked all other
related issue to it as well.
Also it seems there is an
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1074
@prasadns14 please resolve the conflicts.
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1078#discussion_r160665449
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
@@ -195,8 +195,16 @@
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1078#discussion_r160664549
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
@@ -228,13 +236,16 @@
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1087
@sachouche do you have Jira for this fix (if not please create it)? Could
you please include Jira number in PR and description and PR commit message
(it's a Drill standard) [1, 2, 3].
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1084#discussion_r160650090
--- Diff:
exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/snippets/sql.js
---
@@ -0,0 +1,46 @@
+/**
+ * Drill SQL Syntax
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1084#discussion_r160650903
--- Diff:
exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/snippets/sql.js
---
@@ -0,0 +1,46 @@
+/**
+ * Drill SQL Syntax
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1084#discussion_r160651815
--- Diff:
exec/java-exec/src/main/resources/rest/static/js/ace-code-editor/snippets/sql.js
---
@@ -0,0 +1,46 @@
+/**
+ * Drill SQL Syntax
[
https://issues.apache.org/jira/browse/DRILL-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volodymyr Vysotskyi resolved DRILL-5037.
Resolution: Fixed
Fix Version/s: 1.12.0
Fixed in
51 matches
Mail list logo
