Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1023
Travis build is flakey. Rerunning build.
---
GitHub user ilooner reopened a pull request:
https://github.com/apache/drill/pull/1023
DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabalize TestValueVector
tests.
## DRILL-5922
- QueryContext was never closed when the Foreman finished. So the query
child allocator
Github user ilooner closed the pull request at:
https://github.com/apache/drill/pull/1023
---
Github user ilooner closed the pull request at:
https://github.com/apache/drill/pull/1073
---
GitHub user ilooner reopened a pull request:
https://github.com/apache/drill/pull/1073
DRILL-5967: Fixed memory leak in OrderedPartitionSender
The OrderedPartitionSender was leaking memory every time it was created
because it created a wrapper RecordBatch which allocated memory but
Karthikeyan Manivannan created DRILL-6083:
-
Summary: RestClientFixture does not connect to the correct
webserver port
Key: DRILL-6083
URL: https://issues.apache.org/jira/browse/DRILL-6083
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1073
@paul-rogers Added the comment. Please take a look and let me know if you'd
like any other changes.
---
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r161077516
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AggPruleBase.java
---
@@ -82,4 +83,19 @@ protected boolean
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r161069079
--- Diff:
common/src/main/java/org/apache/drill/common/util/CoreDecimalUtility.java ---
@@ -32,6 +32,14 @@ public static long
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r161067313
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalVarchar.java ---
@@ -150,6 +150,14 @@ public void setup() {
public
Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r161066659
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalVarchar.java ---
@@ -150,6 +150,14 @@ public void setup() {
public
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161065237
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -148,6 +148,8 @@ message SerializedField {
optional int32 value_count = 4;
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161040070
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -309,7 +314,7 @@ public void setInitialCapacity(final int valueCount) {
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161039122
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -874,6 +880,46 @@ public void setSafe(int index, BigDecimal value) {
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161036145
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/util/MemoryUtils.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161045748
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -386,7 +391,7 @@ public void reAlloc() {
throw new
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161030963
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
@@ -449,7 +451,7 @@ public void close() throws
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161032779
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
---
@@ -165,17 +181,133 @@
Sorabh Hamirwasia created DRILL-6082:
Summary: RpcExceptionHandler log doesn't print "cause" for
exception
Key: DRILL-6082
URL: https://issues.apache.org/jira/browse/DRILL-6082
Project: Apache
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161028252
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -471,8 +519,8 @@ public void close() throws Exception {
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r161015751
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -418,6 +422,16 @@ public void get(int index,
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r161006318
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/CastVarCharDecimal.java ---
@@ -85,6 +85,30 @@ public void eval() {
//
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r161004122
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/CastIntDecimal.java ---
@@ -68,15 +68,31 @@ public void setup() {
public void
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160963518
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -327,13 +327,17 @@ public Mutator getMutator(){
return v;
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160941530
--- Diff: exec/java-exec/src/main/codegen/templates/SqlAccessors.java ---
@@ -127,6 +127,25 @@ public String getString(int index) {
}
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160980556
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -539,7 +553,12 @@ public void setValueLengthSafe(int index, int length)
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160987506
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalVarchar.java ---
@@ -150,6 +150,14 @@ public void setup() {
public
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160939410
--- Diff:
exec/java-exec/src/main/codegen/templates/Decimal/DecimalFunctions.java ---
@@ -102,7 +111,578 @@
<#-- For each DECIMAL... type (in
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r161002913
--- Diff:
common/src/main/java/org/apache/drill/common/util/CoreDecimalUtility.java ---
@@ -32,6 +32,14 @@ public static long
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160958360
--- Diff: exec/vector/src/main/codegen/templates/ComplexWriters.java ---
@@ -99,7 +99,7 @@ public void write(Nullable${minor.class?cap_first}Holder
h) {
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1074
+1, LGTM.
---
Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1074#discussion_r161012925
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
---
@@ -211,16 +211,25 @@ public String
I am probably missing something minor here, but I am working with Ted
Dunning on some PCAP plugin stuff, so I built his 1.13 SNAPSHOT, and when I
try to login I see
{
"errorMessage" : "No configuration setting found for key
'drill.exec.http.auth'"
}
I am guessing that something was added
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160996060
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -424,6 +429,23 @@ public MetadataContext getMetaContext()
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160997779
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
---
@@ -250,20 +250,12 @@ private boolean
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1083#discussion_r160936248
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SchemalessScan.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Anton Gozhiy created DRILL-6081:
---
Summary: Duration of completed queries is continuously increasing.
Key: DRILL-6081
URL: https://issues.apache.org/jira/browse/DRILL-6081
Project: Apache Drill
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1074#discussion_r160982037
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
---
@@ -211,16 +211,25 @@ public String
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1078
+1, LGTM.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1074
Thanks, +1.
---
40 matches
Mail list logo
