Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162250517
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestAffinityCalculator.java
---
@@ -21,18 +21,14 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162244374
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java
---
@@ -118,7 +118,7 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162229362
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -288,7 +288,7 @@ public static void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162251030
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java ---
@@ -86,37 +117,35 @@
* Multiple threads of execution.
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162251160
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java ---
@@ -127,20 +156,26 @@ public OperatorFixture build() {
*
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162246538
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java
---
@@ -184,7 +184,7 @@ public RawFragmentBatch
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162251307
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java ---
@@ -175,19 +210,189 @@ public DrillConfig getConfig() {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162246947
--- Diff: exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java
---
@@ -84,28 +82,17 @@ protected void testSqlPlan(String sqlCommands) throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162251468
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java ---
@@ -351,8 +603,110 @@ public OperatorStats getStats() {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162229669
--- Diff:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcBatchCreator.java
---
@@ -33,10 +32,10 @@
public class
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162246792
--- Diff: exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java
---
@@ -58,23 +55,24 @@
import com.google.common.collect.ImmutableList;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162246482
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java
---
@@ -172,7 +172,7 @@ public RawFragmentBatch
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1095
Note the test failure on Travis is the infamous Sort operator test failure,
which is unrelated to this change:
```
Failed tests:
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r162226190
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -380,14 +394,19 @@ private void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r162225383
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java
---
@@ -29,9 +28,12 @@
public static long
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r162225832
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -94,8 +98,54 @@ private void clear()
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r162225507
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java
---
@@ -29,9 +28,12 @@
public static long
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r162226341
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -312,12 +312,13 @@ drill.exec: {
memory: {
operator: {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r162225888
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java
---
@@ -38,23 +38,20 @@
public abstract
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r162225575
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -94,8 +98,54 @@ private void clear()
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1090
Pushed a new commit that fixes an indexing error. Also removes the "unsafe"
methods in favor of the "set" methods in DrillBuf as Vlad requested.
@vrozov, please take another look.
---
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1095
@arina-ielchiieva
---
GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/1095
DRILL-6085: Fixed spontaneous vm exits on Travis.
This error occurs sporadically on Travis.
```
Failed to execute goal
[32morg.apache.maven.plugins:maven-surefire-plugin:2.17:test[m
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1057#discussion_r162196004
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/AbstractCopier.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1057#discussion_r162193983
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/AbstractCopier.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/1066
Other than one comment above, rest LGTM. +1
---
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/1066
@vvysotskyi could you pls separate out the HashAggregate OOM related change
from this PR and file a separate JIRA for it since it is unrelated to the
calcite rebase per-se. Lumping them
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1057#discussion_r162175059
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/AbstractSV4Copier.java
---
@@ -17,32 +17,30 @@
*/
package
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r162171143
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DrillRelBuilder.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r162157833
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DrillRelBuilder.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r162161040
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DrillRelBuilder.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r157854723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DrillRelBuilder.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r157853167
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DrillRelBuilder.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162124359
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162120115
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162123690
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162119757
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162121115
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162124388
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/1093
+1 . It would be good to add a unit test using the example in the JIRA.
---
GitHub user milindt opened a pull request:
https://github.com/apache/drill/pull/1094
DRILL-6090: While connecting to drill-bits using JDBC Driver through â¦
â¦Zookeeper, a lot of "Curator-Framework-0" threads are created if
connection to drill-bit is not successful(no drill-bits
41 matches
Mail list logo
