[GitHub] drill issue #1092: DRILL-6088: MainLoginPageModel errors out when http.auth....

Github user sohami commented on the issue: https://github.com/apache/drill/pull/1092 @arina-ielchiieva - I have rebased the commit's on latest master and made the change as suggested. I have also made the MainLoginPageModel class public since it was causing the issue without that at

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162521845 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java --- @@ -86,37 +117,35 @@ * Multiple threads of execution. *

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162518120 --- Diff: exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java --- @@ -58,23 +55,24 @@ import com.google.common.collect.ImmutableList;

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r162517870 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestSqlPatterns.java --- @@ -446,6 +446,61 @@ public void

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162517423 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/managed/TestSorter.java --- @@ -59,7 +59,7 @@

[GitHub] drill pull request #1094: DRILL-6090: While connecting to drill-bits using J...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1094#discussion_r162516548 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java --- @@ -132,10 +132,12 @@ protected DrillConnectionImpl(DriverImpl

[GitHub] drill pull request #1085: DRILL-6049: Misc. hygiene and code cleanup changes

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1085#discussion_r162512667 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorStats.java --- @@ -278,22 +273,62 @@ public void

[GitHub] drill pull request #1085: DRILL-6049: Misc. hygiene and code cleanup changes

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1085#discussion_r162512111 --- Diff: common/src/main/java/org/apache/drill/common/exceptions/UserException.java --- @@ -83,23 +83,17 @@ public static Builder memoryError() {

[GitHub] drill pull request #1085: DRILL-6049: Misc. hygiene and code cleanup changes

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1085#discussion_r162513175 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java --- @@ -38,20 +38,26 @@ import

[GitHub] drill pull request #1085: DRILL-6049: Misc. hygiene and code cleanup changes

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1085#discussion_r162512386 --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java --- @@ -728,4 +733,49 @@ public static boolean isLaterType(MajorType type) {

[jira] [Created] (DRILL-6099) Drill does not push limit past project (flatten) if it cannot be pushed into scan

Gautam Kumar Parai created DRILL-6099: - Summary: Drill does not push limit past project (flatten) if it cannot be pushed into scan Key: DRILL-6099 URL: https://issues.apache.org/jira/browse/DRILL-6099

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162513655 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -288,7 +288,7 @@ public static void

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162513475 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java --- @@ -118,7 +118,7 @@ public IterOutcome innerNext() {

[jira] [Created] (DRILL-6098) Make Drill Failure Handling Consistent

Timothy Farkas created DRILL-6098: - Summary: Make Drill Failure Handling Consistent Key: DRILL-6098 URL: https://issues.apache.org/jira/browse/DRILL-6098 Project: Apache Drill Issue Type:

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162512891 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java --- @@ -172,7 +172,7 @@ public RawFragmentBatch getNext()

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162512429 --- Diff: exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java --- @@ -58,23 +55,24 @@ import com.google.common.collect.ImmutableList;

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162512220 --- Diff: exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java --- @@ -58,23 +55,24 @@ import com.google.common.collect.ImmutableList;

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162511432 --- Diff: exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java --- @@ -84,28 +82,17 @@ protected void testSqlPlan(String sqlCommands) throws

[jira] [Created] (DRILL-6097) Create an interface for the QueryContext

Timothy Farkas created DRILL-6097: - Summary: Create an interface for the QueryContext Key: DRILL-6097 URL: https://issues.apache.org/jira/browse/DRILL-6097 Project: Apache Drill Issue Type:

[GitHub] drill issue #1072: DRILL-5879: Improved SQL Pattern Contains Performance

Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1072 @paul-rogers Is this ready for commit? ---

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162501868 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/managed/TestSorter.java --- @@ -59,7 +59,7 @@

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162499201 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/TestAffinityCalculator.java --- @@ -21,18 +21,14 @@ import

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1066 ---

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162497247 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java --- @@ -86,37 +117,35 @@ * Multiple threads of execution.

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162496772 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java --- @@ -86,37 +117,35 @@ * Multiple threads of execution. *

[jira] [Created] (DRILL-6096) Provide mechanisms to specify field delimiters and quoted text for TextRecordWriter

Kunal Khatua created DRILL-6096: --- Summary: Provide mechanisms to specify field delimiters and quoted text for TextRecordWriter Key: DRILL-6096 URL: https://issues.apache.org/jira/browse/DRILL-6096

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162495937 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java --- @@ -127,20 +156,26 @@ public OperatorFixture build() { * uses

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162495701 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java --- @@ -351,8 +603,110 @@ public OperatorStats getStats() { }

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r162495593 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java --- @@ -175,19 +210,189 @@ public DrillConfig getConfig() { }

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r162478583 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -77,16 +84,17 @@ table.sortable thead .sorting_desc { background-image:

[GitHub] drill issue #570: DRILL-4834 decimal implementation is vulnerable to overflo...

Github user daveoshinsky commented on the issue: https://github.com/apache/drill/pull/570 The new VARDECIMAL one-size-fits-all decimal type, which this PR implements, will now be incorporated into the following new JIRA with additional changes and fixes for Drill 1.13:

Decimal data type enhancements

Hi all, I am going to work on improving decimal data types. I have created Jira DRILL-6094 and design document where analyzed the current state of

[GitHub] drill issue #1066: DRILL-3993: Changes to support Calcite 1.15

Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1066 FYI: changes in pom files: We observed issue with Avatica similar to the issue described in https://issues.apache.org/jira/browse/CALCITE-1694. Therefore we had to make changes in our pom

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r162384019 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -77,16 +84,17 @@ table.sortable thead .sorting_desc { background-image:

[GitHub] drill pull request #1092: DRILL-6088: MainLoginPageModel errors out when htt...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1092#discussion_r162331112 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java --- @@ -132,24 +133,26 @@ public Viewable

[GitHub] drill pull request #1084: DRILL-5868: Support SQL syntax highlighting of que...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1084#discussion_r162329512 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -77,16 +84,17 @@ table.sortable thead .sorting_desc { background-image:

[GitHub] drill issue #1095: DRILL-6085: Fixed spontaneous vm exits on Travis.

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1095 +1 ---

[GitHub] drill pull request #1094: DRILL-6090: While connecting to drill-bits using J...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1094#discussion_r162311140 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java --- @@ -132,10 +132,12 @@ protected

[GitHub] drill issue #1066: DRILL-3993: Changes to support Calcite 1.15

Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1066 @amansinha100, regarding HashAggregate OOM related change, it was done in the scope of this pull request since with new Calcite a physical plan for the query was changed to the correct one but it

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r162292084 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java --- @@ -38,13 +37,16 @@ import

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r162292571 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java --- @@ -19,19 +19,17 @@ package

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r162293231 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -535,4 +541,8 @@ public void close() {

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r162289830 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/JoinTestBase.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r162292685 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java --- @@ -19,20 +19,22 @@ package

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r162293578 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java --- @@ -228,4 +228,20 @@ public WritableBatch

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r162294377 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/JoinTestBase.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the

[GitHub] drill pull request #1094: DRILL-6090: While connecting to drill-bits using J...

Github user milindt commented on a diff in the pull request: https://github.com/apache/drill/pull/1094#discussion_r162286759 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java --- @@ -132,10 +132,12 @@ protected DrillConnectionImpl(DriverImpl

[GitHub] drill issue #1094: DRILL-6090: While connecting to drill-bits using JDBC Dri...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1094 @milindt release 1.12.0 is out. Regarding this fix, once you address code review comments it will be added in 1.13.0. ---

[GitHub] drill pull request #1094: DRILL-6090: While connecting to drill-bits using J...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1094#discussion_r162282830 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java --- @@ -132,10 +132,12 @@ protected

[GitHub] drill issue #1094: DRILL-6090: While connecting to drill-bits using JDBC Dri...

Github user milindt commented on the issue: https://github.com/apache/drill/pull/1094 @paul-rogers can you please review this fix? ---

[GitHub] drill issue #1094: DRILL-6090: While connecting to drill-bits using JDBC Dri...

Github user milindt commented on the issue: https://github.com/apache/drill/pull/1094 Details in [DRILL-6090](https://issues.apache.org/jira/browse/DRILL-6090) ---

[GitHub] drill issue #1093: DRILL-6093 : Account for simple columns in project cpu co...

Github user gparai commented on the issue: https://github.com/apache/drill/pull/1093 @amansinha100 I have addressed your comments. ---