[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165263759 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -215,6 +206,7 @@ public BatchHolder()

Re: [ANNOUNCE] New PMC member: Paul Rogers

Thanks everyone! Glad to be of service. Drill fills a unique niche: the ability to run distributed SQL queries on a large variety of data sources. I look forward to doing my part to bring that to a wider audience. - Paul On Wednesday, January 31, 2018, 7:21:06 PM PST, Saurabh Mahapatra

[GitHub] drill issue #1106: DRILL-6129: Fixed query failure due to nested column data...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1106 Note that a similar bug was recently fixed in (as I recall) the Merge Receiver. As part of this fix, would be good to either: 1. Determine if we have more copies of this logic besides

[GitHub] drill pull request #1103: DRILL-6124: Fixed possible NPE when no injection s...

Github user ilooner closed the pull request at: https://github.com/apache/drill/pull/1103 ---

[GitHub] drill issue #1103: DRILL-6124: Fixed possible NPE when no injection site is ...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1103 You are right @arina-ielchiieva . Thanks for catching this, I will close the PR and mark the jira as invalid. ---

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congrats Paul! On January 31, 2018, at 3:52 PM, Vlad Rozov wrote: Congrats Paul! Thank you, Vlad On 1/31/18 04:37, Vitalii Diravka wrote: > Congratulations, Paul! > Well deserved. > > Kind regards > Vitalii > > On Wed, Jan 31, 2018 at 9:58 AM, Arina Yelchiyeva < >

[GitHub] drill issue #1106: DRILL-6129: Fixed query failure due to nested column data...

Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1106 @amansinha100 can you please review it? ---

[GitHub] drill pull request #1106: DRILL-6129: Fixed query failure due to nested colu...

GitHub user sachouche opened a pull request: https://github.com/apache/drill/pull/1106 DRILL-6129: Fixed query failure due to nested column data type change Problem Description - - The Drillbit was able to successfully send batches containing different metadata (for nested

Build failed in Jenkins: drill-scm #930

See Changes: [bben-zvi] DRILL-6106: Use valueOf method instead of constructor since valueOf has -- [...truncated 731.62 KB...] Downloading:

[jira] [Created] (DRILL-6129) Query fails on nested data type schema change

salim achouche created DRILL-6129: - Summary: Query fails on nested data type schema change Key: DRILL-6129 URL: https://issues.apache.org/jira/browse/DRILL-6129 Project: Apache Drill Issue

[GitHub] drill pull request #1099: DRILL-6106: Use valueOf method instead of construc...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1099 ---

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congrats Paul! Thank you, Vlad On 1/31/18 04:37, Vitalii Diravka wrote: Congratulations, Paul! Well deserved. Kind regards Vitalii On Wed, Jan 31, 2018 at 9:58 AM, Arina Yelchiyeva < arina.yelchiy...@gmail.com> wrote: Congratulations, Paul! Well deserved. Kind regards Arina On Wed, Jan

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congrats ! On January 31, 2018 at 1:54:20 PM, Khurram Faraaz (kfar...@mapr.com) wrote: Congratulations Paul. From: Vova Vysotskyi Sent: Wednesday, January 31, 2018 12:51:25 PM To: dev@drill.apache.org Subject: Re:

Re: Batch handling project next steps

Hi Paul, Looking at your PR plan, I am guessing that the CSV reader changes and the JSON reader changes are independent, right? If yes, I would like to propose that you open a PR for the CSV reader first. That will give us one more way to start exercising and maturing the accessor framework

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congratulations Paul. From: Vova Vysotskyi Sent: Wednesday, January 31, 2018 12:51:25 PM To: dev@drill.apache.org Subject: Re: [ANNOUNCE] New PMC member: Paul Rogers Congrats, Paul! 2018-01-31 22:40 GMT+02:00 Rob Wu : >

[jira] [Created] (DRILL-6128) Wrong Result with Nested Loop Join

Sorabh Hamirwasia created DRILL-6128: Summary: Wrong Result with Nested Loop Join Key: DRILL-6128 URL: https://issues.apache.org/jira/browse/DRILL-6128 Project: Apache Drill Issue Type:

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congrats, Paul! 2018-01-31 22:40 GMT+02:00 Rob Wu : > Congratulations, Paul! > > Best regards, > > Rob > > Best regards, > > Rob > > From: Charles Givre > Sent: Wednesday, January 31, 2018 9:47:25 AM > To:

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congratulations, Paul! Best regards, Rob Best regards, Rob From: Charles Givre Sent: Wednesday, January 31, 2018 9:47:25 AM To: dev@drill.apache.org Subject: Re: [ANNOUNCE] New PMC member: Paul Rogers Congrats Paul! Very well deserved! >

[GitHub] drill issue #1099: DRILL-6106: Use valueOf method instead of constructor sin...

Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1099 @reudismam Travis fails in other PRs as well. See #1105. ---

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165168294 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -84,13 +85,6 @@ public abstract class

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165166234 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java --- @@ -255,7 +254,6 @@ private HashAggregator

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r164617150 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -84,13 +85,6 @@ public abstract class

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165161146 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java --- @@ -255,7 +254,6 @@ private HashAggregator

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165156589 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -215,6 +206,7 @@ public BatchHolder() {

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is cancel...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 @sachouche @arina-ielchiieva ---

[GitHub] drill pull request #1105: DRILL-6125: Fix possible memory leak when query is...

GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1105 DRILL-6125: Fix possible memory leak when query is cancelled. A detailed description of the problem and solution can be found here: https://issues.apache.org/jira/browse/DRILL-6125 You

[GitHub] drill issue #1099: DRILL-6106: Use valueOf method instead of constructor sin...

Github user reudismam commented on the issue: https://github.com/apache/drill/pull/1099 Only pass Travis CI by removing the edits to SSLConfigClient.java ---

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165137630 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -232,9 +251,8 @@ else if (width > 0) {

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165136635 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -397,11 +384,9 @@ private void

[jira] [Created] (DRILL-6127) NullPointerException happens when submitting physical plan to the Hive storage plugin

Anton Gozhiy created DRILL-6127: --- Summary: NullPointerException happens when submitting physical plan to the Hive storage plugin Key: DRILL-6127 URL: https://issues.apache.org/jira/browse/DRILL-6127

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165135291 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -215,6 +206,7 @@ public BatchHolder() {

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user cgivre commented on the issue: https://github.com/apache/drill/pull/897 Yes, it can be closed. Nice work on the syntax highlighting! > On Jan 29, 2018, at 16:46, Kunal Khatua wrote: > > @cgivre can we

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congrats Paul! Very well deserved! > On Jan 30, 2018, at 16:50, Aman Sinha wrote: > > I am pleased to announce that Drill PMC invited Paul Rogers to the PMC and > he has accepted the invitation. > > Congratulations Paul and thanks for your contributions ! > > -Aman >

[GitHub] drill issue #1099: DRILL-6106: Use valueOf method instead of constructor sin...

Github user reudismam commented on the issue: https://github.com/apache/drill/pull/1099 I have squashed the commits, but I’m getting an error in Travis CI similar to the previous one when I reverted some changes. Column a-offsets of type UInt4Vector: Offset (0) must be 0 but was

[GitHub] drill issue #916: DRILL-5377: Five-digit year dates are displayed incorrectl...

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/916 @arina-ielchiieva You are right. According to SQL spec after resolving [CALCITE-2055](https://issues.apache.org/jira/browse/CALCITE-2055) and Drill-Calcite upgrade Drill and Calcite don't

[GitHub] drill pull request #916: DRILL-5377: Five-digit year dates are displayed inc...

Github user vdiravka closed the pull request at: https://github.com/apache/drill/pull/916 ---

[jira] [Resolved] (DRILL-5377) Five-digit year dates are displayed incorrectly via jdbc

[ https://issues.apache.org/jira/browse/DRILL-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-5377. Resolution: Not A Problem [~vvysotskyi] Thank you. So for now test cases from jira

[GitHub] drill issue #916: DRILL-5377: Five-digit year dates are displayed incorrectl...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/916 It seems that this PR is not relevant after Calcite upgrade. @vdiravka please confirm and close PR. ---

[GitHub] drill issue #1104: DRILL-6118: Handle item star columns during project / fil...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1104 @chunhui-shi please review. ---

[GitHub] drill pull request #1104: DRILL-6118: Handle item star columns during projec...

GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/1104 DRILL-6118: Handle item star columns during project / filter push dow… …n and directory pruning 1. Added DrillFilterItemStarReWriterRule to re-write item star fields to

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congratulations, Paul! Well deserved. Kind regards Vitalii On Wed, Jan 31, 2018 at 9:58 AM, Arina Yelchiyeva < arina.yelchiy...@gmail.com> wrote: > Congratulations, Paul! > Well deserved. > > Kind regards > Arina > > On Wed, Jan 31, 2018 at 10:13 AM, Robert Hou wrote: > > >

[GitHub] drill issue #1083: DRILL-4185: UNION ALL involving empty directory on any si...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1083 +1, LGTM. Thanks for making the changes. ---

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r165023581 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java --- @@ -568,6 +570,22 @@ public void nullMixedComparatorEqualJoinHelper(final

[GitHub] drill issue #1099: DRILL-6106: Use valueOf method instead of constructor sin...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1099 Well, you can always use force push to override your previous changes or even replace your remote branch with new local. ---

[GitHub] drill issue #1103: DRILL-6124: Fixed possible NPE when no injection site is ...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1103 @ilooner it looks like if latch is not found, execution control will return dummy latch [1]? If I am missing something, please explain. [1]

[GitHub] drill issue #1099: DRILL-6106: Use valueOf method instead of constructor sin...

Github user reudismam commented on the issue: https://github.com/apache/drill/pull/1099 Maybe it has not worked as expected. It squashed the commit (first commit), but as the commit mix commits from other persons, they come together. Maybe it will be the case of creating a patch file

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congratulations, Paul! Well deserved. Kind regards Arina On Wed, Jan 31, 2018 at 10:13 AM, Robert Hou wrote: > Congratulations, Paul! > > > --Robert > > > From: Abhishek Girish > Sent: Tuesday, January 30, 2018 9:31 PM > To:

Re: [ANNOUNCE] New PMC member: Paul Rogers

Congratulations, Paul! --Robert From: Abhishek Girish Sent: Tuesday, January 30, 2018 9:31 PM To: dev@drill.apache.org Subject: Re: [ANNOUNCE] New PMC member: Paul Rogers Congratulations, Paul! On Tue, Jan 30, 2018 at 2:48 PM, Sorabh