[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401686350 @amansinha100 The scan node's memory copy logic has removed. Thanks for the knowledge of `SelectionVectorPrelVisitor.addSelectionRemoverWhereNecessary

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199395144 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -696,

[GitHub] asfgit closed pull request #1342: DRILL-6537:Limit the batch size for buffering operators based on how …

asfgit closed pull request #1342: DRILL-6537:Limit the batch size for buffering operators based on how … URL: https://github.com/apache/drill/pull/1342 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] asfgit closed pull request #309: DRILL-4020: The not-equal operator returns incorrect results when used on the HBase row key

asfgit closed pull request #309: DRILL-4020: The not-equal operator returns incorrect results when used on the HBase row key URL: https://github.com/apache/drill/pull/309 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for th

[GitHub] asfgit closed pull request #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i…

asfgit closed pull request #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i… URL: https://github.com/apache/drill/pull/1352 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] asfgit closed pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

asfgit closed pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] asfgit closed pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

asfgit closed pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] asfgit closed pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

asfgit closed pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate

ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#issuecomment-401675042 @vvysotskyi sorry about that. fixed the problem.updated the PR. This is an

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199376103 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java ## @@ -226,6 +244,

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199374038 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java ## @@ -32,35 +33

[jira] [Resolved] (DRILL-6061) Doc Request: Global Query List showing queries from all Drill foreman nodes

[ https://issues.apache.org/jira/browse/DRILL-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bridget Bevens resolved DRILL-6061. --- Resolution: Fixed I've added the following doc: https://drill.apache.org/docs/global-query-li

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199369589 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java ## @@ -226,6 +244,96

[GitHub] aravi5 commented on issue #1272: DRILL-5977: Filter Pushdown in Drill-Kafka plugin

aravi5 commented on issue #1272: DRILL-5977: Filter Pushdown in Drill-Kafka plugin URL: https://github.com/apache/drill/pull/1272#issuecomment-401639836 @akumarb2010 - Thank you for reviewing the design and implementation, and providing valuable inputs. ---

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199358015 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@ "storag

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199359888 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199359807 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199357677 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java ###

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199358139 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -17,22 +

[GitHub] vvysotskyi commented on issue #1324: DRILL-6310: limit batch size for hash aggregate

vvysotskyi commented on issue #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#issuecomment-401618980 Unit tests in travis build for this PR failed, @ppadma, could you please take a look at this?

[GitHub] ppadma commented on issue #1342: DRILL-6537:Limit the batch size for buffering operators based on how …

ppadma commented on issue #1342: DRILL-6537:Limit the batch size for buffering operators based on how … URL: https://github.com/apache/drill/pull/1342#issuecomment-401618524 @vvysotskyi Done. I accidentally closed the PR. Reopened it.

[GitHub] ppadma opened a new pull request #1342: DRILL-6537:Limit the batch size for buffering operators based on how …

ppadma opened a new pull request #1342: DRILL-6537:Limit the batch size for buffering operators based on how … URL: https://github.com/apache/drill/pull/1342 …much memory they get @Ben-Zvi please review. This is an aut

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199338763 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterWritable.java ## @@ -0

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199334516 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java ## @@ -226,6 +244,

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199336580 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -49

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199338879 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterWritable.java ## @@ -0

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199336665 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java ## @@ -0,

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199334349 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java ## @@ -32,35 +

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199336779 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java ## @@ -0,

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199334575 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java ## @

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199338885 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterWritable.java ## @@ -0

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199337353 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -49

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199329850 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ValueVectorHashHelper.java ## @@ -

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199336591 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -49

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199354240 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java ## @@ -226,6 +244,

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199336633 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashPrelUtil.java ## @@ -125,6

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199336934 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java ## @@ -0,

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199354604 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -69

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199336769 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java ## @@ -0,

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199334413 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java ## @@ -86,8 +1

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199336697 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java ## @@ -0,

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199337337 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -49

[GitHub] ppadma closed pull request #1342: DRILL-6537:Limit the batch size for buffering operators based on how …

ppadma closed pull request #1342: DRILL-6537:Limit the batch size for buffering operators based on how … URL: https://github.com/apache/drill/pull/1342 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] sohami opened a new pull request #1356: DRILL-6561: Lateral excluding the columns from output container provided by projection push into rules

sohami opened a new pull request #1356: DRILL-6561: Lateral excluding the columns from output container provided by projection push into rules URL: https://github.com/apache/drill/pull/1356 This PR is dependent upon DRILL-6545 and has 2 commits from it for compilation. Once that is merged

[GitHub] vvysotskyi commented on issue #1342: DRILL-6537:Limit the batch size for buffering operators based on how …

vvysotskyi commented on issue #1342: DRILL-6537:Limit the batch size for buffering operators based on how … URL: https://github.com/apache/drill/pull/1342#issuecomment-401614243 @ppadma, could you please resolve merge conflicts? -

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r199343698 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.j