[GitHub] ilooner commented on issue #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase.

ilooner commented on issue #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase. URL: https://github.com/apache/drill/pull/1409#issuecomment-411290968 @Ben-Zvi I have addressed review comments. See the latest commit for consolidating

[GitHub] kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-411285464 Thanks, @HanumathRao . @ilooner Could you please review these changes?

[GitHub] vvysotskyi commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements.

vvysotskyi commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements. URL: https://github.com/apache/drill/pull/1415#discussion_r208451383 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java

[GitHub] ilooner commented on a change in pull request #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase.

ilooner commented on a change in pull request #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase. URL: https://github.com/apache/drill/pull/1409#discussion_r208450659 ## File path:

[GitHub] ilooner commented on issue #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin

ilooner commented on issue #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin URL: https://github.com/apache/drill/pull/1408#issuecomment-411271484 @Ben-Zvi addressed review comments. Please take another look.

[GitHub] ilooner commented on a change in pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin

ilooner commented on a change in pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin URL: https://github.com/apache/drill/pull/1408#discussion_r208445526 ## File path:

[GitHub] ilooner commented on a change in pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin

ilooner commented on a change in pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin URL: https://github.com/apache/drill/pull/1408#discussion_r208445485 ## File path:

[GitHub] ilooner commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements.

ilooner commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements. URL: https://github.com/apache/drill/pull/1415#discussion_r208441905 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java

[jira] [Created] (DRILL-6673) Drill table functions cannot use plugin configs with a constructor

Paul Rogers created DRILL-6673: -- Summary: Drill table functions cannot use plugin configs with a constructor Key: DRILL-6673 URL: https://issues.apache.org/jira/browse/DRILL-6673 Project: Apache Drill

[GitHub] HanumathRao commented on issue #1426: DRILL-6671: Multi level lateral unnest join is throwing an exception …

HanumathRao commented on issue #1426: DRILL-6671: Multi level lateral unnest join is throwing an exception … URL: https://github.com/apache/drill/pull/1426#issuecomment-411245012 @vvysotskyi Please can you help review this change.

[jira] [Created] (DRILL-6672) Drill table functions cannot handle "setFoo" accessors

Paul Rogers created DRILL-6672: -- Summary: Drill table functions cannot handle "setFoo" accessors Key: DRILL-6672 URL: https://issues.apache.org/jira/browse/DRILL-6672 Project: Apache Drill

[GitHub] Ben-Zvi commented on a change in pull request #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase.

Ben-Zvi commented on a change in pull request #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase. URL: https://github.com/apache/drill/pull/1409#discussion_r208421033 ## File path:

[GitHub] HanumathRao opened a new pull request #1426: DRILL-6671: Multi level lateral unnest join is throwing an exception …

HanumathRao opened a new pull request #1426: DRILL-6671: Multi level lateral unnest join is throwing an exception … URL: https://github.com/apache/drill/pull/1426 …during materializing the plan. This PR includes changes to correctly attach the concerned UnnestPOP to LateralJoinPOP.

[GitHub] Ben-Zvi commented on a change in pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin

Ben-Zvi commented on a change in pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin URL: https://github.com/apache/drill/pull/1408#discussion_r208401852 ## File path:

[GitHub] HanumathRao commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

HanumathRao commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-411219653 @kr-arjun Thanks for the changes. Code changes look good to me.

[GitHub] Ben-Zvi commented on a change in pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin

Ben-Zvi commented on a change in pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin URL: https://github.com/apache/drill/pull/1408#discussion_r208401247 ## File path:

Re: Interesting Errors

The core problem is that Japanese has four sets of characters that are commonly used for writing text, but only one set of punctuation. These are Kanji, Hiragana, Katakana and roman characters. Kanji are derived from Chinese Han ideo graphs, hiragana derives from a phonetic courtly language and is

Re: Interesting Errors

As far as I can tell, the SQL grammar is based on the ASCII subset of Unicode, meaning that SQL allows only the "full stop" (.) character, but not the Unicode variations. Since the SQL standard defines the meaning of the full stop, Drill probably does not want to allow variations. It seems

Re: 回复：Is Drill query execution processing model just the same idea with the Spark whole-stage codegen improvement

Hi Qiaoyi, In general, optimal performance occurs when a system knows the schema at the start and can fully optimize based on that schema. Think C or C++ compilers compared with Java or Python. On the other hand, the JVM HotSpot optimizer has shown that one can achieve very good performance

[jira] [Created] (DRILL-6671) Multi level lateral unnest join is throwing an exception during materializing the plan.

Hanumath Rao Maduri created DRILL-6671: -- Summary: Multi level lateral unnest join is throwing an exception during materializing the plan. Key: DRILL-6671 URL: https://issues.apache.org/jira/browse/DRILL-6671

Re: Drill Hangout tomorrow 08/07

Thanks everyone for joining the hangout. Attendees : Boaz, Vitalii, Vova, Gautam Vitalii is facing an issue with Zookeeper - he will post it on the user mailing lists. There were no other topics. Gautam On Mon, Aug 6, 2018 at 10:54 AM, Gautam Parai wrote: > The Apache Drill Hangout will

Re: Is Drill query execution processing model just the same idea with the Spark whole-stage codegen improvement

In Drill the record batches constantly flow between different fragments only in the absence of operators that do not require the entire data set before they can produce any output such as join, sort, aggregate and those operators are almost always present in BI cases. The size of a packet

Re: Interesting Errors

That was the interesting part. The python code that was using that character wasn’t seeming to fail. It was the quoted query that was being sent to Drill that was failing. Sent from my iPhone > On Aug 7, 2018, at 07:20, Pradeeban Kathiravelu > wrote: > > If I understand correctly, he was

Re: Interesting Errors

If I understand correctly, he was using the character ・ Different languages have different symbols. The same thing can be said about the Chinese equivalent 。 The characters ・and 。 are entirely different from the "." Not sure whether this needs to be fixed. If I am not completely

Re: Interesting Errors

Hi Charles, Thanks for the interesting story! I think, specifying the correct charset may help to solve this problem. For more details please refer DRILL-5772 . Kind regards, Volodymyr Vysotskyi On Tue, Aug 7, 2018 at 5:02 PM Charles Givre

Interesting Errors

Hello Drill Developers, I wanted to share an interesting development that happened yesterday. I was teaching a class at BlackHat, and we have a worksheet that includes a Drill demonstration using PyDrill. Basically the students are asked to execute a query in Drill using PyDrill then

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r208168529 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java ## @@ -0,0

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r208165293 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ## @@ -408,6 +424,9 @@

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r208161542 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java ## @@ -0,0

Re: Is Drill query execution processing model just the same idea with the Spark whole-stage codegen improvement

Hello, There is one important difference between the two execution models is how the data flows inside the clusters. In Drill: the complete chain of operators is instantiated at the very beginning of the query, and the data constantly flows between the different fragments as small packets (named

[GitHub] vvysotskyi commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements.

vvysotskyi commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements. URL: https://github.com/apache/drill/pull/1415#discussion_r207829569 ## File path: src/main/resources/checkstyle-config.xml ## @@ -35,11 +35,26 @@

[GitHub] vvysotskyi commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements.

vvysotskyi commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements. URL: https://github.com/apache/drill/pull/1415#discussion_r208128239 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java

[GitHub] vvysotskyi opened a new pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

vvysotskyi opened a new pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425 Most of the changes are connected with changes in Avatica (https://github.com/apache/calcite-avatica/commit/2ebfd8060119efde140a0343fbf9e833b2915505)