GitHub user HanumathRao opened a pull request:
https://github.com/apache/drill/pull/996
DRILL-5878: TableNotFound exception is being reported for a wrong stoâ¦
â¦rage plugin.
@paul-rogers @chunhui-shi Please review these changes. These changes are
for reporting
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/996#discussion_r145268123
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -481,6 +485,19 @@ public RelOptTableImpl getTable
GitHub user HanumathRao opened a pull request:
https://github.com/apache/drill/pull/1007
MD-2888: Selecting a non-existing field from a MapR-DB JSON table faiâ¦
â¦ls with NPE
@amansinha100 @adityakishore
These changes are about having a special handling in case
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/996
@arina-ielchiieva Thank your for the comments. There is some work that went
into calcite to handle meaningful error messages. This is the checkin that has
those changes.
https://github.com
Github user HanumathRao closed the pull request at:
https://github.com/apache/drill/pull/996
---
GitHub user HanumathRao opened a pull request:
https://github.com/apache/drill/pull/1059
DRILL-5851: Empty table during a join operation with a non empty tablâ¦
â¦e produces cast exception.
These code changes handle the cases where either of the table in a join is
empty
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/996
@arina-ielchiieva I think this check shouldn't cause much of a performance
impact as it is in parser code and also it is checked right now by the DRILL's
custom overload of getTable
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/996#discussion_r146118431
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java
---
@@ -77,6 +77,22 @@ public static SchemaPlus findSchema
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/996#discussion_r146118332
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java
---
@@ -77,6 +77,22 @@ public static SchemaPlus findSchema
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/996#discussion_r147896927
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/dfs/TestFileSelection.java
---
@@ -63,4 +63,17 @@ public void
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/996#discussion_r147818548
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java
---
@@ -77,6 +77,22 @@ public static SchemaPlus findSchema
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/996
@arina-ielchiieva Thank you for the review comments. I have modified the
code accordingly. Please let me know if anything needs to be changed.
---
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1059
@paul-rogers Thanks for the review. I have moved the testcase to one test
file and called it from multiple places. I have also made changes to move the
code in checkForEarlyExit to base class
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1059
@vdiravka Thank you for the review comments.
I have done the needed changes.
---
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1059
@amansinha100 These issues might not be because of this PR changes. I
think, these are random issues which are being shown up in my branch. I heard
from @Ben-Zvi that he also had some issues
GitHub user HanumathRao opened a pull request:
https://github.com/apache/drill/pull/1110
DRILL-6115: SingleMergeExchange is not scaling up when many minor fraâ¦
â¦gments are allocated for a query.
Currently a singlemerge exchange is merging all the fragment streams
Github user HanumathRao closed the pull request at:
https://github.com/apache/drill/pull/1007
---
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1117
@ilooner Changes look fine to me. However, as discussed offline I couldn't
reproduce the plan which was sorting one of the inputs for a HASHJOIN. This
might be because in the hashjoinprule we
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1120
@Ben-Zvi Can you please review this change.
---
GitHub user HanumathRao opened a pull request:
https://github.com/apache/drill/pull/1120
DILL-6148: TestSortSpillWithException is sometimes failing.
I have changed the test case to use the EXTERNAL_SORT_MAX_MEMORY to
configure the sort operator to use less memory instead of relying
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1110
@vrozov Thank you for reviewing the code. I have incorporated all the
review comments. Please let me know if anything needs to be changed.
---
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1110
@amansinha100 @vrozov Thank you for the review. I have addressed all the
review comments. Please let me know if any changes are required.
The commits are organized such that one commit
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1120#discussion_r167957209
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java
---
@@ -59,6 +59,7 @@ public static
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r168021043
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/AbstractMuxExchange.java
---
@@ -92,24 +92,19 @@ public Sender getSender
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1120#discussion_r167760816
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java
---
@@ -59,6 +59,7 @@ public static
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r168338663
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SingleMergeExchangePrel.java
---
@@ -93,6 +94,21 @@ public
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1110
@amansinha100 @vrozov Thanks for the review. I have squashed all the
commits into two commits.
Please merge these two commits individually into the apache master branch.
First commit
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158992589
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -305,11 +307,15 @@ public void
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158356421
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java
---
@@ -323,8 +323,6 @@ public void
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1152#discussion_r174558063
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillFilterItemStarReWriterRule.java
---
@@ -54,83 +44,189 @@
import
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1152#discussion_r174568699
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestPushDownAndPruningWithItemStar.java
---
@@ -180,4 +248,38 @@ public void
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1152#discussion_r174558288
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillFilterItemStarReWriterRule.java
---
@@ -54,83 +44,189 @@
import
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183875553
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1238
@vrozov Thanks for making the changes. Code changes looks good to me.
---
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r183886561
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -182,13 +184,18
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1236#discussion_r183384261
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java
---
@@ -88,10 +88,10 @@ public void
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183576093
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183576419
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/FooterGatherer.java
---
@@ -66,8 +69,8 @@ private static void
38 matches
Mail list logo
