Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173041288
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -182,6 +196,66 @@ public boolean isActive() {
protected
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1145
Made all the changes and squashed changes into 2 commits
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1168#discussion_r174866472
--- Diff: exec/jdbc-all/pom.xml ---
@@ -473,6 +473,8 @@
org/yaml/**
hello/**
webapps
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1168
+1 LGTM. Thanks for making the changes.
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1168#discussion_r174882554
--- Diff: exec/jdbc-all/pom.xml ---
@@ -473,6 +473,8 @@
org/yaml/**
hello/**
webapps
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1155
+1 LGTM.
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1145
@vrozov - Thanks for the feedback. Update the PR with latest changes.
Please help to review.
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1153#discussion_r173371697
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -269,9 +277,12
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1153#discussion_r173371305
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -193,7 +192,11 @@
var port = getPortNum();
var timeout;
var
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1153
+1 LGTM. Thanks for making the changes.
---
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1202
DRILL-6311: No logging information in drillbit.log / drillbit.out
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sohami/drill DRILL-6311
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1202
@vrozov - Please help to review.
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1202
@vrozov - Update the PR based on your suggestion. The command `mvn test
-DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.Unlikel
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181165145
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -180,7 +180,7 @@ public void run() throws Exception
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181254054
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -67,9 +73,15 @@
${i}
${drillbit.getAddress
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181161322
--- Diff:
common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181161557
--- Diff:
common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java ---
@@ -60,6 +61,7 @@ private static void registerSystemMetrics
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181252317
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -260,7 +285,7 @@
function fillQueryCount(row_id) {
var requestPath
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181258290
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -283,20 +308,114 @@
alert(errorThrown
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181179746
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -189,11 +189,16 @@ public void run() throws Exception
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181253785
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -283,20 +308,114 @@
alert(errorThrown
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181252867
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -158,7 +158,13 @@ public void start() throws Exception
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181251700
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -79,9 +91,14
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r182495572
--- Diff:
common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java ---
@@ -18,6 +18,7 @@
package org.apache.drill.exec.metrics
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r182510967
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -79,11 +94,15
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r182496734
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -180,20 +180,22 @@ public void run() throws Exception
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r182507182
--- Diff: protocol/src/main/protobuf/Coordination.proto ---
@@ -18,6 +18,7 @@ message DrillbitEndpoint{
OFFLINE = 3;
}
optional State
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183116678
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182873668
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183128175
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183107693
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182639747
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockLateralJoinPOP.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183120789
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182628991
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183117233
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182873443
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182640359
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/unnest/TestingLateralJoinBatch.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182628778
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182628559
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182628483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183114381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183106122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183107099
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183110851
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183145171
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -147,7 +150,19 @@
NUM_BUCKETS
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183169484
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -560,6 +554,40 @@ public void close
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183181073
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -560,6 +554,40 @@ public void close
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183145138
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -157,14 +172,20 @@ public int metricId
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r181830465
--- Diff:
common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1211
DRILL-6322: Lateral Join: Common changes - Add new iterOutcome, Operator
types, MockRecordBatch for testing
@parthchandra - Please review.
You can merge this pull request into a Git repository
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1212
DRILL-6323: Lateral Join - Initial implementation
@parthchandra - Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sohami/drill
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1217
+1 LGTM.
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1212#discussion_r182262104
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -186,6 +186,11 @@ private ExecConstants() {
public static final
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1212#discussion_r182259926
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/LateralJoinBatch.java
---
@@ -0,0 +1,861 @@
+/*
+ * Licensed
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1203
Thanks for all the changes Kunal. LGTM +1
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1217#discussion_r182302719
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -225,14 +225,18 @@ public synchronized void close
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1175
DRILL-6262: IndexOutOfBoundException in RecordBatchSize for empty varâ¦
â¦iableWidthVector
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1175
@ppadma - Please review
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1175
@bitblender - Updated the test. Please review.
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1169#discussion_r175598697
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -272,17 +272,19 @@
}
<#if model.shouldShowAdminI
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1169#discussion_r175598108
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -272,17 +272,19 @@
}
<#if model.shouldShowAdminI
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1180
DRILL-6283: WebServer stores SPNEGO client principal without taking aâ¦
â¦ny conversion rule
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1169
+1 LGTM. Thanks for making the changes.
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1180
@arina-ielchiieva - Please help to review this PR
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1175#discussion_r175629518
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java
---
@@ -321,10 +321,8 @@ public ColumnSize(ValueVector v, String
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1145
@vrozov - Please help to review this PR.
It address the concurrency issue during authentication of control/data
client to server side. Rather than adding the connection into connection holder
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1145
DRILL-6187: Exception in RPC communication between DataClient/Controlâ¦
â¦Client and respective servers when bit-to-bit security is on
You can merge this pull request into a Git repository
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1240
DRILL-6327: Update unary operators to handle IterOutcome.EMIT
Note: Handles for Non-Blocking Unary operators (like
Filter/Project/etc) with EMIT Iter.Outcome
You can merge this pull
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1240
@parthchandra - please help to review this PR.
---
501 - 569 of 569 matches
Mail list logo
