Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r158263816
--- Diff: exec/jdbc-all/pom.xml ---
@@ -572,7 +572,7 @@
This is likely due to you adding new
dependencies to a java-exec
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r158261430
--- Diff: exec/java-exec/src/test/resources/record/test_recorditerator.json
---
@@ -60,7 +60,7 @@
@id:2,
child:1
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1068
@MitchelLabonte, thanks for the pull request, +1
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1068
Sorry, I read your removed comment and made a suggestion that this test
fails.
Did you run all unit tests to see that this change does not break anything?
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1068
@MitchelLabonte, I think this NPE is just a consequence of the bug that
should be fixed. Please investigate why Drill is trying to use child
`PathSegment` when a value has VarChar type.
---
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1068#discussion_r156621897
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/FieldIdUtil.java
---
@@ -131,7 +131,7 @@ public static TypedFieldId
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1049#discussion_r153739725
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java
---
@@ -138,6 +138,8
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1049#discussion_r153735994
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java
---
@@ -138,6 +138,8
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1049
LGTM, +1. Except `INT_32` and `INT_64` parquet can contain other logical
numeric types: `UINT_8`, `UINT_16`, `UINT_32`, `UINT_64`, `INT_8`, `INT_16`[1].
It would be great to add support
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/1046
DRILL-5986: Update jackson-databind version to 2.7.9.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vvysotskyi/drill DRILL-5986
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/904
@weijietong, thanks for the pull request, +1
---
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149616688
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java
---
@@ -120,4 +124,27 @@ protected LogicalExpression parseExpr(String expr
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149615891
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java
---
@@ -120,4 +124,27 @@ protected LogicalExpression parseExpr(String expr
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149612076
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -33,128 +33,140 @@
import
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149614134
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java
---
@@ -120,4 +124,27 @@ protected LogicalExpression parseExpr(String expr
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149613241
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java
---
@@ -120,4 +124,27 @@ protected LogicalExpression parseExpr(String expr
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149440034
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/TestConstantFolding.java
---
@@ -117,6 +123,13 @@ public void createFiles(int
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149440814
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -77,16 +82,23 @@ public void testCastByConstantFolding
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149440392
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -225,4 +243,16 @@ public void
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r148002267
--- Diff:
logical/src/test/java/org/apache/drill/common/expression/fn/JodaDateValidatorTest.java
---
@@ -119,13 +118,14 @@ public void
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147997514
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java
---
@@ -26,14 +26,14 @@
import org.junit.Test
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147996953
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java
---
@@ -26,14 +26,14 @@
import org.junit.Test
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r148000393
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -104,6 +110,13 @@ public void
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r148000718
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -117,10 +130,18 @@ public void testJodaTime
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147581757
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -77,16 +83,21 @@ public void testCastByConstantFolding
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147582599
--- Diff:
logical/src/test/java/org/apache/drill/common/expression/fn/JodaDateValidatorTest.java
---
@@ -24,6 +24,7 @@
import org.junit.BeforeClass
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147581841
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -17,11 +17,10 @@
*/
package
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147582266
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -34,19 +33,22 @@
import
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1012
@vrozov, sorry for the misunderstanding. Currently, it is also not
supported.
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1012
@vrozov, If you meant [geojson](http://geojson.org) when saying about JSON
format support, then my answer - not, it is not supported yet.
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1012
@vrozov As I understand from the [release
notes](https://github.com/Esri/geometry-api-java/releases/tag/v2.0.0), the main
reason for the major version change was changing the interface due
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/1012
DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to avoid depenâ¦
â¦dency on org.json library
Please see [DRILL-5911](https://issues.apache.org/jira/browse/DRILL-5911
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/904
@weijietong thanks for the explanation of your problem. I was able to
reproduce it, but also I found working solution. This mock works correctly. The
problem appears when unit test is run
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/904
@weijietong which problems did you have when tried to mock
`System.getProperty()` method?
As the example of nice mock of this method, you may use [this
test](https://github.com/apache/drill
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/972
@paul-rogers, Thanks for the so informative comments, I completely agree
with the convention that you have proposed.
The problem which this PR is addressed, partially connected to the third
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/980
DRILL-5857: Fix NumberFormatException in Hive unit tests
There is no unit test since with or without this change tests are passes
and query plan does not change.
The exception that has
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/972
DRILL-5838: Fix MaprDB filter pushdown for the case of nested field (reg.
of DRILL-4264)
Please see [DRILL-4264|https://issues.apache.org/jira/browse/DRILL-5838]
for the problem description
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/510
@pmaciolek, could you please close this pull request, since it was merged
in 1ea191fa351b29847e2358f5777982d602cf5ec3
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/805
This my bad habit to regenerate metadata left from the times before fix
DRILL-5660. These functional test failures are the result of the mistake that I
have made when resolving merge conflicts
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
Since Drill does not have enough information about tables in the planning
time to avoid this OOM and since without using the `getMaxRowCount()` for
`ScanPrel`, current approach could not be used
Github user vvysotskyi closed the pull request at:
https://github.com/apache/drill/pull/905
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni it was an inflated example, but considering the case of multiple
joins and when tables have several repeated values, the result will be the
same.
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/805
@paul-rogers, test data should be regenerated (using the Drill version with
this fix) before running functional tests since these tests use metadata cache
files.
Regarding unit test failures
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/905#discussion_r140730762
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdMaxRowCount.java
---
@@ -0,0 +1,71 @@
+/*
+* Licensed
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/942#discussion_r140213645
--- Diff: contrib/storage-hbase/src/test/resources/hbase-site.xml ---
@@ -66,15 +66,13 @@
Default is 10.
-
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/942#discussion_r140215549
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java
---
@@ -100,6 +101,14 @@ public void run() {
return
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/942#discussion_r140209669
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/PathUtils.java ---
@@ -70,4 +72,14 @@ public static final String normalize(final
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/942#discussion_r140214189
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java
---
@@ -100,6 +101,14 @@ public void run() {
return
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r140057495
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1054,8 +1057,36 @@ public void setMax(Object max
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r137591528
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -135,11 +136,16 @@ public void testIntervalArithmetic
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r137590193
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -32,17 +29,21 @@
import
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r13824
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -99,106 +100,142 @@ public void
Github user vvysotskyi closed the pull request at:
https://github.com/apache/drill/pull/930
---
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/942
DRILL-5781: Fix unit test failures to use tests config even if default
config is available
Please see [DRILL-5781](https://issues.apache.org/jira/browse/DRILL-5781)
for details.
You can
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
@paul-rogers, @vrozov, thanks for the review. Squashed commits and rebased
onto master.
---
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/930#discussion_r138620064
--- Diff: common/src/test/resources/logback-test.xml ---
@@ -0,0 +1,92 @@
+
+
+
+
+
+
+
+true
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/930#discussion_r138622881
--- Diff: common/src/test/resources/logback-test.xml ---
@@ -0,0 +1,111 @@
+
+
+
+
+
+
+
+true
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni, the idea is very interesting for me. More appropriate memory
cost estimation will cause to choosing better plans, that will cause the less
time execution and memory costs
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni thanks for looking into this. Completely agree with you that it
would be better to consider both row and column count.
Unfortunately, it does not help to fix this issue, since
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/930#discussion_r138102613
--- Diff: common/src/test/resources/logback-test.xml ---
@@ -0,0 +1,111 @@
+
+
+
+
+
+
+
+true
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/930#discussion_r138103031
--- Diff: common/src/test/resources/logback-test.xml ---
@@ -0,0 +1,111 @@
+
+
+
+
+
+
+
+true
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/930#discussion_r138100617
--- Diff: common/src/test/resources/logback-test.xml ---
@@ -0,0 +1,111 @@
+
+
+
+
+
+
+
+true
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/930#discussion_r137252146
--- Diff: common/src/test/resources/logback.xml ---
@@ -16,17 +16,22 @@
1
true
${LILITH_HOSTNAME:-localhost}
+
Github user vvysotskyi closed the pull request at:
https://github.com/apache/drill/pull/909
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
I have implemented the proposal of @vrozov to conditionally enable Lilith
appender. I have used `ThresholdFilter` in Lilith appender, so it was not
needed to change all places where it is used
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
Yes, we can change hiveserver2 port #, but I think that it would be better
to disable Lilith by default since hiveserver2 port number may be used in the
configs of other applications and it would
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
@priteshm, as I have mentioned in the Jira
[DRILL-5761](https://issues.apache.org/jira/browse/DRILL-5761), port in Lilith
UI cannot be changed (https://github.com/huxi/lilith/issues/10
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
Unit tests hang when Lilith application is not running, but when
`ClassicMultiplexSocketAppender` in `logback.xml` is defined and used in the
loggers.
---
If your project is set up for it, you
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/930
DRILL-5761: Disable Lilith ClassicMultiplexSocketAppender by default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vvysotskyi/drill DRILL
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/927
LGTM! +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/927#discussion_r136373928
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestDynamicUDFSupport.java ---
@@ -120,8 +132,11 @@ public void testDisableDynamicSupport() throws
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/927#discussion_r136384386
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/util/FileSystemUtilTestBase.java
---
@@ -64,7 +63,9 @@
@BeforeClass
public
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r136016798
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
@@ -115,6 +112,33 @@ public static SchemaPath create(NamePart
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r135848539
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -22,14 +22,15 @@
import
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r135849992
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -73,16 +74,23 @@ public void testCastByConstantFolding
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r135850298
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -73,16 +74,23 @@ public void testCastByConstantFolding
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r135850258
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -73,16 +74,23 @@ public void testCastByConstantFolding
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r135850825
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -20,7 +20,9 @@
import static
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r135851159
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -135,11 +139,16 @@ public void testIntervalArithmetic
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r135753493
--- Diff:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/CompareFunctionsProcessor.java
---
@@ -82,466 +45,37 @@ public
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134778939
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/TestSchemaPathMaterialization.java
---
@@ -93,4 +93,23 @@ public void
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134788919
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/TupleAccessor.java
---
@@ -48,9 +48,21 @@
MaterializedField
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134539810
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -359,30 +361,109 @@ public Mutator(OperatorExecContext
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134686740
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -359,30 +361,109 @@ public Mutator(OperatorExecContext
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134688368
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
---
@@ -293,7 +294,7 @@ private
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134764401
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/SchemaPathUtil.java
---
@@ -0,0 +1,59 @@
+/*
+* Licensed
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134782398
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/record/TestMaterializedField.java
---
@@ -84,4 +89,22 @@ public void testClone
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134787569
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java ---
@@ -83,7 +85,13 @@ private void updateStructure(int index
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134540459
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/CompareFunctionsProcessor.java
---
@@ -147,10 +147,10 @@ public Boolean
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134788014
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java ---
@@ -94,12 +102,20 @@ private void updateStructure(int index
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134795741
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
@@ -115,6 +112,33 @@ public static SchemaPath create(NamePart
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134689741
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -362,16 +363,16 @@ protected boolean
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r134262565
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -30,6 +31,11 @@
public class
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r134260296
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java
---
@@ -51,9 +51,9 @@ public void testIsDate() throws
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r134259055
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -43,6 +46,11 @@
public class TestDateFunctions
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/908
Maven uses 'nearest-win' strategy to resolve conflicts and since we specify
the Jackson library in the pom file, there is no need to exclude it from other
libraries.
Therefore the result
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r133927602
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -548,23 +567,57 @@ public void
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r126637301
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -444,123 +478,235 @@ public MajorType
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r133933369
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -181,6 +186,101 @@ else
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r126640837
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -444,123 +478,235 @@ public MajorType
101 - 200 of 246 matches
Mail list logo
