Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@amansinha100 thanks for sharing the information. Got your point. I think
your propose on
[CALCITE-1048](https://issues.apache.org/jira/browse/CALCITE-1048) is possible.
Since
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/889
@weijietong I am interested in getting your basic changes in. It is
unfortunate we are running into this issue with RelSubSet. Let me see if I can
make some changes on top of your changes (I
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/889
@weijietong I ran the functional tests with the PR and saw some failures.
While debugging those failures, I found the simple scalar aggregate case works
but anything with compound aggregate
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
ping @arina-ielchiieva @amansinha100
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@amansinha100 I have removed the override of `getMaxRowCount` method of
`TableScan` type to avoid your worry about unexpected results . This PR's
target adjusts to just enhance the current
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva, @amansinha100 can you take another look at this one and
see if your concerns have been addressed?
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva @amansinha100 any further advice ?
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva, looks like Weijie added a couple of commits since your
+1. Can you take a look at them?
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva @amansinha100 isScalarSubquery method has been
refactored , please review.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/889
+1, LGMT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva thanks for the advice, has corrected that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/889
Thanks @weijietong. LGTM.
@amansinha100 could you please do the final CR since you are familiar with
this issue?
---
If your project is set up for it, you can reply to this email and
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva other tests have passed separately and time zone related
test cases have been corrected in PR 5717
---
If your project is set up for it, you can reply to this email and have
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/889
On mine environment all tests pass. I used to have troubles but long time
ago. I had to fix issues with timezones, memory usage `MAVEN_OPTS="-Xmx2048m
-XX:MaxPermSize=1024m"`. Also I am
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva have passed all the unit tests under java-exec bundle ,
got some errors which are sure not associated with this change, maybe my branch
was old from the master.
>
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/889
@weijietong thanks for code formatting.
> I wonder if the enhanced code does not break the current unit test ,it
will be ok.
Can you please check this? Did all unit tests pass
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva your test case can not reproduce the error . You can
search the dev email to find the origin error description with the keyword
"Drill query planning error". Your query already
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/889
@weijietong regarding the unit test, I have tried to reproduce the problem
and written the following unit test:
```
@Test
public void test() throws Exception {
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva I have corrected the codes as you guide. But sorry for
the unit tests, I have tried a long time to simulate a scan with 1 row ,but
failed to do that. The row count of a scan is
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/889
@weijietong thanks for the PR.
1. Is it possible to add unit tests?
2. Can you please add in method description that a table scan with only one
row should also be considered as a
20 matches
Mail list logo
