Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/914
---
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r152664121
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -882,4 +882,71 @@ public void print(StringBuilder sb, int indent,
Verbosity
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r140644571
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/TupleState.java
---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r151762298
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -275,17 +273,17 @@ public boolean isNull() {
final int offset =
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r151762286
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -882,4 +882,71 @@ public void print(StringBuilder sb, int indent,
Verbosity
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r151019919
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BaseScalarWriter.java
---
@@ -0,0 +1,264 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r150753441
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -191,141 +180,268 @@ public void bind(RowIndex vectorIndex, ValueVector
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r150755238
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java
---
@@ -168,6 +174,58 @@ public boolean equals(Object obj) {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r150758630
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BaseScalarWriter.java
---
@@ -0,0 +1,264 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r150725372
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/RowSetTest.java
---
@@ -19,420 +19,648 @@
import static
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r150753305
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -191,141 +180,268 @@ public void bind(RowIndex vectorIndex, ValueVector
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149764036
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BaseScalarWriter.java
---
@@ -0,0 +1,264 @@
+/*
+ * Licensed
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149765040
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java
---
@@ -168,6 +174,58 @@ public boolean equals(Object obj) {
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149758695
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -191,141 +180,268 @@ public void bind(RowIndex vectorIndex, ValueVector
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149759147
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -191,141 +180,268 @@ public void bind(RowIndex vectorIndex, ValueVector
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149760234
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/RowSetTest.java
---
@@ -19,420 +19,648 @@
import static
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r139296614
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/package-info.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r139296587
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/package-info.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r137852118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/package-info.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r137851895
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/package-info.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/914
DRILL-5657: Size-aware vector writer structure
This large PR provides another two levels of foundation for size-aware
vector writers in the Drill record readers. It combines code from two
21 matches
Mail list logo
