Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/611
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86627650
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -43,43 +51,153 @@ public
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86607745
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
---
@@ -234,4 +286,48 @@ public static int
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86627781
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -43,43 +51,153 @@ public
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86621622
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -417,12 +420,37 @@ private void
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86452041
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86451464
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86452391
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86462356
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/DirectBufInputStream.java
---
@@ -0,0 +1,166 @@
+/**
+ * Licensed
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86446183
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86456058
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86461349
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86444957
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -207,6 +207,10 @@ public
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86446316
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,467 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86460478
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/DirectBufInputStream.java
---
@@ -0,0 +1,166 @@
+/**
+ * Licensed
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86460309
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86588911
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -43,43 +51,153 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86588762
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -43,43 +51,153 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86586621
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -417,12 +420,37 @@ private void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86588306
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -43,43 +51,153 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86586360
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
---
@@ -258,4 +295,74 @@ public static int
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86586473
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
---
@@ -258,4 +295,74 @@ public static int
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86587743
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -43,43 +51,153 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86588221
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -43,43 +51,153 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86397371
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86398411
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86404983
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86395782
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86402453
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86393658
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
---
@@ -370,7 +400,11 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86406381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/DirectBufInputStream.java
---
@@ -0,0 +1,166 @@
+/**
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86398874
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86402801
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86399582
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86395060
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,467 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86403197
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86399835
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86405791
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86405264
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86405115
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86404042
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86394551
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
---
@@ -108,17 +112,31 @@
private
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86394036
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -207,6 +207,10 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86405494
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,460 @@
+/**
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86406660
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/DirectBufInputStream.java
---
@@ -0,0 +1,166 @@
+/**
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86393092
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
---
@@ -48,22 +48,26 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r86392842
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java
---
@@ -95,6 +95,11 @@ public DrillBuf getManagedBuffer(int
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85249179
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85248026
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85248709
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ *
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85248331
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ *
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85153504
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/DirectBufInputStream.java
---
@@ -0,0 +1,183 @@
+/**
+ * Licensed to the
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85152665
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,467 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84990242
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84953931
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85146088
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85150281
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
---
@@ -234,4 +286,48 @@ public static int
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84987279
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -45,12 +46,15 @@
private final BufferAllocator
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84982984
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContext.java ---
@@ -43,10 +45,18 @@
public abstract OperatorStats
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85153076
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/DirectBufInputStream.java
---
@@ -0,0 +1,183 @@
+/**
+ * Licensed to the
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84971152
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85153296
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/DirectBufInputStream.java
---
@@ -0,0 +1,183 @@
+/**
+ * Licensed to the
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85028094
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -41,43 +51,149 @@ public
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84952909
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,467 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84972962
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85136996
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java
---
@@ -174,4 +191,11 @@ public DrillFileSystem
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84972161
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85141426
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84968348
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84969218
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84981300
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -0,0 +1,409 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84957411
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
---
@@ -99,26 +99,47 @@
int
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r85152503
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java
---
@@ -0,0 +1,467 @@
+/**
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84970035
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
---
@@ -148,7 +185,8 @@ public boolean
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84970233
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java
---
@@ -174,4 +191,11 @@ public DrillFileSystem
GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/611
Drill-4800: Improve parquet reader performance
Added a Buffering input stream
Updated parquet reader to optionally use the buffering input stream
Added optional asynchronous reading of
76 matches
Mail list logo
