[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/970 ---

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-19 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r145764765 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java --- @@ -331,21 +320,21 @@ public int next() {

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-19 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r145764035 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -208,17 +208,17 @@ public boolean wasAllPartitionsPruned()

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-19 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r145766449 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -725,21 +724,24 @@ public void

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-19 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r145766019 --- Diff: exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java --- @@ -371,6 +373,16 @@ public static void testNoResult(String query, Object...

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-19 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r145762743 --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java --- @@ -74,10 +73,8 @@ public void

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r144924587 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java --- @@ -84,14 +82,7 @@ private RecordReader

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r144924491 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -184,25 +183,26 @@ public void

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-05 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r143017778 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java --- @@ -84,14 +82,7 @@ private RecordReader

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-05 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/970#discussion_r143020963 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -184,25 +183,26 @@ public void

[GitHub] drill pull request #970: DRILL-5832: Migrate OperatorFixture to use SystemOp...

2017-10-03 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/970 DRILL-5832: Migrate OperatorFixture to use SystemOptionManager rather than mock The `OperatorFixture` provides structure for testing individual operators and other "sub-operator" bits of code.