Hi Gian,
I was able to publish our own artifacts by creating a new oss-parent pom
pointing to our Maven repository and updating the Druid root pom to point
to it.
It was non-obvious where the release plugin was configured until I spotted
the parent reference.
Joseph.
On Tue, Jul 24, 2018 at
Hello. I encountered a problem building druid. *In short,
`TestAWSCredentialsProvider` fails like the following*:
```
mvn -pl extensions-core/s3-extensions test
...
testWithFileSessionCredentials(io.druid.storage.s3.TestAWSCredentialsProvider)
Time elapsed: 6.615 sec <<< ERROR!
After some experiments, I figured out the following:
1. Druid uses above 8gb of memory for testing. (building-druid.png)
2. With 8gb(physical)+4gb(swap) of memory, the test succeeds regardless of
maven version (3.3.9, 3.5.2, 3.5.4) or MAVEN_OPTS. However, with
8gb(physical)+2gb(swap) of
Ah, I see. Thanks for clarifying.
> On Jul 24, 2018, at 6:43 PM, Gian Merlino wrote:
>
> There is a github feature to make multiple comments as a single "review",
> although from what I can see, gitbox splits those up into multiple emails
> anyway, so it doesn't help. I have poked Infra again
There is a github feature to make multiple comments as a single "review",
although from what I can see, gitbox splits those up into multiple emails
anyway, so it doesn't help. I have poked Infra again on our ticket:
https://issues.apache.org/jira/browse/INFRA-16674
On Tue, Jul 24, 2018 at 5:55 PM
I know there is an open request with INFRA to route git review comments to a
list other than dev. But until then, we are still getting a lot of messages on
the list each day. A lot of them come in groups, as a reviewer makes multiple
comments on a particular PR.
I believe git has a feature
asdf2014 commented on issue #5980: Remove redundant type parameters and enforce
some other style and inspection rules
URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-407597210
Hi, @jihoonson . Thanks for you comments. Added.
jihoonson commented on a change in pull request #6041: Synchronize scheduled
poll() calls in SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6041#discussion_r204953651
##
File path:
server/src/main/java/io/druid/metadata/SQLMetadataSegmentManager.java
jihoonson commented on a change in pull request #6041: Synchronize scheduled
poll() calls in SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6041#discussion_r204953478
##
File path:
server/src/main/java/io/druid/metadata/SQLMetadataSegmentManager.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204937406
##
File path:
processing/src/main/java/io/druid/query/aggregation/NullableBufferAggregator.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204944312
##
File path:
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204933856
##
File path:
processing/src/main/java/io/druid/query/aggregation/NullableAggregatorFactory.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204931100
##
File path:
processing/src/main/java/io/druid/query/aggregation/NullableAggregator.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204922799
##
File path:
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204937099
##
File path:
processing/src/main/java/io/druid/query/aggregation/NullableBufferAggregator.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204946252
##
File path:
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204943710
##
File path:
processing/src/main/java/io/druid/query/filter/SelectorDimFilter.java
##
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204937970
##
File path:
processing/src/main/java/io/druid/query/aggregation/NullableAggregatorFactory.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204945663
##
File path: processing/src/main/java/io/druid/segment/filter/LikeFilter.java
##
@@
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204919328
##
File path:
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204930658
##
File path:
processing/src/main/java/io/druid/query/aggregation/NullableAggregator.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204930332
##
File path:
processing/src/main/java/io/druid/query/aggregation/NullableAggregator.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204941324
##
File path:
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204916166
##
File path:
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204933933
##
File path:
processing/src/main/java/io/druid/query/aggregation/NullableAggregatorFactory.java
jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204942207
##
File path:
processing/src/main/java/io/druid/query/extraction/StrlenExtractionFn.java
AlexanderSaydakov closed issue #6037: snapshot quickstart error
URL: https://github.com/apache/incubator-druid/issues/6037
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AlexanderSaydakov commented on issue #6037: snapshot quickstart error
URL:
https://github.com/apache/incubator-druid/issues/6037#issuecomment-407570981
I found a machine with java 1.8.0_161, built druid on it, and there is no
problem.
I think we can close this issue.
Thank you.
leventov commented on a change in pull request #6041: Synchronize scheduled
poll() calls in SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6041#discussion_r204921786
##
File path:
server/src/main/java/io/druid/metadata/SQLMetadataSegmentManager.java
leventov commented on a change in pull request #6041: Synchronize scheduled
poll() calls in SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6041#discussion_r204922700
##
File path:
server/src/main/java/io/druid/metadata/SQLMetadataSegmentManager.java
jihoonson commented on a change in pull request #5471: Implement force push
down for nested group by query
URL: https://github.com/apache/incubator-druid/pull/5471#discussion_r204904971
##
File path: server/src/main/java/io/druid/server/coordination/ServerManager.java
##
jihoonson commented on a change in pull request #5471: Implement force push
down for nested group by query
URL: https://github.com/apache/incubator-druid/pull/5471#discussion_r204899786
##
File path:
jihoonson commented on a change in pull request #5471: Implement force push
down for nested group by query
URL: https://github.com/apache/incubator-druid/pull/5471#discussion_r204903519
##
File path: server/src/main/java/io/druid/server/QueryLifecycle.java
##
@@ -249,8
jihoonson commented on a change in pull request #5471: Implement force push
down for nested group by query
URL: https://github.com/apache/incubator-druid/pull/5471#discussion_r204891826
##
File path:
processing/src/main/java/io/druid/query/groupby/GroupByQueryConfig.java
jihoonson commented on a change in pull request #5471: Implement force push
down for nested group by query
URL: https://github.com/apache/incubator-druid/pull/5471#discussion_r204904422
##
File path: processing/src/main/java/io/druid/query/BaseQuery.java
##
@@ -257,4
jihoonson commented on a change in pull request #5471: Implement force push
down for nested group by query
URL: https://github.com/apache/incubator-druid/pull/5471#discussion_r204897508
##
File path:
jihoonson commented on a change in pull request #5471: Implement force push
down for nested group by query
URL: https://github.com/apache/incubator-druid/pull/5471#discussion_r204894682
##
File path:
processing/src/main/java/io/druid/query/groupby/GroupByQueryQueryToolChest.java
himanshug edited a comment on issue #6016: Druid 'Shapeshifting' Columns
URL: https://github.com/apache/incubator-druid/pull/6016#issuecomment-407536584
This is impressive.
I haven't read the code yet, but just the description. I had few doubts...
First "Time to select rows"
himanshug commented on issue #4865: Unable to query large data set with
`scan-query` via `broker`
URL:
https://github.com/apache/incubator-druid/issues/4865#issuecomment-407538797
while there are multiple PRs trying to solve this by limiting memory used in
DirectDruidClient which is
himanshug commented on issue #6016: Druid 'Shapeshifting' Columns
URL: https://github.com/apache/incubator-druid/pull/6016#issuecomment-407536584
This is impressive.
I haven't read the code yet, but just the description. I had few doubts...
First "Time to select rows"
clintropolis commented on issue #6037: snapshot quickstart error
URL:
https://github.com/apache/incubator-druid/issues/6037#issuecomment-407533842
This looks similar to this issue
https://github.com/apache/incubator-druid/pull/5591#issuecomment-379393497
jihoonson commented on issue #6037: snapshot quickstart error
URL:
https://github.com/apache/incubator-druid/issues/6037#issuecomment-407531966
The latest version of Java 8 is `1.8.0_181`. Try that one.
This is an automated
AlexanderSaydakov commented on issue #6037: snapshot quickstart error
URL:
https://github.com/apache/incubator-druid/issues/6037#issuecomment-407531280
I built the package on my Mac laptop with java 1.8.0_40.
I tried building on the target Linux machine with 1.8.0_60, but got exactly
jihoonson opened a new pull request #6041: Synchronize scheduled poll() calls
in SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6041
Similar issue to https://github.com/apache/incubator-druid/issues/6028.
jihoonson closed issue #6028: Error in SqlMetadataRuleManagerTest
URL: https://github.com/apache/incubator-druid/issues/6028
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jihoonson closed pull request #6033: Synchronize scheduled poll() calls in
SQLMetadataRuleManager to prevent flakiness in SqlMetadataRuleManagerTest
URL: https://github.com/apache/incubator-druid/pull/6033
This is a PR merged from a forked repository.
As GitHub hides the original diff on
Thanks Himanshu!
I will update when we have the ConcurrentUnion in the DataSketches library, or
earlier if we get interesting performance results with the union
implementations.
On Tuesday, July 24, 2018, 8:39:25 PM GMT+3, Himanshu
wrote:
This came up in the dev sync today.
Here is
jihoonson commented on issue #5980: Remove redundant type parameters and
enforce some other style and inspection rules
URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-407504015
@asdf2014 would you update the PR description to include additional changes?
E.g., Added
himanshug edited a comment on issue #3956: Thread safe reads for aggregators in
IncrementalIndex
URL: https://github.com/apache/incubator-druid/pull/3956#issuecomment-407502404
In general, I agree with @leventov here because different aggregators can
handle concurrency with varying
gianm commented on issue #6037: snapshot quickstart error
URL:
https://github.com/apache/incubator-druid/issues/6037#issuecomment-407496867
The release should work, since the issue (I believe) is with the javac
compiler, not with the runtime. Maybe you could try building the package with
AlexanderSaydakov commented on issue #6037: snapshot quickstart error
URL:
https://github.com/apache/incubator-druid/issues/6037#issuecomment-407494838
0.12.1 release works, but doesn't have the module I wanted to play with.
1.8.0_60 jdk seems to be the latest available in our corporate
+1
On Thu, Jul 19, 2018 at 1:09 PM Jihoon Son wrote:
> Hi all,
>
> we have no open issues and PRs for 0.12.2 (
> https://github.com/apache/incubator-druid/milestone/27). The 0.12.2 branch
> is already available and all PRs for 0.12.2 have merged into that branch.
>
> Let's vote on releasing
I can host today.
Here is the link to join:
https://hangouts.google.com/call/_KpvUiS0CO1-BMS8g2XFAAEE.
Jihoon
On Tue, Jul 24, 2018 at 8:40 AM Charles Allen wrote:
> Is someone else able to start the dev sync this week? I'm out of town at a
> conference.
>
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible
Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-407462520
@leventov @jihoonson : Thanks for the review comments, addressed them.
Do you have any more comments ?
Also,
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204816952
##
File path: common/src/main/java/io/druid/math/expr/ExprEval.java
##
@@ -245,36
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204815667
##
File path: common/src/main/java/io/druid/math/expr/ExprEval.java
##
@@ -99,10
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811571
##
File path: sql/src/main/java/io/druid/sql/calcite/rel/DruidSemiJoin.java
##
@@
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811510
##
File path: sql/src/main/java/io/druid/sql/calcite/planner/Calcites.java
##
@@
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811220
##
File path:
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811378
##
File path:
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811156
##
File path:
processing/src/main/java/io/druid/segment/virtual/ExpressionSelectors.java
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811346
##
File path:
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204810950
##
File path:
processing/src/main/java/io/druid/query/groupby/orderby/DefaultLimitSpec.java
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811034
##
File path: processing/src/main/java/io/druid/query/topn/TopNMapFn.java
##
@@
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204810994
##
File path: processing/src/main/java/io/druid/query/topn/TopNMapFn.java
##
@@
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204810789
##
File path:
processing/src/main/java/io/druid/query/groupby/orderby/DefaultLimitSpec.java
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204810693
##
File path: processing/src/main/java/io/druid/query/filter/ValueGetter.java
##
@@
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204810633
##
File path:
processing/src/main/java/io/druid/query/filter/SelectorDimFilter.java
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204810580
##
File path: processing/src/main/java/io/druid/query/expression/ExprUtils.java
##
Is someone else able to start the dev sync this week? I'm out of town at a
conference.
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204801468
##
File path:
processing/src/main/java/io/druid/query/groupby/orderby/DefaultLimitSpec.java
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204801468
##
File path:
processing/src/main/java/io/druid/query/groupby/orderby/DefaultLimitSpec.java
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204801468
##
File path:
processing/src/main/java/io/druid/query/groupby/orderby/DefaultLimitSpec.java
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204797189
##
File path: processing/src/main/java/io/druid/query/expression/ExprUtils.java
##
nishantmonu51 opened a new issue #6040: Review comment - Prohibit Usage of
isNullOrEmpty and isEmpty for null handling
URL: https://github.com/apache/incubator-druid/issues/6040
It seems to me that usage of
com.google.guava.common.base.Strings.isNullOrEmpty(),
java.lang.String.isEmpty(),
nishantmonu51 opened a new issue #6039: Review comment - Extract Combining
Factories for Float/Double/Long First/Last aggregators
URL: https://github.com/apache/incubator-druid/issues/6039
The parameter of NullableAggregatorFactory is not the output selector type,
it's the input selector
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204795900
##
File path:
undertruck opened a new issue #6038: Ingesting Parquet file gives UTF-8 error
[Druid 0.12.0]
URL: https://github.com/apache/incubator-druid/issues/6038
I've a AWS Glue generated Parquet file. I've installed Parquet and Avro
extensions (tried with 0.12.0 and 0.12.1 both) and I get
78 matches
Mail list logo
