Re: dubbo admin 0.1.5 release plan

2019-03-14 Thread Huxing Zhang
Hi, On Thu, Mar 14, 2019 at 11:04 PM Minxuan Zhuang wrote: > > I think 0.2.0 need a major feature like metrics support, and 0.1.1 sounds > like a quick bug fix version, this version includes some features and > enhancements , so I choose 0.1.5. According the the semantic versioning[1], I think

Re: need to revisit pull request 3549 in 2.7.2

2019-03-14 Thread yuhang xiu
Hi, +1 This pr is very big. I also left some comments under it. This feature should be considered more clearly. jun liu 于2019年3月15日周五 上午10:54写道: > Hi, > > +1 > > I think we should revert this merge and postpone to 2.7.2, it has not been > fully discussed yet. > > Jun > > > On Mar 14, 2019, at

Re: need to revisit pull request 3549 in 2.7.2

2019-03-14 Thread jun liu
Hi, +1 I think we should revert this merge and postpone to 2.7.2, it has not been fully discussed yet. Jun > On Mar 14, 2019, at 10:02 PM, Ian Luo wrote: > > Folks, > > I think we need to revisit pull request 3549 in 2.7.2. In my opinion, > fluent api need to be carefully resigned. > >

Re: dubbo admin 0.1.5 release plan

2019-03-14 Thread Minxuan Zhuang
I think 0.2.0 need a major feature like metrics support, and 0.1.1 sounds like a quick bug fix version, this version includes some features and enhancements , so I choose 0.1.5. On Thu, Mar 14, 2019 at 6:44 PM YunKun Huang wrote: > Should the version number be 0.2.0 or 0.1.1? > why jump to

need to revisit pull request 3549 in 2.7.2

2019-03-14 Thread Ian Luo
Folks, I think we need to revisit pull request 3549 in 2.7.2. In my opinion, fluent api need to be carefully resigned. What do you think? Thanks, -Ian.

Re: Filter problems in async way

2019-03-14 Thread 雷舜宇
If you have a plan, please let me know in time, I will solve it as soon as possible, I will always follow up Ian Luo 于2019年3月14日周四 下午3:51写道: > Maple, we will consider it in 2.7.2 release. > > Thanks, > -Ian. > > On Wed, Mar 13, 2019 at 9:57 AM 雷舜宇 wrote: > > > issues

Re: Squashed commit message when merging request

2019-03-14 Thread YunKun Huang
+1 to squash Keep commit history more clear On 2019/03/14 07:57:20, Ian Luo wrote: > I think it is a bad idea to keep all commit messages since it will > introduce the difficulty on maintenance. In fact, I love squash, and I > believe most of github users love it too, since it usually

Re: dubbo admin 0.1.5 release plan

2019-03-14 Thread YunKun Huang
Should the version number be 0.2.0 or 0.1.1? why jump to number 5? On 2019/03/14 09:31:39, Minxuan Zhuang wrote: > Hi all > It has been a log of commits since the first release of dubbo admin, > I'm preparing to release version 0.1.5, this release includes some enhance > of service test,

Re: 2.7.1 release plan

2019-03-14 Thread jun liu
There’s still one PR addressing Zookeeper connection problem that need to be merged, it was raised by cvictory and is reviewing by me. Hopefully, I should be able to finish the review tonight. https://github.com/apache/incubator-dubbo/pull/3603 Jun > On Mar 14, 2019, at 4:01 PM, Ian Luo

dubbo admin 0.1.5 release plan

2019-03-14 Thread Minxuan Zhuang
Hi all It has been a log of commits since the first release of dubbo admin, I'm preparing to release version 0.1.5, this release includes some enhance of service test, project name change[1] and several bug fixes, more importantly, the license issue in binary release[2] has been fixed If

Re: Is 2.5.x still being supported?

2019-03-14 Thread 华 钟明
There is another question, how to deal with the issuse related to the 2.5.x version, for example https://github.com/apache/incubator-dubbo/issues/2132 Best Regards! Zhongming Hua 在 2019/3/14 下午3:46,“Ian Luo” 写入: +1 to announce EOL of 2.5.x On Wed, Mar 13, 2019 at 12:18 AM

Re: 2.7.1 release plan

2019-03-14 Thread Ian Luo
Folks, Today is the code freeze day we planned for the release of 2.7.1. I will folk new branch soon and prepare this release soon. We don't accept any new change for this release once I create the new branch, but you can still submit pull request on master at any time. Thanks, -Ian. On Fri,

Re: Squashed commit message when merging request

2019-03-14 Thread Ian Luo
I think it is a bad idea to keep all commit messages since it will introduce the difficulty on maintenance. In fact, I love squash, and I believe most of github users love it too, since it usually encourages cleaner commit history :). But I strongly agree the person who merges the pull request

Re: Filter problems in async way

2019-03-14 Thread Ian Luo
Maple, we will consider it in 2.7.2 release. Thanks, -Ian. On Wed, Mar 13, 2019 at 9:57 AM 雷舜宇 wrote: > issues address:https://github.com/apache/incubator-dubbo/issues/3483 > > Do you have any opinion on this question, do you need to add a new field, > or do you have any better suggestions? >

Re: Nanjing Meetup Registration is Opening

2019-03-14 Thread Ian Luo
looking forward to it. On Tue, Mar 12, 2019 at 2:47 PM chenwei qi wrote: > Dear all, > > The Apache Dubbo Meetup will be held in Nanjing on March. 23, 2019, and the > schedule of the meetup is as below: > > 9:30-11:30 End User Discussion > 13:00-13:40 Check in > 13:40-14:20 Introduction and

Re: [DISCUSS] Archive incubator-dubbo-docs project

2019-03-14 Thread Ian Luo
+1 to archive this project. Before that, pls. update README so that people know where to submit new issue and pull request. -Ian. On Wed, Mar 13, 2019 at 12:11 AM Huxing Zhang wrote: > Hi All, > > The community has already deprecated incubator-dubbo-docs, with the > following effort: > - all

Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-14 Thread Ian Luo
or at least we can bundle a docker-compose.yaml in dubbo admin project. -Ian. On Wed, Mar 13, 2019 at 11:55 AM Justin Mclean wrote: > Hi, > > > I've see a dubbo-admin docker image[1], which is maintained by one of > > the Dubbo PPMC. To some extend this might be a violation of ASF > >

Re: Is 2.5.x still being supported?

2019-03-14 Thread Ian Luo
+1 to announce EOL of 2.5.x On Wed, Mar 13, 2019 at 12:18 AM Huxing Zhang wrote: > Hi, > > Given the EOL for 2.5.x has been discussed 10 months ago[1]. > I am +1 on shorten the period. > One question, is 2.6.x completely compatible to 2.5.x? > > >