Re: Define the next generation Dubbo - Dubbo 3.0

2020-10-28 Thread yuhang xiu
hi, jun That sounds good. Looking forward to more information and details in the future. :) Jun Liu 于2020年10月23日周五 下午10:10写道: > Hi, Community > > We have discussed Dubbo 3.0 several times in the community, but at this > moment we still haven't formed a very clear plan and goal, not to mention

Re: [VOTE]: Release Apache Dubbo 2.7.4.1 [RC1]

2019-10-25 Thread yuhang xiu
+1 I checked: - can compile from source - unit test success victory 于2019年10月25日周五 下午3:01写道: > Hi, > > +1 binding > > I checked: > - signatures and hashes fine > - no unexpected binary files > - can compile from source > - unit test success > > > From: victory > Official Account: GeekVictory

Re: [VOTE]: Release Apache dubbo-go-hessian2 v1.3.0 RC1

2019-10-25 Thread yuhang xiu
+1 [ ] Are release files in correct location? [ ] Are the digital signature and hashes correct? [v] Do LICENSE and NOTICE files exists? [v] Is the LICENSE and NOTICE text correct? [v] Is the NOTICE year correct? [ ] Un-included software dependencies are not mentioned in LICENSE or NOTICE? [ ]

Re: [VOTE] Accept RitterHou/python-dubbo donation

2019-09-23 Thread yuhang xiu
+1 accept Dubbo's ecology continues to expand. :) Ian Luo 于2019年9月24日周二 上午10:53写道: > Hi All, > > This is a formal vote to bring RitterHou/python-dubbo[1], which is donated > by Qianmi, to Apache Dubbo project. > > Please vote: > > [ ] +1 Accept > [ ] +0 No Opinion > [ ] -1 Reject because... > >

Re: [VOTE] Accept dubbogo/hessian2 donation

2019-07-07 Thread yuhang xiu
+1 accept Ian Luo 于2019年7月8日周一 上午10:26写道: > +1 Accept > > On Thu, Jul 4, 2019 at 11:20 AM Stocks Alex > wrote: > > > 1 > > > > 原始邮件 > > 发件人: Huxing Zhang > > 收件人: dev > > 发送时间: 2019年7月4日(周四) 10:00 > > 主题: [VOTE] Accept dubbogo/hessian2 donation > > > > > > Hi All, > > > > This is a formal

Re: [VOTE] Accept dubbogo/hessian2 donation

2019-07-07 Thread yuhang xiu
+1 accept Ian Luo 于2019年7月8日周一 上午10:23写道: > +1 > > On Thu, Jul 4, 2019 at 7:22 PM Zonghai Shang wrote: > > > +1 Accept > > > > > > -yiji > > > > 华 钟明 于2019年7月4日周四 上午11:54写道: > > > > > +1 Accept > > > > > > Best Regards! > > > Zhongming Hua > > > > > > > > > 在 2019/7/4 上午11:23,“Xin Wang” 写入:

Re: About jprofile license for opensource project

2019-07-05 Thread yuhang xiu
in any public place, it should be maintained by PMCs, and any Committer that needs to use it needs to apply on the dev list. This is a security measure used to ensure that this license is not overused. What do you think? yuhang xiu 于2019年7月4日周四 上午10:24写道: > Hi, > > I took a look at t

Re:

2019-07-04 Thread yuhang xiu
st to do it in ASF level so that other Apache projects can > > benefit as well. > > > > > > On Mon, Jul 1, 2019 at 9:22 PM yuhang xiu wrote: > > > > > > Hi, members. > > > > > > I recently used jprofile[1] to troubleshoot some performance issues. > Si

Re: About jprofile license for opensource project

2019-07-03 Thread yuhang xiu
Hi, I took a look at this guide. It seems that we need to do a few things: 1. Agree with the PMCs to confirm that we are using Jprofile and agree to add the official link to Jprofile. 2. Add a thanks page to the current official website[1]. I personally think that we should also thank Intellij

Re: [ANN] Welcome new committer: Shunyu Lei

2019-06-12 Thread yuhang xiu
Welcome, I am very happy that you can be a member of the community and hope that you can continue to contribute dubbo. :) Huxing Zhang 于2019年6月12日周三 下午3:52写道: > Hi Community, > > On behalf of the Dubbo PMC, I am pleased to announce that > Shunyu Lei[1], a.k.a leishunyu, has been voted in as a

Re: [ANN] Welcome new committer: Xiaoxiang Zhai

2019-05-29 Thread yuhang xiu
Welcome! Thx for your valuable contribution for dubbo! Huxing Zhang 于2019年5月29日周三 下午12:40写道: > Congratulations and welcome! > > On Wed, May 29, 2019 at 10:16 AM Minxuan Zhuang > wrote: > > > > Hi Community, > > > > On behalf of the Dubbo PMC, I am pleased to announce that Xiaoxiang > >

Re: [ANN] Apache Dubbo as a Top-level project

2019-05-20 Thread yuhang xiu
Congratulations! A big step forward. 田 小波 于2019年5月21日周二 上午11:18写道: > Congratulations ! > >

Re: 200 contributors for Dubbo

2019-05-17 Thread yuhang xiu
Hi, Exciting news! The future will definitely be better. Let us move on together! Huxing Zhang 于2019年5月17日周五 下午5:37写道: > Hi All, > > It is very glad to see that dubbo[1] project has reached 200 contributors! > Thanks to all the contributors, and looking forward to more! > > [1]

Re: Projects Can Apply Individually for Google Season of Docs

2019-04-22 Thread yuhang xiu
Hi,huxing It looks like a good choice. But from the point of view [1], seems like the technical writer will try to improve the doc of the entire project? It seems that we need to make two materials: 1. A brief introduction to dubbo as u said (tell them what dubbo is) 2. An official doc

Re: [VOTE] Apache Dubbo graduation to Top Level Project

2019-04-18 Thread yuhang xiu
bbo Project; > > and be it further > > > > RESOLVED, that the persons listed immediately below be and hereby are > > appointed to serve as the initial members of the Apache Dubbo Project: > > > > * Huxing Zhang > > * Ian Luo > > * Jun Liu >

Re: Adding Dubbo Ecosystem page to official website

2019-04-11 Thread yuhang xiu
Hi, I glanced at the ui design. I think it's great, it can't be better. Looking forward to it. Huxing Zhang 于2019年4月11日周四 下午3:36写道: > Hi All, > > It looks like the UI design has been uploaded for preview. > It will be appreciated if the community could take a look and give > some feedback. > >

Re: About polish code related pr

2019-04-10 Thread yuhang xiu
; > > > > > I agree with Ian. I think small patches to polish code is acceptable. > > > People these days are getting busy, and might not have large amount of > > > time to contribute. > > > Meanwhile, the it is easy to review. Large size pull request can be > &

About polish code related pr

2019-04-08 Thread yuhang xiu
Hi, all Recently I found out that we have merged some pull requests for the polish code. I personally do not advocate small-scale polish code, such as this pr [1]. We can't see the improvement clearly. I think that for this pr, we should put it in a large-scale polish code, or bugfix and

Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread yuhang xiu
YES Jun Liu 于2019年4月9日周二 上午10:16写道: > YES > > Jun > > > On Apr 9, 2019, at 10:12 AM, Huxing Zhang wrote: > > > > Dear Dubbo PPMC members, > > > > (bcc to all PPMC members) > > > > The Dubbo community is discussing the graduation of Dubbo to be a Top > > Level project of Apache Software

For Issue 3785

2019-04-03 Thread yuhang xiu
Hi,beiwei I recently saw an issue[1]. It seems that you changed the `dynamic` attribute to false in the previous pr. Is it a special meaning to set it to the default false? If not, perhaps we should set `dynamic` to true to ensure that the new and old versions have the same logic. [1]

Re: [ANN] Welcome new committer: Imteyaz Khan

2019-03-31 Thread yuhang xiu
Thank you for your contribution khan, I really like your review. :) Taosheng, Wei 于2019年4月1日周一 上午10:21写道: > Congraduations :) > > > > > -- Original -- > From: Huxing Zhang > Date: Mon,Apr 1,2019 10:19 AM > To: dev > Subject: Re: [ANN] Welcome new committer:

Re: Pull request merged without approval

2019-03-20 Thread yuhang xiu
agree. I think this is a very good way to help us standardize the pr merge. YunKun Huang 于2019年3月20日周三 上午11:41写道: > Agree, we should have at least one approval before merging > > On 2019/03/20 03:00:51, Huxing Zhang wrote: > > Hi, > > > > > > On Wed, Mar 20, 2019 at 10:55 AM YunKun Huang >

Re: Re: need to revisit pull request 3549 in 2.7.2

2019-03-15 Thread yuhang xiu
Sorry about that.. I mean `hi xu`. Wrong name of this statement.. yuhang xiu 于2019年3月15日周五 下午4:33写道: > Hi jun, > > Not a problem. > > It’s just that we need to pay more attention in the future. > > :) > > kezhenxu94 于2019年3月15日周五 下午4:31写道: > >> Hi, >&

Re: Re: need to revisit pull request 3549 in 2.7.2

2019-03-15 Thread yuhang xiu
> > > > 1. > http://dubbo.apache.org/en-us/docs/developers/committer-guide/label-an-issue-guide_dev.html > > > > > > > > > > > At 2019-03-15 16:28:16, "yuhang xiu" wrote: > >Hi, huxing. > > > >Great advice. In the previous re

Re: need to revisit pull request 3549 in 2.7.2

2019-03-15 Thread yuhang xiu
Hi, huxing. Great advice. In the previous review process, I also ignored some issues. Maybe we need a new label such as: `need-more-review`. When we need more reviews, we can mark this pr to remind other committers to review it. In addition, I think we need to clarify the meaning of

Re: need to revisit pull request 3549 in 2.7.2

2019-03-14 Thread yuhang xiu
Hi, +1 This pr is very big. I also left some comments under it. This feature should be considered more clearly. jun liu 于2019年3月15日周五 上午10:54写道: > Hi, > > +1 > > I think we should revert this merge and postpone to 2.7.2, it has not been > fully discussed yet. > > Jun > > > On Mar 14, 2019, at

Re: Nanjing Meetup Registration is Opening

2019-03-12 Thread yuhang xiu
Thanks for your great work, looking forward to this meetup. Hope everything goes well. :) chenwei qi 于2019年3月12日周二 下午2:47写道: > Dear all, > > The Apache Dubbo Meetup will be held in Nanjing on March. 23, 2019, and the > schedule of the meetup is as below: > > 9:30-11:30 End User Discussion >

Re: Is 2.5.x still being supported?

2019-03-07 Thread yuhang xiu
+1 Ian Luo 于2019年3月8日周五 上午10:42写道: > +1 to announce EOL of 2.5.x as soon as possible. > > On Thu, Mar 7, 2019 at 6:04 PM jun liu wrote: > > > > IMO, we should consider announce the end of life in the near future, > > > say 1 year, and only support critical bug fix or security fix, > > > > In

Re: Pull request review rules

2019-03-07 Thread yuhang xiu
Hi, all In my opinion, both suggestions are good. But what I need to remind is that we should have at least one deadline to prevent a pr from being suspended for a long time. Thx. Ian Luo 于2019年3月8日周五 上午10:41写道: > I think we don't need such a complex rule at all. More reviewers on it, > more

[Discussion] There are so much threadpool, can we merge some threadpool into one threadpool?

2019-03-07 Thread yuhang xiu
Hi, all I noticed that @cvictory made a very good issue[1], I think we can have more discussion, so I brought it here: There are so much threadpool that manage only one thread , and this thread is idle. The threadpool as follow: *

Re: [DISCUSS] Dubbo on Stackoverflow

2019-03-04 Thread yuhang xiu
Hi, huxing Personally think that we should support Stack Overflow. Maybe we need some users who are active on Stack Overflow to answer dubbo related questions. There are some problems on Stack Overflow, and some of them have not been replied [1]. [1]

Re: [DISCUSSION] Idea about making Filter totally asynchronous and event-driven.

2019-03-03 Thread yuhang xiu
Hi, About compatibility issues. The current version will enter onResponse due to all requests (correct or incorrect). If we modify the code, the correct response enters onResponse, the error response enters onError, and onResponse will only process the correct request if the user does not modify

Re: Etcd support in 2.7.x

2019-02-26 Thread yuhang xiu
good news! I remember that yiji is familiar with etcd3, and he may give us some advice. YunKun Huang 于2019年2月27日周三 上午11:54写道: > +1 > good to have official support for etcd. > > From my personal experience, etcd is common and many companies already > have it in their IT infrastructure. > > On

Re: self introduction

2019-02-21 Thread yuhang xiu
By the way, if you are using github to submit pr for the first time, you can find some useful information from this link: http://dubbo.apache.org/en-us/docs/developers/contributor-guide/new-contributor-guide_dev.html yuhang xiu 于2019年2月22日周五 下午1:57写道: > Hi, Daniela > > Welcome

Re: self introduction

2019-02-21 Thread yuhang xiu
Hi, Daniela Welcome to dubbo community! If you have any questions, you can ask here and we will answer them as soon as possible. I saw that you claimed an issue and looked forward to your pull request! I will pay attention to it. Thx Daniela Morais 于2019年2月22日周五 下午1:20写道: > Hello, > > My

Re: Filter problems in async way

2019-02-18 Thread yuhang xiu
temp data? > > Thanks, > -Ian. > > > On Fri, Feb 15, 2019 at 2:55 PM yuhang xiu wrote: > > > Hi, everyone > > > > Recently, I found that dubbo does not handle the data generated during > the > > call process when it is asynchronous. > > > >

Filter problems in async way

2019-02-14 Thread yuhang xiu
Hi, everyone Recently, I found that dubbo does not handle the data generated during the call process when it is asynchronous. For example, in TimeoutFilter, we used invocation#attachments to hold the data that needs to be passed (start time in TimeoutFilter). But I don't think this way is good,

Re: [ANN] Welcome new committer: Xiaojie Li

2019-02-13 Thread yuhang xiu
congratulate! welcome! Thank you for your great contribution! :) Huxing Zhang 于2019年2月14日周四 下午2:24写道: > Hi Community, > > On behalf of the Dubbo PPMC, I am pleased to announce that Xiaojie Li, > a.k.a. lixiaojiee[1], has been voted in as a new Dubbo committer. > > Please join me to say

Re: [Discuss] About Clean Code Plan

2019-01-28 Thread yuhang xiu
n't know why he showed that the entire file was modified, even though > he only modified one line. You can check it. > > yuhang xiu 于2019年1月29日周二 上午10:43写道: > > > Your pr has modified more than 30,000 lines of code, and most of them are > > modifications of the entire fi

Re: [Discuss] About Clean Code Plan

2019-01-28 Thread yuhang xiu
Your pr has modified more than 30,000 lines of code, and most of them are modifications of the entire file. What is the meaning of your pr? Why do I need to keep it open? If you need to discuss, issues and mailing lists are good choices, why do you need to discuss pr? Who can review this pr[1]

Re: [ANN] Welcome new committer: Xianjun Ke

2019-01-24 Thread yuhang xiu
Hi, xianjun, I think your review is great and gives a lot of valuable advice. Congratulations on becoming a committer! Huxing Zhang 于2019年1月25日周五 上午11:40写道: > Hi Community, > > On behalf of the Dubbo PPMC, I am pleased to announce that Xianjun Ke, > a.k.a. kexianjun[1], has been voted in as a

Re: [Discuss] The Timer Design in Dubbo from 2.6 to 2.7

2019-01-24 Thread yuhang xiu
Yesterday I received a reply from the netty community: just because we usually want to be on the same thread as the EventLoop of > the Channel. that said there is nothing wrong about the HashedWheelTimer. It seems that netty does not use HashedWheelTimer not because of its own problems. I

Re: [Discuss] The Timer Design in Dubbo from 2.6 to 2.7

2019-01-23 Thread yuhang xiu
hi,all 回复一下关于引入timer的问题。关于第一个问题,是为了解决defaultFuture的timeout问题,其实这个问题在issue[1]里说的很清楚了,就是为了解决无效的遍历。 对比老的实现即可发现,老的遍历做了非常多的无用功,而timer可以更精确的控制超时。 关于netty为什么不使用的问题,我这里提交了一个issue[2]。 所有的其他讨论我认为应该在netty回复我们以后。 在使用场景上,dubbo确实有需求,在多级时间轮上,这个在引入的时候我也做过调查,并不是必须的,只要我们控制好timer的大小即可。

Re: [Proposal] A proposal to use IdleStateHandler to replace using Timer to send HeartBeat.

2019-01-21 Thread yuhang xiu
Hi, jingfeng, I saw beiwei merge your pr, nice work! However, I think we still need to consider two things. Since we are using a shared timer, this timer will not be closed when a client is closed. In this case, we need to control our tasks without unlimited growth. My current practice is to

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

2019-01-16 Thread yuhang xiu
awesome. Looking forward to dubbo 2.7. I just looked at the milestones of 2.7. It looks like there is no problem. Huxing Zhang 于2019年1月17日周四 上午10:42写道: > Hi All, > > I am seeing that all the issue has been cleaned for the 2.7.0 milestone. > It looks like all the things have been settled, I am

Re: Next steps of projects in Dubbo group

2019-01-14 Thread yuhang xiu
Agree. Awesome extension. Another thing, I noticed that @ningyu provides a dubbo-jmeter test tool, do we need to transfer it to ASF as well? https://github.com/dubbo/jmeter-plugins-dubbo Huxing Zhang 于2019年1月15日周二 上午10:12写道: > Hi, > > Recently I am doing the maven release process, I found the

Re: Propose to add [End User Discussion] in Dubbo Guangzhou Meetup

2019-01-14 Thread yuhang xiu
Hi, I have participated in the meetup of hangzhou, we have a questioning session in the gap between each topic. When I participated in the meetup, many people were very active, and many people in each questioning session wanted to ask questions. But in general, in order to control the time of the

Re: [Proposal] A proposal to use IdleStateHandler to replace using Timer to send HeartBeat.

2019-01-09 Thread yuhang xiu
; [1] https://github.com/apache/incubator-dubbo/issues/3151 > > Ian Luo 于2019年1月7日周一 下午10:47写道: > > > Thanks > > > > On Mon, Jan 7, 2019 at 2:50 PM yuhang xiu wrote: > > > > > Hi, I left some comments in this issue[1] > > > > > &

Re: About Issue 3038

2019-01-09 Thread yuhang xiu
Hi, @guodong Seems like we have a same issue[1] submitted by @yiji Pls check and close your issue if these two issues are with the same thing. If necessary, we can reopen the old one to discuss. [1] https://github.com/apache/incubator-dubbo/issues/2766 Guodong 于2019年1月9日周三 下午5:23写道: > Ok!

Re: issue for aync invoke

2019-01-08 Thread yuhang xiu
agree. Maybe I didn't fully understand what he meant before. The way dubbo's current filter does depend on the user's understanding of the new asynchronous approach. By the way, when I just checked the code, I suspect that our TimeoutFilter might not work properly in an asynchronous scenario,

Re: [Proposal] A proposal to use IdleStateHandler to replace using Timer to send HeartBeat.

2019-01-06 Thread yuhang xiu
Hi, I left some comments in this issue[1] Thanks to beiwei for reminding. I forgot that we have some non-netty servers. In this case, I personally prefer all heartbeats to use the same set of mechanisms to guarantee. But we can learn from netty's heartbeat mechanism to ensure more accurate

Re: slow on pull request and issue

2018-12-29 Thread yuhang xiu
Hi, community I personally encountered problems similar to @beiwei. Before New Year's Day, I had a lot of work to do. There is not much time in the last week to solve problems in the community. My work will start to be easier next week, and I will fix it next week: 1. doc related pr @majinkai 2.

Re: AccessLogFilter simple date format instance creation change PR

2018-12-28 Thread yuhang xiu
is PR containing the all the > > review comments from old PR. Please review mine this PR > > <https://github.com/apache/incubator-dubbo/pull/3090> > > > > > > https://github.com/apache/incubator-dubbo/pull/3090 > > > > Sorry for the inconvenience caused. &g

Re: AccessLogFilter simple date format instance creation change PR

2018-12-27 Thread yuhang xiu
Hi, I simply checked your pr and I agree with you. I will review it. Nice work! Imteyaz Khan 于2018年12月27日周四 下午5:35写道: > Hi All, > I have raised a separate PR for the same issue 3026. > > https://github.com/apache/incubator-dubbo/pull/3080 > > As my old PR was containing may commits of others

[DISCUSS] We need more advice about pr 2964

2018-12-25 Thread yuhang xiu
Hi, all Recently I found a pr about repairing issue 2881[1] submitted by @cvictory. Currently due to the merger of dubbox, dubbo has the ability to register classes to kryo(fst) at startup. In a distributed scenario, kryo's serialization approach can cause problems. @cvictory is currently

Re: [DISCUSSION] Call for ideas and suggestions on v2.7.0 designs and implementations.

2018-12-24 Thread yuhang xiu
Hi, all I also found out that the master ci has failed. This caused some misunderstanding for me to deal with a pending pr[1]. After observing the log, I found that the issue[2] with @xin wang feedback is the same problem. Since the ci of the module of the cluster has passed and the code is well,

Re: about issues-2425

2018-12-24 Thread yuhang xiu
Hello, yeling, I checked the code of the old version. Since the current retry process will execute failed.remove(invocation); anyway, this will cause our retry to be done only once. I think this is a bug in the current failback. I have given a few reviews about your pr. I need you to improve

Re: [ANN] New PPMC member: Yuhang Xiu

2018-12-20 Thread yuhang xiu
Hi, Thank u all. :) Huxing Zhang 于2018年12月20日周四 下午4:49写道: > Congratulations! > > On Thu, Dec 20, 2018 at 4:37 PM Xin Wang wrote: > > > > Hi Community, > > > > On behalf of the Dubbo PPMC, I am pleased to announce that Yuhang Xiu[1] > > has b

Re: About the comments coverage of the code

2018-12-19 Thread yuhang xiu
at the doc. I'd like take a look at these doc prs and give some suggestions. Regarding the goal, I think we can increase the doc coverage rate to 45% first, and increase the coverage by about 20% first. :) Huxing Zhang 于2018年12月20日周四 上午10:20写道: > Hi, > > On Wed, Dec 19, 2018 at 8:48 PM y

Re: About Router:Version compatibility issues below JDK1.8

2018-12-19 Thread yuhang xiu
The code on the master only supports jdk1.8 and above. So this does not cause compatibility issues. :) 雷舜宇 于2018年12月20日周四 上午10:13写道: > Previously submitted a PR, modified the compatibility of the Router's sort. > Before the merge, the committer discussed the default method of adding > jdk1.8 to

Re: About the comments coverage of the code

2018-12-19 Thread yuhang xiu
). Regarding question two, I don't have a idea. Perhaps doc coverage is 40% is a good choice. What do you think? yuhang xiu 于2018年12月18日周二 下午4:21写道: > Hello, Dave. > > (2) Have any committers reached out to the users who had trouble with code >> comments to confirm these ef

Re: The issues of [Enhance the test coverage] project are here waiting for you

2018-12-19 Thread yuhang xiu
It’s great. It seems that we have reached the goal and I agree to close the project. Xin Wang 于2018年12月19日周三 下午8:23写道: > Hi all > It's been a long time since I started this project. I am very > pleased to announce that the test coverage of Dubbo is now 64%. > We have achieved the goal

Re: Use longObjectMap to increase performance

2018-12-18 Thread yuhang xiu
ue 非常有意义,我会持续跟进 > > > English:pls copy the above Chinese issue to google translation ,forgive my > laziness, hhh. > > > 在 2018年12月19日,上午11:04,yuhang xiu 写道: > > > > Hi, jingfeng, > > > > I think we should have a benchm

Re: Use longObjectMap to increase performance

2018-12-18 Thread yuhang xiu
Hi, jingfeng, I think we should have a benchmark about the sync long object map and concurrent map. Personally think the concurrent map is better, but we should have a benchmark about this two cases. Another thing, maybe my description is problematic, we are going to replace longobjectmap and

Re: About the comments coverage of the code

2018-12-18 Thread yuhang xiu
Hello, Dave. (2) Have any committers reached out to the users who had trouble with code > comments to confirm these efforts will meet their concerns? > I used to talk to them, but I forgot to ask them about what kind of docs are better. But don't worry, I still have their contact details. I

Re: About the comments coverage of the code

2018-12-17 Thread yuhang xiu
the code on the 2.6.x branch during the review. If the comments can be shared, we need to remind the submitter. Let them submit the comments to the 2.6.x branch as well. What do you think? yuhang xiu 于2018年12月11日周二 上午10:02写道: > Ok, huxing > I'd like take some time to do this. > > Huxing Zhan

Re: Telnet optimization suggest

2018-12-17 Thread yuhang xiu
Welcome! Do u have some ideas about telnet? IMO, this way is very good: list: [1] listUser(Integer id) [2] listUser(String name) When we use invoke, we can do like this: invoke 1 params There has a line number or id or sth else with one invokable method. This can make this clear. 李振

Re: Telnet optimization suggest

2018-12-17 Thread yuhang xiu
Hi, about overloading, here is an issue to track: https://github.com/apache/incubator-dubbo/issues/2766 Regarding the group problem, it is currently impossible to execute a service under a specific group. This is a point that can be optimized. Would u have some ideas? yeling 于2018年12月17日周一

Re: Re: Use longObjectMap to increase performance

2018-12-12 Thread yuhang xiu
need to > replace. > At 2018-12-13 10:22:20, "yuhang xiu" wrote: > >Hi, all > >Recently, @y1317427691 claimed this part of the work on github, he will > >start in the near future. > >According to my personal assumptions, we need to investigate the > &g

Re: Use longObjectMap to increase performance

2018-12-12 Thread yuhang xiu
2018年12月7日周五 上午11:15写道: > On Tue, Dec 4, 2018 at 9:43 PM Huxing Zhang wrote: > > > > Hi, > > > > On Tue, Dec 4, 2018 at 4:24 PM yuhang xiu wrote: > > > > > > Hi, community > > > At present, there are many Map type maps in dubbo. When > usi

Re: [Integration] Dubbo integrates with Nacos as a registry

2018-12-12 Thread yuhang xiu
Nice work, @khan I saw that you helped us to review a lot of PR, welcome you to make more contributions, I am looking forward to it. :) Imteyaz Khan 于2018年12月12日周三 下午4:00写道: > Sure, I will do that. > > Regards > Imteyaz > > On 12 Dec 2018 1:13 p.m., "Mercy" wrote: > > > Hi, Imteyaz, > > > >

Re: About the comments coverage of the code

2018-12-10 Thread yuhang xiu
Ok, huxing I'd like take some time to do this. Huxing Zhang 于2018年12月10日周一 下午11:43写道: > On Mon, Dec 10, 2018 at 7:14 PM yuhang xiu wrote: > > > > Hi, > > @zhuzi @shunyumaple > > You are welcome to claim a new job. > > > > We currently have a project, bu

Re: Repeated content in dubbo 2.6.4's internal content

2018-12-10 Thread yuhang xiu
. I should have > some extra bandwidth after this week. > > Thanks, > -Ian. > > On Wed, Nov 28, 2018 at 4:12 PM yuhang xiu wrote: > > > Awesome. > > I will also take some time to look at our submission record to find the > > problem. > > > > Ian Luo 于2

Re: About the comments coverage of the code

2018-12-10 Thread yuhang xiu
be done by multiple people, as long as there is no conflict. 竹子 于2018年12月10日周一 下午2:34写道: > 我现在正在补全dubboprotocal的注释 竹子 邮箱zhuzi.w...@gmail.com 签名由 网易邮箱大师 定制 On > 12/10/2018 14:28, yuhang xiu wrote: very nice. If there is any progress, > you can tell us here. 雷舜宇 于2018年12月10日周一 > 下午

Re: About the comments coverage of the code

2018-12-09 Thread yuhang xiu
very nice. If there is any progress, you can tell us here. 雷舜宇 于2018年12月10日周一 下午12:03写道: > I said that I am currently doing the service-completed comments completion > work. If there is a problem, I will exchange this on the mailing list. > > 田 小波 于2018年12月10日周一 上午10:03写道: > > > OK, I will

Re: New contributors for community

2018-12-07 Thread yuhang xiu
ote: I > has just talked to you in wechat yesterday .  yuhang xiu < > carry...@gmail.com> 于2018年12月7日周五 下午5:07写道: > they are my friends. I > didn't know you before, so there is no way to > contact you. > > But > welcome to dubbo. Next time I will distribute the issue d

Re: New contributors for community

2018-12-07 Thread yuhang xiu
的各项社区活动。 > > 初来乍到,还有许多的知识向大家学习,还望以后的时间多多指教。~ > > > > > > -- Original -- > > From: yuhang xiu carry...@gmail.com > > Date: Fri,Dec 7,2018 4:49 PM > > To: dev dev@dubbo.apache.org > > Subject: Re: New contributors for community > > >

Re: New contributors for community

2018-12-07 Thread yuhang xiu
ute to the community too. > You can assign some issues to me . > > yuhang xiu 于2018年12月7日周五 下午4:49写道: > > > 社区的各位大家好。 > > > > 前几天,我发送了一封邮件,关于我会分发一些issue给一些对dubbo有兴趣的新人,让他们参与到dubbo中,从而更好的建设整个社区。 > > > > 在早些时候,我分发了四个issue给四个新人,他们分别是下面四个PR的作者: > > https://gi

New contributors for community

2018-12-07 Thread yuhang xiu
社区的各位大家好。 前几天,我发送了一封邮件,关于我会分发一些issue给一些对dubbo有兴趣的新人,让他们参与到dubbo中,从而更好的建设整个社区。 在早些时候,我分发了四个issue给四个新人,他们分别是下面四个PR的作者: https://github.com/apache/incubator-dubbo/pull/2831 https://github.com/apache/incubator-dubbo/pull/2893 https://github.com/apache/incubator-dubbo/pull/2822

Re: [DISCUSS] A robot for Dubbo to help the community collaboration

2018-12-06 Thread yuhang xiu
Great, this robot is very interesting. Netty also has a similar robot[1] that can control whether or not to perform unit tests (some pr can be judged that we won't accept them during the review phase), I think we can also try this. Another feature. It will leave a comment said: 'Can one of the

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread yuhang xiu
= > > Constants.CACHE_KEY) > > public class CacheFilter implements Filter { > > > > > > > > . > > > > } > > > > > > On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan > wrote: > > > > > Just to make sure I h

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread yuhang xiu
2018 at 7:00 PM Imteyaz Khan > wrote: > > > Thanks a lot for the start, much appreciated. > > > > > > > > On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu wrote: > > > >> In addition, we strongly encourage open discussion. > >> You can post you

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread yuhang xiu
In addition, we strongly encourage open discussion. You can post your comments on a Filter directly here. There will be some people who know more about dubbo to review and discuss. Of course, any problem can be raised here. We will answer as soon as possible. yuhang xiu 于2018年12月5日周三 下午8:58写道

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread yuhang xiu
very sorry. I have some work now, so I didn't respond to your email in time. I am very willing to help you with the completion of the comments. If you are a newbie, I suggest you start with a simple logic. Which parts of the logic are relatively simple? At present, I think that our filter-related

Re: Use longObjectMap to increase performance

2018-12-04 Thread yuhang xiu
ome here. Apache way. :) I saw your comments on some of the pull request. > I can take some of them this week. That is great. Huxing Zhang 于2018年12月4日周二 下午9:43写道: > Hi, > > On Tue, Dec 4, 2018 at 4:24 PM yuhang xiu wrote: > > > > Hi, community > > At present,

Re: About the comments coverage of the code

2018-12-04 Thread yuhang xiu
s. > > Maybe separate them by modules or something smaller and manage them by > Github Project? > > On Tue, Dec 4, 2018 at 5:10 PM yuhang xiu wrote: > > > > Recently dubbo held an offline meetup. When discussing with many > > participants, many people have

About the comments coverage of the code

2018-12-04 Thread yuhang xiu
Recently dubbo held an offline meetup. When discussing with many participants, many people have suggested that dubbo has very few comments. Comments are very important for us to understand the code. If our comments are few, it is very unfriendly for new developers. I created a new issue[1] to

Use longObjectMap to increase performance

2018-12-04 Thread yuhang xiu
Hi, community At present, there are many Map type maps in dubbo. When using this kind of map, jdk performs automatic package. We can use longObjectMap(or intObjectMap or sth else) to replace these maps and add some performance. Similarly, I have opened an issue[1] to track the progress. Of

Re: Repeated content in dubbo 2.6.4's internal content

2018-11-28 Thread yuhang xiu
t 3:47 PM Ian Luo wrote: > > > This issue is worthy a separated issue. I will file it. > > > > -Ian. > > > > On Wed, Nov 28, 2018 at 10:13 AM yuhang xiu wrote: > > > >> Hi, community > >> > >> Recently, a user commit a issue[1]

Repeated content in dubbo 2.6.4's internal content

2018-11-27 Thread yuhang xiu
Hi, community Recently, a user commit a issue[1] about that the dubbo.internal's files has repeated content like this: netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter

Re: Fix issue 2425 and bring a new contributor

2018-11-26 Thread yuhang xiu
/pull/2822 yuhang xiu 于2018年11月23日周五 下午3:22写道: > I agree. > > He will try to subscribe to our mailing list next week. I will introduce > him to you after he comes here. :) > > Ian Luo 于2018年11月23日周五 下午3:18写道: > >> Good job, pls. encourage them to look into 'help wante

Re: [ANNOUNCE] Apache Dubbo(incubating) 2.6.5 has been released

2018-11-22 Thread yuhang xiu
Nice work. Let us move on. victory 于2018年11月23日周五 下午3:23写道: > Hi, community, > > I am pleased to announce that the 2.6.5 version has just been released. > Both the source release[1] and the maven binary release[2] are available > now, you can also find the detailed release notes in here[3] or

Re: Fix issue 2425 and bring a new contributor

2018-11-22 Thread yuhang xiu
g list to discuss, I > think it is still helpful if they can subscribe and act as a watcher for > now. > > On the other hand, we ourselves should discuss more both here and on GitHub > issue. > > Thanks, > -Ian. > > > On Fri, Nov 23, 2018 at 12:17 PM yuhang xiu wrote: &

Re: Fix issue 2425 and bring a new contributor

2018-11-22 Thread yuhang xiu
ing list, most of > them prefer QQ and WeChat group. The mailing list is a new thing for most > the developers, they may not do know what is it, and how to use. > > > 在 2018年11月23日,上午11:58,yuhang xiu 写道: > > > > Hi huxing, > > > > Some people are less willing

Re: Fix issue 2425 and bring a new contributor

2018-11-22 Thread yuhang xiu
2018年11月23日周五 上午11:39写道: > On Fri, Nov 23, 2018 at 11:32 AM yuhang xiu wrote: > > > > Hi, community > > > > Recently I tried to distribute some simple issue fixes to newcomers who > > have not contributed to dubbo to cultivate their passion for > participating &

Re: [ANN] Welcome new committer: Liandong Chen

2018-11-20 Thread yuhang xiu
Welcome to dubbo. Maybe FEer is front engineer, or sth else. :) 大步流星 <835576...@qq.com> 于2018年11月20日周二 下午10:33写道: > Haha, welcome, personal introduction can be more detailed, what is FEer > short. . . . > > > > > -- 原始邮件 -- > 发件人: "陈连东(轩坊)"; > 发送时间:

Re: Transfer wiki New Committer Guide to Official website

2018-11-16 Thread yuhang xiu
Hi, Agree with u. When I became a committer, I referenced the version of Xin Wang's blog [1] and asked him some questions. The new committer can also refer to this Chinese document for the time being. Of course, you can also email specific people.

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.5 [RC1]

2018-11-15 Thread yuhang xiu
I am very sorry that I did not respond in time. I have checked the things on the release note and the corresponding issue and pr. I think there is no problem and I agree to release it. +1 for release. Jun Liu 于2018年11月15日周四 下午4:22写道: > +1. > > 1. Source release package: > * Hash and signature

Re: [ANN] Welcome new committer Victory Cao

2018-11-15 Thread yuhang xiu
congratulations! Jun Liu 于2018年11月15日周四 下午4:23写道: > Hi, Community, > > On behalf of the Dubbo PPMC, I am pleased to announce that Victory Cao, > whose github id is cvictory, has been voted in as a new Dubbo committer. > > Please join me to say congratulations to him! > > Victory, would you

Re: Meetup in Hangzhou

2018-11-13 Thread yuhang xiu
Very looking forward to the meetup in Hangzhou! I will definitely attend. Ian Luo 于2018年11月14日周三 下午1:44写道: > +1 with the proposal. Hangzhou is a city where Dubbo is popular. We should > throw a meetup here as soon as possible. > > -Ian. > > On Wed, Nov 14, 2018 at 11:48 AM Huxing Zhang wrote:

  1   2   >