Your pr has modified more than 30,000 lines of code, and most of them are modifications of the entire file. What is the meaning of your pr? Why do I need to keep it open?
If you need to discuss, issues and mailing lists are good choices, why do you need to discuss pr? Who can review this pr[1] and tell me what this pr is going to do? [1] https://github.com/apache/incubator-dubbo/pull/3371 LiZhenNet <[email protected]> 于2019年1月29日周二 上午10:29写道： > Yes, we can create a project to manage it, and we can talk about it. like: > Should we used Diamond Operator replace explicit type? Use Lambda? > Let's discuss the two pull requests above instead of closed it immediately. > > > > > > Huxing Zhang <[email protected]> 于2019年1月29日周二 上午9:58写道： > > > Hi, > > > > Nice suggestion! > > > > Shall we can create a project to manage it? > > > > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <[email protected]> > wrote: > > > > > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of > unused > > > methods ,unused logic , nonstandard naming in the code. And there are > > some > > > code that can use the new features of java to make the code more > concise > > > and understandable. like Lambda , Diamond Operator and so on.These are > > easy > > > to find and fixed because of the tips of the idea .We should do it > before > > > completing the incubation. > > > > > > > > -- > > Best Regards！ > > Huxing > > >
