[GitHub] incubator-eagle issue #657: [EAGLE-779] add a managed task to regularly sche...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/657 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #660: EAGLE-781 Add unit test for eagle-audit-b...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/660#discussion_r88202951
--- Diff:
eagle-core/eagle-query/eagle-audit-base/src/test/java/org/apache/eagle/audit/dao/TestSearchRequestBuilder.java
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.audit.dao;
+
+import junit.framework.Assert;
+import org.apache.commons.lang.time.DateUtils;
+import
org.apache.eagle.service.client.EagleServiceSingleEntityQueryRequest;
+import org.apache.eagle.service.client.IEagleServiceClient;
+import org.apache.eagle.service.client.impl.EagleServiceClientImpl;
+import org.apache.eagle.service.client.impl.SearchRequestBuilder;
+import org.junit.Test;
+
+import java.lang.reflect.Field;
+
+/**
+ * @Since 11/15/16.
+ */
+public class TestSearchRequestBuilder {
+
+@Test
+public void testQuery() throws Exception {
+IEagleServiceClient client = new
EagleServiceClientImpl("localhost", 9090);
--- End diff --
How could this UT work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #649: [EAGLE-583] implement ldap authentication logic ...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/649 LGTM, please merge once PR building passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #650: upgrade org.codehaus.jackson to com.fasterxml.ja...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/650 @baibaichen LGTM, please go ahead to create JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #649: [EAGLE-583] implement ldap authentication logic ...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/649 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/647 @koone As the PR changed too many files, please it may take a few days for reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #653: [MINOR] Move getHealthCheck from Application to ...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/653 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #654: [EAGLE-769] InjectMembers in ServerApplic...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/654 [EAGLE-769] InjectMembers in ServerApplication when initialization https://issues.apache.org/jira/browse/EAGLE-769 InjectMembers in ServerApplication when initialization You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle EAGLE-769 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/654.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #654 commit 8179f4c44727a8bfc5a1a9e606f893472d0c98cc Author: Hao Chen <h...@apache.org> Date: 2016-11-15T06:36:01Z InjectMembers in ServerApplication when initialization --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #652: [EAGLE-764] MR history feeder support Health Che...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/652 Check failed, please fix it before merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #652: [EAGLE-764] MR history feeder support Health Che...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/652 LGTM. As a future improvement, we could add a managed task to regularly schedule registered healthchecks and report the unhealthy result in different plug-gable `healthreport` ways for example: `logging` (by default) or `notification` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #651: [EAGLE-766] Set default host & port of JP...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/651 [EAGLE-766] Set default host & port of JPM_WEB_APP as null https://issues.apache.org/jira/browse/EAGLE-766 Set default host & port of JPM_WEB_APP as N/A to make sure the web will read web service from configured instead of always using current. You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle EAGLE-766 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/651.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #651 commit ec6d966de784ae0f412c7d01213b7aade622e1b9 Author: Hao Chen <h...@apache.org> Date: 2016-11-15T02:46:15Z Set default host & port of JPM_WEB_APP as N/A to make sure the web will read web service from configured instead of always using current. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/647 @koone thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/647 Could you please rollback the code format of files under `org.apache.eagle.query.antlr.generated` too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #606: EAGLE-643 Implement oozieAuditLogAppProvider
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/606 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/647 Classes under `org.apache.eagle.query.antlr.generated` is automatically generated by `antlr`, so suggest to exclude it from checkstyle and keep the original code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #648: [EAGLE-757] fix alert JdbcDatabaseHandler connec...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/648 LGTM, besides follow suggestions: * Merge `alertDao` into `metadata.store`, probably by simply override system property * Handle possible runtime exception during object mapping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #646: [MINOR]: add back policy scheduler
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/646 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #645: [EAGLE-762] Add AlertEmailPublisherTest t...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/645 [EAGLE-762] Add AlertEmailPublisherTest test cases Add AlertEmailPublisherTest test cases https://issues.apache.org/jira/browse/EAGLE-762 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle EAGLE-762 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/645.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #645 commit fda19ff533949bccac971689a4de99604697c8d2 Author: Hao Chen <h...@apache.org> Date: 2016-11-10T08:09:42Z Add AlertEmailPublisherTest test cases commit 016b85b5636f6695065283d69937e46843083f8c Author: Hao Chen <h...@apache.org> Date: 2016-11-10T08:15:14Z Fix eagle-parent pom.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #606: EAGLE-643 Implement oozieAuditLogAppProvider
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/606 BTW: Could you please provide more description or screenshot about the feature? For example: - Installation Dialog Screenshot - Populated Stream Schema - Any UI features? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #606: EAGLE-643 Implement oozieAuditLogAppProvi...
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/606#discussion_r87327457 --- Diff: eagle-security/eagle-security-oozie-auditlog/src/main/resources/META-INF/providers/org.apache.eagle.security.oozie.parse.OozieAuditLogAppProvider.xml --- @@ -0,0 +1,250 @@ + + + + +OOZIE_AUDIT_LOG_MONITOR +Oozie Audit Log Monitor +0.5.0-incubating + org.apache.eagle.security.oozie.parse.OozieAuditLogApplication + + + +workers +workers +1 +number of topology workers + + +topology.numOfJoinTasks +topology.numOfJoinTasks --- End diff -- Please change `displayName` of all properties in configuration descriptor to **human-readable name**, for example: topology.numOfJoinTasks -> "Join Tasks Num" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #639: [EAGLE-734] Integrate maven-buildNumber-p...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/639 [EAGLE-734] Integrate maven-buildNumber-plugin and Version.java * Integrate maven-buildNumber-plugin and Version.java * Format eagle version desc * Add `/server/version` and `/server/config` API You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle buildNumberVersion Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/639.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #639 commit e4458f73487d476a1512d1282b32d20fedd8a2f6 Author: Hao Chen <h...@apache.org> Date: 2016-11-09T13:37:10Z Integrate buildnumbern and templating maven-plugin and Version commit 3de726567c06e56b09ec4bbc4d8b8b83910b71e2 Author: Hao Chen <h...@apache.org> Date: 2016-11-09T13:43:03Z Format eagle version desc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #606: EAGLE-643 Implement oozieAuditLogAppProvi...
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/606#discussion_r87172938 --- Diff: eagle-security/eagle-security-oozie-auditlog/src/main/java/org/apache/eagle/security/oozie/parse/OozieAuditLogAppProvider.java --- @@ -0,0 +1,13 @@ +package org.apache.eagle.security.oozie.parse; --- End diff -- Missing license header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #631: EAGLE-758: Add tuple log for spout & alert bolt
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/631 For requirements "spout/alert process issue or no event come", please refer to storm metrics. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #631: EAGLE-758: Add tuple log for spout & alert bolt
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/631 Overall, we really don't suggest to print `per-event` log anywhere for any big data application. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #631: EAGLE-758: Add tuple log for spout & aler...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/631#discussion_r87141359
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/spout/SpoutOutputCollectorWrapper.java
---
@@ -103,7 +103,7 @@ public SpoutOutputCollectorWrapper(CorrelationSpout
spout,
*/
List convertedTuple = converter.convert(tuple);
if (convertedTuple == null) {
-LOG.warn("source data {} can't be converted to a stream,
ignore this message", tuple);
+LOG.debug("source data {} can't be converted to a stream,
ignore this message", tuple);
--- End diff --
For any `debug` logging, check with `if(LOG.isDebugEnabled())` before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #623: [EAGLE-736] Fix eagle-data-process checkstyle wa...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/623 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #621: Eagle-748 Streams UI display dataSource describe
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/621 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #616: EAGLE-744: add rest api for searching alerts by ...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/616 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #617: Eagle-735 Policy detail UI update
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/617 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #609: [EAGLE-723] Add unit test for configbus.
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/609 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #609: [EAGLE-723] Add unit test for configbus.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/609#discussion_r86718175
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/config/ConfigBusConsumer.java
---
@@ -54,7 +54,12 @@ public ConfigBusConsumer(ZKConfig config, String topic,
ConfigChangeCallback cal
public ConfigValue getConfigValue() throws Exception {
byte[] value = curator.getData().forPath(zkPath);
-ConfigValue v = mapper.readValue(value, ConfigValue.class);
+ConfigValue v;
+try {
+v = mapper.readValue(value, ConfigValue.class);
+} catch (JsonParseException e) {
+v = new ConfigValue();
--- End diff --
Pls. add `LOG.warn(e.getMessage())` for the ignored exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #567: EAGLE-643 Implement oozieAuditLogAppProvider
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/567 @chitin please resolve the code conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #602: EAGLE-728 Application can't load application.pro...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/602 @wujinhu pls. have a look about this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #:
Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/commit/8beda32daa55b6bbe148140aaf95c8d17ba7b6ff#commitcomment-19674297 In eagle-core/eagle-common/src/main/java/org/apache/eagle/common/DateTimeUtil.java: In eagle-core/eagle-common/src/main/java/org/apache/eagle/common/DateTimeUtil.java on line 37: @qingwen220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #570: EAGLE-690 : integrage topology health check with...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/570 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #570: EAGLE-690 : integrage topology health che...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/570#discussion_r86106454
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/storm/HealthCheckParseBolt.java
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.eagle.topology.storm;
+
+import backtype.storm.task.OutputCollector;
+import backtype.storm.task.TopologyContext;
+import backtype.storm.topology.OutputFieldsDeclarer;
+import backtype.storm.topology.base.BaseRichBolt;
+import backtype.storm.tuple.Fields;
+import backtype.storm.tuple.Tuple;
+import org.apache.eagle.topology.entity.HealthCheckParseAPIEntity;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import storm.kafka.bolt.mapper.FieldNameBasedTupleToKafkaMapper;
+
+import java.util.Arrays;
+import java.util.Map;
+import java.util.TreeMap;
+
+public class HealthCheckParseBolt extends BaseRichBolt {
+
+ private static final long serialVersionUID = 1L;
+
+ private static Logger LOG =
LoggerFactory.getLogger(HealthCheckParseBolt.class);
+private OutputCollector collector;
+
+@Override
+public void prepare(Map map, TopologyContext topologyContext,
OutputCollector outputCollector) {
+this.collector = outputCollector;
+}
+
+@Override
+public void execute(Tuple tuple) {
+ HealthCheckParseAPIEntity result = null;
+try{
+ result = (HealthCheckParseAPIEntity)
tuple.getValueByField("f1");
--- End diff --
check style
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #570: EAGLE-690 : integrage topology health che...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/570#discussion_r86106380
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java
---
@@ -23,17 +23,27 @@
import com.typesafe.config.Config;
import org.apache.eagle.app.StormApplication;
import org.apache.eagle.app.environment.impl.StormEnvironment;
+import org.apache.eagle.app.sink.StormStreamSink;
+import org.apache.eagle.topology.storm.HealthCheckParseBolt;
import org.apache.eagle.topology.storm.TopologyCheckAppSpout;
import org.apache.eagle.topology.storm.TopologyDataPersistBolt;
public class TopologyCheckApp extends StormApplication {
+
+ private static final long serialVersionUID = 1L;
--- End diff --
Pls. make sure using consistent indent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #570: EAGLE-690 : integrage topology health che...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/570#discussion_r86106441
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/storm/HealthCheckParseBolt.java
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.eagle.topology.storm;
+
+import backtype.storm.task.OutputCollector;
+import backtype.storm.task.TopologyContext;
+import backtype.storm.topology.OutputFieldsDeclarer;
+import backtype.storm.topology.base.BaseRichBolt;
+import backtype.storm.tuple.Fields;
+import backtype.storm.tuple.Tuple;
+import org.apache.eagle.topology.entity.HealthCheckParseAPIEntity;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import storm.kafka.bolt.mapper.FieldNameBasedTupleToKafkaMapper;
+
+import java.util.Arrays;
+import java.util.Map;
+import java.util.TreeMap;
+
+public class HealthCheckParseBolt extends BaseRichBolt {
+
+ private static final long serialVersionUID = 1L;
--- End diff --
check style
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #570: EAGLE-690 : integrage topology health check with...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/570 @puyulu please git commit with meaningful comments about what you actually did instead of general "change the code after review". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #570: EAGLE-690 : integrage topology health check with...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/570 @puyulu pls. help fix the conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #599: EAGLE-721: remove duplicate DateTimeUtil
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/599 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #598: [EAGLE-719] fix configuration bug in application...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/598 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #584: [EAGLE-698] Collectd python plugin for gathering...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/584 Please rename `Manual_of_collectd_hadoop_plugin.md` to `README.md` to well integrate with github page. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #570: EAGLE-690 : integrage topology health che...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/570#discussion_r86078122
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java
---
@@ -45,7 +63,16 @@ public StormTopology execute(Config config,
StormEnvironment environment) {
persistBoltName,
new TopologyDataPersistBolt(topologyCheckAppConfig),
topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt
-
).setNumTasks(topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(spoutName);
+
).setNumTasks(topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(spoutName);
+
+topologyBuilder.setBolt(
+ parseBoltName,
+ new HealthCheckParseBolt(),
+
topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(persistBoltName);
+
+logger.info("start to sink messsage to kafka");
--- End diff --
Storm topology is lazy execution, so in fact, current it's just defining
the execution dataflow but not handle data at all, so `start to sink messsage
to kafka` is not correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #570: EAGLE-690 : integrage topology health che...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/570#discussion_r86078024
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java
---
@@ -20,20 +20,38 @@
import backtype.storm.generated.StormTopology;
import backtype.storm.topology.TopologyBuilder;
+
+import com.microsoft.azure.storage.core.Logger;
import com.typesafe.config.Config;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.eagle.app.StormApplication;
import org.apache.eagle.app.environment.impl.StormEnvironment;
+import org.apache.eagle.app.sink.StormStreamSink;
+import org.apache.eagle.topology.storm.HealthCheckParseBolt;
import org.apache.eagle.topology.storm.TopologyCheckAppSpout;
import org.apache.eagle.topology.storm.TopologyDataPersistBolt;
public class TopologyCheckApp extends StormApplication {
+ /**
--- End diff --
Remove useless comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #570: EAGLE-690 : integrage topology health check with...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/570 @puyulu what's the progress? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #540: EAGLE-652 : get valid hostname for datanode
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/540 @puyulu please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #559: EAGLE-680 Can't genetate Html coverage report
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/559 LGTM and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #570: EAGLE-690 : integrage topology health check with...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/570 @puyulu please fix according to comments as @qingwen220 and I leave, and also modify the `displayName` in configuration section of AppProvider.xml. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #570: EAGLE-690 : integrage topology health che...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/570#discussion_r86067948
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java
---
@@ -20,20 +20,38 @@
import backtype.storm.generated.StormTopology;
import backtype.storm.topology.TopologyBuilder;
+
+import com.microsoft.azure.storage.core.Logger;
import com.typesafe.config.Config;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.eagle.app.StormApplication;
import org.apache.eagle.app.environment.impl.StormEnvironment;
+import org.apache.eagle.app.sink.StormStreamSink;
+import org.apache.eagle.topology.storm.HealthCheckParseBolt;
import org.apache.eagle.topology.storm.TopologyCheckAppSpout;
import org.apache.eagle.topology.storm.TopologyDataPersistBolt;
public class TopologyCheckApp extends StormApplication {
+ /**
+*
+*/
+ private static final long serialVersionUID = 1L;
+
+ private static final String SINK_TASK_NUM = "topology.numOfSinkTasks";
+ private static final String TOPOLOGY_HEALTH_CHECK_STREAM =
"topology_health_check_stream";
+ Log logger = LogFactory.getLog(TopologyCheckApp.class);
--- End diff --
Use `private static final Logger LOG` for logger things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #570: EAGLE-690 : integrage topology health che...
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/570#discussion_r86067973 --- Diff: eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java --- @@ -20,20 +20,38 @@ import backtype.storm.generated.StormTopology; import backtype.storm.topology.TopologyBuilder; + +import com.microsoft.azure.storage.core.Logger; --- End diff -- Please use `slf4j-log` as single standard logging library. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #596: [EAGLE-717] Upgrade maven-surefire-plugin for su...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/596 @baibaichen what's the command you use for running it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #595: Eagle 717
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/595 Hi Chang @baibaichen , it seems that this PR includes lots of expected changes, could you please help confirm it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #593: [EAGLE-716][API] Forcefully Validate befo...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/593 [EAGLE-716][API] Forcefully Validate before saving policy into metadata https://issues.apache.org/jira/browse/EAGLE-716 [API] Forcefully Validate before saving policy into metadata when calling POST /policies You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle validateBeforeCreatingPolicy Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/593.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #593 commit 5bf8e415773589034b06d47446d968cf5d931018 Author: Hao Chen <h...@apache.org> Date: 2016-11-01T09:53:55Z [API] Forcefully Validate before saving policy into metadata when calling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #588: [EAGLE-705] streams is null when call /rest/apps...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/588 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #556: EAGLE-670: make kafka publisher configurable and...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/556 The default value is just for example :-). And when using kafka producer `async` mode and throughput becomes extremely larger, batch size is one of the most important configurations for tuning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #556: EAGLE-670: make kafka publisher configura...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/556#discussion_r84639463
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertKafkaPublisher.java
---
@@ -96,44 +103,63 @@ public void close() {
}
@SuppressWarnings( {"rawtypes", "unchecked"})
-protected PublishStatus emit(String topic, List
outputEvents) {
+protected void emit(String topic, List outputEvents)
{
// we need to check producer here since the producer is invisable
to extended kafka publisher
if (producer == null) {
LOG.warn("KafkaProducer is null due to the incorrect
configurations");
-return null;
+return;
}
if (outputEvents == null) {
if (LOG.isDebugEnabled()) {
LOG.debug("Alert stream events list in publishment is
empty");
}
-return null;
+return;
}
this.status = new PublishStatus();
try {
for (AlertStreamEvent outputEvent : outputEvents) {
ProducerRecord record = createRecord(outputEvent, topic);
if (record == null) {
LOG.error("Alert serialize return null, ignored
message! ");
-return null;
+return;
+}
+if (mode == KafkaWriteMode.sync) {
+Future future = producer.send(record);
+future.get(MAX_TIMEOUT_MS, TimeUnit.MILLISECONDS);
+succeed(mode, "");
+} else {
+producer.send(record, new Callback() {
--- End diff --
Oh ... I got what you did now, but what we talk about `async` means "kafka
send message with batch in async thread"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #556: EAGLE-670: make kafka publisher configura...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/556#discussion_r84639212
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertKafkaPublisher.java
---
@@ -96,44 +103,63 @@ public void close() {
}
@SuppressWarnings( {"rawtypes", "unchecked"})
-protected PublishStatus emit(String topic, List
outputEvents) {
+protected void emit(String topic, List outputEvents)
{
// we need to check producer here since the producer is invisable
to extended kafka publisher
if (producer == null) {
LOG.warn("KafkaProducer is null due to the incorrect
configurations");
-return null;
+return;
}
if (outputEvents == null) {
if (LOG.isDebugEnabled()) {
LOG.debug("Alert stream events list in publishment is
empty");
}
-return null;
+return;
}
this.status = new PublishStatus();
try {
for (AlertStreamEvent outputEvent : outputEvents) {
ProducerRecord record = createRecord(outputEvent, topic);
if (record == null) {
LOG.error("Alert serialize return null, ignored
message! ");
-return null;
+return;
+}
+if (mode == KafkaWriteMode.sync) {
+Future future = producer.send(record);
+future.get(MAX_TIMEOUT_MS, TimeUnit.MILLISECONDS);
+succeed(mode, "");
+} else {
+producer.send(record, new Callback() {
--- End diff --
This is not `async` mode in kafka language
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #556: EAGLE-670: make kafka publisher configurable and...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/556 BTW: these selected config keys are what we have evaluated in real-case and impact kafka throughput mostly, instead of not requiring you guys to include additional many kafka configurations ~~~ producer.type = async batch.num.messages = 3000 queue.buffering.max.ms = 5000 queue.buffering.max.messages = 1 ~~~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #556: EAGLE-670: make kafka publisher configurable and...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/556 The configuration is ok. The primary concern here is the `async` implementation, kafka producer natively support `async` mode, so that you just need pass through it instead of handle `async` thread manually which will look not very clean. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #556: EAGLE-670: make kafka publisher configurable and...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/556 @garrettlish the implementation looks a little confusing. Please just simply use kafka configs: https://kafka.apache.org/08/documentation.html#clientconfig and another part using async kafka producer: https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/sink/KafkaStreamSink.java#L53-L57 # kafka properties producer.type = async batch.num.messages = 3000 queue.buffering.max.ms = 5000 queue.buffering.max.messages = 1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #552: [EAGLE-650] Hadoop JMX Metric Monitoring ...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/552 [EAGLE-650] Hadoop JMX Metric Monitoring Application Hadoop JMX Metric Monitoring Application https://issues.apache.org/jira/browse/EAGLE-650 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle EAGLE-650 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/552.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #552 commit de237f6a1d7f91177730778930173f2c1090b69a Author: Hao Chen <h...@apache.org> Date: 2016-10-23T17:38:49Z Add static script-based HadoopMetricMonitorAppProvider --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #551: [EAGLE-665] Refactor kafka stream sink an...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/551 [EAGLE-665] Refactor kafka stream sink and hdfs audit topology using shuffle grouping * Refactor kafka stream sink * hdfs audit topology using shuffle grouping https://issues.apache.org/jira/browse/EAGLE-665 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle refactorHdfsAuditApp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/551.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #551 commit 2c9c04ae9903c69525b9d8b4e700a21fa7ea Author: Hao Chen <h...@apache.org> Date: 2016-10-22T10:36:49Z Refactor kafka stream sink and reorg hdfs audit topology using shuffle grouping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #550: [EAGLE-662] remove jarPath/mode from enti...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/550#discussion_r84570146
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/ApplicationAction.java
---
@@ -70,13 +71,16 @@ public ApplicationAction(Application application,
ApplicationEntity metadata, Co
this.application = application;
this.metadata = metadata;
this.runtime =
ExecutionRuntimeManager.getInstance().getRuntime(application.getEnvironmentType(),
serverConfig);
-Map<String, Object> executionConfig = metadata.getConfiguration();
+Map<String, Object> executionConfig = new
HashMap<>(metadata.getConfiguration());
if (executionConfig == null) {
executionConfig = Collections.emptyMap();
}
if (serverConfig.hasPath(MetricConfigs.METRIC_PREFIX_CONF)) {
LOG.warn("Ignored sever config {} = {}",
MetricConfigs.METRIC_PREFIX_CONF,
serverConfig.getString(MetricConfigs.METRIC_PREFIX_CONF));
}
+
+executionConfig.put("jarPath", metadata.getJarPath());
+executionConfig.put("mode", metadata.getMode().name());
--- End diff --
It may cause the jarPath added into configuration when installating, I
think you should add only in `start` action.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #540: EAGLE-652 : get valid hostname for datanode
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/540 What's the relationship of this ticket with #546 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #546: EAGLE-652:add topology health check to ap...
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/546#discussion_r84412334 --- Diff: eagle-topology-check/eagle-topology-app/src/main/resources/META-INF/providers/org.apache.eagle.topology.TopologyCheckAppProvider.xml --- @@ -22,7 +22,6 @@ Topology Health Check 0.5.0-incubating org.apache.eagle.topology.TopologyCheckApp --- End diff -- `appClass` is useless as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #546: EAGLE-652:add topology health check to app frame...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/546 LGTM if you could fix above two small issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #546: EAGLE-652:add topology health check to ap...
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/546#discussion_r84412447 --- Diff: eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/extractor/hdfs/HdfsTopologyEntityParser.java --- @@ -220,7 +220,7 @@ private void createAllDataNodeEntities(JMXBean bean, long updateTime, TopologyEn final String hostname = liveNodes.getString(i); final JSONObject liveNode = jsonNodesObject.getJSONObject(hostname); -HdfsServiceTopologyAPIEntity entity = createHdfsServiceEntity(TopologyConstants.DATA_NODE_ROLE, hostname, updateTime); +HdfsServiceTopologyAPIEntity entity = createHdfsServiceEntity(TopologyConstants.DATA_NODE_ROLE, EntityBuilderHelper.getValidHostName(hostname), updateTime); final Number configuredCapacity = (Number) liveNode.get(DATA_NODE_CAPACITY); entity.setConfiguredCapacityTB(Double.toString(configuredCapacity.doubleValue() / 1024.0 / 1024.0 / 1024.0 / 1024.0)); --- End diff -- Use static final value `Long TB = 1024.0*1024.0*1024.0*1024.0` then use ~~~ entity.setConfiguredCapacityTB(Double.toString(configuredCapacity.doubleValue() / TB)); ~~~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #539: [MINOR] Resolve unstable UT and clean slf...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/539 [MINOR] Resolve unstable UT and clean slf4j-log4j dependencies Resolve unstable UT and clean useless `slf4j-log4j` dependencies. You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle ResolveUnstableUT Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/539.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #539 commit ca386752578e2b0dde51c0715511907c4616b311 Author: Hao Chen <h...@apache.org> Date: 2016-10-20T08:59:57Z Resolve unstable UT and clean slf4j-log4j dependencies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #544: [EAGLE-656] Integrate metric system with ...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/544 [EAGLE-656] Integrate metric system with application framework Integrate metric system with application framework https://issues.apache.org/jira/browse/EAGLE-656 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle IntegrateMetricSystem Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/544.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #544 commit b20ef751789ccead84cc1cc01919eb87b3e402e3 Author: Hao Chen <h...@apache.org> Date: 2016-10-20T12:28:55Z Integrate metric system with application framework --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #540: EAGLE-652 : get valid hostname for datanode
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/540 Before move on to merge the PR, could you please clean up the changes? Why `+566` changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #538: EAGLE-646: AlertUnitTopology does not reb...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/538#discussion_r84228412
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert-app/src/main/java/org/apache/eagle/alert/app/AlertUnitTopologyAppListener.java
---
@@ -73,6 +74,7 @@ private void updateTopologyMetadata() {
LOG.error(result.message);
throw new IllegalStateException(result.message);
}
+Coordinator.startSchedule();
--- End diff --
Please call `build` directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #536: [EAGLE-647] Support Policy Execution Inte...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/536 [EAGLE-647] Support Policy Execution Interpreter and Planner to compile siddhi query to distributed execution plan Support Policy Execution Interpreter and Planner to compile siddhi query to distributed execution plan * Support parse siddhi pattern and join query as distributed execution * Support alias in inner join condition * Refactor PolicyIntepreter to eagle-alert-engine and decoupel PolicyExecutionPlanner * Fix factory method for PolicyExecutionPlanner You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle SupportPatternAndJoin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/536.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #536 commit 4a804e9a8f3240d4e7c8ad469a160ac06cb32259 Author: Hao Chen <h...@apache.org> Date: 2016-10-19T13:25:20Z Support parse siddhi pattern and join query as distributed execution plan commit 58c63fb10c271cd0de9377fa3935e35f972718ce Author: Hao Chen <h...@apache.org> Date: 2016-10-20T03:10:20Z Support alias in inner join condition commit c30f3b303e8fdc9e25cebc75aa6386ff55a28921 Author: Hao Chen <h...@apache.org> Date: 2016-10-20T03:38:10Z Refactor PolicyIntepreter to eagle-alert-engine and decoupel PolicyExecutionPlanner commit 08d911cb1989f4a05aab19419f3791786023debb Author: Hao Chen <h...@apache.org> Date: 2016-10-20T03:42:23Z Fix factory method for PolicyExecutionPlanner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #532: [EAGLE-639] Generate sortSpec on external...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/532 [EAGLE-639] Generate sortSpec on externalWindow Generate sortSpec on externalWindow https://issues.apache.org/jira/browse/EAGLE-639 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle EnhancePolicyIntepreter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/532.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #532 commit fddcfdb4931ed399fef819d975e1749dcb986b6f Author: Hao Chen <h...@apache.org> Date: 2016-10-19T04:39:32Z Generate sortSpec on externalWindow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #529: [EAGLE-635] Refactor policy parser and va...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/529 [EAGLE-635] Refactor policy parser and validator for richer plan details and better performance - Refactor policy parser and validator for richer plan details and better performance - Decouple PolicyExecutionPlan and PolicyValidation You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle RefactorPolicyValidator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/529.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #526: [MINOR] Fix end of line conflict caused b...
Github user haoch closed the pull request at: https://github.com/apache/incubator-eagle/pull/526 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #526: [MINOR] Fix end of line conflict caused b...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/526 [MINOR] Fix end of line conflict caused by .gitattributes Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle FixEOL Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/526.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #526 commit 2479d32791dd1a424af7513279ba28543baf6af4 Author: wujinhu <wujinhu...@126.com> Date: 2016-10-18T09:20:37Z [EAGLE-633] MR history feeder read some configurations from eagle server Author: wujinhu <wujinhu...@126.com> Closes #525 from wujinhu/EAGLE-633. commit a4cd8248f11226538fad217d265ac1a0b5bd8190 Author: Hao Chen <h...@apache.org> Date: 2016-10-18T09:46:44Z [MINOR] Fix CRLF to LF as default eol commit b8d41cdc2cc8ee8e601ab3147d2339fe6e70dade Author: Hao Chen <h...@apache.org> Date: 2016-10-18T09:50:49Z Merge conflict --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #524: [UI] Improve integeration page
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/524 [UI] Improve integeration page Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle ImproveIntegerationPage Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/524.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #524 commit 5153fca9c36f3854f858ab2a1503c20eb57d190a Author: Hao Chen <h...@apache.org> Date: 2016-10-17T13:01:43Z Improve settings page commit 867d15d9e053ee53d3e5441a7969c11879f191ad Author: Hao Chen <h...@apache.org> Date: 2016-10-17T15:27:15Z Merge branch 'ImproveIntegerationPage' of https://github.com/haoch/incubator-eagle into ImproveIntegerationPage commit 30ab9d5c490807edc09528d09e0613d9e395a487 Author: Hao Chen <h...@apache.org> Date: 2016-10-17T15:28:13Z Make ui-build.sh executable commit 38b3d76fc6e2994259cee4298dcf9ac1030b7dff Author: Hao Chen <h...@apache.org> Date: 2016-10-18T03:51:49Z Change Introduction to Summary commit 485d0f633547a4099e8e58026a1e8f27041cddf8 Author: Hao Chen <h...@apache.org> Date: 2016-10-18T08:30:33Z Cleanup alert engine configuration descriptor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #522: [EAGLE-632] clean up configuration for MR histor...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/522 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #523: [CI] Integrate coveralls to track eagle c...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/523 [CI] Integrate coveralls to track eagle code coverage ## CI Building Command mvn clean test cobertura:cobertura coveralls:report -DrepoToken=$COVERALLS_EAGLE_TOKEN -Dmaven.javadoc.skip=true -P!ui Check report at https://coveralls.io/github/apache/incubator-eagle You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle integrate_coveralls Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/523.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #523 commit ec07c09e874b8928b79f90fff7f0756911156765 Author: Hao Chen <h...@apache.org> Date: 2016-10-18T05:44:53Z Integrate with cobertura and coveralls commit 224a93e5303e0fb0d136736f418d987b7d3b44a2 Author: Hao Chen <h...@apache.org> Date: 2016-10-18T05:48:39Z Add build and coverage badge commit a9fb5cf82a02b1cd3a082735b829753a996e2e95 Author: Hao Chen <h...@apache.org> Date: 2016-10-18T06:14:55Z Disable EmbeddedHbaseTest commit 153b599e03536d11f29a7bea19fba50f3eaeeb97 Author: Hao Chen <h...@apache.org> Date: 2016-10-18T06:28:24Z Add .gitattributes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #518: [EAGLE-630] Add Publishments to Policy AP...
GitHub user haoch opened a pull request:
https://github.com/apache/incubator-eagle/pull/518
[EAGLE-630] Add Publishments to Policy API
Path:
POST /metadata/policies/{policyId}/publishments/
Data: String array, like:
[
"publishmentName1", "publishmentName2",.., "publishmentNameN"
]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/incubator-eagle EAGLE-630
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/518.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #518
commit 8bcaa034d203ee3ef491f6debd99b2eb73750ac2
Author: Hao Chen <h...@apache.org>
Date: 2016-10-16T16:34:10Z
[EAGLE-627] Add Policy PolicyValidator and Validation API
https://issues.apache.org/jira/browse/EAGLE-627
* Validate SiddhiQL syntax problem
* Provide Internal information like:
* Validate syntax is ok
* Explain details like inputStreams and outputStreams
commit 140358b439612aed26f3c4b996ca0f78b346ad88
Author: Hao Chen <h...@apache.org>
Date: 2016-10-16T16:44:45Z
Fix checkstyle warnings
commit dac9c8b23200fe8ed830aa8a4944af1882a6fb9d
Author: Hao Chen <h...@apache.org>
Date: 2016-10-16T16:49:21Z
Ignore unstabled unit test TestDistinctValuesInTimeBatchWindow#testNormal
commit 24308edb1db17c3887b0368b6fa28968efde3c15
Author: Hao Chen <h...@apache.org>
Date: 2016-10-16T17:22:51Z
Rename setException(Exception) to setStackTrace(Throwable) for conflicting
setter definitions for property 'exception'
commit aee5c1b4ee3eb70bd9690bc0a2548aac32b34a73
Author: Hao Chen <h...@apache.org>
Date: 2016-10-17T05:42:26Z
Path:
~~~
POST /metadata/policies/{policyId}/publishments/
~~~
Data: String array, like:
~~~
[
"publishmentName1", "publishmentName2",.., "publishmentNameN"
]
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #499: EAGLE-615 Jsoup parse hive sql return String wit...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/499 LGTM, thanks for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #516: EAGLE-625 remove site ignore
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/516 LGTM, please go ahead to merge into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #515: [EAGLE-627] Add Policy PolicyValidator an...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/515 [EAGLE-627] Add Policy PolicyValidator and Validation API Add Policy SiddhiQL Explain API to: * Validate SiddhiQL syntax problem * Provide Internal information like: * Validate syntax is ok * Explain details like inputStreams and outputStreams You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle EAGLE-627 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/515.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #515 commit 8bcaa034d203ee3ef491f6debd99b2eb73750ac2 Author: Hao Chen <h...@apache.org> Date: 2016-10-16T16:34:10Z [EAGLE-627] Add Policy PolicyValidator and Validation API https://issues.apache.org/jira/browse/EAGLE-627 * Validate SiddhiQL syntax problem * Provide Internal information like: * Validate syntax is ok * Explain details like inputStreams and outputStreams --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #514: [EAGLE-621] set authentication disabled b...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/514#discussion_r83551893
--- Diff:
eagle-server/src/main/java/org/apache/eagle/server/authentication/BasicAuthProviderBuilder.java
---
@@ -0,0 +1,61 @@
+package org.apache.eagle.server.authentication;
+
+import com.google.common.cache.CacheBuilderSpec;
+import com.sun.jersey.api.core.HttpContext;
+import com.sun.jersey.api.model.Parameter;
+import com.sun.jersey.core.spi.component.ComponentContext;
+import com.sun.jersey.server.impl.inject.AbstractHttpContextInjectable;
+import com.sun.jersey.spi.inject.Injectable;
+import io.dropwizard.auth.Auth;
+import io.dropwizard.auth.Authenticator;
+import io.dropwizard.auth.CachingAuthenticator;
+import io.dropwizard.auth.basic.BasicAuthProvider;
+import io.dropwizard.auth.basic.BasicCredentials;
+import io.dropwizard.setup.Environment;
+import org.apache.eagle.common.authentication.User;
+import
org.apache.eagle.server.authentication.authenticator.LdapBasicAuthenticator;
+import
org.apache.eagle.server.authentication.authenticator.SimpleBasicAuthenticator;
+import
org.apache.eagle.server.authentication.config.AuthenticationSettings;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class BasicAuthProviderBuilder {
+private static final String SIMPLE_MODE_REALM =
"SIMPLE_AUTHENTICATION";
+private static final String LDAP_MODE_REALM = "LDAP_AUTHENTICATION";
+private static final Map<String, BasicAuthProvider> MAPPING =
new HashMap<>();
+private AuthenticationSettings authSettings;
+private Environment environment;
+
+public BasicAuthProviderBuilder(AuthenticationSettings authSettings,
Environment environment) {
+this.authSettings = authSettings;
+this.environment = environment;
+Authenticator<BasicCredentials, User> simpleAuthenticator = new
SimpleBasicAuthenticator(authSettings.getSimple());
+Authenticator<BasicCredentials, User> ldapAuthenticator = new
LdapBasicAuthenticator(authSettings.getLdap());
+boolean needsCaching = authSettings.needsCaching();
--- End diff --
Better to register static object in static scope instead of in instance
constructor, and move check `needsCaching` to `build` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #514: [EAGLE-621] set authentication disabled by defau...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/514 Very clear refactoring, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #513: [EAGLE-624][UI] Improve ui information an...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/513 [EAGLE-624][UI] Improve ui information and fix bugs ## Improvements * Show dependencies apps number * Support XML child node tree as String in app docs * Cleanup eagle-server dependencies and output * Move business logic specific logics into dev profile * Rename header and remove pre fo installation content ## Bugs * Fix siteName bug in ui * Installation Doc is not correctly shown in Installation Dialog You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle ImproveUIInfo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/513.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #513 commit 185decfeed9ae2d8675f0412e62157c162e22120 Author: Hao Chen <h...@apache.org> Date: 2016-10-15T06:10:36Z Move business logic specific logics into dev profile commit cf1582c626932fc543509e98f96b809da6b30f8d Author: Hao Chen <h...@apache.org> Date: 2016-10-15T06:32:35Z Cleanup eagle-server dependencies and output commit a4b296197b4cea432b0119f0c6ebfadb5ab8b4e5 Author: Hao Chen <h...@apache.org> Date: 2016-10-15T06:35:59Z Fix siteName bug in ui commit a13120e58b1704c0517de4a34956ea9ec0506236 Author: Hao Chen <h...@apache.org> Date: 2016-10-15T16:29:38Z Support XML child node tree as String in app docs commit b14d501a725a8b95096d3c9201a2b2522eb3bc7a Author: Hao Chen <h...@apache.org> Date: 2016-10-15T17:15:06Z Rename header and remove pre fo installation content commit a7fa5a5d89921eaf30f8a67211016e2cafb4f811 Author: Hao Chen <h...@apache.org> Date: 2016-10-15T17:38:42Z Support XML child node tree as String in app docs commit 2670f14930161613c112f2223d2eed3e10a2d2e5 Author: Hao Chen <h...@apache.org> Date: 2016-10-15T17:46:26Z EAGLE-624 Fix Installation Doc is not correctly shown in Installation Dialog --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #494: [EAGLE-562] added metrics associated with virtua...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/494 @anyway1021 sorry for missing one thing: please make sure it's compatible for both hadoop v2.6 and v2.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #494: [EAGLE-562] added metrics associated with virtua...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/494 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #468: [EAGLE-582] add simple Basic Authenticati...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/468#discussion_r83352374
--- Diff:
eagle-server/src/main/java/org/apache/eagle/server/authentication/authenticator/LdapBasicAuthenticator.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.server.authentication.authenticator;
+
+import com.google.common.base.Optional;
+import io.dropwizard.auth.AuthenticationException;
+import io.dropwizard.auth.basic.BasicCredentials;
+import org.apache.eagle.common.authentication.User;
+import
org.apache.eagle.server.authentication.config.AuthenticationSettings;
+
+public class LdapBasicAuthenticator extends
AbstractSwitchableAuthenticator<BasicCredentials, User> {
+private AuthenticationSettings config = null;
+
+public LdapBasicAuthenticator(AuthenticationSettings settings) {
+super(settings, User.class);
+}
+
+public Optional authenticate(BasicCredentials credentials)
throws AuthenticationException {
+// TODO need to implement ldap authentication logic
+boolean pass = true;
+if (pass) {
--- End diff --
pass is always true?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #502: [Minor]: Update unitApp configuration
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/502 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #497: [Minor] Simply reorg maven repositories
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/497 [Minor] Simply reorg maven repositories Simply reorg maven repositories You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle FixRepo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/497.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #497 commit da0769718c22c8ced057051523150e9673cd7345 Author: Hao Chen <h...@apache.org> Date: 2016-10-12T12:50:27Z Reorg maven repositories --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #495: EAGLE-613 Support modify ApplicationEntit...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/495#discussion_r82965523
--- Diff:
eagle-core/eagle-metadata/eagle-metadata-jdbc/src/main/java/org/apache/eagle/metadata/store/jdbc/service/ApplicationEntityServiceJDBCImpl.java
---
@@ -116,6 +116,14 @@ public ApplicationEntity delete(ApplicationEntity
applicationEntity) {
return entity;
}
+/**
+ * TODO: UPDATE ApplicationEntity through JDBC is not supported yet
+ */
+@Override
+public ApplicationEntity update(ApplicationEntity entity) {
+throw new UnsupportedOperationException("UPDATE ApplicationEntity
through JDBC is not supported yet");
--- End diff --
@r7raul1984 Could you please implement updating operation for JDBC metadata
store?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #495: EAGLE-613 Support modify ApplicationEntity throu...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/495 @zombieJ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #495: EAGLE-613 Support modify ApplicationEntit...
GitHub user haoch opened a pull request:
https://github.com/apache/incubator-eagle/pull/495
EAGLE-613 Support modify ApplicationEntity through POST /rest/apps/{UUID}/
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[EAGLE-] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/incubator-eagle EAGLE-613
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #495
commit 050fc53c9743d0e9636d6b0d889bc400347857da
Author: Hao Chen <h...@apache.org>
Date: 2016-10-12T08:44:16Z
Support modify ApplicationEntity API
commit 04c8ab98185a0d5119073ac86f70e09aa81dfed4
Author: Hao Chen <h...@apache.org>
Date: 2016-10-12T09:07:06Z
Add UpdateOperation for updating ApplicationEntity
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #493: [EAGLE-556] Install/Update Alert Topology Metada...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/493 UT passed successfully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #493: [EAGLE-556] Install/Update Alert Topology...
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/493 [EAGLE-556] Install/Update Alert Topology Metadata when start alert engine Currently alert engine requires additional metadata like TopologyMeta, which in fact could be automatically generated during starting alert engine. *Changes* * Add "ApplicationListener" in ApplicationProvider to support extensible application lifecycle management callback listener * Implement AlertUnitTopologyAppListener to add topology metadata when topology is running and remove topology metadata when topology is stopped You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle EAGLE-556 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/493.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #493 commit aa88bea11a4b7cb0b488c4b4defcac5b7a27aee4 Author: Hao Chen <h...@apache.org> Date: 2016-10-11T08:46:25Z Add application listener commit bce38f0c8625761b7c1d33bea4a3ec0c203694c2 Author: Hao Chen <h...@apache.org> Date: 2016-10-11T08:47:21Z Fix conflict on executable flag commit 6c2dae7744baf7796fa9c01119cd132a6c986b6f Author: Hao Chen <h...@apache.org> Date: 2016-10-11T09:37:39Z Integrate ApplicationListener with ApplicationManagementService commit 84bff0330c6a8371d57f9737f3564c6c274bc090 Author: Hao Chen <h...@apache.org> Date: 2016-10-11T15:41:21Z Add application listener framework and support setup topology metadata * Add topology metadata when topology is running * Remove topology metadata when topology is stopped --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #492: EAGLE-609: Fix nullPointerException in De...
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/492#discussion_r82824325 --- Diff: eagle-core/eagle-alert-parent/eagle-alert-app/src/main/resources/META-INF/providers/org.apache.eagle.alert.app.AlertUnitTopologyAppProvider.xml --- @@ -25,6 +25,12 @@ +topology.name +topology.name +alertUnitTopology_1 --- End diff -- I think we should not keep current implementation only supporting hard-coded "alertUnitTopology_1", and coordinator should be able to easily fix it to use actual topology name accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #490: [EAGLE-605] Fix MR feeder provider.xml and remov...
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/490 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #489: EAGLE-608 UI update: metadata/policies/policy
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/489 Merged at https://github.com/apache/incubator-eagle/commit/6f9fb4eed47c7e4b4ff1b955861a4fdbf8cf296f --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
