Re: FELIX-5782

2018-02-23 Thread Raymond Auge
As you can see I've made some changes based on Tom's feedback: - the exceptions are lazily created once again - the exception types are stupid simple and so cannot bleed impl details - there's javadoc on each type Cheers, - Ray On Fri, Feb 23, 2018 at 10:59 AM, Thomas Watson wrote: > See my co

Re: FELIX-5782

2018-02-23 Thread Thomas Watson
See my comments in the issue. Tom On Fri, Feb 23, 2018 at 9:16 AM, Raymond Auge wrote: > Hello All, > > I'd like to get some feedback particularly from Richard Hall, Thomas Watson > and/or Karl Pauls regarding the change described in > https://issues.apache.org/jira/browse/FELIX-5782 > > Is the

Re: FELIX-5782

2018-02-23 Thread Richard S. Hall
Clearly, this will only be of interest to a very small number of people, but that's probably also true of the resolver API in general. Regardless, the patch itself seems reasonably harmless, so I don't have any technical issues with it as an implementation detail. In general, though, we try to