Re: Upgrade Gradle version used in Fineract

2019-02-22 Thread Vishwas Babu
On Fri, Feb 22, 2019 at 12:01 AM Juhan Aasaru wrote: > Hi! > > Vishwas and Myrle, thanks for explanations regarding Gradle version and > wrapper download instructions. > I first didn't notice that Michael had changed Gradle version inside > gradle-wrapper.properties > Instructions regarding

Re: Upgrade Gradle version used in Fineract

2019-02-22 Thread Juhan Aasaru
Hi! Vishwas and Myrle, thanks for explanations regarding Gradle version and wrapper download instructions. I first didn't notice that Michael had changed Gradle version inside gradle-wrapper.properties Instructions regarding downloading wrapper could include a line: "You only need to download

Re: Upgrade Gradle version used in Fineract

2019-02-18 Thread Myrle Krantz
On Mon, Feb 18, 2019 at 8:39 PM Vishwas Babu < vish...@confluxtechnologies.com> wrote: > @Juhan : While I am not sure why the readme has instructions for > downloading gradle wrapper separately (given that it is a part of the > project repo and committed into the code), > ASF policy is that

Re: Upgrade Gradle version used in Fineract

2019-02-18 Thread Vishwas Babu
> the idea. > > Kind regards, > Juhan > > > > > Kontakt Michael Vorburger () kirjutas kuupƤeval E, 18. > veebruar 2019 kell 01:51: > > > Hello, > > > > I would like to propose https://github.com/apache/fineract/pull/525 to > > upgrade the G

Re: Upgrade Gradle version used in Fineract

2019-02-18 Thread Juhan Aasaru
the idea. Kind regards, Juhan Kontakt Michael Vorburger () kirjutas kuupƤeval E, 18. veebruar 2019 kell 01:51: > Hello, > > I would like to propose https://github.com/apache/fineract/pull/525 to > upgrade the Gradle version used in Fineract. > > It would be good to get some r

Upgrade Gradle version used in Fineract

2019-02-17 Thread Michael Vorburger
Hello, I would like to propose https://github.com/apache/fineract/pull/525 to upgrade the Gradle version used in Fineract. It would be good to get some reviews and perhaps manual testing from some people. I does of course build again (see the "green" PR, now that we have Travis CI i