Re: Flex Issue : AS3 FLEX MOBILE APP CRASHING WHEN SCALING IMAGE

2017-09-21 Thread Mihai Chira
Paul, did you end up making any progress on this? I'd love to know if there was any improvement you could find. On Tue, May 31, 2016 at 6:13 PM Clint M wrote: > Hmmm... if it just crashes you might be hitting the max bitmap data size of > the operating system that the app is

Re: [VOTE] Should the Project Name of the Proposed Fork be FlexJS?

2017-09-14 Thread Mihai Chira
Abstain On Thu, 14 Sep 2017 17:37 Dave Fisher wrote: > VOTE Should the Project Name of the Proposed Fork be FlexJS? > > [ ] Yes - The forked project should be Apache FlexJS. > [ ] No - The forked project should have another name which will be > discussed. > [ ] Abstain -

Re: [DISCUSS] Name of the FlexJS Fork

2017-09-14 Thread Mihai Chira
How about FlexForward? Maybe better for the project name. On Thu, 14 Sep 2017 11:48 Harbs wrote: > Here’s a list of other options which came up off-list: > > > Limber (or maybe Limbre/Limbur for a unique name) > > LimberApp > > Boinga (unique name which retains the

Fwd: [jira] [Commented] (FLEX-35321) LayoutManager initializes components which are no longer on stage

2017-06-07 Thread Mihai Chira
-- Forwarded message -- From: Mihai Chira (JIRA) <j...@apache.org> Date: 7 June 2017 at 13:25 Subject: [jira] [Commented] (FLEX-35321) LayoutManager initializes components which are no longer on stage To: iss...@flex.apache.org [ https://issues.apache.org/jira/brows

Fwd: [jira] [Updated] (FLEX-35321) LayoutManager initializes components which are no longer on stage

2017-06-05 Thread Mihai Chira
(via RobotLegs), which try to work with data that's no longer there, resulting in fatal errors. Thanks. -- Forwarded message -- From: "Mihai Chira (JIRA)" <j...@apache.org> Date: 5 Jun 2017 14:00 Subject: [jira] [Updated] (FLEX-35321) LayoutManager initializes

Re: Build failed in Jenkins: flex-sdk #1453

2017-03-16 Thread Mihai Chira
I'm just taking a look at this On 15 March 2017 at 11:56, wrote: > See > > -- > [...truncated 2049 lines...] > main: > [echo] Compiling

Re: draft announcement for 4.16.0

2017-03-10 Thread Mihai Chira
I see that we're duplicating links. Is it for some specific email readers? Also made some small changes (in-line). On 12 February 2017 at 00:30, Justin Mclean wrote: > The Apache Flex community is pleased to announce the release of Apache > Flex SDK 4.16.0 > > The

Fwd: [jira] [Commented] (FLEX-27509) AdvancedListBase itemMaskFreeList is null

2017-01-12 Thread Mihai Chira
FYI, for anyone who may be interested. -- Forwarded message -- From: Mihai Chira (JIRA) <j...@apache.org> Date: 12 January 2017 at 13:36 Subject: [jira] [Commented] (FLEX-27509) AdvancedListBase itemMaskFreeList is null To: iss...@flex.apache.org [

Re: [DISCUSS] Apache Flex SDK 4.16 RC1 release

2017-01-12 Thread Mihai Chira
I just resolved FLEX-27509 (on develop). Shall I move it onto the 4.16 branch to add it to this release (and update the release notes)?

Re: [VOTE] Release Apache Flex SDK 4.16 RC1

2017-01-12 Thread Mihai Chira
> Thanks for voting but it we’re already working on the next RC. Cool, I'll take another look when it's out.

Re: [LAST CALL] Flex SDK 4.16

2016-11-09 Thread Mihai Chira
I am reverting [1] in the next few hours, and we'll continue the discussion after the release to find a solution which doesn't break backwards compatibility. On 8 November 2016 at 23:59, Justin Mclean wrote: > Hi, > > We’re getting closer to making a release candidate

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2016-11-07 Thread Mihai Chira
> It may also be an issue with 3rd party libraries that you don’t have the > source code to that use sort code. good point > Possibly one option is to use the flex compatibility version so that people > can set it to 4.15 to get the previous functionality. sorry, how does that work? It sounds

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2016-11-07 Thread Mihai Chira
> Seems like you could just copy your current code into ImmutableSortField sure, but ImmutableSortField would have the discovery problem - who would know to use it - and wouldn't actually prevent any of the fatals. I will revert SortField and the other changes (tomorrow), and I'll remove the

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2016-11-07 Thread Mihai Chira
> I guess I > don't fully understand the issue, so I don't have an alternate proposal, To help those reading this anew (but if responding, please also read the whole thread), the issue is: 1. You have a sorted collection 2. You change any of the properties of the Sort or SortField (the order,

Re: New Flex SDK release

2016-11-03 Thread Mihai Chira
> If there are any issues you want to see fixed in this release please add them > to this subtask [2] in the release JIRA. I'd like to get FLEX-34880 done for this release. If I work on it in the weekend, would it be too late, you think?

Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager tries to reapply selection onto changed textFlow

2016-10-20 Thread Mihai Chira
il me a reminder to take a look in a couple of weeks… > > Harbs > > On Oct 20, 2016, at 11:29 AM, Mihai Chira <mihai.ch...@gmail.com> wrote: > >> If anyone with TLF knowledge wants to take a look at this, it would be >> quite helpful. Some of the investigation work is a

Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager tries to reapply selection onto changed textFlow

2016-10-20 Thread Mihai Chira
If anyone with TLF knowledge wants to take a look at this, it would be quite helpful. Some of the investigation work is already done, and someone who understands what _should_ happen can probably spot the problem quickly. Thank you! On 29 August 2016 at 15:26, Mihai Chira <mihai.ch...@gmail.

Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager tries to reapply selection onto changed textFlow

2016-08-29 Thread Mihai Chira
Hi Harbs, just a quick reminder about this ticket, for when you have time. Many thanks! Mihai On 13 April 2016 at 12:54, Mihai Chira <mihai.ch...@gmail.com> wrote: > Actually this bug seems to occur when the empty span is *not* removed. > Thanks for taking a look! > > On 13 A

Re: Volunteers needed to update the Flex showcase

2016-04-22 Thread Mihai Chira
x-site/ > > On Apr 17, 2016, at 9:53 PM, Mihai Chira <mihai.ch...@gmail.com> wrote: > >> I couldn't find such a guide on the wiki, so I just added it, under >> Helping Out[1]. Let me know if you'd like me to change anything (or, >> if you have the tim

Re: Volunteers needed to update the Flex showcase

2016-04-17 Thread Mihai Chira
I couldn't find such a guide on the wiki, so I just added it, under Helping Out[1]. Let me know if you'd like me to change anything (or, if you have the time, go right ahead and make the edits). [1] https://cwiki.apache.org/confluence/display/FLEX/Helping+Out On 1 October 2015 at 10:00,

Fwd: Want to find more contributors for your Apache project?

2016-04-14 Thread Mihai Chira
Should I mail them (if so, should I just reply on committ...@apache.org?) to ask for the inclusion of ActionScript in the list of programming languages there? -- Forwarded message -- From: Shane Curcuru Date: 11 April 2016 at 21:55 Subject: Want to find

Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager tries to reapply selection onto changed textFlow

2016-04-13 Thread Mihai Chira
I find the time. > > On Apr 13, 2016, at 1:22 PM, Mihai Chira <mihai.ch...@gmail.com> wrote: > >> Hey guys, I feel I've done as much as I can on this ticket to pave the >> way for someone with more TLF knowledge to hopefully have an easy time >> understanding and fixing it.

Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager tries to reapply selection onto changed textFlow

2016-04-13 Thread Mihai Chira
Hey guys, I feel I've done as much as I can on this ticket to pave the way for someone with more TLF knowledge to hopefully have an easy time understanding and fixing it. Do any of you have time to take a look? Many thanks! On 13 April 2016 at 11:50, Mihai Chira (JIRA) <j...@apache.org>

Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields with all data types

2016-03-02 Thread Mihai Chira
Yep, agreed, and done. On 2 March 2016 at 09:18, Justin Mclean wrote: > Hi, > >> Justin, maybe you noticed that I finally got round to integrating your >> unit tests into the framework, > > Yep thanks for that. > >> and that they uncovered the bug with >> setItemAt() in

Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields with all data types

2016-03-02 Thread Mihai Chira
. Any ideas how to solve this issue? On 8 June 2015 at 10:48, Mihai Chira <mihai.ch...@gmail.com> wrote: > Thanks, I'll take a look in a while, when I work on this again. > > On 8 June 2015 at 00:43, Justin Mclean <jus...@classsoftware.com> wrote: >> Hi, >> >

Re: [2/7] git commit: [flex-sdk] [refs/heads/develop] - FLEX-35031 -Since I'm planning to use ObjectUtil.isDynamicObject() in the fix, I wanted to unit test it. -Also, I introduced a new function in O

2016-02-22 Thread Mihai Chira
> class and any subclass of it must be marked Dynamic so I think you are ok > here. Phew :) Thanks, Mihai

Re: [2/7] git commit: [flex-sdk] [refs/heads/develop] - FLEX-35031 -Since I'm planning to use ObjectUtil.isDynamicObject() in the fix, I wanted to unit test it. -Also, I introduced a new function in O

2016-02-22 Thread Mihai Chira
dynamic functionality... And yes, the current implementation of isDynamicObject, as donated by Adobe, seems faster (though I haven't tested it) than describeType, so, if it yields correct results, I'd be in favour of keeping it this way. On 18 February 2016 at 14:26, Mihai Chira <mihai

Re: [7/7] git commit: [flex-sdk] [refs/heads/develop] - FLEX-35031 FLEX-33058 -Simplified algorithm in findAny() and findLast(). -Improved asdoc for these functions. Note that all tests still pass.

2016-02-22 Thread Mihai Chira
d11c2f44bc36-7ff6.html > > I previously ran into this issue when I was documenting Feathers. Extra > text after @inheritDoc seems to be ignored. You need to put it before > @inheritDoc. > > - Josh > > > On Wed, Feb 17, 2016 at 9:11 AM, Mihai Chira <mih...@apache.org> w

Re: [2/7] git commit: [flex-sdk] [refs/heads/develop] - FLEX-35031 -Since I'm planning to use ObjectUtil.isDynamicObject() in the fix, I wanted to unit test it. -Also, I introduced a new function in O

2016-02-18 Thread Mihai Chira
dk/repo >>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/680b405d >>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/680b405d >>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/680b405d >> >>Branch: refs/heads/develop >>Comm

Re: [7/7] git commit: [flex-sdk] [refs/heads/develop] - FLEX-35031 FLEX-33058 -Simplified algorithm in findAny() and findLast(). -Improved asdoc for these functions. Note that all tests still pass.

2016-02-17 Thread Mihai Chira
lex-sdk/commit/22f81c47 > Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/22f81c47 > Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/22f81c47 > > Branch: refs/heads/develop > Commit: 22f81c478a097a019b2f714d1d85f3200ce69fb4 > Parents: 0f811ec > Author: Mihai Chi

Re: [jira] [Updated] (FLEX-35031) HierarchicalCollectionViewCursor cannot find sealed class instance

2016-02-16 Thread Mihai Chira
Note that some of the unit tests for this ticket and for FLEX-33058 are currently failing. That's known, and it's because the bugs haven't yet been solved. I'm starting to do that tomorrow. On 16 February 2016 at 13:35, Mihai Chira (JIRA) <j...@apache.org> wrote: > >

Re: AW: AW: Flex SDK Converter Maven Extension available

2016-02-03 Thread Mihai Chira
xmojos 7.1.0 this weekend (assuming that I will get some free time by my > girlfriend ;-) ) > > If you need any help with the transition, please feel free to ask any > question. I'll do my best to assist you. > > Chris > > ____ > Von: Mihai C

Re: AW: AW: Flex SDK Converter Maven Extension available

2016-01-29 Thread Mihai Chira
Also just noticed [2], which seems to have been updated much more recently. [2] https://cwiki.apache.org/confluence/display/FLEX/Quick+Start+Guide:+Building+Apache+Flex+applications+using+Maven On 29 January 2016 at 15:29, Mihai Chira <mihai.ch...@gmail.com> wrote: > In my team we ar

Re: Jenkins build is back to stable : flex-sdk_test #459

2016-01-06 Thread Mihai Chira
hallelujah! On 4 January 2016 at 21:30, wrote: > See >

Re: [2/3] git commit: [flex-sdk] [refs/heads/develop] - fix script

2016-01-06 Thread Mihai Chira
thanks for that, I hadn't noticed. On 5 January 2016 at 00:39, wrote: > fix script > > > Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo > Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/fb263b33 > Tree:

Re: git commit: [flex-sdk] [refs/heads/develop] - this got these test to pass on my mac

2016-01-04 Thread Mihai Chira
This also means that we'll need to update this xml when we release a new version of FlexUnit. Is there a way we could reference the flexunit build.xml's "${build.version}-${build.number}-flex_${build.sdk}" variables, instead of having to maintain these manually? On 4 January 2016 at 14

Re: Jenkins build is still unstable: flex-sdk_test #432

2015-12-23 Thread Mihai Chira
com> wrote: > > > On 12/22/15, 2:59 AM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: > >>> >>> If the answer >>> is to explicitly list the SWCs, that should be straightforward to do. >> >>I suggest that we try to see what happe

Re: Jenkins build is still unstable: flex-sdk_test #432

2015-12-22 Thread Mihai Chira
> That thread seems to be about Flash Builder compatibility. This is just > Ant stuff, isn't it? Yes, but it does detail some of the internal logic, logic which may explain why we're seeing the as3 version of UIImpersonator, despite the fact that we're also including the flex version of the swc.

Re: Jenkins build is still unstable: flex-sdk_test #432

2015-12-21 Thread Mihai Chira
> I don't know FlexUnit very well. Is it normal to have both the as3 and > flex version in the library-path so their definitions compete or is it > normal to only have one or the other? I'm trying to understand whether > the current situation where both are in the library-path is the default >

Re: Jenkins build is still unstable: flex-sdk_test #432

2015-12-18 Thread Mihai Chira
> Also note that the compiler shouldn't care as much about the order in the > library path as the compile time for the definitions in the SWCs. So if > class Foo was compiled into the as3 SWC and then later into the flex SWC, > the definition in the flex SWC should always win regardless of order.

Re: Jenkins build is still unstable: flex-sdk_test #432

2015-12-17 Thread Mihai Chira
> It appears that flex-sdk_test uses the flex-flexunit build on the CI > server. Does that mean the flex-flexunit build is not configured to > produce the right artifacts for Flex customers. If so, that should > probably get fixed. flex-flexunit does produce both

Re: a new spriteflexjs test

2015-12-17 Thread Mihai Chira
pretty cool, nice work! 2015-12-17 12:26 GMT+02:00 Carlos Rovira : > Wow! :) > > 2015-12-17 9:19 GMT+01:00 Harbs : > >> Very cool! >> >> On Dec 17, 2015, at 7:42 AM, lizhi wrote: >> >> > >>

Re: [1/8] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34958 Initial bugs fixed in 4.15 - may be missing a couple

2015-12-16 Thread Mihai Chira
I'd say FLEX-34879, FLEX-34927, FLEX-34941, FLEX-34945 and FLEX-34852 are features rather than bugs. I'm happy to move them up if it's agreed. Also, FLEX-34883 and FLEX-34884 are sub-tasks of FLEX-34852 - do we always include sub-tasks? If so, there are a couple more to add, and if not, I can

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-16 Thread Mihai Chira
Yay! Thank you. On 10 December 2015 at 17:52, Alex Harui <aha...@adobe.com> wrote: > > > On 12/10/15, 1:00 AM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: > >>Finding "FAIL: .*Sort" in the old reports highlights about 21 lines, >>and in

Re: Jenkins build is still unstable: flex-sdk_test #432

2015-12-16 Thread Mihai Chira
The two test classes still failing are ones I wrote. They're failing because UIImpersonator doesn't work correctly, which is a big hint that in Jenkins we're using a version of FlexUnit that was compiled for pure AS development, instead of for Flex development. In March Chris offered to release

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-10 Thread Mihai Chira
Thanks for sticking with it. I have my fingers crossed. > > -Alex > > On 12/8/15, 7:58 AM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: > >>Just pushed another commit. Locally all the mustella tests in the >>spark/Collections/Sort/Other are now passing, fingers

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-08 Thread Mihai Chira
r spark counterparts. This meant that a change to one had to be reflected in the other, which usually didn't happen. It also meant that tests would have needed duplication as well, etc). On 3 December 2015 at 15:51, Mihai Chira <mihai.ch...@gmail.com> wrote: > In the end it's an improvement

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-03 Thread Mihai Chira
About to commit and push a fix for this in the next hour. (It took me so long because my HDD had bad sectors which caused lots of pain in the last few days.) On 24 November 2015 at 18:03, Alex Harui <aha...@adobe.com> wrote: > > > On 11/24/15, 8:41 AM, "Mihai Chira" <

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-03 Thread Mihai Chira
ks, -Alex > > On 12/3/15, 6:01 AM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: > >>About to commit and push a fix for this in the next hour. (It took me >>so long because my HDD had bad sectors which caused lots of pain in >>the last few days.) >> >>O

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-11-24 Thread Mihai Chira
e stable and we're trying to clean > up failures and get a release out. Can you find some time to look at the > sort failures again? > > Thanks, > -Alex > > On 7/18/15, 12:39 PM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: > > >Yep, it's pret

Re: do-while-false

2015-11-20 Thread Mihai Chira
+1, as a class getter, an internal function, or even a local variable with a descriptive name. On 19 November 2015 at 09:44, Justin Mclean wrote: > Hi, > > I prefer: > > if (giveItName()) { > …. > } > > giveItName() { > return condition1 && condition2 &&

Re: Build failed in Jenkins: flex-sdk #884

2015-10-21 Thread Mihai Chira
i, can you fix the build? It looks like an import statement got > >deleted. > > > >-Alex > > > >On 10/21/15, 8:49 AM, "flex.ci.bui...@gmail.com" > ><flex.ci.bui...@gmail.com> wrote: > > > >>See <http://apacheflexbuild.cloudapp.

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34876 Added/fixed tests

2015-10-21 Thread Mihai Chira
Harbs, in relation to FLEX-34807, I don't understand the change you made to FLEX_34807_Test.as: why is it expected that a new line will be added when pasting text? Or is it something to do with the exporting to plain text that requires it? Otherwise I'd see it as a bug, not as expected behaviour.

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-10-11 Thread Mihai Chira
bump. I will be away next week, so I can check your code when I return, from the 20th. If you could take a look at it until then it would be great. Thank you! On 2 October 2015 at 14:53, Harbs <harbs.li...@gmail.com> wrote: > I will take a look next week. > > On Oct 2, 2015, at

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-10-04 Thread Mihai Chira
Nice, thank you. On 2 October 2015 at 13:53, Harbs <harbs.li...@gmail.com> wrote: > I will take a look next week. > > On Oct 2, 2015, at 3:49 PM, Mihai Chira <mihai.ch...@gmail.com> wrote: > >>> still the problem that the pasted text adds a new line (or a new

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-10-02 Thread Mihai Chira
> still the problem that the pasted text adds a new line (or a new > paragraph, resulting in a new line when exported to plain text). Harbs, the fatal error is gone, which is great. Would you have time these days to take a look at this regression? (Or whether it is a regression in the first

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-10-02 Thread Mihai Chira
Thanks for the detailed steps. If I ever need to debug tlf unit tests again and the browser won't work it's great to have an alternative. On 23 September 2015 at 06:42, piotrz wrote: > Mihai, > > This is the projects [1] which you have to import to intellij in order to

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-22 Thread Mihai Chira
Hi Piotr, no worries, I found the reason why Firefox was closing unexpectedly: when ran from ant, the ant task tries to make sure the browser is closed once it finishes analysing the results. So then I could just refresh the VellumUnit page in Firefox (rather than run it from ant) and debug

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-22 Thread Mihai Chira
September 2015 at 12:06, Harbs <harbs.li...@gmail.com> wrote: > You probably have the timeout set in Firefox and need to disable it. Check > this: > https://support.mozilla.org/en-US/questions/705051 > > On Sep 22, 2015, at 12:44 PM, Mihai Chira <mihai.ch...@gmail.com&g

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-22 Thread Mihai Chira
I realise that I'm making the assumption that my latest tlf sources are used (which include your fix), although I'm not sure if that's true. (I think it is, because the fatal in the bug itself seems to not be thrown.) On 22 September 2015 at 12:55, Mihai Chira <mihai.ch...@gmail.com> wrot

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-22 Thread Mihai Chira
That's great to know, Piotr. Yes, I was debugging using ant, and with Alex's suggestion (thanks!) I could get the test to run in Firefox, to which I could connect with a remote debugging session. The problem is, most times the browser simply shuts down in the middle of debugging, which isn't a way

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-22 Thread Mihai Chira
spatcher/dispatchEventFunction() at flash.events::EventDispatcher/dispatchEvent() at flash.utils::Timer/tick() On 22 September 2015 at 12:31, Mihai Chira <mihai.ch...@gmail.com> wrote: > It's not that. The whole of Firefox shuts down (without warning, as if > I had closed it), not just the plugin. Same

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34807

2015-09-21 Thread Mihai Chira
ything in one line while > keeping the declaration at the beginning of the line). > > It might be a bit confusing the first time you see it, but I think it’s > pretty easy to read once you are familiar with the style. > > On Sep 21, 2015, at 12:46 PM, Mihai Chira <mihai.ch...@g

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-21 Thread Mihai Chira
that IE is not my default browser, but the tests still open in it.) [1] https://forums.adobe.com/message/7922164#7922164 On 21 September 2015 at 11:43, Mihai Chira <mihai.ch...@gmail.com> wrote: > Thanks Piotr. I was just looking at a few of the tests now, and the > ones I can find with Pa

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-21 Thread Mihai Chira
Thanks Piotr. I was just looking at a few of the tests now, and the ones I can find with PasteOperation are UnitTest.Tests.OperationTest.limitPasteTest() and deleteNextCharExceptionTest(), but they are both a bit confusing: the functions are marked private, and the only other references to them

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34807

2015-09-21 Thread Mihai Chira
Is this line only confusing for me? var destinationParagraph:ParagraphElement = destinationLeaf ? destinationLeaf.getParagraph() : destinationParagraph; Is this the intention? if (destinationLeaf) destinationParagraph = destinationLeaf.getParagraph(); On 19 September 2015 at 21:52,

Re: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-20 Thread Mihai Chira
not normalized which it now (sort-of) is.. > > On Sep 9, 2015, at 7:37 PM, Mihai Chira <mihai.ch...@gmail.com> wrote: > > > Hey guys (addressed to Piotr and Harbs), > > > > if you have time to take a look at this, it would really help. I have > > a f

Re: Fwd: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-19 Thread Mihai Chira
bump On 9 Sep 2015 18:37, "Mihai Chira" <mihai.ch...@gmail.com> wrote: > Hey guys (addressed to Piotr and Harbs), > > if you have time to take a look at this, it would really help. I have > a feeling you'd have much better ideas on how to go forward wit

Fwd: [jira] [Comment Edited] (FLEX-34807) TLF - EditManager - TextFlowEdit -insertTextScrap

2015-09-09 Thread Mihai Chira
Hey guys (addressed to Piotr and Harbs), if you have time to take a look at this, it would really help. I have a feeling you'd have much better ideas on how to go forward with the fix. Many thanks! -- Forwarded message -- From: Mihai Chira (JIRA) <j...@apache.org> D

flex-tool-api.jar and optimizer.jar missing

2015-07-23 Thread Mihai Chira
For a while now, running `ant` in the flex sdk root fails with this message: modules\compiler\build.xml:171: Warning: Could not find file C:\Users\user\workspace\flex-sdk\in\flex-tool-api.jar to copy. I then tried running `ant frameworks-rsls`, which then gives me Error: Unable to access jarfile

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-23 Thread Mihai Chira
at 07:15, Alex Harui aha...@adobe.com wrote: On 7/18/15, 3:05 PM, Mihai Chira mihai.ch...@gmail.com wrote: The swf should hit breakpoints in the sort code. Is it not doing that? I could only break the app on the constructors of UnitTester and TestCase. Nothing in SortField or Sort (I didn't

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-18 Thread Mihai Chira
. Do I need to change the code to get it to execute somehow (maybe using that static function init()?), and then regenerate the SWF? On 18 July 2015 at 21:39, Mihai Chira mihai.ch...@gmail.com wrote: Yep, it's pretty clear which ones are still failing. I'm looking, for instance

Re: Can we unify spark and mx Sort and SortField?

2015-07-18 Thread Mihai Chira
Thanks for working on it. What is it using instead of sortOn? Array.sort(compareFunction) BTW, the build failed some sort tests. See a recent set of results. thanks for the heads up. Some are fixed, and some I'm now struggling to debug (more details in the thread called git commit: [flex-sdk]

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-18 Thread Mihai Chira
The swf should hit breakpoints in the sort code. Is it not doing that? I could only break the app on the constructors of UnitTester and TestCase. Nothing in SortField or Sort (I didn't test the constructors, just other methods that should have been called - even if the bug was still there, that

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-18 Thread Mihai Chira
that some day to see if it works for him as well. -Alex On 7/17/15, 3:16 AM, Mihai Chira mihai.ch...@gmail.com wrote: Cool, thanks for the link. I'll take a look tonight or tomorrow at the results. On 16 Jul 2015 22:53, Alex Harui aha...@adobe.com wrote: The link at [1] is the build server

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-17 Thread Mihai Chira
. -Alex On 7/16/15, 1:48 PM, Mihai Chira mihai.ch...@gmail.com wrote: At least one of the failures should now be fixed. If others are left, I'll tackle them in the next few days. How can I monitor the test results? The bookmark I have for the build server is this[1] and it doesn't seem

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-16 Thread Mihai Chira
changes. Can you take a look? on it

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-16 Thread Mihai Chira
://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_test/ On 16 July 2015 at 21:52, Mihai Chira mihai.ch...@gmail.com wrote: changes. Can you take a look? on it

Re: Can we unify spark and mx Sort and SortField?

2015-06-21 Thread Mihai Chira
project it would be ace. Also, does anyone know why spark.collections.Sort didn't use Array.sortOn in the sort() function? If not, does anyone see a problem if I add it? [1] http://imgur.com/yB6HEz5 On 10 June 2015 at 14:58, Mihai Chira mihai.ch...@gmail.com wrote: That's very useful Peter, many

Re: Can we unify spark and mx Sort and SortField?

2015-06-10 Thread Mihai Chira
Great points, thanks all. Does anyone know how I can check which swcs are included in mx-only projects and which in spark-only projects, so I can see where I can put the common functionality if that's the route I / we'll choose? Thanks. On 10 June 2015 at 12:40, Kessler CTR Mark J

Re: Can we unify spark and mx Sort and SortField?

2015-06-10 Thread Mihai Chira
functionality used in both sets. regards, Peter On 10/06/2015 12:59, Mihai Chira wrote: Great points, thanks all. Does anyone know how I can check which swcs are included in mx-only projects and which in spark-only projects, so I can see where I can put the common functionality

Re: Why are there two ArrayList classes? [PING Justin Mclean)

2015-06-09 Thread Mihai Chira
(Carol Frampton committed it against an Adobe ticket SDK-30008) this is in our FLEX-27127[1] ticket [1] https://issues.apache.org/jira/browse/FLEX-27127

Re: Why are there two ArrayList classes? [PING Justin Mclean)

2015-06-09 Thread Mihai Chira
I just looked quickly at the differences. It appears that the second ArrayList has different update event logic so it may be that it was safer to create a different ArrayList so we wouldn’t have to worry about backward compatibility issues. If we're talking about the same classes

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34885 While trying to figure out whether ComplexFieldChangeWatcher should handle CollectionEventKind.UPDATE events, I stumbled on this

2015-06-09 Thread Mihai Chira
: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/2779ea9f Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/2779ea9f Branch: refs/heads/develop Commit: 2779ea9f32e8053edd3bc2620ccfbc37f52c3eba Parents: 97e625a Author: Mihai Chira mih...@apache.org Authored: Tue Jun 9 10:21:18 2015

Can we unify spark and mx Sort and SortField?

2015-06-09 Thread Mihai Chira
I'm making lots of changes to SortField and Sort, and I'm realising that having two versions of these files is error prone and duplicates effort. From what I can see, the differences are: Between mx.collections.SortField and spark.collections.SortField: 1. lots of asdocs changes 2. spark version

Re: Why are there two ArrayList classes? [PING Justin Mclean)

2015-06-09 Thread Mihai Chira
http://apache-flex-development.247.n4.nabble.com/ArrayList-itemUpdateHandler-Change-td7774.html Mike, you mention here If you look at the unit tests I wrote for ArrayList - do you mean the Mustella tests, or are there unit tests too?

Re: Can we unify spark and mx Sort and SortField?

2015-06-09 Thread Mihai Chira
base classes. -Alex On 6/9/15, 5:48 AM, Peter Ginneberge p.ginnebe...@gmail.com wrote: This may affect mx only projects (in FB at least) where spark related swc's are removed when selecting mx only as the project's component set. On 9/06/2015 13:33, Mihai Chira wrote: I'm making lots

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34885 While trying to figure out whether ComplexFieldChangeWatcher should handle CollectionEventKind.UPDATE events, I stumbled on this

2015-06-09 Thread Mihai Chira
Thanks, it's fixed (at least on the mx side). On 9 June 2015 at 21:08, Alex Harui aha...@adobe.com wrote: Good luck. -Alex On 6/9/15, 1:25 AM, Mihai Chira mih...@apache.org wrote: Just want to make sure that everyone thinks this is a bug? I think it is because

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-06-08 Thread Mihai Chira
. On 7 June 2015 at 18:26, Mihai Chira (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/FLEX-34852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mihai Chira updated FLEX-34852: --- Description: Currently

Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields with all data types

2015-06-08 Thread Mihai Chira
Thanks, I'll take a look in a while, when I work on this again. On 8 June 2015 at 00:43, Justin Mclean jus...@classsoftware.com wrote: Hi, This may be of some help: http://people.apache.org/~jmclean/ArrayCollectionTests.fxp Justin

Re: [1/8] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34852 Added unit test (actually moved the first function from ListCollectionView_FLEX_34837_Tests, as it's better suited for this ticket).

2015-06-08 Thread Mihai Chira
Great, thank you. On 8 June 2015 at 05:44, piotrz piotrzarzyck...@gmail.com wrote: Done. :) From my experience 90% of VO objects which I have created was Bindable in 100%. Although if for some reason some at least one property wasn't bindable I was going that grained path as you Mihai. :)

Re: [1/8] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34852 Added unit test (actually moved the first function from ListCollectionView_FLEX_34837_Tests, as it's better suited for this ticket).

2015-06-07 Thread Mihai Chira
-us.apache.org/repos/asf/flex-sdk/commit/7cd1b3bc Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7cd1b3bc Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7cd1b3bc Branch: refs/heads/develop Commit: 7cd1b3bc69f11c6c9d88a65e0df9eae39a17afa3 Parents: 11489c6 Author: Mihai Chira mih

Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields with all data types

2015-06-07 Thread Mihai Chira
tested, nor is sorting alongside filtering. [1] https://issues.apache.org/jira/browse/FLEX-34852 On 7 June 2015 at 18:27, Mihai Chira (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/FLEX-34883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-06-07 Thread Mihai Chira
I’m a little concerned that someone somewhere is relying on sharing a mutable SortField, so I’d be careful about making a change like that. At least, add an mx_internal flag to get back old behavior so if someone does complain they have a way of recovering. Great idea. In the end I decided to

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-06-07 Thread Mihai Chira
I would add a flag to get the new behavior or add a new set of Sort classes with the new behavior. Now implemented, see ComplexSortField.as. This was the only class necessary, at least on the mx side, plus a few changes to SortField (no API changes). If things look all right, I'll apply the

Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-06-07 Thread Mihai Chira
Hi Fréd, thanks for your suggestion. (I responded inline.) I have to admit I'm not very keen to see an already overly complex class to become even more complex adding complex field managment. Me neither, I agree. I was thinking to add the field watcher as an optional constructor parameter /

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Mihai Chira
collection.sort but nothing happens until the call refresh(). This is helpful if you have to make several changes to the sort (rather than just a one line change to sort.fields) as it avoids multiple re-sorts on a partially set up sort. that's true, and in the vast majority of cases it can

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-05-22 Thread Mihai Chira
“complexSortEnabled” and switch between old behavior and new behavior that way? I don’t think you can just presume that “.” means complex field in case folks are sorting on a field name that just happens to have a “.” in it. -Alex On 5/22/15, 7:58 AM, Mihai Chira mihai.ch...@gmail.com wrote

Re: [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

2015-05-22 Thread Mihai Chira
once the fields change. To me, though, it's not reason enough to keep this potential for runtime errors. Thoughts? On 22 May 2015 at 16:19, Mihai Chira (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/FLEX-34853?page=com.atlassian.jira.plugin.system.issuetabpanels:all

Re: [jira] [Updated] (FLEX-34852) Allow sorting by complex fields in ListCollectionView

2015-05-22 Thread Mihai Chira
-then-review process. On 22 May 2015 at 16:34, Mihai Chira (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/FLEX-34852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mihai Chira updated FLEX-34852

  1   2   3   >