Re: ASDocs issue

2013-10-11 Thread Justin Mclean
Hi, Did you push the other ASDoc fixes required to get to this problem? Yes in the release branch. But the release branch is merged with develop so you should see it there as well. Some minor stuff like missing imports for Falcon and some improvements for SWFDump, but also: FLEX-33690

Re: ASDocs issue

2013-10-11 Thread Alex Harui
On 10/10/13 10:59 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, Did you push the other ASDoc fixes required to get to this problem? Yes in the release branch. But the release branch is merged with develop so you should see it there as well. Hmm. I'll rebuild develop and see. None of

Re: ASDocs issue

2013-10-11 Thread Justin Mclean
Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me.

Re: ASDocs issue

2013-10-11 Thread Alex Harui
On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've

Re: ASDocs issue

2013-10-11 Thread Justin Mclean
Hi, Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Day is already over for me. Any help would be appreciated. OK, pushed and merged (I think). Yep. looks good. Mind updating the RELEASE_NOTES? Thanks, Justin

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
Hi Justin, I have created a test subdirectory in asdoc containing this single file and also build_test.xml so that I can quickly quickly changes to the asdoc compiler or templates Without having to run through the whole SDK classes asdocs (while I was working on the experimental asdoc

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
 : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
to recover that lost changes by hand. Any idea ? Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 10:13 À : dev@flex.apache.org Objet : RE: ASDocs issue Actually, the problem comes from asdoc build.xml It's

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
This is because original spark AnimationTarget is marked as internal, and that's probably why it was duplicated in experimental, to make it public. Since the redundant class was removed from experimental, the original internal class cannot be accessed anymore. I has changed spark AnimationTarget

Re: ASDocs issue

2013-10-11 Thread Tom Chiverton
09:48 À : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
Thanks, I will do. -Message d'origine- De : Tom Chiverton [mailto:t...@extravision.com] Envoyé : vendredi 11 octobre 2013 10:46 À : dev@flex.apache.org Objet : Re: ASDocs issue Check the web view of the branch e.g. https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
, to understand what went wrong. Maurice -Message d'origine- De : Maurice Amsellem Envoyé : vendredi 11 octobre 2013 11:04 À : dev@flex.apache.org Objet : RE: ASDocs issue Thanks, I will do. -Message d'origine- De : Tom Chiverton [mailto:t...@extravision.com] Envoyé : vendredi 11

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 11:07 À : dev@flex.apache.org Objet : RE: ASDocs issue I have fixed the issue with AnimationTarget, and experimental manifest and now Experimental.swc and asdoc are compiling ok. Didn't commit yet. However, I noticed

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
Committed to : https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commit;h=5ae5a847 -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 12:10 À : dev@flex.apache.org Objet : RE: ASDocs issue However, I noticed

Re: ASDocs issue

2013-10-11 Thread Justin Mclean
Hi, Status: - build is OK - asdoc build is OK (no error) - asdoc content looks good. Much appreciated for sorting that out. Thanks, Justin

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
You're welcome. My configuration being a little tweaked (with .gitignored files), can you please double check ... Maurice -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : vendredi 11 octobre 2013 13:01 À : dev@flex.apache.org Objet : Re: ASDocs

Re: ASDocs issue

2013-10-11 Thread Justin Mclean
Hi, My configuration being a little tweaked (with .gitignored files), can you please double check ... You might want to not check in changes to flex-sdk-description.xml but other than that all good from what I can see. Thanks, Justin

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
Ah, OK sorry for that one. I will add it to my .gitignore. Maurice -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : vendredi 11 octobre 2013 14:57 À : dev@flex.apache.org Objet : Re: ASDocs issue Hi, My configuration being a little tweaked

Re: ASDocs issue

2013-10-11 Thread Justin Mclean
Hi, Ah, OK sorry for that one. I will add it to my .gitignore. I wouldn't do that, sometime it does need to change and if someone else changes it you'll need to update it. Justin

RE: ASDocs issue

2013-10-11 Thread Maurice Amsellem
Ok, I will add it to .ignoreButKeepAnEyeOnIt file :-) -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : vendredi 11 octobre 2013 23:29 À : dev@flex.apache.org Objet : Re: ASDocs issue Hi, Ah, OK sorry for that one. I will add it to my .gitignore. I

Re: ASDocs issue

2013-10-10 Thread Justin Mclean
Hi, Looks like an issue with the asdocs build file - just trying to sort. Justin

Re: ASDocs issue

2013-10-10 Thread Justin Mclean
Hi, Fixed that issue (and a few more) but now have this one: doc: [asdoc] Loading configuration file /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/flex-config.xml [asdoc]

Re: ASDocs issue

2013-10-10 Thread Alex Harui
On 10/10/13 8:21 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, Fixed that issue (and a few more) but now have this one: doc: [asdoc] Loading configuration file /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/flex-config.xml [asdoc]

Re: ASDocs issue

2013-10-10 Thread Justin Mclean
Hi, I assume you meant ViewMenuLayout? The manifests, etc look ok. Yep I meant ViewMenuLayout. I guess you could dump the mobilecomponents.swc and see if that class is actually in there It;s in there: swfdump ./mobile/mobilecomponents.swc | grep ViewMenuLayout DoABC2

Re: ASDocs issue

2013-10-10 Thread Alex Harui
On 10/10/13 10:22 PM, Justin Mclean jus...@classsoftware.com wrote: but the main build should have failed in the same way. It compiles no issues. Did you push the other ASDoc fixes required to get to this problem? I just ran ant asdoc and got the AnimationTarget issue. I have a fix for

Re: ASDocs issue

2013-10-10 Thread Alex Harui
The TLF change is part of https://issues.apache.org/jira/browse/FLEX-33409 On 10/10/13 10:44 PM, Alex Harui aha...@adobe.com wrote: On 10/10/13 10:22 PM, Justin Mclean jus...@classsoftware.com wrote: but the main build should have failed in the same way. It compiles no issues. Did you push