Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Peter Ent
The osmf download still fails for me. I tried Java 1.8 and Java 1.7 since someone in an email thread said that seemed to be the issue. I am going on vacation for the US Thanksgiving holiday and will be back next week. Regards, Peter On 11/15/17, 4:16 AM, "Piotr Zarzycki"

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Piotr Zarzycki
Hi Peter, Too bad! I will take a look into that. It seems that this release is going to take much longer. I'm wondering why Alex didn't have such problems... Happy Thanksgiving! Piotr 2017-11-20 19:41 GMT+01:00 Peter Ent : > The osmf download still fails for me. I

Re: [VOTE] Release Apache Flex SDK 4.16.1 - RC2

2017-11-20 Thread Peter Ent
-1 ApproveSDK.xml I used both Java 1.8 and Java 1.7. The script fails on the osmf.xml download again. macOS 10.12.6 Peter Ent On 11/15/17, 4:15 AM, "Piotr Zarzycki" wrote: >Hi Folks, > >This is a Apache Flex SDK 4.16.1 release candidate 2 Please see the

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Piotr Zarzycki
I did exactly what Alex saying and it resolve my problems. I just thought right now that it may be something else in Peter's case. Let's wait to his info having your email. Thanks, Piotr 2017-11-20 19:54 GMT+01:00 Alex Harui : > Peter and others, if you are going to

Re: [VOTE] Release Apache Flex SDK 4.16.1 - RC2

2017-11-20 Thread Peter Ent
+1 The problem on my part which caused the failure of the installation. Once corrected the install completed and I was able to verify it. Regards, Peter On 11/20/17, 1:40 PM, "Peter Ent" wrote: >-1 > >ApproveSDK.xml >I used both Java 1.8 and Java 1.7. The script fails

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Peter Ent
That was the problem. I guess I forgot to install that; lots of parts to get Apache Royale going, that's for sure. ‹peter On 11/20/17, 1:54 PM, "Alex Harui" wrote: >Peter and others, if you are going to test this release, you will probably >need the JCE upgrade.

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, Looks like we may still have some unicode issues. Some that are likely to cause issues: Comparing the source release to a clean checked out repo: file apache-flex-sdk-4.16.1-src/licenseParts/saxon9-NOTICES/UNICODE.txt apache-flex-sdk-4.16.1-src/licenseParts/saxon9-NOTICES/UNICODE.txt:

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, > diff -w -r > apache-flex-sdk-4.16.1-src/frameworks/projects/framework/bundles/en_GB/SharedResources.properties > > /Users/justinmclean/flex-sdk/frameworks/projects/framework/bundles/en_GB/SharedResources.properties > 39c39 > < currencySymbol=� > --- >> currencySymbol= Just confirmed

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Alex Harui
I am not an expert on code pages and what the consumers of these files are expecting. I believe that if we ensure that all source files are in UTF-8, we will be better off, but Windows is a strange place, and how Ant and Maven and Java interact with various code pages on Windows is a potential

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, > I have so far more +1 than -1 so I can release it, but wondering how to fix > it for the next release. For a release you need at least 3 +1 binding votes and more +1’s than -1’s. Currently by my count there’s two +2 and one -1. Piotr you could vote +1 and make this a release. However

Re: [VOTE] Release Apache Flex SDK 4.16.1 - RC2

2017-11-20 Thread Justin Mclean
Hi, -1 binding because of locale issues. I checked: - hashes and signatures correct - LICENSE and NOTICE good - no unexpected binary files - all source file has ASF header where needed - can compile from source Tried a few simple tests and while most worked but we are still having locale

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Piotr Zarzycki
Hi, Just the opposite. I have compiled your example with 4.16 and 4.15 and we have exactly same issue. Thanks, Piotr 2017-11-21 7:03 GMT+01:00 Justin Mclean : > Hi, > > > It looks like this was also a problem in 4.16.0. Can you confirm? > > Doesn’t look like it from a

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Piotr Zarzycki
Justin, Please raise jira issue. I'm going to move forward with release, cause it's existing issue and it's probably with us for a long time. Does any user raise that problem ? Thanks, Piotr 2017-11-21 7:20 GMT+01:00 Justin Mclean : > Hi, > > > Perhaps the

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, > Please raise jira issue. I'm going to move forward with release, cause it's > existing issue and it's probably with us for a long time. AFAIKS this is not an existing issue but a new issue. Looking at the comparison of 4.16.0 to what's in version control they match. 4.16.1 doesn’t match

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, > Please raise jira issue. Will do. > I'm going to move forward with release, cause it’s existing issue and it's > probably with us for a long time. Does any user > raise that problem ? No user has raised an issue for pound sign not showing that I could find. BTW I’ve used en_GB in the

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, > Btw your example failed for me with error [2], so I moved formatter > to declarations - Didn't you have such error ? No error here. Not checked but I think that only happens if you use a s:Application rather than an mx:Application. Thanks, Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Alex Harui
It looks like this was also a problem in 4.16.0. Can you confirm? -Alex On 11/20/17, 8:58 PM, "Justin Mclean" wrote: >Hi, > >> diff -w -r >>apache-flex-sdk-4.16.1-src/frameworks/projects/framework/bundles/en_GB/Sh >>aredResources.properties

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, > It looks like this was also a problem in 4.16.0. Can you confirm? Doesn’t look like it from a quick look but I’ve not tried to compile against it (yet). 4.16.1 vs VC gives: diff -w -r *src ~/flex-sdk | grep currencySymbol < currencySymbol= > currencySymbol=? 4.16.0 vs VC gives no

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, > Perhaps the SharedResources.properties has been incorrectly converted to > UTF-8 when it actually should be ISO-8859? (The pound sign is character 163.) > Perhaps we have a mix of text encodings for resource files? Answer yes and it’s a bit of a mess. In version control we have resource

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Piotr Zarzycki
Alex, What do you mean by this "I think there are code page issues in the source files." ? I have so far more +1 than -1 so I can release it, but wondering how to fix it for the next release. Thanks, Piotr 2017-11-21 7:17 GMT+01:00 Alex Harui : > My suggestion is to

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Justin Mclean
Hi, > My suggestion is to vote +1 and ship this release since this is not a new > issue. And I'd suggest fixing this before making a release. But if the release gets three +1 votes and more +1’s than -1’s then that’s a release. > I think there are code page issues in the source files.

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Piotr Zarzycki
Justin, I just build your example with 4.16 and have same issue [1] - My console build. Btw your example failed for me with error [2], so I moved formatter to declarations - Didn't you have such error ? [1] https://paste.apache.org/DzmO [2] https://paste.apache.org/YXdl Thanks, Piotr

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC2*

2017-11-20 Thread Alex Harui
Peter and others, if you are going to test this release, you will probably need the JCE upgrade. Piotr already mentioned it in the RC1 discussion. Java 8: http://www.oracle.com/technetwork/java/javase/downloads/jce8-download-21331 66.html Java 7: