RE: [FlexJS] OneFlexibleChildVerticalLayout

have been nice if we had a proper unit test for layouts… Thanks, Yishay From: Peter Ent<mailto:p...@adobe.com> Sent: Monday, April 3, 2017 4:46 PM To: dev@flex.apache.org<mailto:dev@flex.apache.org> Subject: Re: [FlexJS] OneFlexibleChildVerticalLayout Hi, I believe I hav

Re: [FlexJS] OneFlexibleChildVerticalLayout

Hi, I believe I have fixed part of the problem. Please refresh your copy of feature/chart-work. There was a problem with the OneFlexibleChildVerticalLayout. However, there is also another problem, but that might take longer to resolve. In the meantime, leave your example exactly as you have it.

Re: [FlexJS] OneFlexibleChildVerticalLayout

Something is not right with the layouts. I'm looking into it today. ‹peter On 4/3/17, 2:43 AM, "yishayw" wrote: >I just tested the test case upthread on feature/chart-work and I'm getting >the same problem. 'cont2' does not get sized and is not shown. > > > >-- >View

Re: [FlexJS] OneFlexibleChildVerticalLayout

I just tested the test case upthread on feature/chart-work and I'm getting the same problem. 'cont2' does not get sized and is not shown. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-OneFlexibleChildVerticalLayout-tp60953p60975.html Sent from the

Re: [FlexJS] OneFlexibleChildVerticalLayout

I tried using the feature/chart branch but since our project uses mdl, I'm getting a runtime error. So it's difficult to test. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-OneFlexibleChildVerticalLayout-tp60953p60966.html Sent from the Apache

Re: [FlexJS] OneFlexibleChildVerticalLayout

Yes - In the feature/chart-work branch it is not. That was an oversight on my part. As soon as I get MDL framework back up and running I think I can safely merge my feature branch into develop, but I will give you all time to do a final check. ‹peter On 4/2/17, 9:33 AM, "Harbs"

Re: [FlexJS] OneFlexibleChildVerticalLayout

It looks like the problem is that layoutViewAfterContentLayout(); is now wrapped in a COMPILE::SWF block. > On Apr 2, 2017, at 8:56 AM, yishayw wrote: > > Peter Ent wrote >> >> >> >> >> >> >> The VerticalLayout will not resize the Container to fit the content. The

Re: [FlexJS] OneFlexibleChildVerticalLayout

Peter Ent wrote > > > > > > > The VerticalLayout will not resize the Container to fit the content. The > Container (actually, GroupView), will do that after it runs the layout. So > if you are seeing that a container is NOT sizing to fit its content - > that's a bug. That seems to be

Re: [FlexJS] OneFlexibleChildVerticalLayout

Hi - just saw this (Sunday morning here). When you use the "flexible" layouts, you don't need percent sizing. If you do put explicit or percent sizing in, the layout code (SWF side) probably won't do the right thing with it and I'd have to see what HTML does with it. I'm still understanding the

Re: [FlexJS] OneFlexibleChildVerticalLayout

That works for the test case, but in our real case we have a toolbar container which lays its children out horizontally and sizes its height according to its child buttons. Changing the layout to VerticalFlexLayout doesn't seem right... -- View this message in context:

Re: [FlexJS] OneFlexibleChildVerticalLayout

Hi Harbs, Adding to "cont2" VerticalFlexLayout [1] bead will work in that case, but not sure whether it is acceptable for you. [1] https://paste.apache.org/aBPD Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] OneFlexibleChildVerticalLayout

Yes. That’s what used to happen in the old layouts. > On Apr 2, 2017, at 6:23 AM, piotrz wrote: > > Yishay, > > You are expecting that "cont2" will be expanded by his child container which > has height="20" ? > > Piotr > > > > - > Apache Flex PMC >

Re: [FlexJS] OneFlexibleChildVerticalLayout

Yishay, You are expecting that "cont2" will be expanded by his child container which has height="20" ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] OneFlexibleChildVerticalLayout

Yes, Harbs and I inspected the HTML and container sizes are no longer sized to content, which makes this test app fail. I'm wondering what Peter has in mind to help us make sizing to content work. -- View this message in context:

Re: [FlexJS] OneFlexibleChildVerticalLayout

Hi Yishay, I think cause height of "cont2" is 0, when I add some height it appears. I checked it with Peter's branch "feature/chart-work" Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: