Re: ASDocs issue
Hi, Did you push the other ASDoc fixes required to get to this problem? Yes in the release branch. But the release branch is merged with develop so you should see it there as well. Some minor stuff like missing imports for Falcon and some improvements for SWFDump, but also: FLEX-33690 https://issues.apache.org/jira/browse/FLEX-33690 (overlapping windows and focus) FLEX-33678 https://issues.apache.org/jira/browse/FLEX-33678 (scrollbar issue in DG) FLEX-33052 https://issues.apache.org/jira/browse/FLEX-33052 (charts in modules) Sounds fine to me, update the RELEASE_NOTES as well if you can. Thanks, Justin
Re: ASDocs issue
On 10/10/13 10:59 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, Did you push the other ASDoc fixes required to get to this problem? Yes in the release branch. But the release branch is merged with develop so you should see it there as well. Hmm. I'll rebuild develop and see. None of the commit emails I see from you seem to mention develop branch. If that doesn't work I'll switch branches and try the release branch. Some minor stuff like missing imports for Falcon and some improvements for SWFDump, but also: FLEX-33690 https://issues.apache.org/jira/browse/FLEX-33690 (overlapping windows and focus) FLEX-33678 https://issues.apache.org/jira/browse/FLEX-33678 (scrollbar issue in DG) FLEX-33052 https://issues.apache.org/jira/browse/FLEX-33052 (charts in modules) Sounds fine to me, update the RELEASE_NOTES as well if you can. Do you know the best way to handle this given they've been committed to my local develop branch? Should I just push everything to develop then merge all of it to release? Anything I have to watch out for? Thanks, -Alex
Re: ASDocs issue
Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. Thanks, Justin
Re: ASDocs issue
On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other failures like this. Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. OK, pushed and merged (I think). Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. I'm about to shut down for the night. I'll see what the mustella runs report in the morning. Thanks, -Alex
Re: ASDocs issue
Hi, Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Day is already over for me. Any help would be appreciated. OK, pushed and merged (I think). Yep. looks good. Mind updating the RELEASE_NOTES? Thanks, Justin
RE: ASDocs issue
Hi Justin, I have created a test subdirectory in asdoc containing this single file and also build_test.xml so that I can quickly quickly changes to the asdoc compiler or templates Without having to run through the whole SDK classes asdocs (while I was working on the experimental asdoc changes). I thought it could be useful for other people so I committed it. I have just added the missing header and committed/pushed to develop. Maurice -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : vendredi 11 octobre 2013 04:16 À : dev@flex.apache.org Objet : ASDocs issue Hi, Looks like this file is showing up in ASdocs: SampleExperimental.as Should that be the case? and if so why is it missing an Apache header? Thanks, Justin
RE: ASDocs issue
I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other failures like this. Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. OK, pushed and merged (I think). Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. I'm about to shut down for the night. I'll see what the mustella runs report in the morning. Thanks, -Alex
RE: ASDocs issue
I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin) have reappeared when I merged from origin. I don't know what went wrong. I can make sure the asdoc build works again on my side and recommit/push the changes to origin. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:39 À : dev@flex.apache.org Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other failures like this. Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. OK, pushed and merged (I think). Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. I'm about to shut down for the night. I'll see what the mustella runs report in the morning. Thanks, -Alex
RE: ASDocs issue
Actually, the problem comes from asdoc build.xml It's referencing (line 150 and 168 the namespace library://ns.adobe.com/flex/spark-mobilecomponents which does not exist) As far as I know, mobile components are also in the regular spar namespace (library://ns.adobe.com/flex/spark) Since mobile components and spark components are referenced in a different manifest file in the asdoc build (166 and 168). it's legal that they use the same namespace. It shouldn't cause any collision or overlap. So I made the change above, and now I have the AnimationTarget compilation error :-(. Regarding this error, it's because AnimationTarget (which has been removed from experimental, as it was redundant with spark) has mysteriously reappeared . Trying to fix -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:48 À : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin) have reappeared when I merged from origin. I don't know what went wrong. I can make sure the asdoc build works again on my side and recommit/push the changes to origin. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:39 À : dev@flex.apache.org Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other failures like this. Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. OK, pushed and merged (I think). Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. I'm about to shut down for the night. I'll see what the mustella runs report in the morning. Thanks, -Alex
RE: ASDocs issue
Actually , there is a general problem here, that a number of files that were removed have reappeared, of changes that was made have been cancelled, after I made a pull/merge. I am not familiar enough with git to understand how this can happen. Anyway I feel like it's not safe to just try to recover that lost changes by hand. Any idea ? Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 10:13 À : dev@flex.apache.org Objet : RE: ASDocs issue Actually, the problem comes from asdoc build.xml It's referencing (line 150 and 168 the namespace library://ns.adobe.com/flex/spark-mobilecomponents which does not exist) As far as I know, mobile components are also in the regular spar namespace (library://ns.adobe.com/flex/spark) Since mobile components and spark components are referenced in a different manifest file in the asdoc build (166 and 168). it's legal that they use the same namespace. It shouldn't cause any collision or overlap. So I made the change above, and now I have the AnimationTarget compilation error :-(. Regarding this error, it's because AnimationTarget (which has been removed from experimental, as it was redundant with spark) has mysteriously reappeared . Trying to fix -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:48 À : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin) have reappeared when I merged from origin. I don't know what went wrong. I can make sure the asdoc build works again on my side and recommit/push the changes to origin. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:39 À : dev@flex.apache.org Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other failures like this. Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. OK, pushed and merged (I think). Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. I'm about to shut down for the night. I'll see what the mustella runs report in the morning. Thanks, -Alex
RE: ASDocs issue
This is because original spark AnimationTarget is marked as internal, and that's probably why it was duplicated in experimental, to make it public. Since the redundant class was removed from experimental, the original internal class cannot be accessed anymore. I has changed spark AnimationTarget to public, and the problem has gone. Maurice -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : vendredi 11 octobre 2013 04:34 À : dev@flex.apache.org Objet : ASDocs issue Hi, We're currently getting this: doc: [asdoc] Loading configuration file /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/flex-config.xml [asdoc] /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/projects/experimental/src/spark/layouts/supportClasses/AnimationNavigatorLayoutBase.as(277): col: 19 Error: Type was not found or was not a compile-time constant: AnimationTarget. [asdoc] [asdoc] var animTarget:AnimationTarget = new AnimationTarget(); [asdoc]^ [asdoc] It's probably related to me renaming supportClazzes to supportClasses but I can't see any remaining references to supportClazzes - any one have any idea why we might be getting the error. AnimationTarget class is in ExperimentalClasses.as so that's not teh issue. Thanks, Justin
Re: ASDocs issue
Check the web view of the branch e.g. https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=shortlog;h=refs/heads/develop and or the tree https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=refs/heads/develop and find the commitdiff that brought them back ? Tom On 11/10/2013 09:19, Maurice Amsellem wrote: Actually , there is a general problem here, that a number of files that were removed have reappeared, of changes that was made have been cancelled, after I made a pull/merge. I am not familiar enough with git to understand how this can happen. Anyway I feel like it's not safe to just try to recover that lost changes by hand. Any idea ? Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 10:13 À : dev@flex.apache.org Objet : RE: ASDocs issue Actually, the problem comes from asdoc build.xml It's referencing (line 150 and 168 the namespace library://ns.adobe.com/flex/spark-mobilecomponents which does not exist) As far as I know, mobile components are also in the regular spar namespace (library://ns.adobe.com/flex/spark) Since mobile components and spark components are referenced in a different manifest file in the asdoc build (166 and 168). it's legal that they use the same namespace. It shouldn't cause any collision or overlap. So I made the change above, and now I have the AnimationTarget compilation error :-(. Regarding this error, it's because AnimationTarget (which has been removed from experimental, as it was redundant with spark) has mysteriously reappeared . Trying to fix -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:48 À : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin) have reappeared when I merged from origin. I don't know what went wrong. I can make sure the asdoc build works again on my side and recommit/push the changes to origin. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:39 À : dev@flex.apache.org Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other failures like this. Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. OK, pushed and merged (I think). Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. I'm about to shut down for the night. I'll see what the mustella runs report in the morning. Thanks, -Alex __ This email has been scanned by the Symantec Email Security.cloud service. For more information please visit http://www.symanteccloud.com __
RE: ASDocs issue
Thanks, I will do. -Message d'origine- De : Tom Chiverton [mailto:t...@extravision.com] Envoyé : vendredi 11 octobre 2013 10:46 À : dev@flex.apache.org Objet : Re: ASDocs issue Check the web view of the branch e.g. https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=shortlog;h=refs/heads/develop and or the tree https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=refs/heads/develop and find the commitdiff that brought them back ? Tom On 11/10/2013 09:19, Maurice Amsellem wrote: Actually , there is a general problem here, that a number of files that were removed have reappeared, of changes that was made have been cancelled, after I made a pull/merge. I am not familiar enough with git to understand how this can happen. Anyway I feel like it's not safe to just try to recover that lost changes by hand. Any idea ? Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 10:13 À : dev@flex.apache.org Objet : RE: ASDocs issue Actually, the problem comes from asdoc build.xml It's referencing (line 150 and 168 the namespace library://ns.adobe.com/flex/spark-mobilecomponents which does not exist) As far as I know, mobile components are also in the regular spar namespace (library://ns.adobe.com/flex/spark) Since mobile components and spark components are referenced in a different manifest file in the asdoc build (166 and 168). it's legal that they use the same namespace. It shouldn't cause any collision or overlap. So I made the change above, and now I have the AnimationTarget compilation error :-(. Regarding this error, it's because AnimationTarget (which has been removed from experimental, as it was redundant with spark) has mysteriously reappeared . Trying to fix -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:48 À : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin) have reappeared when I merged from origin. I don't know what went wrong. I can make sure the asdoc build works again on my side and recommit/push the changes to origin. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:39 À : dev@flex.apache.org Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other failures like this. Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. OK, pushed and merged (I think). Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. I'm about to shut down for the night. I'll see what the mustella runs report in the morning. Thanks, -Alex __ This email has been scanned by the Symantec Email Security.cloud service. For more information please visit http://www.symanteccloud.com __
RE: ASDocs issue
I have fixed the issue with AnimationTarget, and experimental manifest and now Experimental.swc and asdoc are compiling ok. Didn't commit yet. However, I noticed that asdoc experimental disclaimer does not show anymore :-( I am going to dig into the history of diffs, as suggested by Tom, to understand what went wrong. Maurice -Message d'origine- De : Maurice Amsellem Envoyé : vendredi 11 octobre 2013 11:04 À : dev@flex.apache.org Objet : RE: ASDocs issue Thanks, I will do. -Message d'origine- De : Tom Chiverton [mailto:t...@extravision.com] Envoyé : vendredi 11 octobre 2013 10:46 À : dev@flex.apache.org Objet : Re: ASDocs issue Check the web view of the branch e.g. https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=shortlog;h=refs/heads/develop and or the tree https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=refs/heads/develop and find the commitdiff that brought them back ? Tom On 11/10/2013 09:19, Maurice Amsellem wrote: Actually , there is a general problem here, that a number of files that were removed have reappeared, of changes that was made have been cancelled, after I made a pull/merge. I am not familiar enough with git to understand how this can happen. Anyway I feel like it's not safe to just try to recover that lost changes by hand. Any idea ? Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 10:13 À : dev@flex.apache.org Objet : RE: ASDocs issue Actually, the problem comes from asdoc build.xml It's referencing (line 150 and 168 the namespace library://ns.adobe.com/flex/spark-mobilecomponents which does not exist) As far as I know, mobile components are also in the regular spar namespace (library://ns.adobe.com/flex/spark) Since mobile components and spark components are referenced in a different manifest file in the asdoc build (166 and 168). it's legal that they use the same namespace. It shouldn't cause any collision or overlap. So I made the change above, and now I have the AnimationTarget compilation error :-(. Regarding this error, it's because AnimationTarget (which has been removed from experimental, as it was redundant with spark) has mysteriously reappeared . Trying to fix -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:48 À : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin) have reappeared when I merged from origin. I don't know what went wrong. I can make sure the asdoc build works again on my side and recommit/push the changes to origin. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:39 À : dev@flex.apache.org Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other failures like this. Let me know if you get past this before you quit for the day otherwise I'll try to dig deeper. Should I just push everything to develop then merge all of it to release? That seems the simplest way to me. OK, pushed and merged (I think). Anything I have to watch out for? Given that these were done a long time ago that there no merge issues. I'm about to shut down for the night. I'll see what
RE: ASDocs issue
However, I noticed that asdoc experimental disclaimer does not show anymore :-( Fixed ( I forgot to rebuild the asdoc compiler jars). Status: - build is OK - asdoc build is OK (no error) - asdoc content looks good. Committing/pushing now. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 11:07 À : dev@flex.apache.org Objet : RE: ASDocs issue I have fixed the issue with AnimationTarget, and experimental manifest and now Experimental.swc and asdoc are compiling ok. Didn't commit yet. However, I noticed that asdoc experimental disclaimer does not show anymore :-( I am going to dig into the history of diffs, as suggested by Tom, to understand what went wrong. Maurice -Message d'origine- De : Maurice Amsellem Envoyé : vendredi 11 octobre 2013 11:04 À : dev@flex.apache.org Objet : RE: ASDocs issue Thanks, I will do. -Message d'origine- De : Tom Chiverton [mailto:t...@extravision.com] Envoyé : vendredi 11 octobre 2013 10:46 À : dev@flex.apache.org Objet : Re: ASDocs issue Check the web view of the branch e.g. https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=shortlog;h=refs/heads/develop and or the tree https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=refs/heads/develop and find the commitdiff that brought them back ? Tom On 11/10/2013 09:19, Maurice Amsellem wrote: Actually , there is a general problem here, that a number of files that were removed have reappeared, of changes that was made have been cancelled, after I made a pull/merge. I am not familiar enough with git to understand how this can happen. Anyway I feel like it's not safe to just try to recover that lost changes by hand. Any idea ? Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 10:13 À : dev@flex.apache.org Objet : RE: ASDocs issue Actually, the problem comes from asdoc build.xml It's referencing (line 150 and 168 the namespace library://ns.adobe.com/flex/spark-mobilecomponents which does not exist) As far as I know, mobile components are also in the regular spar namespace (library://ns.adobe.com/flex/spark) Since mobile components and spark components are referenced in a different manifest file in the asdoc build (166 and 168). it's legal that they use the same namespace. It shouldn't cause any collision or overlap. So I made the change above, and now I have the AnimationTarget compilation error :-(. Regarding this error, it's because AnimationTarget (which has been removed from experimental, as it was redundant with spark) has mysteriously reappeared . Trying to fix -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:48 À : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin) have reappeared when I merged from origin. I don't know what went wrong. I can make sure the asdoc build works again on my side and recommit/push the changes to origin. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:39 À : dev@flex.apache.org Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears that there is a separate namespace for mobilecomponents and that may be why this code doesn't compile, since the s in the mxml is mapped to the spark namespace which is mapped to a manifest that doesn't have mobile components. But if that were true, I'd think there'd be lots of other
RE: ASDocs issue
Committed to : https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commit;h=5ae5a847 -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 12:10 À : dev@flex.apache.org Objet : RE: ASDocs issue However, I noticed that asdoc experimental disclaimer does not show anymore :-( Fixed ( I forgot to rebuild the asdoc compiler jars). Status: - build is OK - asdoc build is OK (no error) - asdoc content looks good. Committing/pushing now. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 11:07 À : dev@flex.apache.org Objet : RE: ASDocs issue I have fixed the issue with AnimationTarget, and experimental manifest and now Experimental.swc and asdoc are compiling ok. Didn't commit yet. However, I noticed that asdoc experimental disclaimer does not show anymore :-( I am going to dig into the history of diffs, as suggested by Tom, to understand what went wrong. Maurice -Message d'origine- De : Maurice Amsellem Envoyé : vendredi 11 octobre 2013 11:04 À : dev@flex.apache.org Objet : RE: ASDocs issue Thanks, I will do. -Message d'origine- De : Tom Chiverton [mailto:t...@extravision.com] Envoyé : vendredi 11 octobre 2013 10:46 À : dev@flex.apache.org Objet : Re: ASDocs issue Check the web view of the branch e.g. https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=shortlog;h=refs/heads/develop and or the tree https://git-wip-us.apache.org/repos/asf/flex-sdk/repo?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=refs/heads/develop and find the commitdiff that brought them back ? Tom On 11/10/2013 09:19, Maurice Amsellem wrote: Actually , there is a general problem here, that a number of files that were removed have reappeared, of changes that was made have been cancelled, after I made a pull/merge. I am not familiar enough with git to understand how this can happen. Anyway I feel like it's not safe to just try to recover that lost changes by hand. Any idea ? Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 10:13 À : dev@flex.apache.org Objet : RE: ASDocs issue Actually, the problem comes from asdoc build.xml It's referencing (line 150 and 168 the namespace library://ns.adobe.com/flex/spark-mobilecomponents which does not exist) As far as I know, mobile components are also in the regular spar namespace (library://ns.adobe.com/flex/spark) Since mobile components and spark components are referenced in a different manifest file in the asdoc build (166 and 168). it's legal that they use the same namespace. It shouldn't cause any collision or overlap. So I made the change above, and now I have the AnimationTarget compilation error :-(. Regarding this error, it's because AnimationTarget (which has been removed from experimental, as it was redundant with spark) has mysteriously reappeared . Trying to fix -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:48 À : dev@flex.apache.org Objet : RE: ASDocs issue I have checked the asdoc build.xml and it's missing some of the changes I have made before (and I am sure I have commited and pushed, on 10/6). I have also noticed some of the classes I have removed in experimental (CalloutDropDownController, CallOutSkin) have reappeared when I merged from origin. I don't know what went wrong. I can make sure the asdoc build works again on my side and recommit/push the changes to origin. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 09:39 À : dev@flex.apache.org Objet : RE: ASDocs issue I have run the asdoc build.xml and getting this error: D:\ApacheFlex\git_source\flex-sdk\frameworks\projects\mobiletheme\src\spark\skins\mobile\ViewMenuSkin.mxml: Could not resolve s:ViewMenuLayout to a component implementation. s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout It seems to be related to the manifest issue you are talking about. I will check later today when I have some time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 08:58 À : dev@flex.apache.org Objet : Re: ASDocs issue On 10/10/13 11:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, None of the commit emails I see from you seem to mention develop branch. Look like my local develop branch was tracking release for some odd reason I'll fix and merge for you. OK, was able to reproduce the problem. I've never worked with ASDoc, but in looking at the ant script, it appears there are no Flex SWCs in the process and everything is based on source paths. Also, it appears
Re: ASDocs issue
Hi, Status: - build is OK - asdoc build is OK (no error) - asdoc content looks good. Much appreciated for sorting that out. Thanks, Justin
RE: ASDocs issue
You're welcome. My configuration being a little tweaked (with .gitignored files), can you please double check ... Maurice -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : vendredi 11 octobre 2013 13:01 À : dev@flex.apache.org Objet : Re: ASDocs issue Hi, Status: - build is OK - asdoc build is OK (no error) - asdoc content looks good. Much appreciated for sorting that out. Thanks, Justin
Re: ASDocs issue
Hi, My configuration being a little tweaked (with .gitignored files), can you please double check ... You might want to not check in changes to flex-sdk-description.xml but other than that all good from what I can see. Thanks, Justin
RE: ASDocs issue
Ah, OK sorry for that one. I will add it to my .gitignore. Maurice -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : vendredi 11 octobre 2013 14:57 À : dev@flex.apache.org Objet : Re: ASDocs issue Hi, My configuration being a little tweaked (with .gitignored files), can you please double check ... You might want to not check in changes to flex-sdk-description.xml but other than that all good from what I can see. Thanks, Justin
Re: ASDocs issue
Hi, Ah, OK sorry for that one. I will add it to my .gitignore. I wouldn't do that, sometime it does need to change and if someone else changes it you'll need to update it. Justin
RE: ASDocs issue
Ok, I will add it to .ignoreButKeepAnEyeOnIt file :-) -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : vendredi 11 octobre 2013 23:29 À : dev@flex.apache.org Objet : Re: ASDocs issue Hi, Ah, OK sorry for that one. I will add it to my .gitignore. I wouldn't do that, sometime it does need to change and if someone else changes it you'll need to update it. Justin
Re: ASDocs issue
Hi, Looks like an issue with the asdocs build file - just trying to sort. Justin
Re: ASDocs issue
Hi, Fixed that issue (and a few more) but now have this one: doc: [asdoc] Loading configuration file /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/flex-config.xml [asdoc] /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/projects/mobiletheme/src/spark/skins/mobile/ViewMenuSkin.mxml(187): Error: Could not resolve s:ViewMenuLayout to a component implementation. [asdoc] [asdoc] s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout [asdoc] ViewMenuSkin is in the mobile manifest file and that is being included in the asdoc ant file. I'd appreciate if someone could take a look at this and I'm out of ideas and it's stopping me from making a release candidate. Thanks, Justin
Re: ASDocs issue
On 10/10/13 8:21 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, Fixed that issue (and a few more) but now have this one: doc: [asdoc] Loading configuration file /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/flex-config.xml [asdoc] /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/projects/mobilet heme/src/spark/skins/mobile/ViewMenuSkin.mxml(187): Error: Could not resolve s:ViewMenuLayout to a component implementation. [asdoc] [asdoc] s:ViewMenuLayout horizontalGap=2 verticalGap=2 id=contentGroupLayout [asdoc] ViewMenuSkin is in the mobile manifest file and that is being included in the asdoc ant file. I assume you meant ViewMenuLayout? The manifests, etc look ok. I guess you could dump the mobilecomponents.swc and see if that class is actually in there, but the main build should have failed in the same way. I'd appreciate if someone could take a look at this and I'm out of ideas and it's stopping me from making a release candidate. I have a fix for that FTETextField bug. The revert you did to fix the mustella tests effectively re-opens FLEX-33428. Unfortunately, I also discovered that I have a bunch of other commits that never got pushed. I think I held off last time mustella was broken and forgot to go back and push them afterwards. I also have one commit pending for tlf. I'm thinking of pushing them all to the develop branch and see if the full mustella run passes, and then we can move them to the release branch if nothing breaks. Thoughts?
Re: ASDocs issue
Hi, I assume you meant ViewMenuLayout? The manifests, etc look ok. Yep I meant ViewMenuLayout. I guess you could dump the mobilecomponents.swc and see if that class is actually in there It;s in there: swfdump ./mobile/mobilecomponents.swc | grep ViewMenuLayout DoABC2 name='spark/layouts/ViewMenuLayout' but the main build should have failed in the same way. It compiles no issues. I have a fix for that FTETextField bug. The revert you did to fix the mustella tests effectively re-opens FLEX-33428. Check it into release if you can, FLEX-33428 was not resolved yet so don't think any issue there. Unfortunately, I also discovered that I have a bunch of other commits that never got pushed. What are they? Thanks, Justin
Re: ASDocs issue
On 10/10/13 10:22 PM, Justin Mclean jus...@classsoftware.com wrote: but the main build should have failed in the same way. It compiles no issues. Did you push the other ASDoc fixes required to get to this problem? I just ran ant asdoc and got the AnimationTarget issue. I have a fix for that FTETextField bug. The revert you did to fix the mustella tests effectively re-opens FLEX-33428. Check it into release if you can, FLEX-33428 was not resolved yet so don't think any issue there. Unfortunately, I also discovered that I have a bunch of other commits that never got pushed. What are they? Some minor stuff like missing imports for Falcon and some improvements for SWFDump, but also: FLEX-33690 https://issues.apache.org/jira/browse/FLEX-33690 (overlapping windows and focus) FLEX-33678 https://issues.apache.org/jira/browse/FLEX-33678 (scrollbar issue in DG) FLEX-33052 https://issues.apache.org/jira/browse/FLEX-33052 (charts in modules) I'm still trying to find out the TLF change. -Alex
Re: ASDocs issue
The TLF change is part of https://issues.apache.org/jira/browse/FLEX-33409 On 10/10/13 10:44 PM, Alex Harui aha...@adobe.com wrote: On 10/10/13 10:22 PM, Justin Mclean jus...@classsoftware.com wrote: but the main build should have failed in the same way. It compiles no issues. Did you push the other ASDoc fixes required to get to this problem? I just ran ant asdoc and got the AnimationTarget issue. I have a fix for that FTETextField bug. The revert you did to fix the mustella tests effectively re-opens FLEX-33428. Check it into release if you can, FLEX-33428 was not resolved yet so don't think any issue there. Unfortunately, I also discovered that I have a bunch of other commits that never got pushed. What are they? Some minor stuff like missing imports for Falcon and some improvements for SWFDump, but also: FLEX-33690 https://issues.apache.org/jira/browse/FLEX-33690 (overlapping windows and focus) FLEX-33678 https://issues.apache.org/jira/browse/FLEX-33678 (scrollbar issue in DG) FLEX-33052 https://issues.apache.org/jira/browse/FLEX-33052 (charts in modules) I'm still trying to find out the TLF change. -Alex
