Re: SQL return type change from 1.17 to 1.18

2023-12-08 Thread Leonard Xu
+1 to revert this breaking change and include it to 1.18.1 Best, Leonard > 2023年12月8日 下午4:14,Jing Ge 写道: > > Hi all, > > FYI: the 1.18.1 release discussion thread: > https://lists.apache.org/thread/1sjmn3lj32rrqmdmqom43hr2c34qczvw > Look forward to your feedback. Thanks! > > Best regards, >

Re: [DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Leonard Xu
Thanks Jing for driving this release, +1 Best, Leonard > 2023年12月9日 上午1:23,Danny Cranmer 写道: > > +1 > > Thanks for driving this > > On Fri, 8 Dec 2023, 12:05 Timo Walther, wrote: > >> Thanks for taking care of this Jing. >> >> +1 to release 1.18.1 for this. >> >> Cheers, >> Timo >> >>

[jira] [Created] (FLINK-33787) Java 17 support for jdbc connector

2023-12-08 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33787: --- Summary: Java 17 support for jdbc connector Key: FLINK-33787 URL: https://issues.apache.org/jira/browse/FLINK-33787 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

2023-12-08 Thread Jim Hughes
Hi Xuyang, As a clarification, since FLINK-24204 is finishing up work from FLIP-145[1], do we need to discuss anything before you work out the details of FLINK-24024 as a PR? Relatedly, as that goes up for a PR, as part of FLINK-33421 [2], Bonnie and I are working through migrating some of the

[NOTICE] Hive connector externalization

2023-12-08 Thread Sergey Nuyanzin
Hi everyone We are getting close to the externalization of Hive connector[1]. Since currently externalized version is already passing tests against release-1.18 and release-1.19 then I'm going to remove Hive connector code from Flink main repo[2]. For that reason I would kindly ask to avoid

[jira] [Created] (FLINK-33786) Remove Hive connector from master branch

2023-12-08 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33786: --- Summary: Remove Hive connector from master branch Key: FLINK-33786 URL: https://issues.apache.org/jira/browse/FLINK-33786 Project: Flink Issue Type:

Re: [DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Danny Cranmer
+1 Thanks for driving this On Fri, 8 Dec 2023, 12:05 Timo Walther, wrote: > Thanks for taking care of this Jing. > > +1 to release 1.18.1 for this. > > Cheers, > Timo > > > On 08.12.23 10:00, Benchao Li wrote: > > I've merged FLINK-33313 to release-1.18 branch. > > > > Péter Váry

Building Flink JDBC connector locally on M1 Mac

2023-12-08 Thread David Radley
Hi, When I build the JDBC connector locally on my M1 Mac with a mvn clean install, I get the following errors: in (XaFacadeImpl.java:75) [ERROR] Errors: [ERROR] DerbyExactlyOnceSinkE2eTest.testInsert » JobExecution Job execution failed. [ERROR] MySqlExactlyOnceSinkE2eTest »

Re: Kubernetes Operator Managed Ingress with TLS

2023-12-08 Thread Gyula Fóra
Hi Ryan! There is not really a Flink Kubernetes Operator team :) Everyone is welcome to contribute and bring new improvement and feature ideas! Sounds like a valuable addition, I will assign the ticket to you (please comment on it so I can see your jira handle) so you can follow up with your PR.

Kubernetes Operator Managed Ingress with TLS

2023-12-08 Thread Ryan van Huuksloot
Hi, Would the Flink Kubernetes Operator team be open to adding TLS to the managed ingress? We have migrated to the operator but can't use the managed ingress because there is no TLS support. At the same time I'd like to add a label pass through mechanism, similar to the annotations. I've noticed

[jira] [Created] (FLINK-33785) TableJdbcUpsertOutputFormat could not deal with DELETE record correctly when primary keys were set

2023-12-08 Thread Bodong Liu (Jira)
Bodong Liu created FLINK-33785: -- Summary: TableJdbcUpsertOutputFormat could not deal with DELETE record correctly when primary keys were set Key: FLINK-33785 URL: https://issues.apache.org/jira/browse/FLINK-33785

[jira] [Created] (FLINK-33784) CatalogStoreFactory can not be configured via StreamExecutionEnvironment

2023-12-08 Thread Timo Walther (Jira)
Timo Walther created FLINK-33784: Summary: CatalogStoreFactory can not be configured via StreamExecutionEnvironment Key: FLINK-33784 URL: https://issues.apache.org/jira/browse/FLINK-33784 Project:

[jira] [Created] (FLINK-33783) Add options to ignore parsing error in Kafka SQL Connector

2023-12-08 Thread Bartosz Mikulski (Jira)
Bartosz Mikulski created FLINK-33783: Summary: Add options to ignore parsing error in Kafka SQL Connector Key: FLINK-33783 URL: https://issues.apache.org/jira/browse/FLINK-33783 Project: Flink

Re: [DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Timo Walther
Thanks for taking care of this Jing. +1 to release 1.18.1 for this. Cheers, Timo On 08.12.23 10:00, Benchao Li wrote: I've merged FLINK-33313 to release-1.18 branch. Péter Váry 于2023年12月8日周五 16:56写道: Hi Jing, Thanks for taking care of this! +1 (non-binding) Peter Sergey Nuyanzin ezt

FW: Re: flink-sql-connector-jdbc new release

2023-12-08 Thread David Radley
Hi, As below, I am keen to help get the next flink JDBC connector release out - so we can get DB2 and Trino connectors released. When I first mentioned this, Jingsong mentioned that we should fix a blocking issue first. I put in pr https://github.com/apache/flink-connector-jdbc/pull/79 to fix

Re: Re: Re: Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

2023-12-08 Thread Shengkai Fang
Hi, Xuyang. Thanks for your response. I just thought an another way to solve this question instead of introducing > a new configuration. When using legacy syntax like `GROUP BY TUMBLE(xxx), > f0`, the rewritten sql can be GROUP BY f0, window_start, > window_end(window_start and window_end is

Re:Re: Re: Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

2023-12-08 Thread Xuyang
Hi, Martijn, thanks for your share. >On the topic of syntax for early/late fires, there is existing >configuration for the legacy group windows: > >SET table.exec.emit.early-fire.enabled = true; >SET table.exec.emit.early-fire.delay = 5s; >SET table.exec.emit.late-fire.enabled = true; >SET

[jira] [Created] (FLINK-33782) GroupAggregateRestoreTest fails

2023-12-08 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33782: - Summary: GroupAggregateRestoreTest fails Key: FLINK-33782 URL: https://issues.apache.org/jira/browse/FLINK-33782 Project: Flink Issue Type: Bug

Re: [DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Benchao Li
I've merged FLINK-33313 to release-1.18 branch. Péter Váry 于2023年12月8日周五 16:56写道: > > Hi Jing, > Thanks for taking care of this! > +1 (non-binding) > Peter > > Sergey Nuyanzin ezt írta (időpont: 2023. dec. 8., P, > 9:36): > > > Thanks Jing driving it > > +1 > > > > also +1 to include

Re: [DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Péter Váry
Hi Jing, Thanks for taking care of this! +1 (non-binding) Peter Sergey Nuyanzin ezt írta (időpont: 2023. dec. 8., P, 9:36): > Thanks Jing driving it > +1 > > also +1 to include FLINK-33313 mentioned by Benchao Li > > On Fri, Dec 8, 2023 at 9:17 AM Benchao Li wrote: > > > Thanks Jing for

Re: [DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Sergey Nuyanzin
Thanks Jing driving it +1 also +1 to include FLINK-33313 mentioned by Benchao Li On Fri, Dec 8, 2023 at 9:17 AM Benchao Li wrote: > Thanks Jing for driving 1.18.1 releasing. > > I would like to include FLINK-33313[1] in 1.18.1, it's just a bugfix, > not a blocker, but it's already merged into

Re: [DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Martijn Visser
Hi Jing, +1 to get this release out asap. Thanks for volunteering! Best regards, Martijn On Fri, Dec 8, 2023 at 9:06 AM Jing Ge wrote: > > Hi all, > > I would like to discuss creating a new 1.18 patch release (1.18.1). The > last 1.18 release is nearly two months old, and since then, 37

Re: [DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Benchao Li
Thanks Jing for driving 1.18.1 releasing. I would like to include FLINK-33313[1] in 1.18.1, it's just a bugfix, not a blocker, but it's already merged into master, I plan to merge it to 1.8/1.7 branches today after the CI passes. [1] https://issues.apache.org/jira/browse/FLINK-33313 Jing Ge

[jira] [Created] (FLINK-33781) Cleanup usage of deprecated org.apache.flink.table.api.TableConfig#ctor()

2023-12-08 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-33781: - Summary: Cleanup usage of deprecated org.apache.flink.table.api.TableConfig#ctor() Key: FLINK-33781 URL: https://issues.apache.org/jira/browse/FLINK-33781 Project: Flink

Re: SQL return type change from 1.17 to 1.18

2023-12-08 Thread Jing Ge
Hi all, FYI: the 1.18.1 release discussion thread: https://lists.apache.org/thread/1sjmn3lj32rrqmdmqom43hr2c34qczvw Look forward to your feedback. Thanks! Best regards, Jing On Fri, Dec 8, 2023 at 8:51 AM Jing Ge wrote: > Hi all, > > +1 for reverting it. > > I'd like to volunteer as the

[jira] [Created] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-08 Thread Yubin Li (Jira)
Yubin Li created FLINK-33780: Summary: Support to store default catalog in CatalogStore Key: FLINK-33780 URL: https://issues.apache.org/jira/browse/FLINK-33780 Project: Flink Issue Type:

[DISCUSS] Release Flink 1.18.1

2023-12-08 Thread Jing Ge
Hi all, I would like to discuss creating a new 1.18 patch release (1.18.1). The last 1.18 release is nearly two months old, and since then, 37 tickets have been closed [1], of which 6 are blocker/critical [2]. Some of them are quite important, such as FLINK-33598 [3] Most urgent and important

[jira] [Created] (FLINK-33779) Cleanup usage of deprecated BaseExpressions#cast(TypeInformation)

2023-12-08 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-33779: - Summary: Cleanup usage of deprecated BaseExpressions#cast(TypeInformation) Key: FLINK-33779 URL: https://issues.apache.org/jira/browse/FLINK-33779 Project: Flink