Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

+1 (non binding) Thanks for the effort. Best, Yuxin Samrat Deb 于2023年12月12日周二 15:25写道： > +1 (non binding) > Thanks for driving > > On Tue, 12 Dec 2023 at 11:59 AM, Sergey Nuyanzin > wrote: > > > +1 (binding) > > > > Thanks for driving this > > > > On Tue, Dec 12, 2023, 07:22 Rui Fan

Re: [DISCUSS] FLIP-380: Support Full Partition Processing On Non-keyed DataStream

Thanks Wencong for driving this FLIP. +1 from my side. It appears to significantly improve the handling of full-window data within the DataStream API. However, I do have a small question regarding the current limitation to batch processing: does this stem from performance-related considerations?

Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

+1 (non binding) Thanks for driving On Tue, 12 Dec 2023 at 11:59 AM, Sergey Nuyanzin wrote: > +1 (binding) > > Thanks for driving this > > On Tue, Dec 12, 2023, 07:22 Rui Fan <1996fan...@gmail.com> wrote: > > > +1(binding) > > > > Best, > > Rui > > > > On Tue, Dec 12, 2023 at 11:58 AM weijie

Re: [DISCUSS] Change the default restart-strategy to exponential-delay

Hi Maximilian and Mason, Thanks a lot for your feedback! After an offline consultation with Max, I guess I understand your concern for now: when flink job restarts, it will make a bunch of calls to the Kubernetes API, e.g. read/write to config maps, create task managers. Currently, the default

Re: [DISCUSS][2.0] FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

Hi Wencong, Thanks for driving this! This is valuable refactoring from my side, so I'm +1 for this proposal. Best regards, Weijie Lijie Wang 于2023年12月12日周二 14:58写道： > Hi Wencong > > Thanks for driving the discussion, +1 for the proposal. I left two minor > questions/suggestions: > > 1. Is

Re: [DISCUSS] FLIP-398: Improve Serialization Configuration And Usage In Flink

Thanks Yong for creating the FLIP and starting the discussion. Having a unified config option for all kinds of serializers can make it much easier for users to set, track and maintain the serializers for jobs. +1 Thanks, Zhu weijie guo 于2023年12月12日周二 14:01写道： > Thanks for driving this, Yong.

Re: [DISCUSS] FLIP-380: Support Full Partition Processing On Non-keyed DataStream

Thanks Wencong for driving this! I believe this is a useful feature, so +1 from my side. I only have one minor question about the exchange mode of `xxxPartition` method. Does this means the window operator must be connected to the upstream operator in forward edge (otherwise the concept of

Re:Re: Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

Hi, Jim. Thanks for your explaination. >Ah, I mean to ask if you can contribute the new SESSION Table support >without needing FLIP-392 completely settled. I was trying to see if that >is separate work which can be done or if there is some dependency on this >FLIP. The pr available about session

Re: [DISCUSS][2.0] FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

Hi Wencong Thanks for driving the discussion, +1 for the proposal. I left two minor questions/suggestions: 1. Is the getTaskNameWithIndexAndAttemptNumber method a bit redundant? It can be replaced by getTaskName + getTaskIndex + getAttemptNumber. 2. I think it would be better if we can

Re: [DISCUSS] Resolve diamond inheritance of Sink.createWriter

Thanks Peter and Marton for the quick response and fix, I’ve left +1 for this PR. I’d like to take a look at followup FLIP-372 as well. Best, Leonard > 2023年12月12日 上午7:39，Becket Qin 写道： > > Hi Peter, > > Thanks for updating the patch. The latest patch looks good to me. I've +1ed > on the

Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

+1 (binding) Thanks for driving this On Tue, Dec 12, 2023, 07:22 Rui Fan <1996fan...@gmail.com> wrote: > +1(binding) > > Best, > Rui > > On Tue, Dec 12, 2023 at 11:58 AM weijie guo > wrote: > > > Thanks Matthias for this efforts. > > > > +1(binding) > > > > > > Best regards, > > > > Weijie > >

Re: [VOTE] FLIP-401: REST API JSON response deserialization unknown field tolerance

+1 Gyula On Mon, Dec 11, 2023 at 1:26 PM Gabor Somogyi wrote: > Hi All, > > I'd like to start a vote on FLIP-401: REST API JSON response > deserialization unknown field tolerance [1] which has been discussed in > this thread [2]. > > The vote will be open for at least 72 hours unless there is

Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

+1(binding) Best, Rui On Tue, Dec 12, 2023 at 11:58 AM weijie guo wrote: > Thanks Matthias for this efforts. > > +1(binding) > > > Best regards, > > Weijie > > > Matthias Pohl 于2023年12月11日周一 21:51写道： > > > Hi everyone, > > I'd like to start a vote on FLIP-396 [1]. It covers enabling GitHub >

Re: [DISCUSS] Release Flink 1.18.1

Thanks Jing for driving this bug-fix release. +1 from my side. Best regards, Weijie Jark Wu 于2023年12月12日周二 12:17写道： > Thanks Jing for driving 1.18.1. > +1 for this. > > Best, > Jark > > On Mon, 11 Dec 2023 at 16:59, Hong Liang wrote: > > > +1. Thanks Jing for driving this. > > > > Hong > >

Re: [DISCUSS] FLIP-398: Improve Serialization Configuration And Usage In Flink

Thanks for driving this, Yong. This FLIP look good to me overall. I also used a similar approach to decouple the serializer from ExecutionConfig in the PoC of DataStream API V2. I'm +1 for this. Best regards, Weijie Xintong Song 于2023年12月12日周二 12:10写道： > Thanks for working on this, Yong.

Re: [DISCUSS] FLIP-383: Support Job Recovery for Batch Jobs

Hi devs, After an offline discussion with the Apache Celeborn folks, we changed the signatures of "snapshotState" and "retoreState" as follows: void snapshotState(CompletableFuture snapshotFuture, ShuffleMasterSnapshotContext context); void restoreState(List snapshots); We believe the above

Re: [DISCUSS] Release Flink 1.18.1

Thanks Jing for driving 1.18.1. +1 for this. Best, Jark On Mon, 11 Dec 2023 at 16:59, Hong Liang wrote: > +1. Thanks Jing for driving this. > > Hong > > On Mon, Dec 11, 2023 at 2:27 AM Yun Tang wrote: > > > Thanks Jing for driving 1.18.1 release, +1 for this. > > > > > > Best > > Yun Tang > >

Re: [DISCUSS] FLIP-398: Improve Serialization Configuration And Usage In Flink

Thanks for working on this, Yong. The usability of the serialization mechanism has indeed been a pain for a long time. The proposed changes look good to me. +1 from my side. Best, Xintong On Thu, Dec 7, 2023 at 10:36 AM Yong Fang wrote: > Hi devs, > > I'd like to start a discussion about

Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

Thanks Matthias for this efforts. +1(binding) Best regards, Weijie Matthias Pohl 于2023年12月11日周一 21:51写道： > Hi everyone, > I'd like to start a vote on FLIP-396 [1]. It covers enabling GitHub Actions > (GHA) in Apache Flink. This means that GHA workflows will run aside from > the usual Azure

Using Fury serializer with Flink

Hi all, Is anyone else looking into using Fury as a serializer for Flink? I’m asking because the early results of my tests are very encouraging. Check out performance results here . The

Re: [DISCUSS] Resolve diamond inheritance of Sink.createWriter

Hi Peter, Thanks for updating the patch. The latest patch looks good to me. I've +1ed on the PR. Cheers, Jiangjie (Becket) Qin On Mon, Dec 11, 2023 at 9:21 PM Péter Váry wrote: > Thanks everyone for the lively discussion! > > The PR is available which strictly adheres the accepted changes

[jira] [Created] (FLINK-33800) Allow passing parameters to database via jdbc url

Sergey Nuyanzin created FLINK-33800: --- Summary: Allow passing parameters to database via jdbc url Key: FLINK-33800 URL: https://issues.apache.org/jira/browse/FLINK-33800 Project: Flink

Re: [DISCUSS] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

+1 to the idea, I don't have any comments. Best, Piotrek czw., 7 gru 2023 o 07:15 Alan Sheinberg napisał(a): > > > > Nicely written and makes sense. The only feedback I have is around the > > naming of the generalization, e.g. "Specifically, PythonCalcSplitRuleBase > > will be generalized

[jira] [Created] (FLINK-33799) Add e2e's for tls enabled operator

Tony Garrard created FLINK-33799: Summary: Add e2e's for tls enabled operator Key: FLINK-33799 URL: https://issues.apache.org/jira/browse/FLINK-33799 Project: Flink Issue Type: Technical

[VOTE] FLIP-335: Deprecation and removal of Flink's Time classes in favor of Java's Duration

Hi everyone, I'd like to start a vote on FLIP-335 [1]. It covers the deprecation (and Flink 2.0-related removal) of Flink's Time classes in favor of Java's Duration class. The related discussion thread can be found in [2]. The vote will remain open for at least 72 hours and only concluded if

[jira] [Created] (FLINK-33798) Automatically clean up rocksdb logs when the task failover.

Ming Li created FLINK-33798: --- Summary: Automatically clean up rocksdb logs when the task failover. Key: FLINK-33798 URL: https://issues.apache.org/jira/browse/FLINK-33798 Project: Flink Issue

[VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

Hi everyone, I'd like to start a vote on FLIP-396 [1]. It covers enabling GitHub Actions (GHA) in Apache Flink. This means that GHA workflows will run aside from the usual Azure CI workflows in a trial phase (which ends earliest with the release of Flink 1.19). Azure CI will still serve as the

Re: Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

Hi Xuyang, On Sun, Dec 10, 2023 at 10:41 PM Xuyang wrote: > Hi, Jim. > >As a clarification, since FLINK-24204 is finishing up work from > >FLIP-145[1], do we need to discuss anything before you work out the > details > >of FLINK-24024 as a PR? > Which issue do you mean? It seems that

Re: [DISCUSS] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

We identified another issue with the current Sink API in a thread [1] related to FLIP-371 [2]. Currently it is not possible to evolve the Sink.createWriter method with deprecation, because StatefulSink and TwoPhaseCommittingSink has methods with the same name and parameters, but narrowed down

Re: [DISCUSS] Resolve diamond inheritance of Sink.createWriter

Thanks everyone for the lively discussion! The PR is available which strictly adheres the accepted changes from FLIP-371. Thanks Gyula and Marton for the review. Becket, if you have any questions left, please let me know, so I can fix and we can merge the changes. I would like to invite everyone

[jira] [Created] (FLINK-33797) Flink application FAILED log in info instead of warn

Nicolas Fraison created FLINK-33797: --- Summary: Flink application FAILED log in info instead of warn Key: FLINK-33797 URL: https://issues.apache.org/jira/browse/FLINK-33797 Project: Flink

Re: Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

Hi Xuyang, Thanks for driving this discussion. I briefly reviewed the first PoC code[1] you provided for implementing the session window TVF, and I noticed a problem. In the `translateToExecNode` method of `StreamPhysicalWindowAggregate`, the session window TVF is translated into the legacy

Re: [DISCUSS] FLIP-401: REST API JSON response deserialization unknown field tolerance

Thanks for the responses! I'm going to start a vote based on that... On Mon, Dec 11, 2023 at 1:13 PM Márton Balassi wrote: > +1 This greatly improves interfacing with multiple Flink versions, e.g. > upgrades from the Kubernetes Operator. > > On Mon, Dec 11, 2023 at 12:36 PM Gyula Fóra wrote: >

[VOTE] FLIP-401: REST API JSON response deserialization unknown field tolerance

Hi All, I'd like to start a vote on FLIP-401: REST API JSON response deserialization unknown field tolerance [1] which has been discussed in this thread [2]. The vote will be open for at least 72 hours unless there is an objection or not enough votes. BR, G [1]

Re: [DISCUSS] FLIP-401: REST API JSON response deserialization unknown field tolerance

+1 This greatly improves interfacing with multiple Flink versions, e.g. upgrades from the Kubernetes Operator. On Mon, Dec 11, 2023 at 12:36 PM Gyula Fóra wrote: > Thanks Gabor! > > +1 from my side, this sounds like a reasonable change that will > improve integration and backward compatibility.

[jira] [Created] (FLINK-33796) Add ability to customize java version for python ci in connectors

Sergey Nuyanzin created FLINK-33796: --- Summary: Add ability to customize java version for python ci in connectors Key: FLINK-33796 URL: https://issues.apache.org/jira/browse/FLINK-33796 Project:

Re: [DISCUSS] FLIP-401: REST API JSON response deserialization unknown field tolerance

Thanks Gabor! +1 from my side, this sounds like a reasonable change that will improve integration and backward compatibility. Let's keep this open for at least another day before starting the vote. Cheers, Gyula On Thu, Dec 7, 2023 at 10:48 AM Gabor Somogyi wrote: > Hi All, > > I'd like to

[jira] [Created] (FLINK-33795) Add new config to forbid autoscaling in certain periods of a day

yonghua jian created FLINK-33795: Summary: Add new config to forbid autoscaling in certain periods of a day Key: FLINK-33795 URL: https://issues.apache.org/jira/browse/FLINK-33795 Project: Flink

[jira] [Created] (FLINK-33794) After Flink Avro deserialization fails, subsequent correct data cannot be deserialized correctly

WeichengJi created FLINK-33794: -- Summary: After Flink Avro deserialization fails, subsequent correct data cannot be deserialized correctly Key: FLINK-33794 URL: https://issues.apache.org/jira/browse/FLINK-33794

Re: [DISCUSS] Release Flink 1.18.1

+1. Thanks Jing for driving this. Hong On Mon, Dec 11, 2023 at 2:27 AM Yun Tang wrote: > Thanks Jing for driving 1.18.1 release, +1 for this. > > > Best > Yun Tang > > From: Rui Fan <1996fan...@gmail.com> > Sent: Saturday, December 9, 2023 21:46 > To:

Re: [PROPOSAL] Contribute Flink CDC Connectors project to Apache Flink

Hey all, I want to extend my gratitude for the positive feedback we've received, particularly from voices in other communities. It is an honor for the Flink CDC community to have received your recognition. Moving forward, I will collaborate with the Flink CDC community maintainers to prepare

[jira] [Created] (FLINK-33793) java.lang.NoSuchMethodError when checkpointing in Google Cloud Storage

ChangZhuo Chen (陳昌倬) created FLINK-33793: Summary: java.lang.NoSuchMethodError when checkpointing in Google Cloud Storage Key: FLINK-33793 URL: https://issues.apache.org/jira/browse/FLINK-33793

Re: [PROPOSAL] Contribute Flink CDC Connectors project to Apache Flink

Excited to hear the news, +1 Best, Yunhong (Swuferhong) liu ron 于2023年12月11日周一 14:05写道： > +1 > > Best, > Ron > > Yunqing Mo 于2023年12月11日周一 12:01写道： > > > So cool, Big +1 for this exciting work. > > > > On 2023/12/07 03:24:59 Leonard Xu wrote: > > > Dear Flink devs, > > > > > > As you may have