Re: Re: Re: [DISCUSS] Aligning migration test data generation

2022-10-19 Thread Matthias Pohl
Works for me. Feel free to ping me for a review. Best, Matthias On Wed, Oct 19, 2022 at 10:01 AM Yun Gao wrote: > Hi Matthias, > > Thanks a lot for the clarification! If it is not a blocker for 1.16, I > could also continue to > finish the whole work roughly in the next week so we could avoid

Re: Re: Re: [DISCUSS] Aligning migration test data generation

2022-10-19 Thread Yun Gao
Hi Matthias, Thanks a lot for the clarification! If it is not a blocker for 1.16, I could also continue to finish the whole work roughly in the next week so we could avoid redundant work. Do you think this would be also ok? Best, Yun Gao --Original Mail

Re: Re: [DISCUSS] Aligning migration test data generation

2022-10-19 Thread Matthias Pohl
I don't think that it's actually a blocker for the current release. It's more like a nice-to-have. The release managers for 1.16 could still do the test data generation manually like you did it for 1.15. So, in this sense, we're not under pressure to finalize it before 1.16. But ok, I will go

Re: Re: [DISCUSS] Aligning migration test data generation

2022-10-18 Thread Yun Gao
Hi Matthias, I was mainly working on the generator class to automates the process, but sorry I'm bound up with some affairs in this week. Since currently it seems generating the snapshots is a blocker for the releasing, I think one possible way to merge the current efforts are that you continue

Re: Re: [DISCUSS] Aligning migration test data generation

2022-10-18 Thread Matthias Pohl
Thanks for clarifying things and providing the link to the Jira issue. I'd be curious about the state of your efforts. I'm happy to close my PR if you're saying that your approach is more reasonable or you're almost done. But we could also merge both efforts. Either way is fine with me. Best,

Re: Re: [DISCUSS] Aligning migration test data generation

2022-10-18 Thread Yun Gao
Hi Matthias, Very thanks for proposing the issue! Currently when releasing a new version, it is indeed required to manully generates new test data on the branch to release (namely release-1.16) for all the compatibility tests, and then pick the files back to the master branch so that the