Re: Review Request: FLUME-1940, FLUME-1957 - Logging Snapshots of Flume Metrics on Shutdown

2013-04-16 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10416/#review19246 --- Looks good overall. However I think there is an issue where there

[jira] [Commented] (FLUME-2003) It'll be nice if we can control the HDFS block-size and replication for specific HDFS-sink instances

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632640#comment-13632640 ] Mike Percy commented on FLUME-2003: --- Hi Thiruvalluvan, Thanks for the patch. Offhand,

[jira] [Commented] (FLUME-1987) Improving Documentation for Apache Flume

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632643#comment-13632643 ] Mike Percy commented on FLUME-1987: --- By the way, we could also add to the existing web

[jira] [Commented] (FLUME-2003) It'll be nice if we can control the HDFS block-size and replication for specific HDFS-sink instances

2013-04-16 Thread Thiruvalluvan M. G. (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632752#comment-13632752 ] Thiruvalluvan M. G. commented on FLUME-2003: Yes it would. But such a

[jira] [Commented] (FLUME-2004) Need to capture metrics on the Flume exec source such as events received, rejected, etc.

2013-04-16 Thread Robert Justice (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632838#comment-13632838 ] Robert Justice commented on FLUME-2004: --- Thanks Venkatesh! We'll review and let you

Re: Review Request: FLUME-1940, FLUME-1957 - Logging Snapshots of Flume Metrics on Shutdown

2013-04-16 Thread Israel Ekpo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10416/#review19250 --- I think instead of adding the start and stop times for the

Re: Review Request: FLUME-1940, FLUME-1957 - Logging Snapshots of Flume Metrics on Shutdown

2013-04-16 Thread Israel Ekpo
On April 16, 2013, 7:10 a.m., Mike Percy wrote: Looks good overall. However I think there is an issue where there are certain assumptions made about keys existing when they may not be set. I am getting a NullPointerException at stop() time (when I kill Flume via Ctrl-C) when running

[jira] [Commented] (FLUME-2004) Need to capture metrics on the Flume exec source such as events received, rejected, etc.

2013-04-16 Thread Venkatesh Sivasubramanian (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632953#comment-13632953 ] Venkatesh Sivasubramanian commented on FLUME-2004: -- Thanks Robert!

[jira] [Commented] (FLUME-1987) Improving Documentation for Apache Flume

2013-04-16 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633127#comment-13633127 ] Roshan Naik commented on FLUME-1987: {quote} Hi Israel gents, I would love to see

[jira] [Commented] (FLUME-1987) Improving Documentation for Apache Flume

2013-04-16 Thread Israel Ekpo (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633179#comment-13633179 ] Israel Ekpo commented on FLUME-1987: Excellent feedback Gentlemen, I see your point

[jira] [Commented] (FLUME-2003) It'll be nice if we can control the HDFS block-size and replication for specific HDFS-sink instances

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633198#comment-13633198 ] Mike Percy commented on FLUME-2003: --- I can see that... playing devil's advocate here...

[jira] [Commented] (FLUME-1987) Improving Documentation for Apache Flume

2013-04-16 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633341#comment-13633341 ] Roshan Naik commented on FLUME-1987: the user guide is also version specific.

[jira] [Commented] (FLUME-1987) Improving Documentation for Apache Flume

2013-04-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633379#comment-13633379 ] Ralph Goers commented on FLUME-1987: The documentation on the web site has to be

[jira] [Updated] (FLUME-1262) Move doc generation to a different profile

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy updated FLUME-1262: -- Attachment: FLUME-1262-2.patch OK I cleaned some junk out of doc generation Maven stuff, so now

Review Request: FLUME-1262: Move doc generation to a different profile

2013-04-16 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10555/ --- Review request for Flume. Description --- Moved stuff around This

Re: Review Request: FLUME-1262: Move doc generation to a different profile

2013-04-16 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10555/ --- (Updated April 16, 2013, 9:55 p.m.) Review request for Flume. Changes

[jira] [Updated] (FLUME-1262) Move doc generation to a different profile

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy updated FLUME-1262: -- Attachment: FLUME-1262-3.patch Move doc generation to a different profile

[jira] [Commented] (FLUME-1262) Move doc generation to a different profile

2013-04-16 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633448#comment-13633448 ] Hari Shreedharan commented on FLUME-1262: - +1. Looks good Mike. Could you also

[jira] [Commented] (FLUME-1321) BasicTransactionSemantics should never throw from close()

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633475#comment-13633475 ] Mike Percy commented on FLUME-1321: --- Roshan I was thinking about this one recently...

[jira] [Commented] (FLUME-1321) BasicTransactionSemantics should never throw from close()

2013-04-16 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633493#comment-13633493 ] Hari Shreedharan commented on FLUME-1321: - Hi Mike, There is a conversation

Re: Review Request: BasicTransactionSemantics should avoid throw-ing from close()

2013-04-16 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10362/#review19278 --- I think it'd be great to preserve or enable the Lock-like idiom as

Re: Review Request: BasicTransactionSemantics should avoid throw-ing from close()

2013-04-16 Thread Mike Percy
On April 16, 2013, 10:51 p.m., Mike Percy wrote: I think it'd be great to preserve or enable the Lock-like idiom as a best-practice, i.e. txn.begin() try { // do stuff, puts, whatever ch.put(...); ch.commit(); } catch (FlumeException ex) { ch.rollback(); }

[jira] [Commented] (FLUME-1321) BasicTransactionSemantics should never throw from close()

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633517#comment-13633517 ] Mike Percy commented on FLUME-1321: --- Thanks Hari, I commented on RB

Re: Review Request: BasicTransactionSemantics should avoid throw-ing from close()

2013-04-16 Thread Roshan Naik
On April 16, 2013, 10:51 p.m., Mike Percy wrote: I think it'd be great to preserve or enable the Lock-like idiom as a best-practice, i.e. txn.begin() try { // do stuff, puts, whatever ch.put(...); ch.commit(); } catch (FlumeException ex) { ch.rollback(); }

[jira] [Updated] (FLUME-2005) Minor improvements to Flume assembly config

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy updated FLUME-2005: -- Attachment: FLUME-2005.patch Improvements: - get rid of long file name warning - remove unneeded

[jira] [Updated] (FLUME-2005) Minor improvements to Flume assembly config

2013-04-16 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy updated FLUME-2005: -- Issue Type: Improvement (was: Bug) Minor improvements to Flume assembly config

[jira] [Created] (FLUME-2005) Minor improvements to Flume assembly config

2013-04-16 Thread Mike Percy (JIRA)
Mike Percy created FLUME-2005: - Summary: Minor improvements to Flume assembly config Key: FLUME-2005 URL: https://issues.apache.org/jira/browse/FLUME-2005 Project: Flume Issue Type: Bug

[jira] [Created] (FLUME-2006) in Avro the batch size is called batch-size, in all other sources batchSize

2013-04-16 Thread Alexander Alten-Lorenz (JIRA)
Alexander Alten-Lorenz created FLUME-2006: - Summary: in Avro the batch size is called batch-size, in all other sources batchSize Key: FLUME-2006 URL: https://issues.apache.org/jira/browse/FLUME-2006