Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Christopher]

-1

* Reviewed signatures, hashes
* Commit matches tarball (with the exception of the generated DEPENDENCIES
file, which is created by the maven-remote-resources-plugin)
* Builds fine with tests, but with a compiler warning about unused
auto-closeable in FluoSparkHelperIT.java which should be fixed

Issues (minor):
* The NOTICE and DISCLAIMER files at the top incorrectly identifies itself
as Apache Fluo, rather than Apache Fluo Recipes. This might be okay with
DISCLAIMER (though, some wording to explain the relationship Apache Fluo
Recipes has to Apache Fluo would help, but it's certainly confusing for
NOTICE.
* The modules don't have the "Apache" branding in their  elements in
the pom. This results in NOTICE files that don't have the Apache branding
on the project name, and jar manifests which have the same. Also, the
generated NOTICE files in the jars for the modules look funny "Fluo Recipes
Accumulo". Should we name them more like "Fluo Recipes For Accumulo"?
* We can/should also update the  fields and NOTICE files to have "
(incubating)" suffixed at the end.

Other:

* saw weird Implementation-URLs in jar manifests. Not really sure these add
any value... but the URLs certainly shouldn't be expected to exist (they
don't)


On Tue, Oct 18, 2016 at 3:33 PM Christopher  wrote:

> I'm reviewing this now, but wanted to mention that the branch didn't match
> the commit (it was one commit ahead), so I just now pushed a rollback of
> that 1 commit to the rc0 branch, and I staged that extra commit to an
> rc0-next branch.
>
> On Tue, Oct 18, 2016 at 2:24 PM Josh Elser  wrote:
>
> Keith Turner wrote:
> > On Tue, Oct 18, 2016 at 1:37 PM, Josh Elser
> wrote:
> >> Keith Turner wrote:
>  * Saw libthrift in the parent pom.xml, but could not see usages of
> that
> >   anywhere in the child modules. (not a release issue, just curious)
> >>>
> >>> Its in the dep mgmt section.  The reason is its needed to build
> >>> recipes against accumulo 1.8.0.  Fluo also uses thrift and depends on
> >>> 0.9.1.  If thrift 0.9.1 ends up on path, then MiniAccumulo will hang.
> >>> I can add a comment to the pom.
> >>>
> >> Ah, ok. I just did a grep and did see any usages of Thrift in the
> recipes
> >> which made me wonder why it was defined (even if only in depMgmt).
> >> Overriding Fluo's thrift dependency makes sense -- you don't need to
> >> document on my account.
> >
> > It took me a bit to remember why it was there. I made a PR to add a
> > comment to pom.
>
> Ok, sounds great, guys. I just assumed I was being dense and did not
> want to demand a comment to be added :)
>
>

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Christopher]

I'm reviewing this now, but wanted to mention that the branch didn't match
the commit (it was one commit ahead), so I just now pushed a rollback of
that 1 commit to the rc0 branch, and I staged that extra commit to an
rc0-next branch.

On Tue, Oct 18, 2016 at 2:24 PM Josh Elser  wrote:

> Keith Turner wrote:
> > On Tue, Oct 18, 2016 at 1:37 PM, Josh Elser
> wrote:
> >> Keith Turner wrote:
>  * Saw libthrift in the parent pom.xml, but could not see usages of
> that
> >   anywhere in the child modules. (not a release issue, just curious)
> >>>
> >>> Its in the dep mgmt section.  The reason is its needed to build
> >>> recipes against accumulo 1.8.0.  Fluo also uses thrift and depends on
> >>> 0.9.1.  If thrift 0.9.1 ends up on path, then MiniAccumulo will hang.
> >>> I can add a comment to the pom.
> >>>
> >> Ah, ok. I just did a grep and did see any usages of Thrift in the
> recipes
> >> which made me wonder why it was defined (even if only in depMgmt).
> >> Overriding Fluo's thrift dependency makes sense -- you don't need to
> >> document on my account.
> >
> > It took me a bit to remember why it was there. I made a PR to add a
> > comment to pom.
>
> Ok, sounds great, guys. I just assumed I was being dense and did not
> want to demand a comment to be added :)
>

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Christopher]

On Tue, Oct 18, 2016 at 1:37 PM Josh Elser  wrote:

> Keith Turner wrote:
> >> * Saw libthrift in the parent pom.xml, but could not see usages of that
> >> >  anywhere in the child modules. (not a release issue, just curious)
> >
> > Its in the dep mgmt section.  The reason is its needed to build
> > recipes against accumulo 1.8.0.  Fluo also uses thrift and depends on
> > 0.9.1.  If thrift 0.9.1 ends up on path, then MiniAccumulo will hang.
> > I can add a comment to the pom.
> >
>
> Ah, ok. I just did a grep and did see any usages of Thrift in the
> recipes which made me wonder why it was defined (even if only in
> depMgmt). Overriding Fluo's thrift dependency makes sense -- you don't
> need to document on my account.
>

Still nice to document for the next release.

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Keith Turner]

On Tue, Oct 18, 2016 at 1:37 PM, Josh Elser  wrote:
> Keith Turner wrote:
>>>
>>> * Saw libthrift in the parent pom.xml, but could not see usages of that
>>> >  anywhere in the child modules. (not a release issue, just curious)
>>
>>
>> Its in the dep mgmt section.  The reason is its needed to build
>> recipes against accumulo 1.8.0.  Fluo also uses thrift and depends on
>> 0.9.1.  If thrift 0.9.1 ends up on path, then MiniAccumulo will hang.
>> I can add a comment to the pom.
>>
>
> Ah, ok. I just did a grep and did see any usages of Thrift in the recipes
> which made me wonder why it was defined (even if only in depMgmt).
> Overriding Fluo's thrift dependency makes sense -- you don't need to
> document on my account.

It took me a bit to remember why it was there. I made a PR to add a
comment to pom.

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Josh Elser]

Keith Turner wrote:

* Saw libthrift in the parent pom.xml, but could not see usages of that
>  anywhere in the child modules. (not a release issue, just curious)


Its in the dep mgmt section.  The reason is its needed to build
recipes against accumulo 1.8.0.  Fluo also uses thrift and depends on
0.9.1.  If thrift 0.9.1 ends up on path, then MiniAccumulo will hang.
I can add a comment to the pom.



Ah, ok. I just did a grep and did see any usages of Thrift in the 
recipes which made me wonder why it was defined (even if only in 
depMgmt). Overriding Fluo's thrift dependency makes sense -- you don't 
need to document on my account.

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Keith Turner]

On Tue, Oct 18, 2016 at 12:20 PM, Josh Elser  wrote:
> +1
>
> * xsums/sigs OK
> * Can build and run tests
> * No binaries in source release
> * mvn apache-rat:check passes (no exclusions)
> * DISCLAIMER present
> * L are good
> * README looks good.
>
> Some comments:
>
> * Keith, you could consider adding your apache.org email addr to your key.
> Not required, but a nice to have.
> * Would prefer to see "apache-fluo-recipes-1.0.0-incubating..." as the file
> name.
> * Saw libthrift in the parent pom.xml, but could not see usages of that
> anywhere in the child modules. (not a release issue, just curious)

Its in the dep mgmt section.  The reason is its needed to build
recipes against accumulo 1.8.0.  Fluo also uses thrift and depends on
0.9.1.  If thrift 0.9.1 ends up on path, then MiniAccumulo will hang.
I can add a comment to the pom.

>
> - Josh
>
> Keith Turner wrote:
>>
>> Fluo Developers,
>>
>> Please consider the following candidate for Fluo Recipes 1.0.0-incubating.
>>
>> Git Commit:
>>  2eb367e173721607a2cb958927e3c753b40188ed
>> Branch:
>>  1.0.0-incubating-rc0
>>
>> If this vote passes, a gpg-signed tag will be created using:
>>  git tag -f -m 'Apache Fluo Recipes 1.0.0-incubating' \
>>  -s rel/fluo-recipes-1.0.0-incubating \
>>  2eb367e173721607a2cb958927e3c753b40188ed
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/orgapachefluo-1014
>>
>> Source (official release artifact):
>>
>> https://repository.apache.org/content/repositories/orgapachefluo-1014/org/apache/fluo/fluo-recipes/1.0.0-incubating/fluo-recipes-1.0.0-incubating-source-release.tar.gz
>> (Append ".sha1", ".md5", or ".asc" to download the signature/hash for a
>> given artifact.)
>>
>> All artifacts were built and staged with:
>>  mvn release:prepare&&  mvn release:perform
>>
>> Signing keys are available at
>> https://www.apache.org/dist/incubator/fluo/KEYS
>> (Expected fingerprint: CF72 CA07 C8BC 86A1 C862  765F 9AAC FB56 352A CF76)
>>
>> Release notes (in progress) can be found at:
>> https://fluo.apache.org/.../1.0.0-incubating (not yet started)
>>
>> Please vote one of:
>> [ ] +1 - I have verified and accept...
>> [ ] +0 - I have reservations, but not strong enough to vote against...
>> [ ] -1 - Because..., I do not accept...
>> ... these artifacts as the 1.0.0-incubating release of Apache Fluo.
>>
>> This vote will end on Thur Oct 20 18:10:00 UTC 2016
>> (Fri Oct 14:10:00 EDT 2016 / Fri Oct 20 11:10:00 PDT 2016)
>>
>> Thanks!
>>
>> P.S. Hint: download the whole staging repo with
>>  wget -erobots=off -r -l inf -np -nH \
>>
>> https://repository.apache.org/content/repositories/orgapachefluo-1014/
>>  # note the trailing slash is needed

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Josh Elser]

+1

* xsums/sigs OK
* Can build and run tests
* No binaries in source release
* mvn apache-rat:check passes (no exclusions)
* DISCLAIMER present
* L are good
* README looks good.

Some comments:

* Keith, you could consider adding your apache.org email addr to your 
key. Not required, but a nice to have.
* Would prefer to see "apache-fluo-recipes-1.0.0-incubating..." as the 
file name.
* Saw libthrift in the parent pom.xml, but could not see usages of that 
anywhere in the child modules. (not a release issue, just curious)


- Josh

Keith Turner wrote:

Fluo Developers,

Please consider the following candidate for Fluo Recipes 1.0.0-incubating.

Git Commit:
 2eb367e173721607a2cb958927e3c753b40188ed
Branch:
 1.0.0-incubating-rc0

If this vote passes, a gpg-signed tag will be created using:
 git tag -f -m 'Apache Fluo Recipes 1.0.0-incubating' \
 -s rel/fluo-recipes-1.0.0-incubating \
 2eb367e173721607a2cb958927e3c753b40188ed

Staging repo:
https://repository.apache.org/content/repositories/orgapachefluo-1014

Source (official release artifact):
https://repository.apache.org/content/repositories/orgapachefluo-1014/org/apache/fluo/fluo-recipes/1.0.0-incubating/fluo-recipes-1.0.0-incubating-source-release.tar.gz
(Append ".sha1", ".md5", or ".asc" to download the signature/hash for a
given artifact.)

All artifacts were built and staged with:
 mvn release:prepare&&  mvn release:perform

Signing keys are available at
https://www.apache.org/dist/incubator/fluo/KEYS
(Expected fingerprint: CF72 CA07 C8BC 86A1 C862  765F 9AAC FB56 352A CF76)

Release notes (in progress) can be found at:
https://fluo.apache.org/.../1.0.0-incubating (not yet started)

Please vote one of:
[ ] +1 - I have verified and accept...
[ ] +0 - I have reservations, but not strong enough to vote against...
[ ] -1 - Because..., I do not accept...
... these artifacts as the 1.0.0-incubating release of Apache Fluo.

This vote will end on Thur Oct 20 18:10:00 UTC 2016
(Fri Oct 14:10:00 EDT 2016 / Fri Oct 20 11:10:00 PDT 2016)

Thanks!

P.S. Hint: download the whole staging repo with
 wget -erobots=off -r -l inf -np -nH \
 https://repository.apache.org/content/repositories/orgapachefluo-1014/
 # note the trailing slash is needed

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Keith Turner]

+1

 * Sigs on all artifacts check out
 * Source tar contents match commit
 * Successfully ran mvn verify for stress, webindex, and phrasecount
use staging repo

On Mon, Oct 17, 2016 at 2:08 PM, Keith Turner  wrote:
> Fluo Developers,
>
> Please consider the following candidate for Fluo Recipes 1.0.0-incubating.
>
> Git Commit:
> 2eb367e173721607a2cb958927e3c753b40188ed
> Branch:
> 1.0.0-incubating-rc0
>
> If this vote passes, a gpg-signed tag will be created using:
> git tag -f -m 'Apache Fluo Recipes 1.0.0-incubating' \
> -s rel/fluo-recipes-1.0.0-incubating \
> 2eb367e173721607a2cb958927e3c753b40188ed
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachefluo-1014
>
> Source (official release artifact):
> https://repository.apache.org/content/repositories/orgapachefluo-1014/org/apache/fluo/fluo-recipes/1.0.0-incubating/fluo-recipes-1.0.0-incubating-source-release.tar.gz
> (Append ".sha1", ".md5", or ".asc" to download the signature/hash for a
> given artifact.)
>
> All artifacts were built and staged with:
> mvn release:prepare && mvn release:perform
>
> Signing keys are available at
> https://www.apache.org/dist/incubator/fluo/KEYS
> (Expected fingerprint: CF72 CA07 C8BC 86A1 C862  765F 9AAC FB56 352A CF76)
>
> Release notes (in progress) can be found at:
> https://fluo.apache.org/.../1.0.0-incubating (not yet started)
>
> Please vote one of:
> [ ] +1 - I have verified and accept...
> [ ] +0 - I have reservations, but not strong enough to vote against...
> [ ] -1 - Because..., I do not accept...
> ... these artifacts as the 1.0.0-incubating release of Apache Fluo.
>
> This vote will end on Thur Oct 20 18:10:00 UTC 2016
> (Fri Oct 14:10:00 EDT 2016 / Fri Oct 20 11:10:00 PDT 2016)
>
> Thanks!
>
> P.S. Hint: download the whole staging repo with
> wget -erobots=off -r -l inf -np -nH \
> https://repository.apache.org/content/repositories/orgapachefluo-1014/
> # note the trailing slash is needed

Re: [VOTE] Fluo Recipes 1.0.0-incubating-rc0

[Keith Turner]

On Mon, Oct 17, 2016 at 7:46 PM, Christopher  wrote:
> Were you intending this to be a vote thread or just a test? By convention,

I was intending it to be a test, but as I looked at it I could not
find any problems.  So I decided to try voting on it.


> I usually reserve rc0 for test of the release process itself, and rc1+ for
> actual release candidates... but you may have something else in mind. I
> just want to be sure before I prioritize testing this RC over other stuffs.
>
> On Mon, Oct 17, 2016, 16:42 Mike Walch  wrote:
>
>> +1
>>
>> * Verified signatures and hashes for source release
>> * Verified that recipes jars exist in staging repo
>> * Ran 'mvn verify' for stresso and webindex using staging repo
>> * Ran webindex dev server using staging repo
>>
>> On Mon, Oct 17, 2016 at 2:08 PM Keith Turner  wrote:
>>
>> > Fluo Developers,
>> >
>> > Please consider the following candidate for Fluo Recipes
>> 1.0.0-incubating.
>> >
>> > Git Commit:
>> > 2eb367e173721607a2cb958927e3c753b40188ed
>> > Branch:
>> > 1.0.0-incubating-rc0
>> >
>> > If this vote passes, a gpg-signed tag will be created using:
>> > git tag -f -m 'Apache Fluo Recipes 1.0.0-incubating' \
>> > -s rel/fluo-recipes-1.0.0-incubating \
>> > 2eb367e173721607a2cb958927e3c753b40188ed
>> >
>> > Staging repo:
>> > https://repository.apache.org/content/repositories/orgapachefluo-1014
>> >
>> > Source (official release artifact):
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachefluo-1014/org/apache/fluo/fluo-recipes/1.0.0-incubating/fluo-recipes-1.0.0-incubating-source-release.tar.gz
>> > (Append ".sha1", ".md5", or ".asc" to download the signature/hash for a
>> > given artifact.)
>> >
>> > All artifacts were built and staged with:
>> > mvn release:prepare && mvn release:perform
>> >
>> > Signing keys are available at
>> > https://www.apache.org/dist/incubator/fluo/KEYS
>> > (Expected fingerprint: CF72 CA07 C8BC 86A1 C862  765F 9AAC FB56 352A
>> CF76)
>> >
>> > Release notes (in progress) can be found at:
>> > https://fluo.apache.org/.../1.0.0-incubating (not yet started)
>> >
>> > Please vote one of:
>> > [ ] +1 - I have verified and accept...
>> > [ ] +0 - I have reservations, but not strong enough to vote against...
>> > [ ] -1 - Because..., I do not accept...
>> > ... these artifacts as the 1.0.0-incubating release of Apache Fluo.
>> >
>> > This vote will end on Thur Oct 20 18:10:00 UTC 2016
>> > (Fri Oct 14:10:00 EDT 2016 / Fri Oct 20 11:10:00 PDT 2016)
>> >
>> > Thanks!
>> >
>> > P.S. Hint: download the whole staging repo with
>> > wget -erobots=off -r -l inf -np -nH \
>> >
>> https://repository.apache.org/content/repositories/orgapachefluo-1014/
>> > # note the trailing slash is needed
>> >
>>