On Tue, Oct 18, 2016 at 12:20 PM, Josh Elser <els...@apache.org> wrote:
> +1
>
> * xsums/sigs OK
> * Can build and run tests
> * No binaries in source release
> * mvn apache-rat:check passes (no exclusions)
> * DISCLAIMER present
> * L&N are good
> * README looks good.
>
> Some comments:
>
> * Keith, you could consider adding your apache.org email addr to your key.
> Not required, but a nice to have.
> * Would prefer to see "apache-fluo-recipes-1.0.0-incubating..." as the file
> name.
> * Saw libthrift in the parent pom.xml, but could not see usages of that
> anywhere in the child modules. (not a release issue, just curious)

Its in the dep mgmt section.  The reason is its needed to build
recipes against accumulo 1.8.0.  Fluo also uses thrift and depends on
0.9.1.  If thrift 0.9.1 ends up on path, then MiniAccumulo will hang.
I can add a comment to the pom.

>
> - Josh
>
> Keith Turner wrote:
>>
>> Fluo Developers,
>>
>> Please consider the following candidate for Fluo Recipes 1.0.0-incubating.
>>
>> Git Commit:
>>      2eb367e173721607a2cb958927e3c753b40188ed
>> Branch:
>>      1.0.0-incubating-rc0
>>
>> If this vote passes, a gpg-signed tag will be created using:
>>      git tag -f -m 'Apache Fluo Recipes 1.0.0-incubating' \
>>      -s rel/fluo-recipes-1.0.0-incubating \
>>      2eb367e173721607a2cb958927e3c753b40188ed
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/orgapachefluo-1014
>>
>> Source (official release artifact):
>>
>> https://repository.apache.org/content/repositories/orgapachefluo-1014/org/apache/fluo/fluo-recipes/1.0.0-incubating/fluo-recipes-1.0.0-incubating-source-release.tar.gz
>> (Append ".sha1", ".md5", or ".asc" to download the signature/hash for a
>> given artifact.)
>>
>> All artifacts were built and staged with:
>>      mvn release:prepare&&  mvn release:perform
>>
>> Signing keys are available at
>> https://www.apache.org/dist/incubator/fluo/KEYS
>> (Expected fingerprint: CF72 CA07 C8BC 86A1 C862  765F 9AAC FB56 352A CF76)
>>
>> Release notes (in progress) can be found at:
>> https://fluo.apache.org/.../1.0.0-incubating (not yet started)
>>
>> Please vote one of:
>> [ ] +1 - I have verified and accept...
>> [ ] +0 - I have reservations, but not strong enough to vote against...
>> [ ] -1 - Because..., I do not accept...
>> ... these artifacts as the 1.0.0-incubating release of Apache Fluo.
>>
>> This vote will end on Thur Oct 20 18:10:00 UTC 2016
>> (Fri Oct 14:10:00 EDT 2016 / Fri Oct 20 11:10:00 PDT 2016)
>>
>> Thanks!
>>
>> P.S. Hint: download the whole staging repo with
>>      wget -erobots=off -r -l inf -np -nH \
>>
>> https://repository.apache.org/content/repositories/orgapachefluo-1014/
>>      # note the trailing slash is needed

Reply via email to