Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-15 Thread Woonsan Ko
On Thu, Sep 14, 2017 at 5:09 AM, Daniel Dekany wrote: > Thursday, September 14, 2017, 4:15:04 AM, Woonsan Ko wrote: > > [snip] And, I'd like to ask about this example: ${user.id!} The reason why I had to use ?string built-in was that user.id returns

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-13 Thread Woonsan Ko
On Wed, Sep 13, 2017 at 2:28 PM, Daniel Dekany wrote: > Wednesday, September 13, 2017, 6:48:25 PM, Woonsan Ko wrote: > >> On Wed, Sep 13, 2017 at 5:50 AM, Daniel Dekany wrote: >>> Wednesday, September 13, 2017, 4:20:35 AM, Woonsan Ko wrote: >>> >>> [snip]

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-13 Thread Daniel Dekany
Wednesday, September 13, 2017, 6:48:25 PM, Woonsan Ko wrote: > On Wed, Sep 13, 2017 at 5:50 AM, Daniel Dekany wrote: >> Wednesday, September 13, 2017, 4:20:35 AM, Woonsan Ko wrote: >> >> [snip] >>> I've proposed a PR for tags defined in spring.tld for now: >>>

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-13 Thread Woonsan Ko
On Wed, Sep 13, 2017 at 5:50 AM, Daniel Dekany wrote: > Wednesday, September 13, 2017, 4:20:35 AM, Woonsan Ko wrote: > > [snip] >> I've proposed a PR for tags defined in spring.tld for now: >> https://github.com/apache/incubator-freemarker/pull/34 >> I'll continue to replace

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-13 Thread Daniel Dekany
Wednesday, September 13, 2017, 4:20:35 AM, Woonsan Ko wrote: [snip] > I've proposed a PR for tags defined in spring.tld for now: > https://github.com/apache/incubator-freemarker/pull/34 > I'll continue to replace tags in form.tld. Thanks, looks good, I have merged it! One day (probably when you

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-12 Thread Woonsan Ko
On Tue, Sep 5, 2017 at 8:58 AM, Woonsan Ko wrote: > On Sun, Sep 3, 2017 at 7:55 AM, Daniel Dekany wrote: >> Sunday, September 3, 2017, 6:29:54 AM, Woonsan Ko wrote: >> >>> On Sat, Sep 2, 2017 at 7:33 PM, Woonsan Ko wrote: On Sat,

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-05 Thread Woonsan Ko
On Sun, Sep 3, 2017 at 7:55 AM, Daniel Dekany wrote: > Sunday, September 3, 2017, 6:29:54 AM, Woonsan Ko wrote: > >> On Sat, Sep 2, 2017 at 7:33 PM, Woonsan Ko wrote: >>> On Sat, Sep 2, 2017 at 3:36 AM, Daniel Dekany wrote:

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-03 Thread Daniel Dekany
Sunday, September 3, 2017, 6:29:54 AM, Woonsan Ko wrote: > On Sat, Sep 2, 2017 at 7:33 PM, Woonsan Ko wrote: >> On Sat, Sep 2, 2017 at 3:36 AM, Daniel Dekany wrote: >>> Saturday, September 2, 2017, 5:24:11 AM, Woonsan Ko wrote: >>> On Thu, Aug 24,

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-02 Thread Woonsan Ko
On Sat, Sep 2, 2017 at 3:11 AM, Daniel Dekany wrote: > Saturday, September 2, 2017, 5:03:51 AM, Woonsan Ko wrote: > >> On Thu, Aug 24, 2017 at 3:53 AM, Daniel Dekany wrote: >>> Thursday, August 24, 2017, 6:19:29 AM, Woonsan Ko wrote: >>> On Mon, Aug

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-02 Thread Daniel Dekany
Saturday, September 2, 2017, 5:24:11 AM, Woonsan Ko wrote: > On Thu, Aug 24, 2017 at 4:04 PM, Daniel Dekany wrote: >> Thursday, August 24, 2017, 9:53:11 AM, Daniel Dekany wrote: >> >>> Thursday, August 24, 2017, 6:19:29 AM, Woonsan Ko wrote: >>> On Mon, Aug 21, 2017 at

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-02 Thread Daniel Dekany
Saturday, September 2, 2017, 5:03:51 AM, Woonsan Ko wrote: > On Thu, Aug 24, 2017 at 3:53 AM, Daniel Dekany wrote: >> Thursday, August 24, 2017, 6:19:29 AM, Woonsan Ko wrote: >> >>> On Mon, Aug 21, 2017 at 12:19 AM, Daniel Dekany wrote: Monday,

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-01 Thread Woonsan Ko
On Thu, Aug 24, 2017 at 4:04 PM, Daniel Dekany wrote: > Thursday, August 24, 2017, 9:53:11 AM, Daniel Dekany wrote: > >> Thursday, August 24, 2017, 6:19:29 AM, Woonsan Ko wrote: >> >>> On Mon, Aug 21, 2017 at 12:19 AM, Daniel Dekany wrote: Monday,

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-09-01 Thread Woonsan Ko
On Thu, Aug 24, 2017 at 3:53 AM, Daniel Dekany wrote: > Thursday, August 24, 2017, 6:19:29 AM, Woonsan Ko wrote: > >> On Mon, Aug 21, 2017 at 12:19 AM, Daniel Dekany wrote: >>> Monday, August 7, 2017, 9:18:36 PM, Woonsan Ko wrote: >>> On Mon, Aug 7,

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-29 Thread Daniel Dekany
Tuesday, August 29, 2017, 8:48:34 PM, Woonsan Ko wrote: > On Tue, Aug 29, 2017 at 10:40 AM, Daniel Dekany wrote: >> Tuesday, August 29, 2017, 3:03:02 PM, Woonsan Ko wrote: >> >>> On Tue, Aug 29, 2017 at 5:00 AM, Daniel Dekany wrote: Tuesday, August

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-29 Thread Woonsan Ko
On Tue, Aug 29, 2017 at 2:48 PM, Woonsan Ko wrote: > On Tue, Aug 29, 2017 at 10:40 AM, Daniel Dekany wrote: >> Tuesday, August 29, 2017, 3:03:02 PM, Woonsan Ko wrote: >> >>> On Tue, Aug 29, 2017 at 5:00 AM, Daniel Dekany wrote:

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-29 Thread Woonsan Ko
On Tue, Aug 29, 2017 at 10:40 AM, Daniel Dekany wrote: > Tuesday, August 29, 2017, 3:03:02 PM, Woonsan Ko wrote: > >> On Tue, Aug 29, 2017 at 5:00 AM, Daniel Dekany wrote: >>> Tuesday, August 29, 2017, 5:25:31 AM, Woonsan Ko wrote: >>> Hi Daniel,

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-29 Thread Daniel Dekany
Tuesday, August 29, 2017, 3:03:02 PM, Woonsan Ko wrote: > On Tue, Aug 29, 2017 at 5:00 AM, Daniel Dekany wrote: >> Tuesday, August 29, 2017, 5:25:31 AM, Woonsan Ko wrote: >> >>> Hi Daniel, >>> >>> Thanks for the remarks and hints! Please see my question inline. >>> >>> On

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-29 Thread Woonsan Ko
On Tue, Aug 29, 2017 at 5:00 AM, Daniel Dekany wrote: > Tuesday, August 29, 2017, 5:25:31 AM, Woonsan Ko wrote: > >> Hi Daniel, >> >> Thanks for the remarks and hints! Please see my question inline. >> >> On Sat, Aug 26, 2017 at 4:50 AM, Daniel Dekany

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-26 Thread Daniel Dekany
Saturday, August 26, 2017, 10:44:03 AM, Daniel Dekany wrote: [snip] > <#macro foo> > <#local status = 'blah'> > <@spring.bind "user.name"> > ${status.value} <#-- Means 'blah'.value, won't work --> To clarify, here I have assumed that spring.bind calls env.setVariable("status",

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-26 Thread Daniel Dekany
Saturday, August 26, 2017, 10:17:55 AM, Daniel Dekany wrote: > Saturday, August 26, 2017, 7:27:03 AM, Woonsan Ko wrote: > >> Hi Daniel, >> >> I've tried to write a directive to replace the spring:bind tag >> library. But I get "IllegalStateException: Not executing macro body" >> when invoking

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-25 Thread Woonsan Ko
Hi Daniel, I've tried to write a directive to replace the spring:bind tag library. But I get "IllegalStateException: Not executing macro body" when invoking Environment#setLocalVariable(...). <@spring.bind> is supposed to set a variable called 'status'. Could you give me a hint on how to add a

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-24 Thread Daniel Dekany
Thursday, August 24, 2017, 9:53:11 AM, Daniel Dekany wrote: > Thursday, August 24, 2017, 6:19:29 AM, Woonsan Ko wrote: > >> On Mon, Aug 21, 2017 at 12:19 AM, Daniel Dekany wrote: >>> Monday, August 7, 2017, 9:18:36 PM, Woonsan Ko wrote: >>> On Mon, Aug 7, 2017 at 11:03

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-24 Thread Daniel Dekany
Thursday, August 24, 2017, 6:19:29 AM, Woonsan Ko wrote: > On Mon, Aug 21, 2017 at 12:19 AM, Daniel Dekany wrote: >> Monday, August 7, 2017, 9:18:36 PM, Woonsan Ko wrote: >> >>> On Mon, Aug 7, 2017 at 11:03 AM, Daniel Dekany wrote: If you are going

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-20 Thread Daniel Dekany
Monday, August 7, 2017, 9:18:36 PM, Woonsan Ko wrote: > On Mon, Aug 7, 2017 at 11:03 AM, Daniel Dekany wrote: >> If you are going to implement these directly as >> TemplateDirectiveModel-s and TemplateFunctionModel-s, then you better >> wait until I merge at least the

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-08 Thread Daniel Dekany
Monday, August 7, 2017, 9:18:36 PM, Woonsan Ko wrote: > On Mon, Aug 7, 2017 at 11:03 AM, Daniel Dekany wrote: >> If you are going to implement these directly as >> TemplateDirectiveModel-s and TemplateFunctionModel-s, then you better >> wait until I merge at least the

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-07 Thread Daniel Dekany
Monday, August 7, 2017, 9:18:36 PM, Woonsan Ko wrote: > On Mon, Aug 7, 2017 at 11:03 AM, Daniel Dekany wrote: >> If you are going to implement these directly as >> TemplateDirectiveModel-s and TemplateFunctionModel-s, then you better >> wait until I merge at least the

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-07 Thread Woonsan Ko
On Mon, Aug 7, 2017 at 11:03 AM, Daniel Dekany wrote: > If you are going to implement these directly as > TemplateDirectiveModel-s and TemplateFunctionModel-s, then you better > wait until I merge at least the FREEMARKER-63 PR... probably also > FREEMARKER-64. I will try to do

Re: (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2017-08-07 Thread Woonsan Ko
On Sun, Aug 6, 2017 at 6:14 AM, Daniel Dekany wrote: > The big problem is that spring.ftl is copyrighted by some of the > Spring authors (or the Spring project as a whole - it's not clear). So > certainly we can't just copy it. It has to be reimplemented without > looking at